96433 2012-09-11 15:26:30 -0700 [V8] 8% regression in dom_perf 2012-09-12 16:40:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth adamk eric haraken jamesr japhet webkit.review.bot oldest_to_newest 717617 0 abarth 2012-09-11 15:26:30 -0700 [V8] 8% regression in dom_perf 717618 1 163455 abarth 2012-09-11 15:27:59 -0700 Created attachment 163455 Patch 717621 2 abarth 2012-09-11 15:28:35 -0700 http://code.google.com/p/chromium/issues/detail?id=147639 717660 3 163455 haraken 2012-09-11 16:01:42 -0700 Comment on attachment 163455 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163455&action=review > Source/WebCore/bindings/v8/V8DOMWrapper.cpp:146 > + if (document && document->frame()) Shall we add a comment that this code is for performance? 717666 4 163467 abarth 2012-09-11 16:04:21 -0700 Created attachment 163467 Patch for landing 717667 5 abarth 2012-09-11 16:04:32 -0700 Done 717723 6 163467 webkit.review.bot 2012-09-11 16:48:47 -0700 Comment on attachment 163467 Patch for landing Clearing flags on attachment: 163467 Committed r128242: <http://trac.webkit.org/changeset/128242> 717724 7 webkit.review.bot 2012-09-11 16:48:50 -0700 All reviewed patches have been landed. Closing bug. 717771 8 jamesr 2012-09-11 17:44:19 -0700 I think this made bindings-tests on cr-mac fail: http://build.webkit.org/builders/Chromium%20Mac%20Release%20%28Tests%29/builds/23809/steps/bindings-generation-tests/logs/stdio FAIL: (V8) V8TestCustomNamedGetter.cpp --- WebCore/bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp 2012-09-11 02:59:54.000000000 -0700 +++ /var/folders/OH/OHv-vytAG2GCWI6iDiG7U++++Tg/-Tmp-/tmpj7R5NQ/V8TestCustomNamedGetter.cpp 2012-09-11 17:28:22.000000000 -0700 @@ -112,6 +112,8 @@ v8::Handle<v8::Object> V8TestCustomNamedGetter::wrapSlow(PassRefPtr<TestCustomNamedGetter> impl, v8::Handle<v8::Object> creationContext, v8::Isolate* isolate) { v8::Handle<v8::Object> wrapper; + Document* document = 0; + UNUSED_PARAM(document); v8::Handle<v8::Context> context; if (!creationContext.IsEmpty() && creationContext->CreationContext() != v8::Context::GetCurrent()) { @@ -122,7 +124,7 @@ context->Enter(); } - wrapper = V8DOMWrapper::instantiateV8Object(&info, impl.get()); + wrapper = V8DOMWrapper::instantiateV8Object(document, &info, impl.get()); if (!context.IsEmpty()) context->Exit(); etc.... 717774 9 jamesr 2012-09-11 17:50:17 -0700 Actually, bindings test seem to be failing everywhere that uses v8. Probably just needs an expectation update, but I don't feel confident enough in the change to do it. Could you take a look when you get a sec, Adam? 717779 10 abarth 2012-09-11 17:59:29 -0700 Yeah, sorry. Just needs an update. 717780 11 abarth 2012-09-11 17:59:45 -0700 /me will fix 718874 12 abarth 2012-09-12 16:40:10 -0700 Fixed. 163455 2012-09-11 15:27:59 -0700 2012-09-11 16:04:17 -0700 Patch bug-96433-20120911152733.patch text/plain 3959 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWZiYTM5MzlmMTkwMGY1 NWQyYThjMGY4Y2Q1ZDJmMjAwZTU5NjdmYi4uNWVlMjAwMjQwMjBhOGIxY2RkOWExYjRkODBlMDA3 MDBjYTcxMzVjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTExICBBZGFt IEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIDglIHJlZ3Jlc3Np b24gaW4gZG9tX3BlcmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk2NDMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVGhpcyBjb2RlIHVzZWQgdG8gaGF2ZSBhIGZhc3QgcGF0aCB0byBmaW5kIHRoZSBWOFBl ckNvbnRleHREYXRhIGZvciBET00KKyAgICAgICAgbm9kZXMuIEkgdHJpZWQgYSBidW5jaCBvZiB2 YXJpYXRpb25zLCBidXQgbm90aGluZyBJIGNhbiBjb21lIHVwIHdpdGggaXMKKyAgICAgICAgYXMg ZmFzdCBhcyB0aGUgb2xkIGZhc3QgcGF0aCwgc28gSSd2ZSBhZGRlZCBiYWNrIHRoZSBmYXN0IHBh dGguCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKyAg ICAgICAgKEdlbmVyYXRlVG9WOENvbnZlcnRlcnMpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4 RE9NV3JhcHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpWOERPTVdyYXBwZXI6Omluc3RhbnRp YXRlVjhPYmplY3QpOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oOgorICAg ICAgICAoVjhET01XcmFwcGVyKToKKwogMjAxMi0wOS0xMSAgRGltaXRyaSBHbGF6a292ICA8ZGds YXprb3ZAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJlbW92ZSBTdHlsZVJlc29sdmVyOjpzZXRT dHlsZSwgYmVjYXVzZSBpdCdzIG5vIGxvbmdlciB1c2VkLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0gYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQppbmRleCBjMjljYzVjMGY4MmIx OWVjYzYxY2MxODk5YmUxODg5NTMyNmUzODliLi4xNDU4ZGIwYzVlNWYxZTU1OWZlNGEwODYxZDFk OWRlMDQxNzBmYmI1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JWOC5wbQpAQCAtMzM1OCw2ICszMzU4LDE3IEBAIEVORAogICAgIH0KIAog ICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7CisgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0g MDsKKyAgICBVTlVTRURfUEFSQU0oZG9jdW1lbnQpOworRU5ECisKKyAgICBpZiAoSXNOb2RlU3Vi VHlwZSgkZGF0YU5vZGUpKSB7CisgICAgICAgIHB1c2goQGltcGxDb250ZW50LCA8PEVORCk7Cisg ICAgZG9jdW1lbnQgPSBpbXBsLT5kb2N1bWVudCgpOyAKK0VORAorICAgIH0KKworICAgIHB1c2go QGltcGxDb250ZW50LCA8PEVORCk7CiAKICAgICB2ODo6SGFuZGxlPHY4OjpDb250ZXh0PiBjb250 ZXh0OwogICAgIGlmICghY3JlYXRpb25Db250ZXh0LklzRW1wdHkoKSAmJiBjcmVhdGlvbkNvbnRl eHQtPkNyZWF0aW9uQ29udGV4dCgpICE9IHY4OjpDb250ZXh0OjpHZXRDdXJyZW50KCkpIHsKQEAg LTMzNjgsNyArMzM3OSw3IEBAIEVORAogICAgICAgICBjb250ZXh0LT5FbnRlcigpOwogICAgIH0K IAotICAgIHdyYXBwZXIgPSBWOERPTVdyYXBwZXI6Omluc3RhbnRpYXRlVjhPYmplY3QoJmluZm8s IGltcGwuZ2V0KCkpOworICAgIHdyYXBwZXIgPSBWOERPTVdyYXBwZXI6Omluc3RhbnRpYXRlVjhP YmplY3QoZG9jdW1lbnQsICZpbmZvLCBpbXBsLmdldCgpKTsKIAogICAgIGlmICghY29udGV4dC5J c0VtcHR5KCkpCiAgICAgICAgIGNvbnRleHQtPkV4aXQoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IGZjM2FiNzdhOGM4MWNhN2VlOWMyNmRjMmRi NWUwNjhkZjYyMDVlZGYuLmEzYzE3NDQ2NmFlNDFjZDJlZDI2ZjNkMWY4NWZhYWU5ZDZkYzFjYWYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcApAQCAtMTQw LDkgKzE0MCwxMyBAQCBQYXNzUmVmUHRyPE5vZGVGaWx0ZXI+IFY4RE9NV3JhcHBlcjo6d3JhcE5h dGl2ZU5vZGVGaWx0ZXIodjg6OkhhbmRsZTx2ODo6VmFsdWU+CiAgICAgcmV0dXJuIE5vZGVGaWx0 ZXI6OmNyZWF0ZShWOE5vZGVGaWx0ZXJDb25kaXRpb246OmNyZWF0ZShmaWx0ZXIpKTsKIH0KIAot djg6OkxvY2FsPHY4OjpPYmplY3Q+IFY4RE9NV3JhcHBlcjo6aW5zdGFudGlhdGVWOE9iamVjdChX cmFwcGVyVHlwZUluZm8qIHR5cGUsIHZvaWQqIGltcGwpCit2ODo6TG9jYWw8djg6Ok9iamVjdD4g VjhET01XcmFwcGVyOjppbnN0YW50aWF0ZVY4T2JqZWN0KERvY3VtZW50KiBkb2N1bWVudCwgV3Jh cHBlclR5cGVJbmZvKiB0eXBlLCB2b2lkKiBpbXBsKQogewotICAgIFY4UGVyQ29udGV4dERhdGEq IHBlckNvbnRleHREYXRhID0gVjhQZXJDb250ZXh0RGF0YTo6Y3VycmVudCgpOworICAgIFY4UGVy Q29udGV4dERhdGEqIHBlckNvbnRleHREYXRhID0gMDsKKyAgICBpZiAoZG9jdW1lbnQgJiYgZG9j dW1lbnQtPmZyYW1lKCkpCisgICAgICAgIHBlckNvbnRleHREYXRhID0gcGVyQ29udGV4dERhdGFG b3JDdXJyZW50V29ybGQoZG9jdW1lbnQtPmZyYW1lKCkpOworICAgIGVsc2UKKyAgICAgICAgcGVy Q29udGV4dERhdGEgPSBWOFBlckNvbnRleHREYXRhOjpjdXJyZW50KCk7CiAKICAgICB2ODo6TG9j YWw8djg6Ok9iamVjdD4gaW5zdGFuY2UgPSBwZXJDb250ZXh0RGF0YSA/IHBlckNvbnRleHREYXRh LT5jcmVhdGVXcmFwcGVyRnJvbUNhY2hlKHR5cGUpIDogVjhPYmplY3RDb25zdHJ1Y3Rvcjo6bmV3 SW5zdGFuY2UodHlwZS0+Z2V0VGVtcGxhdGUoKS0+R2V0RnVuY3Rpb24oKSk7CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5oIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKaW5kZXggZTI0NDc5YTFjMzFmNzUzMjdk OTg2YjI4NjI5ZDI1OWQ5NDgyNmNmOC4uZWE5OGM2ZTM2ZjRlOGU3OGRjOTc1NjM3ZDliYzc3ZjAx OGRhN2M3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFw cGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKQEAg LTExMiw3ICsxMTIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICAgICAgc3RhdGljIHZv aWQgc2V0TmFtZWRIaWRkZW5SZWZlcmVuY2Uodjg6OkhhbmRsZTx2ODo6T2JqZWN0PiBwYXJlbnQs IGNvbnN0IGNoYXIqIG5hbWUsIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjaGlsZCk7CiAKLSAgICAg ICAgc3RhdGljIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBpbnN0YW50aWF0ZVY4T2JqZWN0KFdyYXBw ZXJUeXBlSW5mbyosIHZvaWQqKTsKKyAgICAgICAgc3RhdGljIHY4OjpMb2NhbDx2ODo6T2JqZWN0 PiBpbnN0YW50aWF0ZVY4T2JqZWN0KERvY3VtZW50KiwgV3JhcHBlclR5cGVJbmZvKiwgdm9pZCop OwogCiAgICAgICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpPYmplY3Q+IGdldENhY2hlZFdyYXBw ZXIoTm9kZSogbm9kZSkKICAgICAgICAgewo= 163467 2012-09-11 16:04:21 -0700 2012-09-11 16:48:47 -0700 Patch for landing bug-96433-20120911160355.patch text/plain 4091 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MjI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWZiYTM5MzlmMTkwMGY1 NWQyYThjMGY4Y2Q1ZDJmMjAwZTU5NjdmYi4uNmIwODdlY2Q4MmQxODA4MTY4NjUwZDgyNmQ1MWZh YmY4MzRjMGQ4MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTExICBBZGFt IEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KKworICAgICAgICBbVjhdIDglIHJlZ3Jlc3Np b24gaW4gZG9tX3BlcmYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk2NDMzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VudGFybyBIYXJhLgorCisgICAg ICAgIFRoaXMgY29kZSB1c2VkIHRvIGhhdmUgYSBmYXN0IHBhdGggdG8gZmluZCB0aGUgVjhQZXJD b250ZXh0RGF0YSBmb3IgRE9NCisgICAgICAgIG5vZGVzLiBJIHRyaWVkIGEgYnVuY2ggb2YgdmFy aWF0aW9ucywgYnV0IG5vdGhpbmcgSSBjYW4gY29tZSB1cCB3aXRoIGlzCisgICAgICAgIGFzIGZh c3QgYXMgdGhlIG9sZCBmYXN0IHBhdGgsIHNvIEkndmUgYWRkZWQgYmFjayB0aGUgZmFzdCBwYXRo LgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisgICAg ICAgIChHZW5lcmF0ZVRvVjhDb252ZXJ0ZXJzKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERP TVdyYXBwZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhET01XcmFwcGVyOjppbnN0YW50aWF0 ZVY4T2JqZWN0KToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuaDoKKyAgICAg ICAgKFY4RE9NV3JhcHBlcik6CisKIDIwMTItMDktMTEgIERpbWl0cmkgR2xhemtvdiAgPGRnbGF6 a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZW1vdmUgU3R5bGVSZXNvbHZlcjo6c2V0U3R5 bGUsIGJlY2F1c2UgaXQncyBubyBsb25nZXIgdXNlZC4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtIGIvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggYzI5Y2M1YzBmODJiMTll Y2M2MWNjMTg5OWJlMTg4OTUzMjZlMzg5Yi4uMTQ1OGRiMGM1ZTVmMWU1NTlmZTRhMDg2MWQxZDlk ZTA0MTcwZmJiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9yVjgucG0KQEAgLTMzNTgsNiArMzM1OCwxNyBAQCBFTkQKICAgICB9CiAKICAg ICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOworICAgIERvY3VtZW50KiBkb2N1bWVudCA9IDA7 CisgICAgVU5VU0VEX1BBUkFNKGRvY3VtZW50KTsKK0VORAorCisgICAgaWYgKElzTm9kZVN1YlR5 cGUoJGRhdGFOb2RlKSkgeworICAgICAgICBwdXNoKEBpbXBsQ29udGVudCwgPDxFTkQpOworICAg IGRvY3VtZW50ID0gaW1wbC0+ZG9jdW1lbnQoKTsgCitFTkQKKyAgICB9CisKKyAgICBwdXNoKEBp bXBsQ29udGVudCwgPDxFTkQpOwogCiAgICAgdjg6OkhhbmRsZTx2ODo6Q29udGV4dD4gY29udGV4 dDsKICAgICBpZiAoIWNyZWF0aW9uQ29udGV4dC5Jc0VtcHR5KCkgJiYgY3JlYXRpb25Db250ZXh0 LT5DcmVhdGlvbkNvbnRleHQoKSAhPSB2ODo6Q29udGV4dDo6R2V0Q3VycmVudCgpKSB7CkBAIC0z MzY4LDcgKzMzNzksNyBAQCBFTkQKICAgICAgICAgY29udGV4dC0+RW50ZXIoKTsKICAgICB9CiAK LSAgICB3cmFwcGVyID0gVjhET01XcmFwcGVyOjppbnN0YW50aWF0ZVY4T2JqZWN0KCZpbmZvLCBp bXBsLmdldCgpKTsKKyAgICB3cmFwcGVyID0gVjhET01XcmFwcGVyOjppbnN0YW50aWF0ZVY4T2Jq ZWN0KGRvY3VtZW50LCAmaW5mbywgaW1wbC5nZXQoKSk7CiAKICAgICBpZiAoIWNvbnRleHQuSXNF bXB0eSgpKQogICAgICAgICBjb250ZXh0LT5FeGl0KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhET01XcmFwcGVyLmNwcAppbmRleCBmYzNhYjc3YThjODFjYTdlZTljMjZkYzJkYjVl MDY4ZGY2MjA1ZWRmLi45MWY4NDU0YWQyZmY0YTE2YWJkOTliYjA1MmIwMzgyMTc3ZmJkZjk3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKQEAgLTE0MCw5 ICsxNDAsMTYgQEAgUGFzc1JlZlB0cjxOb2RlRmlsdGVyPiBWOERPTVdyYXBwZXI6OndyYXBOYXRp dmVOb2RlRmlsdGVyKHY4OjpIYW5kbGU8djg6OlZhbHVlPgogICAgIHJldHVybiBOb2RlRmlsdGVy OjpjcmVhdGUoVjhOb2RlRmlsdGVyQ29uZGl0aW9uOjpjcmVhdGUoZmlsdGVyKSk7CiB9CiAKLXY4 OjpMb2NhbDx2ODo6T2JqZWN0PiBWOERPTVdyYXBwZXI6Omluc3RhbnRpYXRlVjhPYmplY3QoV3Jh cHBlclR5cGVJbmZvKiB0eXBlLCB2b2lkKiBpbXBsKQordjg6OkxvY2FsPHY4OjpPYmplY3Q+IFY4 RE9NV3JhcHBlcjo6aW5zdGFudGlhdGVWOE9iamVjdChEb2N1bWVudCogZG9jdW1lbnQsIFdyYXBw ZXJUeXBlSW5mbyogdHlwZSwgdm9pZCogaW1wbCkKIHsKLSAgICBWOFBlckNvbnRleHREYXRhKiBw ZXJDb250ZXh0RGF0YSA9IFY4UGVyQ29udGV4dERhdGE6OmN1cnJlbnQoKTsKKyAgICBWOFBlckNv bnRleHREYXRhKiBwZXJDb250ZXh0RGF0YSA9IDA7CisKKyAgICAvLyBJZiB3ZSBoYXZlIGEgcG9p bnRlciB0byB0aGUgZnJhbWUsIHdlIGNuYSBnZXQgdGhlIFY4UGVyQ29udGV4dERhdGEKKyAgICAv LyBkaXJlY3RseSwgd2hpY2ggaXMgZmFzdGVyIHRoYW4gZ29pbmcgdGhyb3VnaCBWOC4KKyAgICBp ZiAoZG9jdW1lbnQgJiYgZG9jdW1lbnQtPmZyYW1lKCkpCisgICAgICAgIHBlckNvbnRleHREYXRh ID0gcGVyQ29udGV4dERhdGFGb3JDdXJyZW50V29ybGQoZG9jdW1lbnQtPmZyYW1lKCkpOworICAg IGVsc2UKKyAgICAgICAgcGVyQ29udGV4dERhdGEgPSBWOFBlckNvbnRleHREYXRhOjpjdXJyZW50 KCk7CiAKICAgICB2ODo6TG9jYWw8djg6Ok9iamVjdD4gaW5zdGFuY2UgPSBwZXJDb250ZXh0RGF0 YSA/IHBlckNvbnRleHREYXRhLT5jcmVhdGVXcmFwcGVyRnJvbUNhY2hlKHR5cGUpIDogVjhPYmpl Y3RDb25zdHJ1Y3Rvcjo6bmV3SW5zdGFuY2UodHlwZS0+Z2V0VGVtcGxhdGUoKS0+R2V0RnVuY3Rp b24oKSk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3Jh cHBlci5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKaW5kZXgg ZTI0NDc5YTFjMzFmNzUzMjdkOTg2YjI4NjI5ZDI1OWQ5NDgyNmNmOC4uZWE5OGM2ZTM2ZjRlOGU3 OGRjOTc1NjM3ZDliYzc3ZjAxOGRhN2M3MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhET01XcmFwcGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvdjgv VjhET01XcmFwcGVyLmgKQEAgLTExMiw3ICsxMTIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK ICAgICAgICAgc3RhdGljIHZvaWQgc2V0TmFtZWRIaWRkZW5SZWZlcmVuY2Uodjg6OkhhbmRsZTx2 ODo6T2JqZWN0PiBwYXJlbnQsIGNvbnN0IGNoYXIqIG5hbWUsIHY4OjpIYW5kbGU8djg6OlZhbHVl PiBjaGlsZCk7CiAKLSAgICAgICAgc3RhdGljIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBpbnN0YW50 aWF0ZVY4T2JqZWN0KFdyYXBwZXJUeXBlSW5mbyosIHZvaWQqKTsKKyAgICAgICAgc3RhdGljIHY4 OjpMb2NhbDx2ODo6T2JqZWN0PiBpbnN0YW50aWF0ZVY4T2JqZWN0KERvY3VtZW50KiwgV3JhcHBl clR5cGVJbmZvKiwgdm9pZCopOwogCiAgICAgICAgIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpPYmpl Y3Q+IGdldENhY2hlZFdyYXBwZXIoTm9kZSogbm9kZSkKICAgICAgICAgewo=