96411 2012-09-11 11:20:37 -0700 Garden-o-matic should ignore a wider variety of warnings in buildbot json 2012-09-11 11:49:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 adamk adamk abarth dglazkov ojan webkit.review.bot oldest_to_newest 717410 0 adamk 2012-09-11 11:20:37 -0700 Garden-o-matic should ignore a wider variety of warnings in buildbot json 717412 1 163409 adamk 2012-09-11 11:22:23 -0700 Created attachment 163409 Patch 717415 2 163409 abarth 2012-09-11 11:26:43 -0700 Comment on attachment 163409 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60 > + function isWarning(text) { return text.indexOf('warning') != -1; } > + return step.results[0] > 0 && !step.text.some(isWarning); I would have just used an anonymous function, but this is fine too. 717418 3 163409 adamk 2012-09-11 11:29:48 -0700 Comment on attachment 163409 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163409&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:60 >> + return step.results[0] > 0 && !step.text.some(isWarning); > > I would have just used an anonymous function, but this is fine too. I found the anonymous function version hard to reason about; adding the name made this more readable to me. 717443 4 163409 webkit.review.bot 2012-09-11 11:49:50 -0700 Comment on attachment 163409 Patch Clearing flags on attachment: 163409 Committed r128213: <http://trac.webkit.org/changeset/128213> 717444 5 webkit.review.bot 2012-09-11 11:49:53 -0700 All reviewed patches have been landed. Closing bug. 163409 2012-09-11 11:22:23 -0700 2012-09-11 11:49:50 -0700 Patch bug-96411-20120911112158.patch text/plain 2860 adamk U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTk4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMGI1ZjA2ODNkZDczYjIzZTdkOGU1ODFlODA1MmQ0YTM5 NmU0MzRjYy4uMzk5ZTgzNzk5MzcwMmRmN2NhZWJjMjAzNDEwNmNiNWI0MjFlZGU2ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDEyLTA5LTExICBBZGFtIEtsZWluICA8YWRhbWtAY2hyb21pdW0ub3JnPgorCisgICAg ICAgIEdhcmRlbi1vLW1hdGljIHNob3VsZCBpZ25vcmUgYSB3aWRlciB2YXJpZXR5IG9mIHdhcm5p bmdzIGluIGJ1aWxkYm90IGpzb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk2NDExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgUHJldmlvdXNseSBvbmx5IHRoZSBleGFjdCBzdHJpbmcgIndhcm5pbmciIHdh cyB0cmVhdGVkIGFzIGEgd2FybmluZworICAgICAgICByZXN1bHQuIFRoaXMgcGF0Y2ggdHJlYXRz IGFueSBzdHJpbmcgd2l0aCAid2FybmluZyIgYXMgYSBzdWJzdHJpbmcKKyAgICAgICAgYXMgYSB3 YXJuaW5nIChlLmcuLCAid2FybmluZ3MiLCBhcyBzZWVuIG9uIHRoZSBjci13aW4gYnVpbGRib3Rz KS4KKworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmln L3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRzL2J1aWxkZXJzLmpzOgorICAgICAgICAo Lik6CisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnNfdW5pdHRlc3RzLmpzOgor CiAyMDEyLTA5LTExICBQaGlsaXBwZSBMaWFyZCAgPHBsaWFyZEBnb29nbGUuY29tPgogCiAgICAg ICAgIE1ha2Ugc3VyZSB0aGF0IG1kNXN1bSBpcyBub3Qgc2V0dXAgb24gbm9uLUNocm9taXVtIEFu ZHJvaWQgcGxhdGZvcm1zLgpkaWZmIC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVp bGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVp bGRlcnMuanMgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZp Zy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVycy5qcwppbmRleCAzY2I4 MDRhZjRhMWJkYjg4NmJiOGU2MDRmZjk0ZWVkODU1NTFiM2NkLi44MjIxMjk3YjY2M2MzODVmNmJi NjljZjg4MzNkZTY5M2JjNzI4MmZjIDEwMDY0NAotLS0gYS9Ub29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0 cy9idWlsZGVycy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQu b3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWlsZGVycy5qcwpA QCAtNTYsNyArNTYsOCBAQCBmdW5jdGlvbiBkaWRGYWlsKHN0ZXApCiAgICAgICAgIC8vIEZJWE1F OiBEbyBidWlsZC53ZWJraXQub3JnIGJvdHMgb3V0cHV0IHRoaXMgbWFya2VyIHdoZW4gdGhlIHRl c3RzIGZhaWwgdG8gcnVuPwogICAgICAgICByZXR1cm4gc3RlcC50ZXh0LmluZGV4T2Yoa0NyYXNo ZWRPckh1bmdPdXRwdXRNYXJrZXIpICE9IC0xOwogICAgIH0KLSAgICByZXR1cm4gc3RlcC5yZXN1 bHRzWzBdID4gMCAmJiBzdGVwLnRleHQuaW5kZXhPZignd2FybmluZycpID09IC0xOworICAgIGZ1 bmN0aW9uIGlzV2FybmluZyh0ZXh0KSB7IHJldHVybiB0ZXh0LmluZGV4T2YoJ3dhcm5pbmcnKSAh PSAtMTsgfQorICAgIHJldHVybiBzdGVwLnJlc3VsdHNbMF0gPiAwICYmICFzdGVwLnRleHQuc29t ZShpc1dhcm5pbmcpOwogfQogCiBmdW5jdGlvbiBmYWlsaW5nU3RlcHMoYnVpbGRJbmZvKQpkaWZm IC0tZ2l0IGEvVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcv cHVibGljX2h0bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnNfdW5pdHRlc3RzLmpzIGIv VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvcHVibGljX2h0 bWwvVGVzdEZhaWx1cmVzL3NjcmlwdHMvYnVpbGRlcnNfdW5pdHRlc3RzLmpzCmluZGV4IDdmMjNk MzkwZjUwOWJiMmYxYjU0ZTYzY2YzMWNkNDgyZmE3NTk3NmIuLmU3NzQ2OWJmYTg1ZGZkZjQzN2E5 ZTMzYzhmMjhlN2M1YThiZmIyMGMgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0 L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1YmxpY19odG1sL1Rlc3RGYWlsdXJlcy9zY3JpcHRz L2J1aWxkZXJzX3VuaXR0ZXN0cy5qcworKysgYi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWls ZC53ZWJraXQub3JnLWNvbmZpZy9wdWJsaWNfaHRtbC9UZXN0RmFpbHVyZXMvc2NyaXB0cy9idWls ZGVyc191bml0dGVzdHMuanMKQEAgLTU0MSw3ICs1NDEsNyBAQCB2YXIga0V4YW1wbGVCdWlsZElu Zm9XaXRoV2ViS2l0VGVzdENyYXNoSlNPTiA9IHsKICAgICAgICAgInJlc3VsdHMiOiBbMSwgW11d LAogICAgICAgICAic3RhdGlzdGljcyI6IHt9LAogICAgICAgICAic3RlcF9udW1iZXIiOiA0LAot ICAgICAgICAidGV4dCI6IFsiZXh0cmFjdF9idWlsZCIsICJ3YXJuaW5nIl0sCisgICAgICAgICJ0 ZXh0IjogWyJleHRyYWN0X2J1aWxkIiwgIndhcm5pbmdzIl0sCiAgICAgICAgICJ0aW1lcyI6IFsx MzE4MzY2MzcwLjk0NzcxLCAxMzE4MzY2NDA0LjU1Mjc4M10sCiAgICAgICAgICJ1cmxzIjoge30K ICAgICB9LCB7Cg==