96407 2012-09-11 10:26:06 -0700 We should wait longer before killing the PluginProcess 2012-09-11 10:42:08 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 beidson beidson oldest_to_newest 717338 0 beidson 2012-09-11 10:26:06 -0700 We should wait longer before killing the PluginProcess. Firing up a process and loading in the plug-in bundle is an I/O intensive task. Currently we kill the PluginProcess after 15 seconds of inactivity. That's nuts! It should be much longer. 717340 1 beidson 2012-09-11 10:26:28 -0700 In radar as <rdar://problem/12067728> 717349 2 163399 beidson 2012-09-11 10:35:09 -0700 Created attachment 163399 Patch v1 717351 3 163399 andersca 2012-09-11 10:36:36 -0700 Comment on attachment 163399 Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=163399&action=review > Source/WebKit2/UIProcess/Plugins/PluginProcessProxy.cpp:51 > +static const double minimumLifetime = 1800; > +static const double shutdownTimeout = 600; Please write these as 30 * 60 and 10 * 60 respectively, that makes it easier to read the timeouts. 717362 4 beidson 2012-09-11 10:42:08 -0700 http://trac.webkit.org/changeset/128205 163399 2012-09-11 10:35:09 -0700 2012-09-11 10:36:36 -0700 Patch v1 patch.txt text/plain 7060 beidson ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1ZjQ3YWE0Li4xM2Y3MjgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsNDAg QEAKKzIwMTItMDktMTEgIEJyYWR5IEVpZHNvbiAgPGJlaWRzb25AYXBwbGUuY29tPgorCisgICAg ICAgIFdlIHNob3VsZCB3YWl0IGxvbmdlciBiZWZvcmUga2lsbGluZyB0aGUgUGx1Z2luUHJvY2Vz cy4KKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzEyMDY3NzI4PiBhbmQgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NDA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5IHdlIGtpbGwgdGhlIFBsdWdpblByb2Nl c3MgMTUgc2Vjb25kcyBhZnRlciB0aGUgbGFzdCBwbHVnLWluIGlzIGRlc3Ryb3llZC4KKyAgICAg ICAgVGhpcyBpcyBzaG9ydCBlbm91Z2ggdGhhdCBtb3N0IHVzZXJzIHdpbGwgaGF2ZSB0aGUgcHJv Y2VzcyBraWxsZWQgbWFueSB0aW1lcyBkdXJpbmcgYnJvd3Npbmcgc2Vzc2lvbnMsCisgICAgICAg IHdoaWNoIGlzIHBhaW5mdWwgYmVjYXVzZSByZWxhdW5jaGluZyB0aGUgcHJvY2VzcyBpcyBJL08g YW5kIGtlcm5lbCBpbnRlbnNpdmUuCisKKyAgICAgICAgSW4gYW4gaWRlYWwgd29ybGQgd2UgY291 bGQga2VlcCBpdCBhcm91bmQgZm9yZXZlciB1bnRpbCB0aGUgc3lzdGVtIHRlbGxzIHVzIHJlc291 cmNlcyBhcmUgcnVubmluZyBsb3cuCisKKyAgICAgICAgSW4gcmVhbGl0eSB3ZSBkbyB3YW50IHRv IGtpbGwgaXQgb2NjYXNpb25hbGx5IHRvIGdldCBhIGNsZWFuIHNsYXRlIGZyb20gYW55IHBsdWct aW4gbGVha3MuCisKKyAgICAgICAgQSByZWFzb25hYmxlIGJhbGFuY2UgZm9yIG5vdyBpcyB0byBz ZXQgYSBtaW5pbXVtIGxpZmV0aW1lIG9mIDMwIG1pbnV0ZXMgb24gdGhlIHBsdWctaW4gcHJvY2Vz cyBhbmQgdG8gCisgICAgICAgIGV4dGVuZCB0aGUgdGVybWluYXRpb24gdGltZXIgZnJvbSAxNSBz ZWNvbmRzIHRvIDEwIG1pbnV0ZXMuCisgICAgICAgIAorICAgICAgICAqIFBsdWdpblByb2Nlc3Mv UGx1Z2luUHJvY2Vzcy5jcHA6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3M6OlBsdWdp blByb2Nlc3MpOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Qcm9jZXNzOjppbml0aWFsaXplUGx1 Z2luUHJvY2Vzcyk6CisgICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3M6OnNldE1pbmltdW1M aWZldGltZSk6CisgICAgICAgIChXZWJLaXQpOgorICAgICAgICAoV2ViS2l0OjpQbHVnaW5Qcm9j ZXNzOjptaW5pbXVtTGlmZXRpbWVUaW1lckZpcmVkKToKKyAgICAgICAgKiBQbHVnaW5Qcm9jZXNz L1BsdWdpblByb2Nlc3MuaDoKKyAgICAgICAgKFBsdWdpblByb2Nlc3MpOgorCisgICAgICAgICog U2hhcmVkL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5jcHA6CisgICAg ICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnM6OmVuY29kZSk6Cisg ICAgICAgIChXZWJLaXQ6OlBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnM6OmRlY29kZSk6 CisgICAgICAgICogU2hhcmVkL1BsdWdpbnMvUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVy cy5oOgorICAgICAgICAoUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycyk6CisKKyAgICAg ICAgKiBVSVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuY3BwOgorICAgICAgICAo V2ViS2l0KToKKyAgICAgICAgKFdlYktpdDo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpkaWRGaW5pc2hM YXVuY2hpbmcpOgorCiAyMDEyLTA5LTEwICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBKYXZhc2NyaXB0IGluIGZvcmVncm91bmQgdGFicyBzaG91bGQgbm90IHdh aXQgc3luY2hyb25vdXNseSBmb3IgcGx1Zy1pbnMgdG8gbG9hZApkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Qcm9jZXNzLmNwcCBiL1NvdXJjZS9XZWJLaXQy L1BsdWdpblByb2Nlc3MvUGx1Z2luUHJvY2Vzcy5jcHAKaW5kZXggNmY4NjhiYi4uMWJmZmFmZSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvUGx1Z2luUHJvY2Vzcy9QbHVnaW5Qcm9jZXNzLmNw cAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpblByb2Nlc3MuY3BwCkBA IC03Myw2ICs3Myw3IEBAIFBsdWdpblByb2Nlc3MmIFBsdWdpblByb2Nlc3M6OnNoYXJlZCgpCiAK IFBsdWdpblByb2Nlc3M6OlBsdWdpblByb2Nlc3MoKQogICAgIDogbV9zdXBwb3J0c0FzeW5jaHJv bm91c1BsdWdpbkluaXRpYWxpemF0aW9uKGZhbHNlKQorICAgICwgbV9taW5pbXVtTGlmZXRpbWVU aW1lcihSdW5Mb29wOjptYWluKCksIHRoaXMsICZQbHVnaW5Qcm9jZXNzOjptaW5pbXVtTGlmZXRp bWVUaW1lckZpcmVkKQogI2lmIFBMQVRGT1JNKE1BQykKICAgICAsIG1fY29tcG9zaXRpbmdSZW5k ZXJTZXJ2ZXJQb3J0KE1BQ0hfUE9SVF9OVUxMKQogI2VuZGlmCkBAIC0xNTksNiArMTYwLDcgQEAg dm9pZCBQbHVnaW5Qcm9jZXNzOjppbml0aWFsaXplUGx1Z2luUHJvY2Vzcyhjb25zdCBQbHVnaW5Q cm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXIKIAogICAgIG1fcGx1Z2luUGF0aCA9IHBhcmFtZXRlcnMu cGx1Z2luUGF0aDsKICAgICBtX3N1cHBvcnRzQXN5bmNocm9ub3VzUGx1Z2luSW5pdGlhbGl6YXRp b24gPSBwYXJhbWV0ZXJzLnN1cHBvcnRzQXN5bmNocm9ub3VzUGx1Z2luSW5pdGlhbGl6YXRpb247 CisgICAgc2V0TWluaW11bUxpZmV0aW1lKHBhcmFtZXRlcnMubWluaW11bUxpZmV0aW1lKTsKICAg ICBzZXRUZXJtaW5hdGlvblRpbWVvdXQocGFyYW1ldGVycy50ZXJtaW5hdGlvblRpbWVvdXQpOwog CiAgICAgcGxhdGZvcm1Jbml0aWFsaXplKHBhcmFtZXRlcnMpOwpAQCAtMjU0LDYgKzI1NiwyMSBA QCB2b2lkIFBsdWdpblByb2Nlc3M6OmNsZWFyU2l0ZURhdGEoY29uc3QgVmVjdG9yPFN0cmluZz4m IHNpdGVzLCB1aW50NjRfdCBmbGFncywgdQogICAgIG1fY29ubmVjdGlvbi0+c2VuZChNZXNzYWdl czo6UGx1Z2luUHJvY2Vzc1Byb3h5OjpEaWRDbGVhclNpdGVEYXRhKGNhbGxiYWNrSUQpLCAwKTsK IH0KIAordm9pZCBQbHVnaW5Qcm9jZXNzOjpzZXRNaW5pbXVtTGlmZXRpbWUoZG91YmxlIGxpZmV0 aW1lKQoreworICAgIGlmIChsaWZldGltZSA8PSAwLjApCisgICAgICAgIHJldHVybjsKKyAgICAK KyAgICBkaXNhYmxlVGVybWluYXRpb24oKTsKKyAgICAKKyAgICBtX21pbmltdW1MaWZldGltZVRp bWVyLnN0YXJ0T25lU2hvdChsaWZldGltZSk7Cit9CisKK3ZvaWQgUGx1Z2luUHJvY2Vzczo6bWlu aW11bUxpZmV0aW1lVGltZXJGaXJlZCgpCit7CisgICAgZW5hYmxlVGVybWluYXRpb24oKTsKK30K KwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKICNlbmRpZiAvLyBFTkFCTEUoUExVR0lOX1BST0NF U1MpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9QbHVnaW5Qcm9jZXNzL1BsdWdpblByb2Nl c3MuaCBiL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1Z2luUHJvY2Vzcy5oCmluZGV4 IGJjYmQyMDAuLjVhZTRkMzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nl c3MvUGx1Z2luUHJvY2Vzcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1BsdWdpblByb2Nlc3MvUGx1 Z2luUHJvY2Vzcy5oCkBAIC04Niw2ICs4Niw5IEBAIHByaXZhdGU6CiAgICAgdm9pZCBjbGVhclNp dGVEYXRhKGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBzaXRlcywgdWludDY0X3QgZmxhZ3MsIHVpbnQ2 NF90IG1heEFnZUluU2Vjb25kcywgdWludDY0X3QgY2FsbGJhY2tJRCk7CiAKICAgICB2b2lkIHBs YXRmb3JtSW5pdGlhbGl6ZShjb25zdCBQbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzJik7 CisgICAgCisgICAgdm9pZCBzZXRNaW5pbXVtTGlmZXRpbWUoZG91YmxlKTsKKyAgICB2b2lkIG1p bmltdW1MaWZldGltZVRpbWVyRmlyZWQoKTsKIAogICAgIC8vIFRoZSBjb25uZWN0aW9uIHRvIHRo ZSBVSSBwcm9jZXNzLgogICAgIFJlZlB0cjxDb3JlSVBDOjpDb25uZWN0aW9uPiBtX2Nvbm5lY3Rp b247CkBAIC0xMDAsMTIgKzEwMywxNCBAQCBwcml2YXRlOgogICAgIFJlZlB0cjxOZXRzY2FwZVBs dWdpbk1vZHVsZT4gbV9wbHVnaW5Nb2R1bGU7CiAgICAgCiAgICAgYm9vbCBtX3N1cHBvcnRzQXN5 bmNocm9ub3VzUGx1Z2luSW5pdGlhbGl6YXRpb247CisKKyAgICBXZWJDb3JlOjpSdW5Mb29wOjpU aW1lcjxQbHVnaW5Qcm9jZXNzPiBtX21pbmltdW1MaWZldGltZVRpbWVyOwogICAgIAogI2lmIFVT RShBQ0NFTEVSQVRFRF9DT01QT1NJVElORykgJiYgUExBVEZPUk0oTUFDKQogICAgIC8vIFRoZSBN YWNoIHBvcnQgdXNlZCBmb3IgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcuCiAgICAgbWFjaF9wb3J0 X3QgbV9jb21wb3NpdGluZ1JlbmRlclNlcnZlclBvcnQ7CiAjZW5kaWYKLSAgICAKKwogfTsKIAog fSAvLyBuYW1lc3BhY2UgV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQv UGx1Z2lucy9QbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1NoYXJlZC9QbHVnaW5zL1BsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwCmlu ZGV4IGYzMjVlYjYuLjhkMzk1MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9Q bHVnaW5zL1BsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQyL1NoYXJlZC9QbHVnaW5zL1BsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMuY3Bw CkBAIC00MSw2ICs0MSw3IEBAIHZvaWQgUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVyczo6 ZW5jb2RlKENvcmVJUEM6OkFyZ3VtZW50RW5jb2RlciogZW5jb2RlcikKIHsKICAgICBlbmNvZGVy LT5lbmNvZGUocGx1Z2luUGF0aCk7CiAgICAgZW5jb2Rlci0+ZW5jb2RlKHN1cHBvcnRzQXN5bmNo cm9ub3VzUGx1Z2luSW5pdGlhbGl6YXRpb24pOworICAgIGVuY29kZXItPmVuY29kZShtaW5pbXVt TGlmZXRpbWUpOwogICAgIGVuY29kZXItPmVuY29kZSh0ZXJtaW5hdGlvblRpbWVvdXQpOwogCiAj aWYgUExBVEZPUk0oTUFDKQpAQCAtNTUsNiArNTYsOCBAQCBib29sIFBsdWdpblByb2Nlc3NDcmVh dGlvblBhcmFtZXRlcnM6OmRlY29kZShDb3JlSVBDOjpBcmd1bWVudERlY29kZXIqIGRlY29kZXIs CiAgICAgICAgIHJldHVybiBmYWxzZTsKICAgICBpZiAoIWRlY29kZXItPmRlY29kZShyZXN1bHQu c3VwcG9ydHNBc3luY2hyb25vdXNQbHVnaW5Jbml0aWFsaXphdGlvbikpCiAgICAgICAgIHJldHVy biBmYWxzZTsKKyAgICBpZiAoIWRlY29kZXItPmRlY29kZShyZXN1bHQubWluaW11bUxpZmV0aW1l KSkKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIGlmICghZGVjb2Rlci0+ZGVjb2RlKHJlc3Vs dC50ZXJtaW5hdGlvblRpbWVvdXQpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAjaWYgUExBVEZP Uk0oTUFDKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdpbnMvUGx1Z2lu UHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oIGIvU291cmNlL1dlYktpdDIvU2hhcmVkL1BsdWdp bnMvUGx1Z2luUHJvY2Vzc0NyZWF0aW9uUGFyYW1ldGVycy5oCmluZGV4IGVhYWRmMTkuLjFkNmQy ZTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9QbHVnaW5zL1BsdWdpblByb2Nl c3NDcmVhdGlvblBhcmFtZXRlcnMuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvUGx1Z2lu cy9QbHVnaW5Qcm9jZXNzQ3JlYXRpb25QYXJhbWV0ZXJzLmgKQEAgLTUwLDYgKzUwLDcgQEAgc3Ry dWN0IFBsdWdpblByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMgewogICAgIFN0cmluZyBwbHVnaW5Q YXRoOwogICAgIGJvb2wgc3VwcG9ydHNBc3luY2hyb25vdXNQbHVnaW5Jbml0aWFsaXphdGlvbjsK IAorICAgIGRvdWJsZSBtaW5pbXVtTGlmZXRpbWU7CiAgICAgZG91YmxlIHRlcm1pbmF0aW9uVGlt ZW91dDsKIAogI2lmIFBMQVRGT1JNKE1BQykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9QbHVnaW5zL1BsdWdpblByb2Nlc3NQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvUGx1Z2lucy9QbHVnaW5Qcm9jZXNzUHJveHkuY3BwCmluZGV4IDdjNTNiNjkuLmFi NjY1ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QbHVnaW5zL1BsdWdp blByb2Nlc3NQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BsdWdpbnMv UGx1Z2luUHJvY2Vzc1Byb3h5LmNwcApAQCAtNDcsNyArNDcsOCBAQCB1c2luZyBuYW1lc3BhY2Ug V2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKLXN0YXRpYyBjb25zdCBkb3VibGUgc2h1 dGRvd25UaW1lb3V0ID0gMTU7CitzdGF0aWMgY29uc3QgZG91YmxlIG1pbmltdW1MaWZldGltZSA9 IDE4MDA7CitzdGF0aWMgY29uc3QgZG91YmxlIHNodXRkb3duVGltZW91dCA9IDYwMDsKIAogUGFz c1JlZlB0cjxQbHVnaW5Qcm9jZXNzUHJveHk+IFBsdWdpblByb2Nlc3NQcm94eTo6Y3JlYXRlKFBs dWdpblByb2Nlc3NNYW5hZ2VyKiBQbHVnaW5Qcm9jZXNzTWFuYWdlciwgY29uc3QgUGx1Z2luTW9k dWxlSW5mbyYgcGx1Z2luSW5mbykKIHsKQEAgLTIxMyw2ICsyMTQsNyBAQCB2b2lkIFBsdWdpblBy b2Nlc3NQcm94eTo6ZGlkRmluaXNoTGF1bmNoaW5nKFByb2Nlc3NMYXVuY2hlciosIENvcmVJUEM6 OkNvbm5lY3RpbwogCiAgICAgcGFyYW1ldGVycy5wbHVnaW5QYXRoID0gbV9wbHVnaW5JbmZvLnBh dGg7CiAKKyAgICBwYXJhbWV0ZXJzLm1pbmltdW1MaWZldGltZSA9IG1pbmltdW1MaWZldGltZTsK ICAgICBwYXJhbWV0ZXJzLnRlcm1pbmF0aW9uVGltZW91dCA9IHNodXRkb3duVGltZW91dDsKIAog ICAgIHBsYXRmb3JtSW5pdGlhbGl6ZVBsdWdpblByb2Nlc3MocGFyYW1ldGVycyk7Cg==