96400 2012-09-11 09:26:36 -0700 WTF fails to compile in thumb mode when llint is enabled. 2012-09-13 22:51:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Linux RESOLVED FIXED P2 Normal --- 0 xingri webkit-unassigned benjamin fpizlo joone mark.lam webkit.review.bot oldest_to_newest 717260 0 xingri 2012-09-11 09:26:36 -0700 libWTF_la_FastMalloc.o compile error with follwing error when the -mthumb option is passed to Armv7 GCC Cross Compiler for llint build mode of JavaScript Core. GNU assembler version 2.21(armv7a-linux-gnuabi) using BFD version(GNU Binutils) 2.21 /tmp/ccqNNDc0.s: Assembler messages: /tmp/ccqNNDc0.s: 1268: Error: bad immediate value for offset(4080) /tmp/ccqNNDc0.s: 1271: Error: bad immediate value for offset(4080) /tmp/ccqNNDc0.s: 1800: Error: bad immediate value for offset(4080) /tmp/ccqNNDc0.s: 1803: Error: bad immediate value for offset(4080) /tmp/ccqNNDc0.s: 2758: Error: bad immediate value for offset(4080) /tmp/ccqNNDc0.s: 2761: Error: bad immediate value for offset(4080) ................ /tmp/ccqNNDc0.s: 10064: Error: bad immediate value for offset(4080) /tmp/ccqNNDc0.s: 10067: Error: bad immediate value for offset(4080) /opt/crosstool/bin/../lib/gcc/armv7a-linux-gnuabi/4.5.1/../../../../armv7a-linux-gnuabi/bin/as: BFD (GNU Binutils) 2.21 assertion fail ../../binutils-2.21/bfd/elf.c:2795 armv7a-vfp-linux-gnueabi-g++: Internal error: Segmentation fault(program as) 717306 1 163391 xingri 2012-09-11 09:57:39 -0700 Created attachment 163391 Patch 717436 2 163391 fpizlo 2012-09-11 11:41:57 -0700 Comment on attachment 163391 Patch Can you rebase the patch? 717769 3 xingri 2012-09-11 17:43:58 -0700 Reopening to attach new patch. 717770 4 163490 xingri 2012-09-11 17:44:01 -0700 Created attachment 163490 Patch 718038 5 mark.lam 2012-09-12 01:23:00 -0700 I don't have reviewer privileges, but the change looks good to me. I verified it against gcc specs here: http://gcc.gnu.org/onlinedocs/gcc-4.7.1/gcc.pdf (page 395). 720198 6 xingri 2012-09-13 18:23:17 -0700 Reopening to attach new patch. 720199 7 164023 xingri 2012-09-13 18:23:19 -0700 Created attachment 164023 Update ChangeLog 720207 8 joone 2012-09-13 18:35:31 -0700 This patch doesn't land yet. 720328 9 164023 webkit.review.bot 2012-09-13 22:51:24 -0700 Comment on attachment 164023 Update ChangeLog Clearing flags on attachment: 164023 Committed r128557: <http://trac.webkit.org/changeset/128557> 720329 10 webkit.review.bot 2012-09-13 22:51:28 -0700 All reviewed patches have been landed. Closing bug. 163391 2012-09-11 09:57:39 -0700 2012-09-11 17:43:53 -0700 Patch bug-96400-20120912015728.patch text/plain 1225 xingri SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjgxOTIpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA5LTExICBCeXVuZ3Nlb24gU2hpbiAgPHhp bmdyaUBnbWFpbC5jb20+CisKKyAgICAgICAgRml4IGludmFsaWQgb2Zmc2V0IHJhbmdlIHVzZSBv ZiBUaHVtYiBsZHIgaW5zdHJ1Y3Rpb24uCisgICAgICAgIFdoZW4gdXNpbmcgIittIiBjb21waWxl ciBhc3N1bWUgb2Zmc2V0IHJhbmdlIGJldHdlZW4gKy8tIDQwOTUKKyAgICAgICAgKHRoZSBsYXJn ZXN0IHBvc3NpYmxlIG9mZnNldCByYW5nZSkuCisgICAgICAgIEhvd2V2ZXIsIGxkcmV4L3N0cmV4 IGNhbiBvbmx5IHVzZXIgb2Zmc2V0IHJhbmdlIGluIDB+MTAyMC4KKyAgICAgICAgU28sICIrUSIg c2hvdWxkIGJlIHVzZWQgZm9yIGZpeGluZyBpdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NDAwCisKIDIwMTItMDktMTEgIFJhcGhhZWwgS3VibyBk YSBDb3N0YSAgPHJha3Vjb0B3ZWJraXQub3JnPgogCiAgICAgICAgIFtFRkxdIFJld3JpdGUgdGhl IEVGTC1yZWxhdGVkIEZpbmQgbW9kdWxlcwpJbmRleDogU291cmNlL1dURi93dGYvQXRvbWljcy5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F0b21pY3MuaAkocmV2aXNpb24gMTI4MTky KQorKysgU291cmNlL1dURi93dGYvQXRvbWljcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAsNyAr MTYwLDcgQEAgaW5saW5lIGJvb2wgd2Vha0NvbXBhcmVBbmRTd2FwKHVuc2lnbmVkKgogICAgICAg ICAiYm5lLm4gMGZcblx0IgogICAgICAgICAic3RyZXggJTEsICU0LCAlMFxuXHQiCiAgICAgICAg ICIwOiIKLSAgICAgICAgOiAiK20iKCpsb2NhdGlvbiksICI9JnIiKHJlc3VsdCksICI9JnIiKHRt cCkKKyAgICAgICAgOiAiK1EiKCpsb2NhdGlvbiksICI9JnIiKHJlc3VsdCksICI9JnIiKHRtcCkK ICAgICAgICAgOiAiciIoZXhwZWN0ZWQpLCAiciIobmV3VmFsdWUpCiAgICAgICAgIDogIm1lbW9y eSIpOwogICAgIHJlc3VsdCA9ICFyZXN1bHQ7Cg== 163490 2012-09-11 17:44:01 -0700 2012-09-13 18:23:11 -0700 Patch bug-96400-20120912094349.patch text/plain 1417 xingri SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjgyNDkpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTExICBCeXVuZ3Nlb24gU2hpbiAgPHhp bmdyaUBnbWFpbC5jb20+CisKKyAgICAgICAgRml4IGZvciBXVEYgZmFpbHMgdG8gY29tcGlsZSBp biB0aHVtYiBtb2RlIHdoZW4gbGxpbnQgaXMgZW5hYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hlbiB1c2luZyAiK20iIHdpdGggQXJtdjcgY3Jv c3MgY29tcGlsZXIgYXNzdW1lIG9mZnNldCByYW5nZSBiZXR3ZWVuICsvLSA0MDk1CisgICAgICAg ICh0aGUgbGFyZ2VzdCBwb3NzaWJsZSBvZmZzZXQgcmFuZ2UpLgorICAgICAgICBIb3dldmVyLCBs ZHJleC9zdHJleCBjYW4gb25seSB1c2Ugb2Zmc2V0IHJhbmdlIG9mIDB+MTAyMCwgc28gIittIiBu ZWVkZWQgdG8gYmUgY2hhbmdlZCB0byAiK1EiLgorICAgICAgICBSZWYuIGh0dHA6Ly9nY2MuZ251 Lm9yZy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/aWQ9NTQ0ODAKKworICAgICAgICAqIHd0Zi9BdG9t aWNzLmg6CisgICAgICAgIChXVEY6OndlYWtDb21wYXJlQW5kU3dhcCk6CisKIDIwMTItMDktMTEg IE1pY2hhZWwgU2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgQnVpbGQgZml4 ZWQgZm9yIGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzEyODI0MwpJbmRleDogU291 cmNlL1dURi93dGYvQXRvbWljcy5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL0F0b21p Y3MuaAkocmV2aXNpb24gMTI4MjQ2KQorKysgU291cmNlL1dURi93dGYvQXRvbWljcy5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0xNjAsNyArMTYwLDcgQEAgaW5saW5lIGJvb2wgd2Vha0NvbXBhcmVBbmRT d2FwKHVuc2lnbmVkKgogICAgICAgICAiYm5lLm4gMGZcblx0IgogICAgICAgICAic3RyZXggJTEs ICU0LCAlMFxuXHQiCiAgICAgICAgICIwOiIKLSAgICAgICAgOiAiK20iKCpsb2NhdGlvbiksICI9 JnIiKHJlc3VsdCksICI9JnIiKHRtcCkKKyAgICAgICAgOiAiK1EiKCpsb2NhdGlvbiksICI9JnIi KHJlc3VsdCksICI9JnIiKHRtcCkKICAgICAgICAgOiAiciIoZXhwZWN0ZWQpLCAiciIobmV3VmFs dWUpCiAgICAgICAgIDogIm1lbW9yeSIpOwogICAgIHJlc3VsdCA9ICFyZXN1bHQ7Cg== 164023 2012-09-13 18:23:19 -0700 2012-09-13 22:51:24 -0700 Update ChangeLog bug-96400-20120914102307.patch text/plain 1427 xingri SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjg1MzYpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTEzICBCeXVuZ3Nlb24gU2hpbiAgPHhp bmdyaUBnbWFpbC5jb20+CisKKyAgICAgICAgRml4IGZvciBXVEYgZmFpbHMgdG8gY29tcGlsZSBp biB0aHVtYiBtb2RlIHdoZW4gbGxpbnQgaXMgZW5hYmxlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2NDAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg RmlsaXAgUGl6bG8uCisKKyAgICAgICAgV2hlbiB1c2luZyAiK20iIHdpdGggQXJtdjcgY3Jvc3Mg Y29tcGlsZXIgYXNzdW1lIG9mZnNldCByYW5nZSBiZXR3ZWVuICsvLSA0MDk1CisgICAgICAgICh0 aGUgbGFyZ2VzdCBwb3NzaWJsZSBvZmZzZXQgcmFuZ2UpLgorICAgICAgICBIb3dldmVyLCBsZHJl eC9zdHJleCBjYW4gb25seSB1c2Ugb2Zmc2V0IHJhbmdlIG9mIDB+MTAyMCwgc28gIittIiBuZWVk ZWQgdG8gYmUgY2hhbmdlZCB0byAiK1EiLgorICAgICAgICBSZWYuIGh0dHA6Ly9nY2MuZ251Lm9y Zy9idWd6aWxsYS9zaG93X2J1Zy5jZ2k/aWQ9NTQ0ODAKKworICAgICAgICAqIHd0Zi9BdG9taWNz Lmg6CisgICAgICAgIChXVEY6OndlYWtDb21wYXJlQW5kU3dhcCk6CisKIDIwMTItMDktMTMgIEtl bm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAg IEV2YXNfT2JqZWN0KiBpcyBhIHJlZidlZCBzdHJ1Y3R1cmUsIHNvIHRyZWFkIGl0IGFzIHN1Y2gK SW5kZXg6IFNvdXJjZS9XVEYvd3RmL0F0b21pY3MuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RG L3d0Zi9BdG9taWNzLmgJKHJldmlzaW9uIDEyODUzNikKKysrIFNvdXJjZS9XVEYvd3RmL0F0b21p Y3MuaAkod29ya2luZyBjb3B5KQpAQCAtMTYwLDcgKzE2MCw3IEBAIGlubGluZSBib29sIHdlYWtD b21wYXJlQW5kU3dhcCh1bnNpZ25lZCoKICAgICAgICAgImJuZS5uIDBmXG5cdCIKICAgICAgICAg InN0cmV4ICUxLCAlNCwgJTBcblx0IgogICAgICAgICAiMDoiCi0gICAgICAgIDogIittIigqbG9j YXRpb24pLCAiPSZyIihyZXN1bHQpLCAiPSZyIih0bXApCisgICAgICAgIDogIitRIigqbG9jYXRp b24pLCAiPSZyIihyZXN1bHQpLCAiPSZyIih0bXApCiAgICAgICAgIDogInIiKGV4cGVjdGVkKSwg InIiKG5ld1ZhbHVlKQogICAgICAgICA6ICJtZW1vcnkiKTsKICAgICByZXN1bHQgPSAhcmVzdWx0 Owo=