96392 2012-09-11 08:14:55 -0700 [BlackBerry] Colour Dialog popup request should return proper state. 2012-09-11 09:48:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mifenton mifenton tonikitoo webkit.review.bot oldest_to_newest 717183 0 mifenton 2012-09-11 08:14:55 -0700 The request always returns true regardless of whether the popup was launched. 717191 1 163367 mifenton 2012-09-11 08:23:29 -0700 Created attachment 163367 Patch 717264 2 163367 rwlbuis 2012-09-11 09:27:26 -0700 Comment on attachment 163367 Patch Looks good. 717289 3 163367 webkit.review.bot 2012-09-11 09:47:58 -0700 Comment on attachment 163367 Patch Clearing flags on attachment: 163367 Committed r128197: <http://trac.webkit.org/changeset/128197> 717290 4 webkit.review.bot 2012-09-11 09:48:01 -0700 All reviewed patches have been landed. Closing bug. 163367 2012-09-11 08:23:29 -0700 2012-09-11 09:47:58 -0700 Patch 0001-2012-09-10-Mike-Fenton-mifenton-rim.com.patch text/plain 2337 mifenton RnJvbSA0NWE1NTJiYThiY2QwODU3NmFmZTcwMDM2MjgwODdjOTdlY2I4MzAyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNaWtlIEZlbnRvbiA8bWlmZW50b25AcmltLmNvbT4KRGF0ZTog TW9uLCAxMCBTZXAgMjAxMiAwODoxOTo0MyAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTItMDkt MTAgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KCiAgICAgICAgUmV0dXJuIHByb3Bl ciBzdGF0ZSBmcm9tIG9wZW5Db2xvclBvcHVwIGRlcGVuZGVudCBvbgogICAgICAgIHdoZXRoZXIg dGhlIHBvcHVwIGFjdHVhbGx5IG9wZW5lZC4KCiAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgogICAgICAgICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgogICAgICAg IChCbGFja0JlcnJ5OjpXZWJLaXQ6OklucHV0SGFuZGxlcjo6b3BlbkNvbG9yUG9wdXApOgotLS0K IFNvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgIHwgICAx NSArKysrKysrKysrKysrKysKIC4uLi9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5k bGVyLmNwcCAgICAgIHwgICAgNCArKy0tCiAyIGZpbGVzIGNoYW5nZWQsIDE3IGluc2VydGlvbnMo KyksIDIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5 L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFuZ2VMb2cKaW5kZXggODIz ZjliOC4uODBjZmZkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTggQEAKKzIwMTItMDktMTEgIE1pa2UgRmVudG9uICA8bWlmZW50b25AcmltLmNvbT4KKworICAg ICAgICBbQmxhY2tCZXJyeV0gQ29sb3VyIERpYWxvZyBwb3B1cCByZXF1ZXN0IHNob3VsZCByZXR1 cm4gcHJvcGVyIHN0YXRlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9OTYzOTIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSZXR1cm4gcHJvcGVyIHN0YXRlIGZyb20gb3BlbkNvbG9yUG9wdXAgZGVwZW5kZW50 IG9uCisgICAgICAgIHdoZXRoZXIgdGhlIHBvcHVwIGFjdHVhbGx5IG9wZW5lZC4KKworICAgICAg ICBSZXZpZXdlZCBJbnRlcm5hbGx5IGJ5IENocmlzIEh1dHRlbi1DemFwc2tpCisKKyAgICAgICAg KiBXZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OklucHV0SGFuZGxlcjo6b3BlbkNvbG9yUG9wdXApOgorCiAyMDEyLTA5LTA5ICBBcnZp ZCBOaWxzc29uICA8YW5pbHNzb25AcmltLmNvbT4KIAogICAgICAgICBbQmxhY2tCZXJyeV0gRml4 IGZsaWNrZXIgZHVlIHRvIGludHJvZHVjdGlvbiBvZiB0aGUgZmVuY2UgZXh0ZW5zaW9uLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5k bGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFu ZGxlci5jcHAKaW5kZXggN2U1ZDQ2Mi4uYWEyZjdiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAorKysgYi9Tb3VyY2Uv V2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCkBAIC05ODAs OSArOTgwLDkgQEAgYm9vbCBJbnB1dEhhbmRsZXI6Om9wZW5Db2xvclBvcHVwKEhUTUxJbnB1dEVs ZW1lbnQqIGVsZW1lbnQpCiAKICAgICAvLyBDaGVjayBpZiBwb3B1cCBhbHJlYWR5IGV4aXN0cywg Y2xvc2UgaXQgaWYgZG9lcy4KICAgICBtX3dlYlBhZ2UtPm1fcGFnZS0+Y2hyb21lKCktPmNsaWVu dCgpLT5jbG9zZVBhZ2VQb3B1cCgwKTsKKwogICAgIENvbG9yUGlja2VyQ2xpZW50KiBjbGllbnQg PSBuZXcgQ29sb3JQaWNrZXJDbGllbnQoZWxlbWVudC0+dmFsdWUoKSwgbV93ZWJQYWdlLCBlbGVt ZW50KTsKLSAgICBtX3dlYlBhZ2UtPm1fcGFnZS0+Y2hyb21lKCktPmNsaWVudCgpLT5vcGVuUGFn ZVBvcHVwKGNsaWVudCwgIFdlYkNvcmU6OkludFJlY3QoKSk7Ci0gICAgcmV0dXJuIHRydWU7Cisg ICAgcmV0dXJuIG1fd2ViUGFnZS0+bV9wYWdlLT5jaHJvbWUoKS0+Y2xpZW50KCktPm9wZW5QYWdl UG9wdXAoY2xpZW50LCAgV2ViQ29yZTo6SW50UmVjdCgpKTsKIH0KIAogdm9pZCBJbnB1dEhhbmRs ZXI6OnNldElucHV0VmFsdWUoY29uc3QgV1RGOjpTdHJpbmcmIHZhbHVlKQotLSAKMS43LjkuNQoK