<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>96391</bug_id>
          
          <creation_ts>2012-09-11 08:12:56 -0700</creation_ts>
          <short_desc>[BlackBerry] Switching from Slogger to Slogger2 requires changes in CMakeList of webkit in order to include libraries of slog2</short_desc>
          <delta_ts>2012-09-14 06:08:15 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit BlackBerry</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Parth Patel">parpatel</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>gyuyoung.kim</cc>
    
    <cc>rakuco</cc>
    
    <cc>tonikitoo</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>717181</commentid>
    <comment_count>0</comment_count>
    <who name="Parth Patel">parpatel</who>
    <bug_when>2012-09-11 08:12:56 -0700</bug_when>
    <thetext>Modification in CMakelist in JavaScriptCore of webkit to include libraries of Slog2 in build files of webkit.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>717217</commentid>
    <comment_count>1</comment_count>
      <attachid>163376</attachid>
    <who name="Parth Patel">parpatel</who>
    <bug_when>2012-09-11 08:47:28 -0700</bug_when>
    <thetext>Created attachment 163376
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>717222</commentid>
    <comment_count>2</comment_count>
      <attachid>163376</attachid>
    <who name="Yong Li">yong.li.webkit</who>
    <bug_when>2012-09-11 08:50:26 -0700</bug_when>
    <thetext>Comment on attachment 163376
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=163376&amp;action=review

LGTM

&gt; Source/JavaScriptCore/ChangeLog:9
&gt; +        Changes in Cmake files of JavaScriptCore of webkit to include slog2 libs in build 

Cmake =&gt; CMake?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>717223</commentid>
    <comment_count>3</comment_count>
      <attachid>163376</attachid>
    <who name="Parth Patel">parpatel</who>
    <bug_when>2012-09-11 08:51:18 -0700</bug_when>
    <thetext>Comment on attachment 163376
Patch

request for commit-queue? after r+</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720657</commentid>
    <comment_count>4</comment_count>
      <attachid>163376</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-14 06:08:12 -0700</bug_when>
    <thetext>Comment on attachment 163376
Patch

Clearing flags on attachment: 163376

Committed r128599: &lt;http://trac.webkit.org/changeset/128599&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>720658</commentid>
    <comment_count>5</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-14 06:08:15 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>163376</attachid>
            <date>2012-09-11 08:47:28 -0700</date>
            <delta_ts>2012-09-14 06:08:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96391-20120911115143.patch</filename>
            <type>text/plain</type>
            <size>1579</size>
            <attacher name="Parth Patel">parpatel</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw
dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAz
MWRkMWZmYTBiNDc2OTIxZWMyZjMyZmQyNWFjYzIyMDEzMTVkZDIxLi4xZWUyOWVjMjJlZTBmOTRh
YWU3ZTVlZGE0MTgzYzQ0OTlkYWRjYjQ5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv
cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs
MyArMSwxNiBAQAorMjAxMi0wOS0xMSAgUGFydGggUGF0ZWwgIDxwYXJwYXRlbEByaW0uY29tPgor
CisgICAgICAgIFtCbGFja0JlcnJ5XSBTd2l0Y2hpbmcgZnJvbSBTbG9nZ2VyIHRvIFNsb2dnZXIy
IHJlcXVpcmVzIGNoYW5nZXMgaW4gQ01ha2VMaXN0IG9mIAorICAgICAgICB3ZWJraXQgaW4gb3Jk
ZXIgdG8gaW5jbHVkZSBsaWJyYXJpZXMgb2Ygc2xvZzIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MzkxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlcyBpbiBDbWFrZSBmaWxlcyBvZiBKYXZhU2Ny
aXB0Q29yZSBvZiB3ZWJraXQgdG8gaW5jbHVkZSBzbG9nMiBsaWJzIGluIGJ1aWxkIAorICAgICAg
ICBmaWxlcyBvZiB3ZWJraXQgaW4gcmVzcG9uc2UgdG8gc3dpdGNoaW5nIGZyb20gU2xvZ2dlciB0
byBTbG9nZ2VyMi4KKworICAgICAgICAqIHNoZWxsL1BsYXRmb3JtQmxhY2tCZXJyeS5jbWFrZToK
KwogMjAxMi0wOS0wOSAgR2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAg
ICAgIFJlZmFjdG9yZWQgb3BfdGVhcl9vZmYqIHRvIHN1cHBvcnQgYWN0aXZhdGlvbnMgdGhhdCBk
b24ndCBhbGxvY2F0ZSBzcGFjZSBmb3IgJ2FyZ3VtZW50cycKZGlmZiAtLWdpdCBhL1NvdXJjZS9K
YXZhU2NyaXB0Q29yZS9zaGVsbC9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvc2hlbGwvUGxhdGZvcm1CbGFja0JlcnJ5LmNtYWtlCmluZGV4IDQyNzExNDhj
NjZhZDU3ZmY3NmU3NjA3ZWM3Y2QzOTJmOWNjMzc5ZGMuLmFmZjc3Y2FmN2I1Y2Y4YmYxNjliYmQ3
MTRlZjE2NWJiZWE5ZWE5NTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9zaGVs
bC9QbGF0Zm9ybUJsYWNrQmVycnkuY21ha2UKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3No
ZWxsL1BsYXRmb3JtQmxhY2tCZXJyeS5jbWFrZQpAQCAtMSwzICsxLDQgQEAKK0ZJTkRfU1RBR0lO
R19MSUJSQVJZKFNMT0cyX0xJQlJBUlkgc2xvZzIpCiBMSVNUKEFQUEVORCBKU0NfTElCUkFSSUVT
CiAgICAgJHtJQ1VJMThOX0xJQlJBUll9CiAgICAgJHtJQ1VVQ19MSUJSQVJZfQpAQCAtNiw2ICs3
LDcgQEAgTElTVChBUFBFTkQgSlNDX0xJQlJBUklFUwogICAgICR7U2NyZWVuX0xJQlJBUll9CiAg
ICAgJHtTa2lhX1FOWF9MSUJSQVJZfQogICAgICR7V2ViS2l0UGxhdGZvcm1fTElCUkFSWX0KKyAg
ICAke1NMT0cyX0xJQlJBUll9CiApCiAKIElGIChQUk9GSUxJTkcpCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>