96389 2012-09-11 07:38:46 -0700 [BlackBerry] Take account for single words that exceed our client character limit 2012-09-11 08:08:23 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 nima.ghanavatian nima.ghanavatian mifenton tonikitoo webkit.review.bot oldest_to_newest 717152 0 nima.ghanavatian 2012-09-11 07:38:46 -0700 When spellchecking text we currently pool words up to a predefined character limit. We need to address the case where a single word exceeds this limit and skip it, continuing to check all words before and after it. 717154 1 163361 nima.ghanavatian 2012-09-11 07:42:12 -0700 Created attachment 163361 Patch 717157 2 163361 rwlbuis 2012-09-11 07:45:31 -0700 Comment on attachment 163361 Patch Looks good. 717174 3 163361 webkit.review.bot 2012-09-11 08:08:21 -0700 Comment on attachment 163361 Patch Clearing flags on attachment: 163361 Committed r128188: <http://trac.webkit.org/changeset/128188> 717175 4 webkit.review.bot 2012-09-11 08:08:23 -0700 All reviewed patches have been landed. Closing bug. 163361 2012-09-11 07:42:12 -0700 2012-09-11 08:08:20 -0700 Patch bug-96389-20120911103724.patch text/plain 3589 nima.ghanavatian U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3OTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0NjhmNWZiZGU1YTEzZTliYjRiMTJkOWFkNjA0ZTQ5ZTNlN2Y0Y2IyLi4wNzY0ZmFkZjlh ZjQ3MGJkYzNiNzM1OTZkNGIzOTQ3NjQ5OWIwNjM5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMi0wOS0xMCAgTmltYSBHaGFuYXZhdGlhbiAgPG5n aGFuYXZhdGlhbkByaW0uY29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBUYWtlIGFjY291bnQg Zm9yIHNpbmdsZSB3b3JkcyB0aGF0IGV4Y2VlZCBvdXIgY2xpZW50IGNoYXJhY3RlciBsaW1pdAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYzODkKKwor ICAgICAgICBGaXggdG8gdGhlIHByb2Nlc3Npbmcgb2YgbG9uZyBzaW5nbGUtbGluZSB0ZXh0IHVz aW5nIGdldFJhbmdlRm9yU3BlbGxDaGVja1dpdGhGaW5lR3JhbnVsYXJpdHkuCisgICAgICAgIFRo aXMgd2FzIGZhaWxpbmcgaWYgYSBzaW5nbGUgd29yZCB3YXMgbG9uZ2VyIHRoYW4gb3VyIG1heGlt dW0gYWxsb3dlZCBsaW1pdC4KKworICAgICAgICBJbnRlcm5hbGx5IHJldmlld2VkIGJ5IE1pa2Ug RmVudG9uLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwOgorICAgICAgICAoV2ViS2l0KToKKyAg ICAgICAgKEJsYWNrQmVycnk6OldlYktpdDo6SW5wdXRIYW5kbGVyOjpnZXRSYW5nZUZvclNwZWxs Q2hlY2tXaXRoRmluZUdyYW51bGFyaXR5KToKKwogMjAxMi0wOS0wOCAgTWF4IEZlaWwgIDxtZmVp bEByaW0uY29tPgogCiAgICAgICAgIFtCbGFja0JlcnJ5XSBFeGl0aW5nIGZ1bGxzY3JlZW4gbW9k ZSBjYW4gbGVhdmUgdXNlciBzdHVjayB3aXRob3V0IEJyb3dzZXIgbWVudXMKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAg Yi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3Bw CmluZGV4IGE0YWQ2NjY5M2VlNjNhYWMxNDliYTdiMTMxZjI0ZTkyNDI3NTZiNDAuLjE4ZjNlMTBk YjA5YzEyYTJmOWY5MzhjNGI3ZDg3MzEyMWE3M2VjOWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKKysrIGIvU291cmNl L1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcApAQCAtOTI5 LDE0ICs5MjksMjQgQEAgdm9pZCBJbnB1dEhhbmRsZXI6OnNwZWxsQ2hlY2tCbG9jayhWaXNpYmxl U2VsZWN0aW9uJiB2aXNpYmxlU2VsZWN0aW9uLCBUZXh0Q2hlY2sKIFBhc3NSZWZQdHI8UmFuZ2U+ IElucHV0SGFuZGxlcjo6Z2V0UmFuZ2VGb3JTcGVsbENoZWNrV2l0aEZpbmVHcmFudWxhcml0eShW aXNpYmxlUG9zaXRpb24gc3RhcnRQb3NpdGlvbiwgVmlzaWJsZVBvc2l0aW9uIGVuZFBvc2l0aW9u KQogewogICAgIFZpc2libGVQb3NpdGlvbiBlbmRPZkN1cnJlbnRXb3JkID0gZW5kT2ZXb3JkKHN0 YXJ0UG9zaXRpb24pOwotICAgIFJlZlB0cjxSYW5nZT4gcmFuZ2VGb3JTcGVsbENoZWNraW5nOwot ICAgIHdoaWxlIChlbmRPZkN1cnJlbnRXb3JkICE9IGVuZFBvc2l0aW9uKSB7Ci0gICAgICAgIHJh bmdlRm9yU3BlbGxDaGVja2luZyA9IFZpc2libGVTZWxlY3Rpb24oc3RhcnRQb3NpdGlvbiwgZW5k T2ZDdXJyZW50V29yZCkudG9Ob3JtYWxpemVkUmFuZ2UoKTsKLSAgICAgICAgLy8gSWYgd2UgZXhj ZWVkIHRoZSBNYXhTcGVsbENoZWNraW5nU3RyaW5nTGVuZ3RoIGxpbWl0LCB0aGVuIGdvIGJhY2sg b25lIHdvcmQgYW5kIHJldHVybiB0aGlzIHJhbmdlLgotICAgICAgICBpZiAocmFuZ2VGb3JTcGVs bENoZWNraW5nLT50ZXh0KCkubGVuZ3RoKCkgPj0gTWF4U3BlbGxDaGVja2luZ1N0cmluZ0xlbmd0 aCkKLSAgICAgICAgICAgIHJldHVybiBWaXNpYmxlU2VsZWN0aW9uKHN0YXJ0UG9zaXRpb24sIGVu ZE9mV29yZChwcmV2aW91c1dvcmRQb3NpdGlvbihlbmRPZkN1cnJlbnRXb3JkKSkpLnRvTm9ybWFs aXplZFJhbmdlKCk7Ci0KLSAgICAgICAgZW5kT2ZDdXJyZW50V29yZCA9IGVuZE9mV29yZChuZXh0 V29yZFBvc2l0aW9uKGVuZE9mQ3VycmVudFdvcmQpKTsKKworICAgIC8vIEtlZXAgaXRlcmF0aW5n IHVudGlsIG9uZSBvZiBvdXIgY2FzZXMgaXMgaGl0LCBvciB3ZSd2ZSBpbmNyZW1lbnRlZCB0aGUg c3RhcnRpbmcgcG9zaXRpb24gcmlnaHQgdG8gdGhlIGVuZC4KKyAgICB3aGlsZSAoc3RhcnRQb3Np dGlvbiAhPSBlbmRQb3NpdGlvbikgeworICAgICAgICAvLyBDaGVjayB0aGUgdGV4dCBsZW5ndGgg d2l0aGluIHRoaXMgcmFuZ2UuCisgICAgICAgIGlmIChWaXNpYmxlU2VsZWN0aW9uKHN0YXJ0UG9z aXRpb24sIGVuZE9mQ3VycmVudFdvcmQpLnRvTm9ybWFsaXplZFJhbmdlKCktPnRleHQoKS5sZW5n dGgoKSA+PSBNYXhTcGVsbENoZWNraW5nU3RyaW5nTGVuZ3RoKSB7CisgICAgICAgICAgICAvLyBJ ZiB0aGlzIGlzIG5vdCB0aGUgZmlyc3Qgd29yZCwgcmV0dXJuIGEgUmFuZ2Ugd2l0aCBlbmQgYm91 bmRhcnkgc2V0IHRvIHRoZSBwcmV2aW91cyB3b3JkLgorICAgICAgICAgICAgaWYgKHN0YXJ0T2ZX b3JkKGVuZE9mQ3VycmVudFdvcmQsIExlZnRXb3JkSWZPbkJvdW5kYXJ5KSAhPSBzdGFydFBvc2l0 aW9uKQorICAgICAgICAgICAgICAgIHJldHVybiBWaXNpYmxlU2VsZWN0aW9uKHN0YXJ0UG9zaXRp b24sIGVuZE9mV29yZChwcmV2aW91c1dvcmRQb3NpdGlvbihlbmRPZkN1cnJlbnRXb3JkKSwgTGVm dFdvcmRJZk9uQm91bmRhcnkpKS50b05vcm1hbGl6ZWRSYW5nZSgpOworCisgICAgICAgICAgICAv LyBPdXIgZmlyc3Qgd29yZCBoYXMgZ29uZSBvdmVyIHRoZSBjaGFyYWN0ZXIgbGltaXQuIEluY3Jl bWVudCB0aGUgc3RhcnRpbmcgcG9zaXRpb24gcGFzdCBhbiB1bmNoZWNrYWJsZSB3b3JkLgorICAg ICAgICAgICAgc3RhcnRQb3NpdGlvbiA9IGVuZE9mQ3VycmVudFdvcmQ7CisgICAgICAgIH0gZWxz ZSBpZiAoZW5kT2ZDdXJyZW50V29yZCA9PSBlbmRQb3NpdGlvbikgeworICAgICAgICAgICAgLy8g UmV0dXJuIHRoZSBsYXN0IHNlZ21lbnQgaWYgdGhlIGVuZCBvZiBvdXIgd29yZCBsaWVzIGF0IHRo ZSBlbmQgb2YgdGhlIHJhbmdlLgorICAgICAgICAgICAgcmV0dXJuIFZpc2libGVTZWxlY3Rpb24o c3RhcnRQb3NpdGlvbiwgZW5kUG9zaXRpb24pLnRvTm9ybWFsaXplZFJhbmdlKCk7CisgICAgICAg IH0gZWxzZSB7CisgICAgICAgICAgICAvLyBJbmNyZW1lbnQgdGhlIGN1cnJlbnQgd29yZC4KKyAg ICAgICAgICAgIGVuZE9mQ3VycmVudFdvcmQgPSBlbmRPZldvcmQobmV4dFdvcmRQb3NpdGlvbihl bmRPZkN1cnJlbnRXb3JkKSk7CisgICAgICAgIH0KICAgICB9CiAgICAgcmV0dXJuIDA7CiB9Cg==