96378 2012-09-11 05:18:28 -0700 [BlackBerry] SelectionHandler drops caret change notifications 2012-09-11 07:30:01 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 anilsson anilsson mifenton tonikitoo webkit.review.bot oldest_to_newest 717069 0 anilsson 2012-09-11 05:18:28 -0700 The selection handler deliberately drops caret change notifications while the input handler is processing changes, to avoid displaying intermediate state during a complex change. However, this means that the client is never informed of the final caret position. 717109 1 163349 anilsson 2012-09-11 06:31:30 -0700 Created attachment 163349 Patch 717122 2 163349 anilsson 2012-09-11 07:02:23 -0700 Comment on attachment 163349 Patch Thanks Mike and Antonio! 717140 3 163349 webkit.review.bot 2012-09-11 07:29:56 -0700 Comment on attachment 163349 Patch Clearing flags on attachment: 163349 Committed r128183: <http://trac.webkit.org/changeset/128183> 717141 4 webkit.review.bot 2012-09-11 07:30:01 -0700 All reviewed patches have been landed. Closing bug. 163349 2012-09-11 06:31:30 -0700 2012-09-11 07:29:56 -0700 Patch bug-96378-20120911153104.patch text/plain 7304 anilsson U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3OTc1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCA0NjhmNWZiZGU1YTEzZTliYjRiMTJkOWFkNjA0ZTQ5ZTNlN2Y0Y2IyLi4zZTU0YTkxZDU2 ZGY0ODZkZTJkNDEzMTI3N2Y4ZjM1YzAxZDU0ZjdiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwzOCBAQAorMjAxMi0wOS0xMSAgQXJ2aWQgTmlsc3NvbiAgPGFuaWxz c29uQHJpbS5jb20+CisKKyAgICAgICAgW0JsYWNrQmVycnldIFNlbGVjdGlvbkhhbmRsZXIgZHJv cHMgY2FyZXQgY2hhbmdlIG5vdGlmaWNhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk2Mzc4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIHNlbGVjdGlvbiBoYW5kbGVyIGRlbGliZXJhdGVseSBk cm9wcyBjYXJldCBjaGFuZ2Ugbm90aWZpY2F0aW9ucworICAgICAgICB3aGlsZSB0aGUgaW5wdXQg aGFuZGxlciBpcyBwcm9jZXNzaW5nIGNoYW5nZXMsIHRvIGF2b2lkIGRpc3BsYXlpbmcKKyAgICAg ICAgaW50ZXJtZWRpYXRlIHN0YXRlIGR1cmluZyBhIGNvbXBsZXggY2hhbmdlLgorCisgICAgICAg IEhvd2V2ZXIsIHRoaXMgbWVhbnQgdGhhdCB0aGUgY2xpZW50IHdhcyBuZXZlciBpbmZvcm1lZCBv ZiB0aGUgZmluYWwKKyAgICAgICAgY2FyZXQgcG9zaXRpb24uCisKKyAgICAgICAgRml4ZWQgYnkg bm90aWZ5aW5nIGNsaWVudCBhYm91dCBjYXJldCBjaGFuZ2UgYWZ0ZXIgcHJvY2Vzc2luZyBlbmRz LCBpZgorICAgICAgICBvbmUgb3IgbW9yZSBjYXJldCBjaGFuZ2Ugbm90aWZpY2F0aW9ucyB3ZXJl IGRyb3BwZWQgZHVyaW5nIHByb2Nlc3NpbmcuCisKKyAgICAgICAgUFIgIzIwNTA3MworCisgICAg ICAgIFJldmlld2VkIGludGVybmFsbHkgYnkgTWlrZSBGZW50b24uCisKKyAgICAgICAgKiBXZWJL aXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6 OklucHV0SGFuZGxlcjo6c2V0UHJvY2Vzc2luZ0NoYW5nZSk6CisgICAgICAgIChXZWJLaXQpOgor ICAgICAgICAqIFdlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmg6CisgICAgICAgIChJbnB1dEhh bmRsZXIpOgorICAgICAgICAqIFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHA6Cisg ICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OlNlbGVjdGlvbkhh bmRsZXIpOgorICAgICAgICAoQmxhY2tCZXJyeTo6V2ViS2l0OjpTZWxlY3Rpb25IYW5kbGVyOjpp bnB1dEhhbmRsZXJEaWRGaW5pc2hQcm9jZXNzaW5nQ2hhbmdlKToKKyAgICAgICAgKFdlYktpdCk6 CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlvbkhhbmRsZXI6OnNlbGVjdGlv blBvc2l0aW9uQ2hhbmdlZCk6CisgICAgICAgIChCbGFja0JlcnJ5OjpXZWJLaXQ6OlNlbGVjdGlv bkhhbmRsZXI6Om5vdGlmeUNhcmV0UG9zaXRpb25DaGFuZ2VkSWZOZWVkZWQpOgorICAgICAgICAq IFdlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oOgorICAgICAgICAoU2VsZWN0aW9uSGFu ZGxlcik6CisKIDIwMTItMDktMDggIE1heCBGZWlsICA8bWZlaWxAcmltLmNvbT4KIAogICAgICAg ICBbQmxhY2tCZXJyeV0gRXhpdGluZyBmdWxsc2NyZWVuIG1vZGUgY2FuIGxlYXZlIHVzZXIgc3R1 Y2sgd2l0aG91dCBCcm93c2VyIG1lbnVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFj a2JlcnJ5L1dlYktpdFN1cHBvcnQvSW5wdXRIYW5kbGVyLmNwcAppbmRleCA3OWRmNTFjY2M0MjYx NzFiNWY5ZGFkZGQ4N2U4ZWIwMTA3NGE4ZDIzLi44ZjMxMGRhOGQ1OWNiMDUwNWFhZDQ2MDg3YmRj MTJhZTE0YTI3Y2FjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkvV2ViS2l0 U3VwcG9ydC9JbnB1dEhhbmRsZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9X ZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5jcHAKQEAgLTMzOCw2ICszMzgsMTcgQEAgc3RhdGlj IFZpcnR1YWxLZXlib2FyZEVudGVyS2V5VHlwZSBrZXlib2FyZEVudGVyS2V5VHlwZUF0dHJpYnV0 ZShjb25zdCBXZWJDb3JlOjoKICAgICByZXR1cm4gVktCRW50ZXJLZXlOb3RTZXQ7CiB9CiAKK3Zv aWQgSW5wdXRIYW5kbGVyOjpzZXRQcm9jZXNzaW5nQ2hhbmdlKGJvb2wgcHJvY2Vzc2luZ0NoYW5n ZSkKK3sKKyAgICBpZiAocHJvY2Vzc2luZ0NoYW5nZSA9PSBtX3Byb2Nlc3NpbmdDaGFuZ2UpCisg ICAgICAgIHJldHVybjsKKworICAgIG1fcHJvY2Vzc2luZ0NoYW5nZSA9IHByb2Nlc3NpbmdDaGFu Z2U7CisKKyAgICBpZiAoIW1fcHJvY2Vzc2luZ0NoYW5nZSkKKyAgICAgICAgbV93ZWJQYWdlLT5t X3NlbGVjdGlvbkhhbmRsZXItPmlucHV0SGFuZGxlckRpZEZpbmlzaFByb2Nlc3NpbmdDaGFuZ2Uo KTsKK30KKwogV1RGOjpTdHJpbmcgSW5wdXRIYW5kbGVyOjplbGVtZW50VGV4dCgpCiB7CiAgICAg aWYgKCFpc0FjdGl2ZVRleHRFZGl0KCkpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2JsYWNr YmVycnkvV2ViS2l0U3VwcG9ydC9JbnB1dEhhbmRsZXIuaCBiL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L0lucHV0SGFuZGxlci5oCmluZGV4IGYwZWNiN2RmZWY3YjkyMTcz M2MwN2QyYjI4OGJkYjAyYjllOTdiNWYuLmU2ZDMyOTdmNzBlOTU3ZmYyNzM2NGE2NTk5MDU2ZWQw OWE3ZGFjZmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBw b3J0L0lucHV0SGFuZGxlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRT dXBwb3J0L0lucHV0SGFuZGxlci5oCkBAIC0xMTAsNyArMTEwLDcgQEAgcHVibGljOgogICAgIHZv aWQgc2V0UG9wdXBMaXN0SW5kZXhlcyhpbnQgc2l6ZSwgY29uc3QgYm9vbCogc2VsZWN0ZWRzKTsK IAogICAgIGJvb2wgcHJvY2Vzc2luZ0NoYW5nZSgpIGNvbnN0IHsgcmV0dXJuIG1fcHJvY2Vzc2lu Z0NoYW5nZTsgfQotICAgIHZvaWQgc2V0UHJvY2Vzc2luZ0NoYW5nZShib29sIHByb2Nlc3NpbmdD aGFuZ2UpIHsgbV9wcm9jZXNzaW5nQ2hhbmdlID0gcHJvY2Vzc2luZ0NoYW5nZTsgfQorICAgIHZv aWQgc2V0UHJvY2Vzc2luZ0NoYW5nZShib29sKTsKIAogICAgIFdURjo6U3RyaW5nIGVsZW1lbnRU ZXh0KCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9XZWJLaXRTdXBw b3J0L1NlbGVjdGlvbkhhbmRsZXIuY3BwIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKaW5kZXggMjQwOTM4ZDkyYWM0YzE1YmFmZWFi NjFlNGYxNDFiNDYwOGI5NGIzMy4uNmE2YzI5M2QwZTNlMWMxM2M4MzQxMjAwMTFlMzk1NGY5M2Ey Njk4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQv U2VsZWN0aW9uSGFuZGxlci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L1dlYktp dFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5jcHAKQEAgLTcwLDYgKzcwLDcgQEAgU2VsZWN0aW9u SGFuZGxlcjo6U2VsZWN0aW9uSGFuZGxlcihXZWJQYWdlUHJpdmF0ZSogcGFnZSkKICAgICAsIG1f c2VsZWN0aW9uQWN0aXZlKGZhbHNlKQogICAgICwgbV9jYXJldEFjdGl2ZShmYWxzZSkKICAgICAs IG1fbGFzdFVwZGF0ZWRFbmRQb2ludElzVmFsaWQoZmFsc2UpCisgICAgLCBtX2RpZFN1cHByZXNz Q2FyZXRQb3NpdGlvbkNoYW5nZWROb3RpZmljYXRpb24oZmFsc2UpCiB7CiB9CiAKQEAgLTI3MCw2 ICsyNzEsMTIgQEAgdm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpzZXRDYXJldFBvc2l0aW9uKGNvbnN0 IFdlYkNvcmU6OkludFBvaW50ICZwb3NpdGlvbikKICAgICBTZWxlY3Rpb25Mb2coTG9nTGV2ZWxJ bmZvLCAiU2VsZWN0aW9uSGFuZGxlcjo6c2V0Q2FyZXRQb3NpdGlvbiBwb2ludCB2YWxpZCwgY3Vy c29yIHVwZGF0ZWQiKTsKIH0KIAordm9pZCBTZWxlY3Rpb25IYW5kbGVyOjppbnB1dEhhbmRsZXJE aWRGaW5pc2hQcm9jZXNzaW5nQ2hhbmdlKCkKK3sKKyAgICBpZiAobV9kaWRTdXBwcmVzc0NhcmV0 UG9zaXRpb25DaGFuZ2VkTm90aWZpY2F0aW9uKQorICAgICAgICBub3RpZnlDYXJldFBvc2l0aW9u Q2hhbmdlZElmTmVlZGVkKCk7Cit9CisKIC8vIFRoaXMgZnVuY3Rpb24gbWFrZXMgc3VyZSB3ZSBh cmUgbm90IHJlZHVjaW5nIHRoZSBzZWxlY3Rpb24gdG8gYSBjYXJldCBzZWxlY3Rpb24uCiBzdGF0 aWMgYm9vbCBzaG91bGRFeHRlbmRTZWxlY3Rpb25JbkRpcmVjdGlvbihjb25zdCBWaXNpYmxlU2Vs ZWN0aW9uJiBzZWxlY3Rpb24sIHVuc2lnbmVkIHNob3J0IGNoYXJhY3RlcikKIHsKQEAgLTg3MCwx MyArODc3LDE0IEBAIHZvaWQgU2VsZWN0aW9uSGFuZGxlcjo6c2VsZWN0aW9uUG9zaXRpb25DaGFu Z2VkKGJvb2wgZm9yY2VVcGRhdGVXaXRob3V0Q2hhbmdlKQogCiAgICAgaWYgKG1fd2ViUGFnZS0+ bV9pbnB1dEhhbmRsZXItPmlzSW5wdXRNb2RlKCkgJiYgbV93ZWJQYWdlLT5tX2lucHV0SGFuZGxl ci0+cHJvY2Vzc2luZ0NoYW5nZSgpKSB7CiAgICAgICAgIG1fd2ViUGFnZS0+bV9jbGllbnQtPmNh bmNlbFNlbGVjdGlvblZpc3VhbHMoKTsKKworICAgICAgICAvLyBTaW5jZSB3ZSdyZSBub3QgY2Fs bGluZyBub3RpZnlDYXJldFBvc2l0aW9uQ2hhbmdlZElmTmVlZGVkIG5vdywgd2UgaGF2ZSB0byBk byBzbyBhdCB0aGUgZW5kIG9mIHByb2Nlc3NpbmcKKyAgICAgICAgLy8gdG8gYXZvaWQgZHJvcHBp bmcgYSBub3RpZmljYXRpb24uCisgICAgICAgIG1fZGlkU3VwcHJlc3NDYXJldFBvc2l0aW9uQ2hh bmdlZE5vdGlmaWNhdGlvbiA9IHRydWU7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAKLSAgICBp ZiAobV9jYXJldEFjdGl2ZSB8fCAobV93ZWJQYWdlLT5tX2lucHV0SGFuZGxlci0+aXNJbnB1dE1v ZGUoKSAmJiBtX3dlYlBhZ2UtPmZvY3VzZWRPck1haW5GcmFtZSgpLT5zZWxlY3Rpb24oKS0+aXND YXJldCgpKSkgewotICAgICAgICAvLyBUaGlzIG1heSB1cGRhdGUgdGhlIGNhcmV0IHRvIG5vIGxv bmdlciBiZSBhY3RpdmUuCi0gICAgICAgIGNhcmV0UG9zaXRpb25DaGFuZ2VkKCk7Ci0gICAgfQor ICAgIG5vdGlmeUNhcmV0UG9zaXRpb25DaGFuZ2VkSWZOZWVkZWQoKTsKIAogICAgIC8vIEVudGVy IHNlbGVjdGlvbiBtb2RlIGlmIHNlbGVjdGlvbiB0eXBlIGlzIFJhbmdlU2VsZWN0aW9uLCBhbmQg ZGlzYWJsZSBzZWxlY3Rpb24gaWYKICAgICAvLyBzZWxlY3Rpb24gaXMgYWN0aXZlIGFuZCBiZWNv bWVzIGNhcmV0IHNlbGVjdGlvbi4KQEAgLTk2NSw2ICs5NzMsMTcgQEAgdm9pZCBTZWxlY3Rpb25I YW5kbGVyOjpzZWxlY3Rpb25Qb3NpdGlvbkNoYW5nZWQoYm9vbCBmb3JjZVVwZGF0ZVdpdGhvdXRD aGFuZ2UpCiAgICAgU2VsZWN0aW9uVGltaW5nTG9nKExvZ0xldmVsSW5mbywgIlNlbGVjdGlvbkhh bmRsZXI6OnNlbGVjdGlvblBvc2l0aW9uQ2hhbmdlZCBjb21wbGV0ZWQgYXQgJWYiLCBtX3RpbWVy LmVsYXBzZWQoKSk7CiB9CiAKKwordm9pZCBTZWxlY3Rpb25IYW5kbGVyOjpub3RpZnlDYXJldFBv c2l0aW9uQ2hhbmdlZElmTmVlZGVkKCkKK3sKKyAgICBtX2RpZFN1cHByZXNzQ2FyZXRQb3NpdGlv bkNoYW5nZWROb3RpZmljYXRpb24gPSBmYWxzZTsKKworICAgIGlmIChtX2NhcmV0QWN0aXZlIHx8 IChtX3dlYlBhZ2UtPm1faW5wdXRIYW5kbGVyLT5pc0lucHV0TW9kZSgpICYmIG1fd2ViUGFnZS0+ Zm9jdXNlZE9yTWFpbkZyYW1lKCktPnNlbGVjdGlvbigpLT5pc0NhcmV0KCkpKSB7CisgICAgICAg IC8vIFRoaXMgbWF5IHVwZGF0ZSB0aGUgY2FyZXQgdG8gbm8gbG9uZ2VyIGJlIGFjdGl2ZS4KKyAg ICAgICAgY2FyZXRQb3NpdGlvbkNoYW5nZWQoKTsKKyAgICB9Cit9CisKIC8vIE5PVEU6IFRoaXMg ZnVuY3Rpb24gaXMgbm90IGluIFdlYktpdCBjb29yZGluYXRlcy4KIHZvaWQgU2VsZWN0aW9uSGFu ZGxlcjo6Y2FyZXRQb3NpdGlvbkNoYW5nZWQoKQogewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oIGIvU291cmNlL1dl YktpdC9ibGFja2JlcnJ5L1dlYktpdFN1cHBvcnQvU2VsZWN0aW9uSGFuZGxlci5oCmluZGV4IDMx YjI1Mjg2YzI2YzllNDQyMDI2M2U1YTk4OWRmMWFjZWFmZGQyMTEuLmExOGVhMzdjNDE4ZmUzZWFk YjQ0MTBhZWRlNmVmZWVmOTM5NmMyYzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvYmxhY2ti ZXJyeS9XZWJLaXRTdXBwb3J0L1NlbGVjdGlvbkhhbmRsZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvV2ViS2l0U3VwcG9ydC9TZWxlY3Rpb25IYW5kbGVyLmgKQEAgLTcyLDcgKzcy LDEwIEBAIHB1YmxpYzoKIAogICAgIGJvb2wgbGFzdFVwZGF0ZWRFbmRQb2ludElzVmFsaWQoKSBj b25zdCB7IHJldHVybiBtX2xhc3RVcGRhdGVkRW5kUG9pbnRJc1ZhbGlkOyB9CiAKKyAgICB2b2lk IGlucHV0SGFuZGxlckRpZEZpbmlzaFByb2Nlc3NpbmdDaGFuZ2UoKTsKKwogcHJpdmF0ZToKKyAg ICB2b2lkIG5vdGlmeUNhcmV0UG9zaXRpb25DaGFuZ2VkSWZOZWVkZWQoKTsKICAgICB2b2lkIGNh cmV0UG9zaXRpb25DaGFuZ2VkKCk7CiAgICAgdm9pZCByZWdpb25Gb3JUZXh0UXVhZHMoV1RGOjpW ZWN0b3I8V2ViQ29yZTo6RmxvYXRRdWFkPiYsIEJsYWNrQmVycnk6OlBsYXRmb3JtOjpJbnRSZWN0 UmVnaW9uJiwgYm9vbCBzaG91bGRDbGlwVG9WaXNpYmxlQ29udGVudCA9IHRydWUpIGNvbnN0Owog ICAgIFdlYkNvcmU6OkludFJlY3QgY2xpcHBpbmdSZWN0Rm9yVmlzaWJsZUNvbnRlbnQoKSBjb25z dDsKQEAgLTkwLDYgKzkzLDcgQEAgcHJpdmF0ZToKICAgICBib29sIG1fc2VsZWN0aW9uQWN0aXZl OwogICAgIGJvb2wgbV9jYXJldEFjdGl2ZTsKICAgICBib29sIG1fbGFzdFVwZGF0ZWRFbmRQb2lu dElzVmFsaWQ7CisgICAgYm9vbCBtX2RpZFN1cHByZXNzQ2FyZXRQb3NpdGlvbkNoYW5nZWROb3Rp ZmljYXRpb247CiAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OkludFJlY3RSZWdpb24gbV9sYXN0 U2VsZWN0aW9uUmVnaW9uOwogCiAgICAgQmxhY2tCZXJyeTo6UGxhdGZvcm06OlN0b3BXYXRjaCBt X3RpbWVyOwo=