96370 2012-09-11 03:02:30 -0700 Clean up functions in RenderLayerBacking.h/.cpp 2012-09-11 14:10:19 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Minor --- 1 cabanier webkit-unassigned eric simon.fraser webkit.review.bot oldest_to_newest 716999 0 cabanier 2012-09-11 03:02:30 -0700 Remove 'layer' from function names in RenderLayerBacking 717004 1 163319 cabanier 2012-09-11 03:07:13 -0700 Created attachment 163319 first try 717536 2 163319 webkit.review.bot 2012-09-11 14:10:16 -0700 Comment on attachment 163319 first try Clearing flags on attachment: 163319 Committed r128225: <http://trac.webkit.org/changeset/128225> 717538 3 webkit.review.bot 2012-09-11 14:10:19 -0700 All reviewed patches have been landed. Closing bug. 163319 2012-09-11 03:07:13 -0700 2012-09-11 14:10:16 -0700 first try patch text/plain 6299 cabanier SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODE2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDEyLTA5LTExICBSaWsgQ2Fi YW5pZXIgIDxjYWJhbmllckBhZG9iZS5jb20+CisKKyAgICAgICAgQ2xlYW4gdXAgZnVuY3Rpb25z IGluIFJlbmRlckxheWVyQmFja2luZy5oLy5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MzcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlICdsYXllcicgZnJvbSBmdW5jdGlvbiBuYW1lcyBp biBSZW5kZXJMYXllckJhY2tpbmcKKworICAgICAgICBObyBuZXcgdGVzdC4gTm8gY2hhbmdlIGlu IGZ1bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyTGF5ZXJCYWNraW5n LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6Y3JlYXRlUHJpbWFy eUdyYXBoaWNzTGF5ZXIpOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyTGF5ZXJCYWNraW5nOjp1 cGRhdGVPcGFjaXR5KToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6dXBk YXRlVHJhbnNmb3JtKToKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckxheWVyQmFja2luZzo6dXBk YXRlRmlsdGVycyk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0 ZUdyYXBoaWNzTGF5ZXJHZW9tZXRyeSk6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJMYXllckJh Y2tpbmc6OnN0YXJ0VHJhbnNpdGlvbik6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckxheWVy QmFja2luZy5oOgorICAgICAgICAoUmVuZGVyTGF5ZXJCYWNraW5nKToKKwogMjAxMi0wOS0xMSAg RGFuIENhcm5leSAgPGRjYXJuZXlAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZW1vdmVkIFY4SXNv bGF0ZWRDb250ZXh0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTGF5ZXJC YWNraW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmNwcAkocmV2aXNpb24gMTI4MTQ0KQorKysgU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckxheWVyQmFja2luZy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwMCwxMCAr MjAwLDEwIEBAIHZvaWQgUmVuZGVyTGF5ZXJCYWNraW5nOjpjcmVhdGVQcmltYXJ5R3IKICAgICB9 CiAjZW5kaWYgICAgCiAgICAgCi0gICAgdXBkYXRlTGF5ZXJPcGFjaXR5KHJlbmRlcmVyKCktPnN0 eWxlKCkpOwotICAgIHVwZGF0ZUxheWVyVHJhbnNmb3JtKHJlbmRlcmVyKCktPnN0eWxlKCkpOwor ICAgIHVwZGF0ZU9wYWNpdHkocmVuZGVyZXIoKS0+c3R5bGUoKSk7CisgICAgdXBkYXRlVHJhbnNm b3JtKHJlbmRlcmVyKCktPnN0eWxlKCkpOwogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKLSAgICB1 cGRhdGVMYXllckZpbHRlcnMocmVuZGVyZXIoKS0+c3R5bGUoKSk7CisgICAgdXBkYXRlRmlsdGVy cyhyZW5kZXJlcigpLT5zdHlsZSgpKTsKICNlbmRpZgogI2lmIEVOQUJMRShDU1NfQ09NUE9TSVRJ TkcpCiAgICAgdXBkYXRlTGF5ZXJCbGVuZE1vZGUocmVuZGVyZXIoKS0+c3R5bGUoKSk7CkBAIC0y MjQsMTIgKzIyNCwxMiBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6ZGVzdHJveUdyYXBoaWNz CiAgICAgbV9zY3JvbGxpbmdDb250ZW50c0xheWVyID0gbnVsbHB0cjsKIH0KIAotdm9pZCBSZW5k ZXJMYXllckJhY2tpbmc6OnVwZGF0ZUxheWVyT3BhY2l0eShjb25zdCBSZW5kZXJTdHlsZSogc3R5 bGUpCit2b2lkIFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlT3BhY2l0eShjb25zdCBSZW5kZXJT dHlsZSogc3R5bGUpCiB7CiAgICAgbV9ncmFwaGljc0xheWVyLT5zZXRPcGFjaXR5KGNvbXBvc2l0 aW5nT3BhY2l0eShzdHlsZS0+b3BhY2l0eSgpKSk7CiB9CiAKLXZvaWQgUmVuZGVyTGF5ZXJCYWNr aW5nOjp1cGRhdGVMYXllclRyYW5zZm9ybShjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpCit2b2lk IFJlbmRlckxheWVyQmFja2luZzo6dXBkYXRlVHJhbnNmb3JtKGNvbnN0IFJlbmRlclN0eWxlKiBz dHlsZSkKIHsKICAgICAvLyBGSVhNRTogVGhpcyBjb3VsZCB1c2UgbV9vd25pbmdMYXllci0+dHJh bnNmb3JtKCksIGJ1dCB0aGF0IGN1cnJlbnRseSBoYXMgdHJhbnNmb3JtLW9yaWdpbgogICAgIC8v IGJha2VkIGludG8gaXQsIGFuZCB3ZSBkb24ndCB3YW50IHRoYXQuCkBAIC0yNDMsNyArMjQzLDcg QEAgdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUxheWVyVHJhbgogfQogCiAjaWYgRU5B QkxFKENTU19GSUxURVJTKQotdm9pZCBSZW5kZXJMYXllckJhY2tpbmc6OnVwZGF0ZUxheWVyRmls dGVycyhjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpCit2b2lkIFJlbmRlckxheWVyQmFja2luZzo6 dXBkYXRlRmlsdGVycyhjb25zdCBSZW5kZXJTdHlsZSogc3R5bGUpCiB7CiAgICAgbV9jYW5Db21w b3NpdGVGaWx0ZXJzID0gbV9ncmFwaGljc0xheWVyLT5zZXRGaWx0ZXJzKHN0eWxlLT5maWx0ZXIo KSk7CiB9CkBAIC00NjUsMTQgKzQ2NSwxNCBAQCB2b2lkIFJlbmRlckxheWVyQmFja2luZzo6dXBk YXRlR3JhcGhpY3NMCiAgICAgLy8gU2V0IHRyYW5zZm9ybSBwcm9wZXJ0eSwgaWYgaXQgaXMgbm90 IGFuaW1hdGluZy4gV2UgaGF2ZSB0byBkbyB0aGlzIGhlcmUgYmVjYXVzZSB0aGUgdHJhbnNmb3Jt CiAgICAgLy8gaXMgYWZmZWN0ZWQgYnkgdGhlIGxheWVyIGRpbWVuc2lvbnMuCiAgICAgaWYgKCFy ZW5kZXJlcigpLT5hbmltYXRpb24oKS0+aXNSdW5uaW5nQWNjZWxlcmF0ZWRBbmltYXRpb25PblJl bmRlcmVyKHJlbmRlcmVyKCksIENTU1Byb3BlcnR5V2Via2l0VHJhbnNmb3JtKSkKLSAgICAgICAg dXBkYXRlTGF5ZXJUcmFuc2Zvcm0ocmVuZGVyZXIoKS0+c3R5bGUoKSk7CisgICAgICAgIHVwZGF0 ZVRyYW5zZm9ybShyZW5kZXJlcigpLT5zdHlsZSgpKTsKIAogICAgIC8vIFNldCBvcGFjaXR5LCBp ZiBpdCBpcyBub3QgYW5pbWF0aW5nLgogICAgIGlmICghcmVuZGVyZXIoKS0+YW5pbWF0aW9uKCkt PmlzUnVubmluZ0FjY2VsZXJhdGVkQW5pbWF0aW9uT25SZW5kZXJlcihyZW5kZXJlcigpLCBDU1NQ cm9wZXJ0eU9wYWNpdHkpKQotICAgICAgICB1cGRhdGVMYXllck9wYWNpdHkocmVuZGVyZXIoKS0+ c3R5bGUoKSk7CisgICAgICAgIHVwZGF0ZU9wYWNpdHkocmVuZGVyZXIoKS0+c3R5bGUoKSk7CiAg ICAgICAgIAogI2lmIEVOQUJMRShDU1NfRklMVEVSUykKLSAgICB1cGRhdGVMYXllckZpbHRlcnMo cmVuZGVyZXIoKS0+c3R5bGUoKSk7CisgICAgdXBkYXRlRmlsdGVycyhyZW5kZXJlcigpLT5zdHls ZSgpKTsKICNlbmRpZgogCiAjaWYgRU5BQkxFKENTU19DT01QT1NJVElORykKQEAgLTE2MTAsNyAr MTYxMCw3IEBAIGJvb2wgUmVuZGVyTGF5ZXJCYWNraW5nOjpzdGFydFRyYW5zaXRpb24KICAgICAg ICAgICAgIC8vIFRoZSBib3hTaXplIHBhcmFtIGlzIG9ubHkgdXNlZCBmb3IgdHJhbnNmb3JtIGFu aW1hdGlvbnMgKHdoaWNoIGNhbiBvbmx5IHJ1biBvbiBSZW5kZXJCb3hlcyksIHNvIHdlIHBhc3Mg YW4gZW1wdHkgc2l6ZSBoZXJlLgogICAgICAgICAgICAgaWYgKG1fZ3JhcGhpY3NMYXllci0+YWRk QW5pbWF0aW9uKG9wYWNpdHlWZWN0b3IsIEludFNpemUoKSwgb3BhY2l0eUFuaW0sIEdyYXBoaWNz TGF5ZXI6OmFuaW1hdGlvbk5hbWVGb3JUcmFuc2l0aW9uKEFuaW1hdGVkUHJvcGVydHlPcGFjaXR5 KSwgdGltZU9mZnNldCkpIHsKICAgICAgICAgICAgICAgICAvLyBUbyBlbnN1cmUgdGhhdCB0aGUg Y29ycmVjdCBvcGFjaXR5IGlzIHZpc2libGUgd2hlbiB0aGUgYW5pbWF0aW9uIGVuZHMsIGFsc28g c2V0IHRoZSBmaW5hbCBvcGFjaXR5LgotICAgICAgICAgICAgICAgIHVwZGF0ZUxheWVyT3BhY2l0 eSh0b1N0eWxlKTsKKyAgICAgICAgICAgICAgICB1cGRhdGVPcGFjaXR5KHRvU3R5bGUpOwogICAg ICAgICAgICAgICAgIGRpZEFuaW1hdGVPcGFjaXR5ID0gdHJ1ZTsKICAgICAgICAgICAgIH0KICAg ICAgICAgfQpAQCAtMTYyNCw3ICsxNjI0LDcgQEAgYm9vbCBSZW5kZXJMYXllckJhY2tpbmc6OnN0 YXJ0VHJhbnNpdGlvbgogICAgICAgICAgICAgdHJhbnNmb3JtVmVjdG9yLmluc2VydChuZXcgVHJh bnNmb3JtQW5pbWF0aW9uVmFsdWUoMSwgJnRvU3R5bGUtPnRyYW5zZm9ybSgpKSk7CiAgICAgICAg ICAgICBpZiAobV9ncmFwaGljc0xheWVyLT5hZGRBbmltYXRpb24odHJhbnNmb3JtVmVjdG9yLCB0 b1JlbmRlckJveChyZW5kZXJlcigpKS0+cGl4ZWxTbmFwcGVkQm9yZGVyQm94UmVjdCgpLnNpemUo KSwgdHJhbnNmb3JtQW5pbSwgR3JhcGhpY3NMYXllcjo6YW5pbWF0aW9uTmFtZUZvclRyYW5zaXRp b24oQW5pbWF0ZWRQcm9wZXJ0eVdlYmtpdFRyYW5zZm9ybSksIHRpbWVPZmZzZXQpKSB7CiAgICAg ICAgICAgICAgICAgLy8gVG8gZW5zdXJlIHRoYXQgdGhlIGNvcnJlY3QgdHJhbnNmb3JtIGlzIHZp c2libGUgd2hlbiB0aGUgYW5pbWF0aW9uIGVuZHMsIGFsc28gc2V0IHRoZSBmaW5hbCB0cmFuc2Zv cm0uCi0gICAgICAgICAgICAgICAgdXBkYXRlTGF5ZXJUcmFuc2Zvcm0odG9TdHlsZSk7CisgICAg ICAgICAgICAgICAgdXBkYXRlVHJhbnNmb3JtKHRvU3R5bGUpOwogICAgICAgICAgICAgICAgIGRp ZEFuaW1hdGVUcmFuc2Zvcm0gPSB0cnVlOwogICAgICAgICAgICAgfQogICAgICAgICB9CkBAIC0x NjM5LDcgKzE2MzksNyBAQCBib29sIFJlbmRlckxheWVyQmFja2luZzo6c3RhcnRUcmFuc2l0aW9u CiAgICAgICAgICAgICBmaWx0ZXJWZWN0b3IuaW5zZXJ0KG5ldyBGaWx0ZXJBbmltYXRpb25WYWx1 ZSgxLCAmdG9TdHlsZS0+ZmlsdGVyKCkpKTsKICAgICAgICAgICAgIGlmIChtX2dyYXBoaWNzTGF5 ZXItPmFkZEFuaW1hdGlvbihmaWx0ZXJWZWN0b3IsIEludFNpemUoKSwgZmlsdGVyQW5pbSwgR3Jh cGhpY3NMYXllcjo6YW5pbWF0aW9uTmFtZUZvclRyYW5zaXRpb24oQW5pbWF0ZWRQcm9wZXJ0eVdl YmtpdEZpbHRlciksIHRpbWVPZmZzZXQpKSB7CiAgICAgICAgICAgICAgICAgLy8gVG8gZW5zdXJl IHRoYXQgdGhlIGNvcnJlY3QgZmlsdGVyIGlzIHZpc2libGUgd2hlbiB0aGUgYW5pbWF0aW9uIGVu ZHMsIGFsc28gc2V0IHRoZSBmaW5hbCBmaWx0ZXIuCi0gICAgICAgICAgICAgICAgdXBkYXRlTGF5 ZXJGaWx0ZXJzKHRvU3R5bGUpOworICAgICAgICAgICAgICAgIHVwZGF0ZUZpbHRlcnModG9TdHls ZSk7CiAgICAgICAgICAgICAgICAgZGlkQW5pbWF0ZUZpbHRlciA9IHRydWU7CiAgICAgICAgICAg ICB9CiAgICAgICAgIH0KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXll ckJhY2tpbmcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy TGF5ZXJCYWNraW5nLmgJKHJldmlzaW9uIDEyODE0NCkKKysrIFNvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9SZW5kZXJMYXllckJhY2tpbmcuaAkod29ya2luZyBjb3B5KQpAQCAtMjAxLDEwICsyMDEs MTAgQEAgcHJpdmF0ZToKICAgICAvLyBSZXN1bHQgaXMgcGVyc3BlY3RpdmUgb3JpZ2luIGluIHBp eGVscy4KICAgICBGbG9hdFBvaW50IGNvbXB1dGVQZXJzcGVjdGl2ZU9yaWdpbihjb25zdCBJbnRS ZWN0JiBib3JkZXJCb3gpIGNvbnN0OwogCi0gICAgdm9pZCB1cGRhdGVMYXllck9wYWNpdHkoY29u c3QgUmVuZGVyU3R5bGUqKTsKLSAgICB2b2lkIHVwZGF0ZUxheWVyVHJhbnNmb3JtKGNvbnN0IFJl bmRlclN0eWxlKik7CisgICAgdm9pZCB1cGRhdGVPcGFjaXR5KGNvbnN0IFJlbmRlclN0eWxlKik7 CisgICAgdm9pZCB1cGRhdGVUcmFuc2Zvcm0oY29uc3QgUmVuZGVyU3R5bGUqKTsKICNpZiBFTkFC TEUoQ1NTX0ZJTFRFUlMpCi0gICAgdm9pZCB1cGRhdGVMYXllckZpbHRlcnMoY29uc3QgUmVuZGVy U3R5bGUqKTsKKyAgICB2b2lkIHVwZGF0ZUZpbHRlcnMoY29uc3QgUmVuZGVyU3R5bGUqKTsKICNl bmRpZgogI2lmIEVOQUJMRShDU1NfQ09NUE9TSVRJTkcpCiAgICAgdm9pZCB1cGRhdGVMYXllckJs ZW5kTW9kZShjb25zdCBSZW5kZXJTdHlsZSopOwo=