96369 2012-09-11 02:35:34 -0700 Recognize the "--chromium-android" argument in run-webkit-tests 2012-09-11 12:40:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 84845 1 peter peter abarth dpranke ojan webkit.review.bot oldest_to_newest 716978 0 peter 2012-09-11 02:35:34 -0700 Recognize the "--chromium-android" argument in run-webkit-tests 716983 1 163312 peter 2012-09-11 02:36:54 -0700 Created attachment 163312 Patch 716992 2 163312 jochen 2012-09-11 02:46:48 -0700 Comment on attachment 163312 Patch Can you add a test to factory_unittest.py (see FactoryTest.assert_port) 717005 3 163320 peter 2012-09-11 03:07:20 -0700 Created attachment 163320 Patch for landing 717006 4 peter 2012-09-11 03:07:37 -0700 (In reply to comment #2) > (From update of attachment 163312 [details]) > Can you add a test to factory_unittest.py (see FactoryTest.assert_port) Done, thank you! 717009 5 peter 2012-09-11 03:09:43 -0700 Committed r128164: <http://trac.webkit.org/changeset/128164> 717333 6 dpranke 2012-09-11 10:22:46 -0700 Is this really much of an improvement over '--platform chromium-android', which already worked? The reason we have the other shortcuts (--qt, --chromium) etc. is not primarily because they're shorter, but rather to indicate "pick the appropriate variant of X for the platform I'm running on". 717336 7 peter 2012-09-11 10:25:24 -0700 (In reply to comment #6) > Is this really much of an improvement over '--platform chromium-android', which already worked? The reason we have the other shortcuts (--qt, --chromium) etc. is not primarily because they're shorter, but rather to indicate "pick the appropriate variant of X for the platform I'm running on". Jochen asked me the same question. I chose to add the argument because it's consistent with the other flags, and with the input of the run-webkit-tests script which had to pass this along. I'd be happy to change this. 717344 8 dpranke 2012-09-11 10:32:22 -0700 (In reply to comment #7) > (In reply to comment #6) > > Is this really much of an improvement over '--platform chromium-android', which already worked? The reason we have the other shortcuts (--qt, --chromium) etc. is not primarily because they're shorter, but rather to indicate "pick the appropriate variant of X for the platform I'm running on". > > Jochen asked me the same question. I chose to add the argument because it's consistent with the other flags, and with the input of the run-webkit-tests script which had to pass this along. > > I'd be happy to change this. I don't feel strongly enough about this to want to revert it, but I'm not sure where this slope stops slipping ... 717350 9 peter 2012-09-11 10:36:23 -0700 (In reply to comment #8) > (In reply to comment #7) > > (In reply to comment #6) > > > Is this really much of an improvement over '--platform chromium-android', which already worked? The reason we have the other shortcuts (--qt, --chromium) etc. is not primarily because they're shorter, but rather to indicate "pick the appropriate variant of X for the platform I'm running on". > > > > Jochen asked me the same question. I chose to add the argument because it's consistent with the other flags, and with the input of the run-webkit-tests script which had to pass this along. > > > > I'd be happy to change this. > > I don't feel strongly enough about this to want to revert it, but I'm not sure where this slope stops slipping ... If there are issues you feel we should be addressing then we should be talking about that. I value your input and concerns, so they'd be most welcome. Since you're comparing Android to a slipping slope it seems you have plenty. I explained my rationale for making this change. I'll upload a patch to change this to --platform=chromium-android momentarily. 717480 10 dpranke 2012-09-11 12:40:38 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > (In reply to comment #6) > > > > Is this really much of an improvement over '--platform chromium-android', which already worked? The reason we have the other shortcuts (--qt, --chromium) etc. is not primarily because they're shorter, but rather to indicate "pick the appropriate variant of X for the platform I'm running on". > > > > > > Jochen asked me the same question. I chose to add the argument because it's consistent with the other flags, and with the input of the run-webkit-tests script which had to pass this along. > > > > > > I'd be happy to change this. > > > > I don't feel strongly enough about this to want to revert it, but I'm not sure where this slope stops slipping ... > > If there are issues you feel we should be addressing then we should be talking about that. I value your input and concerns, so they'd be most welcome. Since you're comparing Android to a slipping slope it seems you have plenty. > > I explained my rationale for making this change. I'll upload a patch to change this to --platform=chromium-android momentarily. Don't read too much into my comment, I'm not upset about the change, and I wouldn't bother uploading another patch. My point was, I'm not sure how we decide to add --chromium-android and not add --chromium-mac or --chromium-mac-lion, but adding a flag for every possible port seems like the wrong solution. Generally, I only like to add command line flags either when required to support new functionality or when they are shortcuts to really commonly used sets of other options (e.g., supporting --debug rather than requiring --configuration debug) that will make things easier for a lot of people. --chromium-android doesn't fall into the first category and it's not clear to me that enough people are going to use it that it'll fall into the latter. 163312 2012-09-11 02:36:54 -0700 2012-09-11 03:07:16 -0700 Patch bug-96369-20120911103629.patch text/plain 2952 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGYxZDExZjU1MzUwNWQ5ODI2ODI0OGU0MWFiODRmNjhi NWZmNjdiYy4uM2E0M2I2MmRmNjJhODNjMThjNWJjZjJjNDg3OTZhOGIwNDMzMWQzYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA5LTExICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZWNvZ25pemUgdGhlICItLWNocm9taXVtLWFuZHJvaWQiIGFyZ3VtZW50IGluIHJ1 bi13ZWJraXQtdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk2MzY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQ2hyb21pdW0gZm9yIHRoZSBBbmRyb2lkIHBsYXRmb3JtIGNhbm5vdCBkZXRlcm1pbmUg dGhlIHBsYXRmb3JtIGJhc2VkIG9uCisgICAgICAgIHRoZSBob3N0IGl0c2VsZiwgc28gd2UnbGwg dXNlIHRoZSAtLWNocm9taXVtLWFuZHJvaWQgYXJndW1lbnQgYXMgdGhlIGJ1aWxkCisgICAgICAg IG1hc3RlciBwYXNzZXMgdG8gcnVuLXdlYmtpdC10ZXN0cy4gTWFrZSBzdXJlIHRoZSBsYXlvdXQg dGVzdCBydW5uZXIKKyAgICAgICAgY2FuIHBpY2sgdGhlIHJpZ2h0IHBvcnQgd2hlbiBkb2luZyBz by4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHk6CisgICAgICAgIChwb3J0 X29wdGlvbnMpOgorCiAyMDEyLTA5LTExICBDaHJpc3RvcGhlIER1bWV6ICA8Y2hyaXN0b3BoZS5k dW1lekBpbnRlbC5jb20+CiAKICAgICAgICAgV1RSIG5lZWRzIGFuIGltcGxlbWVudGF0aW9uIG9m IGFwcGxpY2F0aW9uQ2FjaGVEaXNrVXNhZ2VGb3JPcmlnaW4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj cmlwdHMvcnVuLXdlYmtpdC10ZXN0cyBiL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwpp bmRleCBhY2E4ZDVkYzk3NjBlOGQxZDY3MmU5N2ViYWJhZjZiMGEzYWVlOThiLi40YmI4ZjM5NDQ4 NDY5ZWQ0N2U1ZTdkMjRkZTI2ODdhMmY1ZTM3NmQ1IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRz L3J1bi13ZWJraXQtdGVzdHMKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCkBA IC0xMTIsMTAgKzExMiwxMiBAQCBpZiAoaXNRdCgpKSB7CiAgICAgcHVzaChAQVJHViwgIi0tZ3Rr Iik7CiB9IGVsc2lmIChpc0VmbCgpKSB7CiAgICAgcHVzaChAQVJHViwgIi0tZWZsIik7Cit9IGVs c2lmIChpc0Nocm9taXVtQW5kcm9pZCgpKSB7CisgICAgcHVzaChAQVJHViwgIi0tY2hyb21pdW0t YW5kcm9pZCIpOwogfSBlbHNpZiAoaXNDaHJvbWl1bSgpKSB7Ci0gICAgcHVzaChAQVJHViwgIi0t Y2hyb21pdW0iKQorICAgIHB1c2goQEFSR1YsICItLWNocm9taXVtIik7CiB9IGVsc2lmIChpc1dp bkNhaXJvKCkpIHsKLSAgICBwdXNoKEBBUkdWLCAiLS13aW5jYWlybyIpCisgICAgcHVzaChAQVJH ViwgIi0td2luY2Fpcm8iKTsKIH0KIAogbXkgJGhhcm5lc3NQYXRoID0gRmlsZTo6U3BlYy0+Y2F0 ZmlsZShyZWxhdGl2ZVNjcmlwdHNEaXIoKSwgJGhhcm5lc3NOYW1lKTsKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZmFjdG9yeS5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZmFjdG9yeS5weQppbmRleCA5YjVj ZjI3YjA4MTI2NWE3MDE5NmMxMGU0NTk4N2RlZDk4OThiOGVlLi43ZTQ3NTAyMTkwOGE1ZmQ2ZjI2 MDgyYjdmOTcxNDc4YjdjYmI0ZDI4IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9mYWN0b3J5LnB5CkBAIC00Niw4ICs0NiwxMCBAQCBkZWYgcG9y dF9vcHRpb25zKCoqaGVscF9zdHJpbmdzKToKICAgICAgICAgICAgIGhlbHA9J1NldCB0aGUgY29u ZmlndXJhdGlvbiB0byBSZWxlYXNlJyksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCct LXBsYXRmb3JtJywgYWN0aW9uPSdzdG9yZScsCiAgICAgICAgICAgICBoZWxwPWhlbHBfc3RyaW5n cy5nZXQoJ3BsYXRmb3JtJywgJ1BsYXRmb3JtL1BvcnQgYmVpbmcgdGVzdGVkIChlLmcuLCAibWFj LWxpb24iKScpKSwKLSAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oIi0tY2hyb21pdW0iLCBh Y3Rpb249InN0b3JlX2NvbnN0IiwgY29uc3Q9J2Nocm9taXVtJywgZGVzdD0ncGxhdGZvcm0nLAor ICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbignLS1jaHJvbWl1bScsIGFjdGlvbj0nc3RvcmVf Y29uc3QnLCBjb25zdD0nY2hyb21pdW0nLCBkZXN0PSdwbGF0Zm9ybScsCiAgICAgICAgICAgICBo ZWxwPSdBbGlhcyBmb3IgLS1wbGF0Zm9ybT1jaHJvbWl1bScpLAorICAgICAgICBvcHRwYXJzZS5t YWtlX29wdGlvbignLS1jaHJvbWl1bS1hbmRyb2lkJywgYWN0aW9uPSdzdG9yZV9jb25zdCcsIGNv bnN0PSdjaHJvbWl1bS1hbmRyb2lkJywgZGVzdD0ncGxhdGZvcm0nLAorICAgICAgICAgICAgaGVs cD0nQWxpYXMgZm9yIC0tcGxhdGZvcm09Y2hyb21pdW0tYW5kcm9pZCcpLAogICAgICAgICBvcHRw YXJzZS5tYWtlX29wdGlvbignLS1lZmwnLCBhY3Rpb249J3N0b3JlX2NvbnN0JywgY29uc3Q9J2Vm bCcsIGRlc3Q9InBsYXRmb3JtIiwKICAgICAgICAgICAgIGhlbHA9J0FsaWFzIGZvciAtLXBsYXRm b3JtPWVmbCcpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbignLS1ndGsnLCBhY3Rpb249 J3N0b3JlX2NvbnN0JywgY29uc3Q9J2d0aycsIGRlc3Q9InBsYXRmb3JtIiwK 163320 2012-09-11 03:07:20 -0700 2012-09-11 03:07:20 -0700 Patch for landing bug-96369-20120911110655.patch text/plain 4397 peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTU3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOGYxZDExZjU1MzUwNWQ5ODI2ODI0OGU0MWFiODRmNjhi NWZmNjdiYy4uZDY3ZmJhOWMzNzBhNTRmYjU1OWNmMmIwYTY4OWY4NmZlNTU3MzZhYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDEyLTA5LTExICBQZXRlciBCZXZlcmxvbyAgPHBldGVyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZWNvZ25pemUgdGhlICItLWNocm9taXVtLWFuZHJvaWQiIGFyZ3VtZW50IGluIHJ1 bi13ZWJraXQtdGVzdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk2MzY5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgSm9jaGVuIEVpc2luZ2VyLgorCisg ICAgICAgIENocm9taXVtIGZvciB0aGUgQW5kcm9pZCBwbGF0Zm9ybSBjYW5ub3QgZGV0ZXJtaW5l IHRoZSBwbGF0Zm9ybSBiYXNlZCBvbgorICAgICAgICB0aGUgaG9zdCBpdHNlbGYsIHNvIHdlJ2xs IHVzZSB0aGUgLS1jaHJvbWl1bS1hbmRyb2lkIGFyZ3VtZW50IGFzIHRoZSBidWlsZAorICAgICAg ICBtYXN0ZXIgcGFzc2VzIHRvIHJ1bi13ZWJraXQtdGVzdHMuIE1ha2Ugc3VyZSB0aGUgbGF5b3V0 IHRlc3QgcnVubmVyCisgICAgICAgIGNhbiBwaWNrIHRoZSByaWdodCBwb3J0IHdoZW4gZG9pbmcg c28uCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6CisgICAgICAgICogU2Ny aXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9mYWN0b3J5LnB5OgorICAgICAgICAocG9y dF9vcHRpb25zKToKKwogMjAxMi0wOS0xMSAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUu ZHVtZXpAaW50ZWwuY29tPgogCiAgICAgICAgIFdUUiBuZWVkcyBhbiBpbXBsZW1lbnRhdGlvbiBv ZiBhcHBsaWNhdGlvbkNhY2hlRGlza1VzYWdlRm9yT3JpZ2luCmRpZmYgLS1naXQgYS9Ub29scy9T Y3JpcHRzL3J1bi13ZWJraXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMK aW5kZXggYWNhOGQ1ZGM5NzYwZThkMWQ2NzJlOTdlYmFiYWY2YjBhM2FlZTk4Yi4uNGJiOGYzOTQ0 ODQ2OWVkNDdlNWU3ZDI0ZGUyNjg3YTJmNWUzNzZkNSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy9ydW4td2Via2l0LXRlc3RzCisrKyBiL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwpA QCAtMTEyLDEwICsxMTIsMTIgQEAgaWYgKGlzUXQoKSkgewogICAgIHB1c2goQEFSR1YsICItLWd0 ayIpOwogfSBlbHNpZiAoaXNFZmwoKSkgewogICAgIHB1c2goQEFSR1YsICItLWVmbCIpOworfSBl bHNpZiAoaXNDaHJvbWl1bUFuZHJvaWQoKSkgeworICAgIHB1c2goQEFSR1YsICItLWNocm9taXVt LWFuZHJvaWQiKTsKIH0gZWxzaWYgKGlzQ2hyb21pdW0oKSkgewotICAgIHB1c2goQEFSR1YsICIt LWNocm9taXVtIikKKyAgICBwdXNoKEBBUkdWLCAiLS1jaHJvbWl1bSIpOwogfSBlbHNpZiAoaXNX aW5DYWlybygpKSB7Ci0gICAgcHVzaChAQVJHViwgIi0td2luY2Fpcm8iKQorICAgIHB1c2goQEFS R1YsICItLXdpbmNhaXJvIik7CiB9CiAKIG15ICRoYXJuZXNzUGF0aCA9IEZpbGU6OlNwZWMtPmNh dGZpbGUocmVsYXRpdmVTY3JpcHRzRGlyKCksICRoYXJuZXNzTmFtZSk7CmRpZmYgLS1naXQgYS9U b29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHkgYi9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnkucHkKaW5kZXggOWI1 Y2YyN2IwODEyNjVhNzAxOTZjMTBlNDU5ODdkZWQ5ODk4YjhlZS4uN2U0NzUwMjE5MDhhNWZkNmYy NjA4MmI3Zjk3MTQ3OGI3Y2JiNGQyOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9sYXlvdXRfdGVzdHMvcG9ydC9mYWN0b3J5LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0 cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZmFjdG9yeS5weQpAQCAtNDYsOCArNDYsMTAgQEAgZGVmIHBv cnRfb3B0aW9ucygqKmhlbHBfc3RyaW5ncyk6CiAgICAgICAgICAgICBoZWxwPSdTZXQgdGhlIGNv bmZpZ3VyYXRpb24gdG8gUmVsZWFzZScpLAogICAgICAgICBvcHRwYXJzZS5tYWtlX29wdGlvbign LS1wbGF0Zm9ybScsIGFjdGlvbj0nc3RvcmUnLAogICAgICAgICAgICAgaGVscD1oZWxwX3N0cmlu Z3MuZ2V0KCdwbGF0Zm9ybScsICdQbGF0Zm9ybS9Qb3J0IGJlaW5nIHRlc3RlZCAoZS5nLiwgIm1h Yy1saW9uIiknKSksCi0gICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCItLWNocm9taXVtIiwg YWN0aW9uPSJzdG9yZV9jb25zdCIsIGNvbnN0PSdjaHJvbWl1bScsIGRlc3Q9J3BsYXRmb3JtJywK KyAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oJy0tY2hyb21pdW0nLCBhY3Rpb249J3N0b3Jl X2NvbnN0JywgY29uc3Q9J2Nocm9taXVtJywgZGVzdD0ncGxhdGZvcm0nLAogICAgICAgICAgICAg aGVscD0nQWxpYXMgZm9yIC0tcGxhdGZvcm09Y2hyb21pdW0nKSwKKyAgICAgICAgb3B0cGFyc2Uu bWFrZV9vcHRpb24oJy0tY2hyb21pdW0tYW5kcm9pZCcsIGFjdGlvbj0nc3RvcmVfY29uc3QnLCBj b25zdD0nY2hyb21pdW0tYW5kcm9pZCcsIGRlc3Q9J3BsYXRmb3JtJywKKyAgICAgICAgICAgIGhl bHA9J0FsaWFzIGZvciAtLXBsYXRmb3JtPWNocm9taXVtLWFuZHJvaWQnKSwKICAgICAgICAgb3B0 cGFyc2UubWFrZV9vcHRpb24oJy0tZWZsJywgYWN0aW9uPSdzdG9yZV9jb25zdCcsIGNvbnN0PSdl ZmwnLCBkZXN0PSJwbGF0Zm9ybSIsCiAgICAgICAgICAgICBoZWxwPSdBbGlhcyBmb3IgLS1wbGF0 Zm9ybT1lZmwnKSwKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oJy0tZ3RrJywgYWN0aW9u PSdzdG9yZV9jb25zdCcsIGNvbnN0PSdndGsnLCBkZXN0PSJwbGF0Zm9ybSIsCmRpZmYgLS1naXQg YS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3RvcnlfdW5pdHRl c3QucHkgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9wb3J0L2ZhY3Rvcnlf dW5pdHRlc3QucHkKaW5kZXggY2JhNWQyYjM5MTAyNmMyZmZiYTYwZDRmNzQ5Mjg2NTc3ODgzNWMz Mi4uYmIwNzdjNDBhOTc0OGY1ZjA3MjUyYTYwZjVjNTAyOTY3OWU1ODU0YSAxMDA2NDQKLS0tIGEv VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcG9ydC9mYWN0b3J5X3VuaXR0ZXN0 LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQvZmFjdG9y eV91bml0dGVzdC5weQpAQCAtMzEsNiArMzEsNyBAQCBpbXBvcnQgdW5pdHRlc3QKIGZyb20gd2Vi a2l0cHkudG9vbC5tb2NrdG9vbCBpbXBvcnQgTW9ja09wdGlvbnMKIGZyb20gd2Via2l0cHkuY29t bW9uLnN5c3RlbS5zeXN0ZW1ob3N0X21vY2sgaW1wb3J0IE1vY2tTeXN0ZW1Ib3N0CiAKK2Zyb20g d2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQgaW1wb3J0IGNocm9taXVtX2FuZHJvaWQKIGZyb20g d2Via2l0cHkubGF5b3V0X3Rlc3RzLnBvcnQgaW1wb3J0IGNocm9taXVtX2xpbnV4CiBmcm9tIHdl YmtpdHB5LmxheW91dF90ZXN0cy5wb3J0IGltcG9ydCBjaHJvbWl1bV9tYWMKIGZyb20gd2Via2l0 cHkubGF5b3V0X3Rlc3RzLnBvcnQgaW1wb3J0IGNocm9taXVtX3dpbgpAQCAtODUsNiArODYsMTEg QEAgY2xhc3MgRmFjdG9yeVRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICBzZWxmLmFz c2VydF9wb3J0KHBvcnRfbmFtZT0nY2hyb21pdW0nLCBvc19uYW1lPSdsaW51eCcsIG9zX3ZlcnNp b249J2x1Y2lkJywKICAgICAgICAgICAgICAgICAgICAgICAgICBjbHM9Y2hyb21pdW1fbGludXgu Q2hyb21pdW1MaW51eFBvcnQpCiAKKyAgICBkZWYgdGVzdF9jaHJvbWl1bV9hbmRyb2lkKHNlbGYp OgorICAgICAgICBzZWxmLmFzc2VydF9wb3J0KHBvcnRfbmFtZT0nY2hyb21pdW0tYW5kcm9pZCcs IGNscz1jaHJvbWl1bV9hbmRyb2lkLkNocm9taXVtQW5kcm9pZFBvcnQpCisgICAgICAgICMgTk9U RTogV2UgY2FuJ3QgY2hlY2sgZm9yIHBvcnRfbmFtZT1jaHJvbWl1bSBoZXJlLCBhcyB0aGlzIHdp bGwgYXBwZW5kIHRoZSBob3N0J3MKKyAgICAgICAgIyBvcGVyYXRpbmcgc3lzdGVtLCB3aGVyZWFz IGhvc3QhPXRhcmdldCBmb3IgQW5kcm9pZC4KKwogICAgIGRlZiB0ZXN0X2Nocm9taXVtX3dpbihz ZWxmKToKICAgICAgICAgc2VsZi5hc3NlcnRfcG9ydChwb3J0X25hbWU9J2Nocm9taXVtLXdpbi14 cCcsIGNscz1jaHJvbWl1bV93aW4uQ2hyb21pdW1XaW5Qb3J0KQogICAgICAgICBzZWxmLmFzc2Vy dF9wb3J0KHBvcnRfbmFtZT0nY2hyb21pdW0td2luJywgb3NfbmFtZT0nd2luJywgb3NfdmVyc2lv bj0neHAnLAo=