96363 2012-09-11 01:27:24 -0700 Create Localizer factory method for LocaleICU 2012-09-11 19:24:38 -0700 1 1 1 Unclassified WebKit Forms 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96351 1 keishi keishi tkent webkit.review.bot yosin oldest_to_newest 716936 0 keishi 2012-09-11 01:27:24 -0700 Create Localizer factory method for LocaleICU 716947 1 163303 keishi 2012-09-11 01:53:53 -0700 Created attachment 163303 Patch 716956 2 163303 tkent 2012-09-11 02:03:39 -0700 Comment on attachment 163303 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163303&action=review > Source/WebCore/platform/text/LocaleICU.cpp:47 > + return LocaleICU::create(locale.string().utf8().data()); What happens if a broken locale name is specified? e.g. Null AtomicString, empty string, "12345" 717827 3 163303 webkit.review.bot 2012-09-11 19:24:35 -0700 Comment on attachment 163303 Patch Clearing flags on attachment: 163303 Committed r128257: <http://trac.webkit.org/changeset/128257> 717828 4 webkit.review.bot 2012-09-11 19:24:38 -0700 All reviewed patches have been landed. Closing bug. 163303 2012-09-11 01:53:53 -0700 2012-09-11 19:24:35 -0700 Patch bug-96363-20120911175328.patch text/plain 3777 keishi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2ZkNDk5MDI3NzkyNjBi NDFkM2VmYTgzY2VlMWYzNzdmNWVjNzUxMy4uN2Q3ODQ3NWVhZGM2NjhmNDU5MWEwYmQ3YTgwYmYy YzVkNTI4MTA4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTEyICBLZWlz aGkgSGF0dG9yaSAgPGtlaXNoaUB3ZWJraXQub3JnPgorCisgICAgICAgIENyZWF0ZSBMb2NhbGl6 ZXIgZmFjdG9yeSBtZXRob2QgZm9yIExvY2FsZUlDVQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYzNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBQcmVwYXJpbmcgdG8gdXNlIExvY2FsaXplciBpbnN0ZWFk IG9mIExvY2FsZU1hYy9XaW4vSUNVCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBDb3ZlcmVkIGlu IHVuaXQgdGVzdCB0ZXN0cy9Mb2NhbGl6ZWROdW1iZXJJQ1VUZXN0LmNwcAorCisgICAgICAgICog cGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TG9jYWxpemVy OjpjcmVhdGUpOgorICAgICAgICAoV2ViQ29yZSk6CisKIDIwMTItMDktMTEgIEtlaXNoaSBIYXR0 b3JpICA8a2Vpc2hpQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQ3JlYXRlIExvY2FsaXplciBmYWN0 b3J5IG1ldGhvZCBmb3IgTG9jYWxlTWFjCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4IDJj MjhkYWEwN2MwMjZjZjc3NWUxNGE4NTFiYmM3MDJjMmJkNjZlMTEuLmEyODdkODVkZmYyYjg0MjQ4 ZjY1YmIwNDVmNTE4MzhkMjU3MTNlZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTQgQEAKKzIwMTItMDktMTIgIEtlaXNoaSBIYXR0b3JpICA8a2Vpc2hpQHdlYmtpdC5v cmc+CisKKyAgICAgICAgQ3JlYXRlIExvY2FsaXplciBmYWN0b3J5IG1ldGhvZCBmb3IgTG9jYWxl SUNVCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjM2 MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVz dHMvTG9jYWxpemVkTnVtYmVySUNVVGVzdC5jcHA6CisgICAgICAgICh0ZXN0TnVtYmVySXNSZXZl cnNpYmxlKToKKyAgICAgICAgKHRlc3REZWNpbWFsU2VwYXJhdG9yKToKKwogMjAxMi0wOS0xMSAg S2Vpc2hpIEhhdHRvcmkgIDxrZWlzaGlAd2Via2l0Lm9yZz4KIAogICAgICAgICBDcmVhdGUgTG9j YWxpemVyIGZhY3RvcnkgbWV0aG9kIGZvciBMb2NhbGVNYWMKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL3RleHQvTG9jYWxlSUNVLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3RleHQvTG9jYWxlSUNVLmNwcAppbmRleCAyOTBiNTI4Y2E5M2U0OWEyMTZkZWI2NTVmMDZk ZWQ5Njg5MzgyYWU1Li4wYmNhNWE4MTZjYTE5OThmNDc3NGU0ODQ1Mzc4MDI5MmE4MTFmNjMwIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS90ZXh0L0xvY2FsZUlDVS5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vdGV4dC9Mb2NhbGVJQ1UuY3BwCkBAIC00Miw2ICs0 MiwxMSBAQCB1c2luZyBuYW1lc3BhY2Ugc3RkOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKK1Bh c3NPd25QdHI8TG9jYWxpemVyPiBMb2NhbGl6ZXI6OmNyZWF0ZShjb25zdCBBdG9taWNTdHJpbmcm IGxvY2FsZSkKK3sKKyAgICByZXR1cm4gTG9jYWxlSUNVOjpjcmVhdGUobG9jYWxlLnN0cmluZygp LnV0ZjgoKS5kYXRhKCkpOworfQorCiBMb2NhbGVJQ1U6OkxvY2FsZUlDVShjb25zdCBjaGFyKiBs b2NhbGUpCiAgICAgOiBtX2xvY2FsZShsb2NhbGUpCiAgICAgLCBtX251bWJlckZvcm1hdCgwKQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9Mb2NhbGl6ZWROdW1iZXJJ Q1VUZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvTG9jYWxpemVkTnVtYmVy SUNVVGVzdC5jcHAKaW5kZXggOWY4OWNlN2ExMWU3Yjc1OWI3OTMzZWQ5MzQ0MTM1NTc4ODFlOWNm Yy4uZWM3ZGU0ZTllOTUyYmJjZGEyYWQ0MjA2OGVjMjA3NTQ2NWM1NTBiMyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9Mb2NhbGl6ZWROdW1iZXJJQ1VUZXN0LmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0xvY2FsaXplZE51bWJlcklDVVRlc3Qu Y3BwCkBAIC0zNiwxMyArMzYsMTMgQEAKIAogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKLXZv aWQgdGVzdE51bWJlcklzUmV2ZXJzaWJsZShjb25zdCBjaGFyKiBsb2NhbGVTdHJpbmcsIGNvbnN0 IGNoYXIqIG9yaWdpbmFsLCBjb25zdCBjaGFyKiBzaG91bGRIYXZlID0gMCkKK3ZvaWQgdGVzdE51 bWJlcklzUmV2ZXJzaWJsZShjb25zdCBBdG9taWNTdHJpbmcmIGxvY2FsZSwgY29uc3QgY2hhciog b3JpZ2luYWwsIGNvbnN0IGNoYXIqIHNob3VsZEhhdmUgPSAwKQogewotICAgIE93blB0cjxMb2Nh bGVJQ1U+IGxvY2FsZSA9IExvY2FsZUlDVTo6Y3JlYXRlKGxvY2FsZVN0cmluZyk7Ci0gICAgU3Ry aW5nIGxvY2FsaXplZCA9IGxvY2FsZS0+Y29udmVydFRvTG9jYWxpemVkTnVtYmVyKG9yaWdpbmFs KTsKKyAgICBPd25QdHI8TG9jYWxpemVyPiBsb2NhbGl6ZXIgPSBMb2NhbGl6ZXI6OmNyZWF0ZShs b2NhbGUpOworICAgIFN0cmluZyBsb2NhbGl6ZWQgPSBsb2NhbGl6ZXItPmNvbnZlcnRUb0xvY2Fs aXplZE51bWJlcihvcmlnaW5hbCk7CiAgICAgaWYgKHNob3VsZEhhdmUpCiAgICAgICAgIEVYUEVD VF9UUlVFKGxvY2FsaXplZC5jb250YWlucyhzaG91bGRIYXZlKSk7Ci0gICAgU3RyaW5nIGNvbnZl cnRlZCA9IGxvY2FsZS0+Y29udmVydEZyb21Mb2NhbGl6ZWROdW1iZXIobG9jYWxpemVkKTsKKyAg ICBTdHJpbmcgY29udmVydGVkID0gbG9jYWxpemVyLT5jb252ZXJ0RnJvbUxvY2FsaXplZE51bWJl cihsb2NhbGl6ZWQpOwogICAgIEVYUEVDVF9FUShvcmlnaW5hbCwgY29udmVydGVkKTsKIH0KIApA QCAtODIsMTAgKzgyLDEwIEBAIFRFU1QoTG9jYWxpemVkTnVtYmVySUNVVGVzdCwgUmV2ZXJzaWJs ZSkKIAogI2lmIEVOQUJMRShJTlBVVF9UWVBFX1RJTUVfTVVMVElQTEVfRklFTERTKQogCi1zdGF0 aWMgU3RyaW5nIHRlc3REZWNpbWFsU2VwYXJhdG9yKGNvbnN0IGNoYXIqIGxvY2FsZVN0cmluZykK K3N0YXRpYyBTdHJpbmcgdGVzdERlY2ltYWxTZXBhcmF0b3IoY29uc3QgQXRvbWljU3RyaW5nJiBs b2NhbGUpCiB7Ci0gICAgT3duUHRyPExvY2FsZUlDVT4gbG9jYWxlID0gTG9jYWxlSUNVOjpjcmVh dGUobG9jYWxlU3RyaW5nKTsKLSAgICByZXR1cm4gbG9jYWxlLT5sb2NhbGl6ZWREZWNpbWFsU2Vw YXJhdG9yKCk7CisgICAgT3duUHRyPExvY2FsaXplcj4gbG9jYWxpemVyID0gTG9jYWxpemVyOjpj cmVhdGUobG9jYWxlKTsKKyAgICByZXR1cm4gbG9jYWxpemVyLT5sb2NhbGl6ZWREZWNpbWFsU2Vw YXJhdG9yKCk7CiB9CiAKIFRFU1QoTG9jYWxpemVkTnVtYmVySUNVVGVzdCwgbG9jYWxpemVkRGVj aW1hbFNlcGFyYXRvcikK