96359 2012-09-11 00:29:50 -0700 [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old 2012-09-13 01:54:10 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 96358 90879 1 hausmann hausmann abecsi dino vestbo webkit.review.bot zarvai oldest_to_newest 716899 0 hausmann 2012-09-11 00:29:50 -0700 [Qt] The ANGLE build on Windows breaks with GnuWin32's flex because it is too old 716911 1 163294 hausmann 2012-09-11 00:39:42 -0700 Created attachment 163294 Patch 716957 2 hausmann 2012-09-11 02:04:00 -0700 The introduction of win_flex as dependency for the Windows build shall depend on https://codereview.qt-project.org/#change,34570 716995 3 163294 vestbo 2012-09-11 02:55:31 -0700 Comment on attachment 163294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review > Source/ThirdParty/ANGLE/DerivedSources.pri:17 > +# A newer version of flex is required on Windows. At the moment the only > +# one that appears to provide binaries and is not cygwin is winflex. > +FLEX = flex > +win32: FLEX = win_flex default_pre perhaps, in case we need it elsewhere? 716996 4 163294 hausmann 2012-09-11 02:56:32 -0700 Comment on attachment 163294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review >> Source/ThirdParty/ANGLE/DerivedSources.pri:17 >> +win32: FLEX = win_flex > > default_pre perhaps, in case we need it elsewhere? Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived) 717037 5 vestbo 2012-09-11 04:05:58 -0700 (In reply to comment #4) > (From update of attachment 163294 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review > > >> Source/ThirdParty/ANGLE/DerivedSources.pri:17 > >> +win32: FLEX = win_flex > > > > default_pre perhaps, in case we need it elsewhere? > > Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived) Yepp, always. 717951 6 hausmann 2012-09-11 23:23:09 -0700 (In reply to comment #5) > (In reply to comment #4) > > (From update of attachment 163294 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=163294&action=review > > > > >> Source/ThirdParty/ANGLE/DerivedSources.pri:17 > > >> +win32: FLEX = win_flex > > > > > > default_pre perhaps, in case we need it elsewhere? > > > > Ah, you mean just set the FLEX variable in default_pre always? (or maybe only if TEMPLATE = derived) > > Yepp, always. Alright, sounds good, I'll fix that before landing :) 717971 7 163527 hausmann 2012-09-12 00:00:14 -0700 Created attachment 163527 Patch Updated patch that moves FLEX variable to default_pre.prf and fixes flex.exe vs win_flex.exe detection on Windows in build-webkit 719245 8 163527 webkit.review.bot 2012-09-13 01:54:06 -0700 Comment on attachment 163527 Patch Clearing flags on attachment: 163527 Committed r128430: <http://trac.webkit.org/changeset/128430> 719246 9 webkit.review.bot 2012-09-13 01:54:10 -0700 All reviewed patches have been landed. Closing bug. 163294 2012-09-11 00:39:42 -0700 2012-09-12 00:00:10 -0700 Patch bug-96359-20120911094127.patch text/plain 2041 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTUwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMDc5NzYzYTk1MTM4MTRmNThhYmI2MDZkYmRiMWFkY2U2MjRlY2Q0My4uYzMwODFlMjBhMDI2 ODBhMzVjYTcyODRmZjNhNzViMjE0YzU4MjM1MCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTExICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhh dXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRdIFRoZSBBTkdMRSBidWlsZCBvbiBXaW5k b3dzIGJyZWFrcyB3aXRoIEdudVdpbjMyJ3MgZmxleCBiZWNhdXNlIGl0IGlzIHRvbyBvbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MzU5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR251V2luMzIncyBm bGV4IGlzIDIuNS40IGFuZCB0aGF0IGlzIHRvbyBvbGQgZm9yIEFOR0xFJ3MgcHJlcHJvY2Vzc29y CisgICAgICAgIGxleGVyLiBUaGUgb25seSB2aWFibGUgYWx0ZXJuYXRpdmUgSSBjb3VsZCBmaW5k IG9uIFdpbmRvd3MgdGhhdCBwcm92aWRlcworICAgICAgICBiaW5hcmllcyBpcyB0aGUgd2luZmxl eGJpc29uIGRpc3RyaWJ1dGlvbiAoaHR0cDovL3NvdXJjZWZvcmdlLm5ldC9wcm9qZWN0cy93aW5m bGV4Ymlzb24vKSwKKyAgICAgICAgc28gbGV0J3MgdXNlIHRoYXQgb25lIGluc3RlYWQuCisKKyAg ICAgICAgKiBEZXJpdmVkU291cmNlcy5wcmk6CisKIDIwMTItMDktMDYgIEFuZHJhcyBCZWNzaSAg PGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CiAKICAgICAgICAgW0FOR0xFXSBGaXggdGhlIGJ1aWxk IHdpdGggZ2NjIDQuNwpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvRGVyaXZl ZFNvdXJjZXMucHJpIGIvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvRGVyaXZlZFNvdXJjZXMucHJp CmluZGV4IDc5MWU1MjczNTE0ZTczYWQ2NTBhYmM3YzU1YjNjMGFiNTRmNWU2N2UuLjlmYTdkZjM5 MjBhYWU1NmVlZTYwYjQ5YTI2ZjM2NTlmZjllZWZlY2EgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL0Rlcml2ZWRTb3VyY2VzLnByaQorKysgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9B TkdMRS9EZXJpdmVkU291cmNlcy5wcmkKQEAgLTExLDEzICsxMSwxOCBAQAogc2FuaXRpemVkRmls ZSA9ICQkdG9TYW5pdGl6ZWRQYXRoKCQkX0ZJTEVfKQogZXF1YWxzKHNhbml0aXplZEZpbGUsICQk dG9TYW5pdGl6ZWRQYXRoKCQkX1BST19GSUxFXykpOlRFTVBMQVRFID0gZGVyaXZlZAogCisjIEEg bmV3ZXIgdmVyc2lvbiBvZiBmbGV4IGlzIHJlcXVpcmVkIG9uIFdpbmRvd3MuIEF0IHRoZSBtb21l bnQgdGhlIG9ubHkKKyMgb25lIHRoYXQgYXBwZWFycyB0byBwcm92aWRlIGJpbmFyaWVzIGFuZCBp cyBub3QgY3lnd2luIGlzIHdpbmZsZXguCitGTEVYID0gZmxleAord2luMzI6IEZMRVggPSB3aW5f ZmxleAorCiBBTkdMRV9GTEVYX1NPVVJDRVMgPSBcCiAgICAgJCRQV0Qvc3JjL2NvbXBpbGVyL2ds c2xhbmcubCBcCiAgICAgJCRQV0Qvc3JjL2NvbXBpbGVyL3ByZXByb2Nlc3Nvci9uZXcvVG9rZW5p emVyLmwKIAogYW5nbGVmbGV4Lm91dHB1dCA9ICR7UU1BS0VfRklMRV9CQVNFfV9sZXguY3BwCiBh bmdsZWZsZXguaW5wdXQgPSBBTkdMRV9GTEVYX1NPVVJDRVMKLWFuZ2xlZmxleC5jb21tYW5kcyA9 IGZsZXggLS1ub2xpbmUgLS1ub3VuaXN0ZCAtLW91dGZpbGU9JHtRTUFLRV9GSUxFX09VVH0gJHtR TUFLRV9GSUxFX0lOfQorYW5nbGVmbGV4LmNvbW1hbmRzID0gJCRGTEVYIC0tbm9saW5lIC0tbm91 bmlzdGQgLS1vdXRmaWxlPSR7UU1BS0VfRklMRV9PVVR9ICR7UU1BS0VfRklMRV9JTn0KIEdFTkVS QVRPUlMgKz0gYW5nbGVmbGV4CiAKIEFOR0xFX0JJU09OX1NPVVJDRVMgPSBcCg== 163527 2012-09-12 00:00:14 -0700 2012-09-13 01:54:06 -0700 Patch bug-96359-20120912090201.patch text/plain 4068 hausmann U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MjY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggOWQ2NmE5MjEyZjVmZmNlYjI0NWNkZjI4NTZhMjQwZTBhYWU2NTk2OS4uNmYzYzliMDMzNTUy NDljNmEyYjBhNzg5ODNkMWMzNjE5ZTZlZjljMSAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA5LTExICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhh dXNtYW5uQG5va2lhLmNvbT4KIAorICAgICAgICBbUXRdIFRoZSBBTkdMRSBidWlsZCBvbiBXaW5k b3dzIGJyZWFrcyB3aXRoIEdudVdpbjMyJ3MgZmxleCBiZWNhdXNlIGl0IGlzIHRvbyBvbGQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MzU5CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR251V2luMzIncyBm bGV4IGlzIDIuNS40IGFuZCB0aGF0IGlzIHRvbyBvbGQgZm9yIEFOR0xFJ3MgcHJlcHJvY2Vzc29y CisgICAgICAgIGxleGVyLiBUaGUgb25seSB2aWFibGUgYWx0ZXJuYXRpdmUgSSBjb3VsZCBmaW5k IG9uIFdpbmRvd3MgdGhhdCBwcm92aWRlcworICAgICAgICBiaW5hcmllcyBpcyB0aGUgd2luZmxl eGJpc29uIGRpc3RyaWJ1dGlvbiAoaHR0cDovL3NvdXJjZWZvcmdlLm5ldC9wcm9qZWN0cy93aW5m bGV4Ymlzb24vKSwKKyAgICAgICAgc28gbGV0J3MgdXNlIHRoYXQgb25lIGluc3RlYWQuCisKKyAg ICAgICAgKiBEZXJpdmVkU291cmNlcy5wcmk6CisKKzIwMTItMDktMTEgIFNpbW9uIEhhdXNtYW5u ICA8c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgorCiAgICAgICAgIFtRdF0gQnVpbGQgb24gV2lu ZG93cyByZXF1aXJlcyBiaXNvbi9mbGV4IGluIFBBVEgKICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MzU4CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGly ZFBhcnR5L0FOR0xFL0Rlcml2ZWRTb3VyY2VzLnByaSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L0Rlcml2ZWRTb3VyY2VzLnByaQppbmRleCAwNGFlOGMxYzMzZmZlYWI5OWUzZWY2Y2FhZDMwN2Y2 MjRiNDczMDc2Li5iM2E4OWZjNjc5NTUxNjBmNzg0ODIyM2FkZTY1NDM3NjhmZjJjNjIzIDEwMDY0 NAotLS0gYS9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9EZXJpdmVkU291cmNlcy5wcmkKKysrIGIv U291cmNlL1RoaXJkUGFydHkvQU5HTEUvRGVyaXZlZFNvdXJjZXMucHJpCkBAIC0xNyw3ICsxNyw3 IEBAIEFOR0xFX0ZMRVhfU09VUkNFUyA9IFwKIAogYW5nbGVmbGV4Lm91dHB1dCA9ICR7UU1BS0Vf RklMRV9CQVNFfV9sZXguY3BwCiBhbmdsZWZsZXguaW5wdXQgPSBBTkdMRV9GTEVYX1NPVVJDRVMK LWFuZ2xlZmxleC5jb21tYW5kcyA9IGZsZXggLS1ub2xpbmUgLS1ub3VuaXN0ZCAtLW91dGZpbGU9 JHtRTUFLRV9GSUxFX09VVH0gJHtRTUFLRV9GSUxFX0lOfQorYW5nbGVmbGV4LmNvbW1hbmRzID0g JCRGTEVYIC0tbm9saW5lIC0tbm91bmlzdGQgLS1vdXRmaWxlPSR7UU1BS0VfRklMRV9PVVR9ICR7 UU1BS0VfRklMRV9JTn0KIEdFTkVSQVRPUlMgKz0gYW5nbGVmbGV4CiAKIEFOR0xFX0JJU09OX1NP VVJDRVMgPSBcCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cK aW5kZXggOTljNTU5ODAyY2I1ZWFjYTJmZGIwNTBkNjkyZmM0MGI2ZDdlNmJhNS4uNjZiNDY5MWFi ZWZlZjIxYWY0M2JjNzI2NGE5Nzk4YmY1ODA4MTdkYiAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdl TG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTEyICBT aW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbUXRd IFRoZSBBTkdMRSBidWlsZCBvbiBXaW5kb3dzIGJyZWFrcyB3aXRoIEdudVdpbjMyJ3MgZmxleCBi ZWNhdXNlIGl0IGlzIHRvbyBvbGQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk2MzU5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgR251V2luMzIncyBmbGV4IGlzIDIuNS40IGFuZCB0aGF0IGlzIHRvbyBvbGQg Zm9yIEFOR0xFJ3MgcHJlcHJvY2Vzc29yCisgICAgICAgIGxleGVyLiBUaGUgb25seSB2aWFibGUg YWx0ZXJuYXRpdmUgSSBjb3VsZCBmaW5kIG9uIFdpbmRvd3MgdGhhdCBwcm92aWRlcworICAgICAg ICBiaW5hcmllcyBpcyB0aGUgd2luZmxleGJpc29uIGRpc3RyaWJ1dGlvbiAoaHR0cDovL3NvdXJj ZWZvcmdlLm5ldC9wcm9qZWN0cy93aW5mbGV4Ymlzb24vKSwKKyAgICAgICAgc28gbGV0J3MgdXNl IHRoYXQgb25lIGluc3RlYWQuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06Cisg ICAgICAgIChjaGVja1JlcXVpcmVkU3lzdGVtQ29uZmlnKToKKyAgICAgICAgKiBxbWFrZS9ta3Nw ZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnByZjoKKwogMjAxMi0wOS0xMSAgU2ltb24gSGF1c21h bm4gIDxzaW1vbi5oYXVzbWFubkBub2tpYS5jb20+CiAKICAgICAgICAgW1F0XSBCdWlsZCBvbiBX aW5kb3dzIHJlcXVpcmVzIGJpc29uL2ZsZXggaW4gUEFUSApkaWZmIC0tZ2l0IGEvVG9vbHMvU2Ny aXB0cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IGJh YWZiZGE5ZTcwZWZlM2QxNTVkNDg4N2E0ZDQzN2VkYmU4NmYyMmEuLmJkY2JlMGJmZGFmOTNmMWFk ODQ1Y2FhMjI1MjYyN2JmN2ZjYmRmNzQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0 ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE1NDIsNyArMTU0 MiwxMiBAQCBzdWIgY2hlY2tSZXF1aXJlZFN5c3RlbUNvbmZpZwogICAgICAgICAgICAgcHJpbnQg IioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioqKioq KioqKipcbiI7CiAgICAgICAgIH0KICAgICB9IGVsc2lmIChpc0d0aygpIG9yIGlzUXQoKSBvciBp c1d4KCkgb3IgaXNFZmwoKSkgewotICAgICAgICBteSBAY21kcyA9IHF3KGZsZXggYmlzb24gZ3Bl cmYpOworICAgICAgICBteSBAY21kcyA9IHF3KGJpc29uIGdwZXJmKTsKKyAgICAgICAgaWYgKGlz UXQoKSBhbmQgaXNXaW5kb3dzKCkpIHsKKyAgICAgICAgICAgIHB1c2ggQGNtZHMsICJ3aW5fZmxl eCI7CisgICAgICAgIH0gZWxzZSB7CisgICAgICAgICAgICBwdXNoIEBjbWRzLCAiZmxleCI7Cisg ICAgICAgIH0KICAgICAgICAgbXkgQG1pc3NpbmcgPSAoKTsKICAgICAgICAgbXkgJG9sZFBhdGgg PSAkRU5We1BBVEh9OwogICAgICAgICBpZiAoaXNRdCgpIGFuZCBpc1dpbmRvd3MoKSkgewpkaWZm IC0tZ2l0IGEvVG9vbHMvcW1ha2UvbWtzcGVjcy9mZWF0dXJlcy9kZWZhdWx0X3ByZS5wcmYgYi9U b29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnByZgppbmRleCA4ZjY5NmJh ZDRkOTYwYTBmNmEwZDNkZjhmMWIwNTAzMjk5ZmQyNjNhLi5mYjg3ZmFjZGEwMzFjODFmYjI1NmUx NTJlMzllYmE2ZmExOTNjNjJkIDEwMDY0NAotLS0gYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1 cmVzL2RlZmF1bHRfcHJlLnByZgorKysgYi9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2Rl ZmF1bHRfcHJlLnByZgpAQCAtMTA4LDMgKzEwOCw4IEBAIGlzRW1wdHkoU1FMSVRFM1NSQ0RJUikg ewogICAgIFNRTElURTNTUkNESVIgPSAkJFFULmNvcmUuc291cmNlcy8uLi8zcmRwYXJ0eS9zcWxp dGUvCiB9CiAKKyMgQSBuZXdlciB2ZXJzaW9uIG9mIGZsZXggaXMgcmVxdWlyZWQgb24gV2luZG93 cy4gQXQgdGhlIG1vbWVudCB0aGUgb25seQorIyBvbmUgdGhhdCBhcHBlYXJzIHRvIHByb3ZpZGUg YmluYXJpZXMgYW5kIGlzIG5vdCBjeWd3aW4gaXMgd2luZmxleC4KK0ZMRVggPSBmbGV4Cit3aW4z MjogRkxFWCA9IHdpbl9mbGV4CisK