96346 2012-09-10 18:15:54 -0700 [CMake] Remove duplicated file in CMakeLists.txt 2012-09-10 20:49:58 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 91575 1 gyuyoung.kim gyuyoung.kim rakuco webkit.review.bot oldest_to_newest 716746 0 gyuyoung.kim 2012-09-10 18:15:54 -0700 Below files are already added to main file list in WebCore/CMakeLists.txt. So, this should be removed. IF (ENABLE_REQUEST_ANIMATION_FRAME) LIST(APPEND WebCore_IDL_FILES dom/RequestAnimationFrameCallback.idl ) LIST(APPEND WebCore_SOURCES dom/ScriptedAnimationController.cpp ) ENDIF () IF (ENABLE_VIBRATION) LIST(APPEND WebCore_INCLUDE_DIRECTORIES ${WEBCORE_DIR}/Modules/vibration ) LIST(APPEND WebCore_IDL_FILES Modules/vibration/NavigatorVibration.idl ) LIST(APPEND WebCore_SOURCES Modules/vibration/NavigatorVibration.cpp Modules/vibration/Vibration.cpp ) ENDIF () 716750 1 163259 gyuyoung.kim 2012-09-10 18:19:24 -0700 Created attachment 163259 Patch 716782 2 163259 benjamin 2012-09-10 19:25:34 -0700 Comment on attachment 163259 Patch Shouldn't it be the other way around? Remove the files from the main section, and keep the guarded build one? What if you want a build without ENABLE_VIBRATION? 716794 3 163259 benjamin 2012-09-10 20:37:53 -0700 Comment on attachment 163259 Patch Ok, the file are #ifdef'ed and you prefer to support only that way. 716799 4 163259 webkit.review.bot 2012-09-10 20:49:54 -0700 Comment on attachment 163259 Patch Clearing flags on attachment: 163259 Committed r128143: <http://trac.webkit.org/changeset/128143> 716800 5 webkit.review.bot 2012-09-10 20:49:58 -0700 All reviewed patches have been landed. Closing bug. 163259 2012-09-10 18:19:24 -0700 2012-09-10 20:49:54 -0700 Patch bug-96346-20120911101857.patch text/plain 1621 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjA0NTZhNTc5NmVhY2Ji YjUwNTY1YTk1ODY5MmZkNTI3OWRmZjJkOS4uYTJlYjdlM2I2ODZjMTBkN2M2ZmJjNmU3NTA3MDhm NGNjY2YxZDRmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDEyLTA5LTEwICBHeXV5 b3VuZyBLaW0gIDxneXV5b3VuZy5raW1Ac2Ftc3VuZy5jb20+CisKKyAgICAgICAgW0NNYWtlXSBS ZW1vdmUgZHVwbGljYXRlZCBmaWxlIGluIENNYWtlTGlzdHMudHh0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjM0NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6IFJlbW92ZSBk dXBsaWNhdGVkIGZpbGVzLgorCiAyMDEyLTA5LTA5ICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBs ZS5jb20+CiAKICAgICAgICAgVHJ5IHRvIGZpeCB0aGUgYnVpbGQgYWZ0ZXIgcjEyODAwNi4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUv Q01ha2VMaXN0cy50eHQKaW5kZXggNzZhMTE1ZDIwZjJiMzUxZGU0MWFhNzdmOTkxZjA3OGI4YWEy ZmE0NC4uMDcxZmE1MjdjNTVmZThkN2ZhYTNhY2U3MDU3ZTZjY2U4MjQ1ZWQ1YiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01h a2VMaXN0cy50eHQKQEAgLTI2NzgsMjggKzI2NzgsNiBAQCBJRiAoV1RGX1VTRV8zRF9HUkFQSElD UykKICAgICApCiBFTkRJRiAoKQogCi1JRiAoRU5BQkxFX1JFUVVFU1RfQU5JTUFUSU9OX0ZSQU1F KQotICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfSURMX0ZJTEVTCi0gICAgICAgIGRvbS9SZXF1ZXN0 QW5pbWF0aW9uRnJhbWVDYWxsYmFjay5pZGwKLSAgICApCi0gICAgTElTVChBUFBFTkQgV2ViQ29y ZV9TT1VSQ0VTCi0gICAgICAgIGRvbS9TY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIuY3BwCi0g ICAgKQotRU5ESUYgKCkKLQotSUYgKEVOQUJMRV9WSUJSQVRJT04pCi0gICAgTElTVChBUFBFTkQg V2ViQ29yZV9JTkNMVURFX0RJUkVDVE9SSUVTCi0gICAgICAgICR7V0VCQ09SRV9ESVJ9L01vZHVs ZXMvdmlicmF0aW9uCi0gICAgKQotICAgIExJU1QoQVBQRU5EIFdlYkNvcmVfSURMX0ZJTEVTCi0g ICAgICAgIE1vZHVsZXMvdmlicmF0aW9uL05hdmlnYXRvclZpYnJhdGlvbi5pZGwKLSAgICApCi0g ICAgTElTVChBUFBFTkQgV2ViQ29yZV9TT1VSQ0VTCi0gICAgICAgIE1vZHVsZXMvdmlicmF0aW9u L05hdmlnYXRvclZpYnJhdGlvbi5jcHAKLSAgICAgICAgTW9kdWxlcy92aWJyYXRpb24vVmlicmF0 aW9uLmNwcAotICAgICkKLUVORElGICgpCi0KIFNFVChXZWJDb3JlVGVzdFN1cHBvcnRfSU5DTFVE RV9ESVJFQ1RPUklFUwogICAgICIke1dlYkNvcmVfSU5DTFVERV9ESVJFQ1RPUklFU30iCiAgICAg IiR7V0VCQ09SRV9ESVJ9L3Rlc3RpbmciCg==