96341 2012-09-10 17:35:37 -0700 AX: svg:image not accessible 2012-09-12 22:54:18 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 96599 1 cfleizach cfleizach dmazzoni ossy oldest_to_newest 716722 0 cfleizach 2012-09-10 17:35:37 -0700 Images within <svg> are not accessible <svg> <image alt="cake" x="20" y="20" width="300" height="80" xlink:href="resources/cake.png" />\ </svg> 718701 1 cfleizach 2012-09-12 14:06:06 -0700 *** Bug 96558 has been marked as a duplicate of this bug. *** 718702 2 163690 cfleizach 2012-09-12 14:09:05 -0700 Created attachment 163690 patch 718705 3 cfleizach 2012-09-12 14:11:39 -0700 rdar://12272554 718714 4 163690 dmazzoni 2012-09-12 14:18:39 -0700 Comment on attachment 163690 patch View in context: https://bugs.webkit.org/attachment.cgi?id=163690&action=review Unofficial review. 96323 (refactor AXRenderObj -> AXNodeObj) should re-land momentarily - could you update AccessibilityNodeObject::determineAccessibilityRole as well? > LayoutTests/accessibility/svg-image.html:23 > + var svg = accessibilityController.focusedElement; Maybe call this svgImage or axSvgImage to be more clear? > LayoutTests/accessibility/svg-image.html:24 > + shouldBe("svg.role", "'AXRole: AXImage'"); If you're going to check the exact string, this should go in platform/mac/accessibility. How about a cross-platform test, like this? * Add a <img> to the page also, get its role, assert that the roles of the html img and svg image are the same. * Also, debug() the actual role and description, and add test expectations for each platform. 718758 5 cfleizach 2012-09-12 14:50:55 -0700 Thanks Dominic. Will do that (In reply to comment #4) > (From update of attachment 163690 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=163690&action=review > > Unofficial review. > > 96323 (refactor AXRenderObj -> AXNodeObj) should re-land momentarily - could you update AccessibilityNodeObject::determineAccessibilityRole as well? > > > LayoutTests/accessibility/svg-image.html:23 > > + var svg = accessibilityController.focusedElement; > > Maybe call this svgImage or axSvgImage to be more clear? > > > LayoutTests/accessibility/svg-image.html:24 > > + shouldBe("svg.role", "'AXRole: AXImage'"); > > If you're going to check the exact string, this should go in platform/mac/accessibility. > > How about a cross-platform test, like this? > * Add a <img> to the page also, get its role, assert that the roles of the html img and svg image are the same. > * Also, debug() the actual role and description, and add test expectations for each platform. 718840 6 cfleizach 2012-09-12 15:57:37 -0700 (In reply to comment #5) > Thanks Dominic. Will do that > > (In reply to comment #4) > > (From update of attachment 163690 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=163690&action=review > > > > Unofficial review. > > > > 96323 (refactor AXRenderObj -> AXNodeObj) should re-land momentarily - could you update AccessibilityNodeObject::determineAccessibilityRole as well? > > Since AXNodeObject doesn't deal with other images right now, i think it would be best to save that logic for another patch > > > LayoutTests/accessibility/svg-image.html:23 > > > + var svg = accessibilityController.focusedElement; > > > > Maybe call this svgImage or axSvgImage to be more clear? > > > > > LayoutTests/accessibility/svg-image.html:24 > > > + shouldBe("svg.role", "'AXRole: AXImage'"); > > > > If you're going to check the exact string, this should go in platform/mac/accessibility. > > > > How about a cross-platform test, like this? > > * Add a <img> to the page also, get its role, assert that the roles of the html img and svg image are the same. > > * Also, debug() the actual role and description, and add test expectations for each platform. 718841 7 cfleizach 2012-09-12 15:57:52 -0700 http://trac.webkit.org/changeset/128376 719027 8 ossy 2012-09-12 21:37:41 -0700 (In reply to comment #7) > http://trac.webkit.org/changeset/128376 It broke the !ENABLE(SVG) builds. Could you check it, please? https://bugs.webkit.org/show_bug.cgi?id=96599 719032 9 cfleizach 2012-09-12 21:46:54 -0700 (In reply to comment #8) > (In reply to comment #7) > > http://trac.webkit.org/changeset/128376 > > It broke the !ENABLE(SVG) builds. Could you check it, please? > https://bugs.webkit.org/show_bug.cgi?id=96599 Will fix right now 719068 10 cfleizach 2012-09-12 22:54:18 -0700 (In reply to comment #9) > (In reply to comment #8) > > (In reply to comment #7) > > > http://trac.webkit.org/changeset/128376 > > > > It broke the !ENABLE(SVG) builds. Could you check it, please? > > https://bugs.webkit.org/show_bug.cgi?id=96599 > > Will fix right now Build fix http://trac.webkit.org/changeset/128405 163690 2012-09-12 14:09:05 -0700 2012-09-12 14:18:39 -0700 patch p1 text/plain 3927 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyODM1OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTEyICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IHN2ZzppbWFnZSBu b3QgYWNjZXNzaWJsZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9OTYzNDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUZXN0OiBhY2Nlc3NpYmlsaXR5L3N2Zy1pbWFnZS5odG1sCisKKyAgICAgICAgKiBhY2Nl c3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6ZGV0ZXJtaW5lQWNjZXNzaWJpbGl0eVJvbGUp OgorCiAyMDEyLTA5LTEyICBTaGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNv bT4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTI4MzE4IGFuZCByMTI4MzMy LgpJbmRleDogU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5UmVuZGVy T2JqZWN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCShyZXZpc2lvbiAxMjgzNTgpCisrKyBTb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC0zMTk2LDExICszMTk2LDEyIEBACiAgICAgICAgIHJldHVybiBMZWdlbmRS b2xlOwogICAgIGlmIChtX3JlbmRlcmVyLT5pc1RleHQoKSkKICAgICAgICAgcmV0dXJuIFN0YXRp Y1RleHRSb2xlOwotICAgIGlmIChjc3NCb3ggJiYgY3NzQm94LT5pc0ltYWdlKCkpIHsKKyAgICBp ZiAoKGNzc0JveCAmJiBjc3NCb3gtPmlzSW1hZ2UoKSkgfHwgbV9yZW5kZXJlci0+aXNTVkdJbWFn ZSgpKSB7CiAgICAgICAgIGlmIChub2RlICYmIG5vZGUtPmhhc1RhZ05hbWUoaW5wdXRUYWcpKQog ICAgICAgICAgICAgcmV0dXJuIGFyaWFIYXNQb3B1cCgpID8gUG9wVXBCdXR0b25Sb2xlIDogQnV0 dG9uUm9sZTsKICAgICAgICAgcmV0dXJuIEltYWdlUm9sZTsKICAgICB9CisgICAgCiAgICAgaWYg KG5vZGUgJiYgbm9kZS0+aGFzVGFnTmFtZShjYW52YXNUYWcpKQogICAgICAgICByZXR1cm4gQ2Fu dmFzUm9sZTsKIApJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTI4MzU4KQorKysgTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDktMTIgIENocmlz IEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogc3ZnOmltYWdl IG5vdCBhY2Nlc3NpYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NjM0MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFkZGl0aW9uYWwgaW5mb3JtYXRpb24gb2YgdGhlIGNoYW5nZSBzdWNoIGFzIGFwcHJv YWNoLCByYXRpb25hbGUuIFBsZWFzZSBhZGQgcGVyLWZ1bmN0aW9uIGRlc2NyaXB0aW9ucyBiZWxv dyAoT09QUyEpLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9zdmctaW1hZ2UuaHRtbDogQWRk ZWQuCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkvc3ZnLWltYWdlLWV4cGVj dGVkLnR4dDogQWRkZWQuCisKIDIwMTItMDktMTIgIEFkYW0gS2xlaW4gIDxhZGFta0BjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgV2lkZW4gQ1JBU0ggZXhwZWN0YXRpb25zIGZvciBmYXN0L3JlcGxh Y2VkL2JvcmRlci1yYWRpdXMtY2xpcC5odG1sCkluZGV4OiBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L3N2Zy1pbWFnZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2FjY2Vzc2liaWxp dHkvc3ZnLWltYWdlLmh0bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9hY2Nlc3NpYmls aXR5L3N2Zy1pbWFnZS5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDMyIEBACis8IURPQ1RZ UEUgSFRNTCBQVUJMSUMgIi0vL0lFVEYvL0RURCBIVE1MLy9FTiI+Cis8aHRtbD4KKzxoZWFkPgor PHNjcmlwdCBzcmM9Ii4uL2Zhc3QvanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3Njcmlw dD4KKzwvaGVhZD4KKzxib2R5IGlkPSJib2R5Ij4KKworPHN2ZyB4bWxucz0iaHR0cDovL3d3dy53 My5vcmcvMjAwMC9zdmciIHhtbG5zOnhsaW5rPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5L3hsaW5r Ij4KKworPGltYWdlIHRhYmluZGV4PSIwIiBpZD0iaW1hZ2UiIGFsdD0iVGVzdEltYWdlIiB4PSIy MCIgeT0iMjAiIHdpZHRoPSIyOTgiIGhlaWdodD0iNjUiIHhsaW5rOmhyZWY9InJlc291cmNlcy9j YWtlLnBuZyIvPgorCis8L3N2Zz4KKworPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+Cis8ZGl2IGlk PSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKworICAgIGRlc2NyaXB0aW9uKCJUaGlzIHRl c3RzIHRoYXQgU1ZHIGltYWdlcyBhcmUgYWNjZXNzaWJsZSBlbGVtZW50cy4iKTsKKworICAgIGlm ICh3aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgZG9jdW1lbnQuZ2V0 RWxlbWVudEJ5SWQoImltYWdlIikuZm9jdXMoKTsKKyAgICAgICAgdmFyIHN2ZyA9IGFjY2Vzc2li aWxpdHlDb250cm9sbGVyLmZvY3VzZWRFbGVtZW50OworICAgICAgICBzaG91bGRCZSgic3ZnLnJv bGUiLCAiJ0FYUm9sZTogQVhJbWFnZSciKTsKKyAgICAgICAgc2hvdWxkQmUoInN2Zy5kZXNjcmlw dGlvbiIsICInQVhEZXNjcmlwdGlvbjogVGVzdEltYWdlJyIpOworICAgIH0KKworPC9zY3JpcHQ+ CisKKzxzY3JpcHQgc3JjPSIuLi9mYXN0L2pzL3Jlc291cmNlcy9qcy10ZXN0LXBvc3QuanMiPjwv c2NyaXB0PgorPC9ib2R5PgorPC9odG1sPgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFj L2FjY2Vzc2liaWxpdHkvc3ZnLWltYWdlLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlv dXRUZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zdmctaW1hZ2UtZXhwZWN0ZWQudHh0 CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2liaWxpdHkv c3ZnLWltYWdlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSwxMSBAQAorVGhp cyB0ZXN0cyB0aGF0IFNWRyBpbWFnZXMgYXJlIGFjY2Vzc2libGUgZWxlbWVudHMuCisKK09uIHN1 Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2Vk IGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIHN2Zy5yb2xlIGlzICdBWFJvbGU6IEFYSW1h Z2UnCitQQVNTIHN2Zy5kZXNjcmlwdGlvbiBpcyAnQVhEZXNjcmlwdGlvbjogVGVzdEltYWdlJwor UEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisK