96336 2012-09-10 16:43:27 -0700 [V8] createFunctionOnlyCallback should be in V8Callback.h with the other callback functions 2012-09-10 17:40:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 716680 0 abarth 2012-09-10 16:43:27 -0700 [V8] createFunctionOnlyCallback should be in V8Callback.h with the other callback functions 716681 1 163244 abarth 2012-09-10 16:44:29 -0700 Created attachment 163244 Patch 716682 2 163244 haraken 2012-09-10 16:45:47 -0700 Comment on attachment 163244 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163244&action=review > Source/WebCore/ChangeLog:9 > + setTypeMismatchException because we no longer have a header inclusion Good refactoring. I've wanted to remove it for months:) 716726 3 163244 webkit.review.bot 2012-09-10 17:40:51 -0700 Comment on attachment 163244 Patch Clearing flags on attachment: 163244 Committed r128135: <http://trac.webkit.org/changeset/128135> 716727 4 webkit.review.bot 2012-09-10 17:40:54 -0700 All reviewed patches have been landed. Closing bug. 163244 2012-09-10 16:44:29 -0700 2012-09-10 17:40:51 -0700 Patch bug-96336-20120910164405.patch text/plain 6319 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODQzOGJkNzc5ZmVmYTE3 NzRhNDhlMGJlZjJjYmE1MmU0NDY3NjU0YS4uNDM5OWRiZDE0ZTA0YmYyYTI4ZDkxZWJlMmY5ZGVl Y2NjOTNiNzUzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDEyLTA5LTEwICBBZGFt IEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIGNyZWF0ZUZ1bmN0 aW9uT25seUNhbGxiYWNrIHNob3VsZCBiZSBpbiBWOENhbGxiYWNrLmggd2l0aCB0aGUgb3RoZXIg Y2FsbGJhY2sgZnVuY3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NjMzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIE1vdmluZyB0aGlzIGZ1bmN0aW9uIHRvIFY4Q2FsbGJhY2suaCBhbHNvIGxldHMg dXMgZGVsZXRlCisgICAgICAgIHNldFR5cGVNaXNtYXRjaEV4Y2VwdGlvbiBiZWNhdXNlIHdlIG5v IGxvbmdlciBoYXZlIGEgaGVhZGVyIGluY2x1c2lvbgorICAgICAgICBjeWNsZS4KKworICAgICAg ICAqIGJpbmRpbmdzL3Y4L1Y4Q2FsbGJhY2suaDoKKyAgICAgICAgKFdlYkNvcmU6OmNyZWF0ZUZ1 bmN0aW9uT25seUNhbGxiYWNrKToKKyAgICAgICAgKFdlYkNvcmUpOgorICAgICAgICAqIGJpbmRp bmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcDoKKyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFV0aWxpdGll cy5oOgorICAgICAgICAoV2ViQ29yZSk6CisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4 R2VvbG9jYXRpb25DdXN0b20uY3BwOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOE5v dGlmaWNhdGlvbkN1c3RvbS5jcHA6CisKKzIwMTItMDktMTAgIEFkYW0gQmFydGggIDxhYmFydGhA Y2hyb21pdW0ub3JnPgorCiAgICAgICAgIFtWOF0gVjhQZXJJc29sYXRlRGF0YTo6bV90b1N0cmlu Z1RlbXBsYXRlIGxlYWtzIG1lbW9yeQogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTYzMjIKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhDYWxsYmFjay5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhDYWxsYmFj ay5oCmluZGV4IDkyNTM2NDdmYzQ3YTRlZGRhYjVhZjI1NTNlZmE4ODBlYWQ5ZTE1YjQuLmZlZTE4 YjEzMDM4MDIzZTE0Y2VhMTgwZGMwNWIzNTUwOWFiNzBhYjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q2FsbGJhY2suaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOENhbGxiYWNrLmgKQEAgLTMxLDYgKzMxLDggQEAKICNpZm5kZWYgVjhDYWxsYmFj a19oCiAjZGVmaW5lIFY4Q2FsbGJhY2tfaAogCisjaW5jbHVkZSAiRXhjZXB0aW9uQ29kZS5oIgor I2luY2x1ZGUgIlY4QmluZGluZy5oIgogI2luY2x1ZGUgPHY4Lmg+CiAKIG5hbWVzcGFjZSBXZWJD b3JlIHsKQEAgLTQwLDYgKzQyLDM0IEBAIGNsYXNzIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQ7CiBi b29sIGludm9rZUNhbGxiYWNrKHY4OjpQZXJzaXN0ZW50PHY4OjpPYmplY3Q+IGNhbGxiYWNrLCBp bnQgYXJnYywgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFyZ3ZbXSwgYm9vbCYgY2FsbGJhY2tSZXR1 cm5WYWx1ZSwgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCopOwogYm9vbCBpbnZva2VDYWxsYmFjayh2 ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0PiBjYWxsYmFjaywgdjg6OkhhbmRsZTx2ODo6T2JqZWN0 PiB0aGlzT2JqZWN0LCBpbnQgYXJnYywgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IGFyZ3ZbXSwgYm9v bCYgY2FsbGJhY2tSZXR1cm5WYWx1ZSwgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCopOwogCitlbnVt IENhbGxiYWNrQWxsb3dlZFZhbHVlRmxhZyB7CisgICAgQ2FsbGJhY2tBbGxvd1VuZGVmaW5lZCA9 IDEsCisgICAgQ2FsbGJhY2tBbGxvd051bGwgPSAxIDw8IDEKK307CisKK3R5cGVkZWYgdW5zaWdu ZWQgQ2FsbGJhY2tBbGxvd2VkVmFsdWVGbGFnczsKKworLy8gJ0Z1bmN0aW9uT25seScgaXMgYXNz dW1lZCBmb3IgdGhlIGNyZWF0ZWQgY2FsbGJhY2suCit0ZW1wbGF0ZSA8dHlwZW5hbWUgVjhDYWxs YmFja1R5cGU+CitQYXNzUmVmUHRyPFY4Q2FsbGJhY2tUeXBlPiBjcmVhdGVGdW5jdGlvbk9ubHlD YWxsYmFjayh2ODo6TG9jYWw8djg6OlZhbHVlPiB2YWx1ZSwgYm9vbCYgc3VjY2VlZGVkLCB2ODo6 SXNvbGF0ZSogaXNvbGF0ZSwgQ2FsbGJhY2tBbGxvd2VkVmFsdWVGbGFncyBhY2NlcHRlZFZhbHVl cyA9IDApCit7CisgICAgc3VjY2VlZGVkID0gdHJ1ZTsKKworICAgIGlmICh2YWx1ZS0+SXNVbmRl ZmluZWQoKSAmJiAoYWNjZXB0ZWRWYWx1ZXMgJiBDYWxsYmFja0FsbG93VW5kZWZpbmVkKSkKKyAg ICAgICAgcmV0dXJuIDA7CisKKyAgICBpZiAodmFsdWUtPklzTnVsbCgpICYmIChhY2NlcHRlZFZh bHVlcyAmIENhbGxiYWNrQWxsb3dOdWxsKSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBpZiAo IXZhbHVlLT5Jc0Z1bmN0aW9uKCkpIHsKKyAgICAgICAgc3VjY2VlZGVkID0gZmFsc2U7CisgICAg ICAgIHNldERPTUV4Y2VwdGlvbihUWVBFX01JU01BVENIX0VSUiwgaXNvbGF0ZSk7CisgICAgICAg IHJldHVybiAwOworICAgIH0KKworICAgIHJldHVybiBWOENhbGxiYWNrVHlwZTo6Y3JlYXRlKHZh bHVlLCBnZXRTY3JpcHRFeGVjdXRpb25Db250ZXh0KCkpOworfQorCiB9IC8vIG5hbWVzcGFjZSBX ZWJDb3JlCiAKICNlbmRpZiAvLyBWOENhbGxiYWNrX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3Y4L1Y4VXRpbGl0aWVzLmNwcAppbmRleCBkNGJkMWE5NjM3NzYyMzI5OGM3ZTQyY2ExZGQ4OWI2 ZTRhN2YwZmI3Li44YzkzZTgzNDFiNGI5NDAyNjgwMGVjNmJkMjkzZTNlNmFkN2ZiOGRlIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGlsaXRpZXMuY3BwCkBAIC0xNjMsOSArMTYz LDQgQEAgU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogZ2V0U2NyaXB0RXhlY3V0aW9uQ29udGV4dCgp CiAgICAgcmV0dXJuIGN1cnJlbnREb2N1bWVudChCaW5kaW5nU3RhdGU6Omluc3RhbmNlKCkpOwog fQogCi12b2lkIHNldFR5cGVNaXNtYXRjaEV4Y2VwdGlvbih2ODo6SXNvbGF0ZSogaXNvbGF0ZSkK LXsKLSAgICBzZXRET01FeGNlcHRpb24oVFlQRV9NSVNNQVRDSF9FUlIsIGlzb2xhdGUpOwotfQot CiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9WOFV0aWxpdGllcy5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhVdGls aXRpZXMuaAppbmRleCA4YWI0YWY4YzczNDljNmYwOTZkZTBkN2U3MDQyMzE4NzI1YWJjMGFiLi40 YmM1NmNjYWZmYmQ0YjUxZDNhYWU2ODZjNzcwMjljNGJjZDI5OWFkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFV0aWxpdGllcy5oCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL3Y4L1Y4VXRpbGl0aWVzLmgKQEAgLTUzLDE1ICs1Myw2IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAogICAgIFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGdldFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQoKTsKIAotICAgIHZvaWQgc2V0VHlwZU1pc21hdGNoRXhjZXB0aW9uKHY4OjpJc29s YXRlKik7Ci0KLSAgICBlbnVtIENhbGxiYWNrQWxsb3dlZFZhbHVlRmxhZyB7Ci0gICAgICAgIENh bGxiYWNrQWxsb3dVbmRlZmluZWQgPSAxLAotICAgICAgICBDYWxsYmFja0FsbG93TnVsbCA9IDEg PDwgMQotICAgIH07Ci0KLSAgICB0eXBlZGVmIHVuc2lnbmVkIENhbGxiYWNrQWxsb3dlZFZhbHVl RmxhZ3M7Ci0KICAgICB0eXBlZGVmIFdURjo6VmVjdG9yPFJlZlB0cjxNZXNzYWdlUG9ydD4sIDE+ IE1lc3NhZ2VQb3J0QXJyYXk7CiAgICAgdHlwZWRlZiBXVEY6OlZlY3RvcjxSZWZQdHI8QXJyYXlC dWZmZXI+LCAxPiBBcnJheUJ1ZmZlckFycmF5OwogCkBAIC03MiwyNyArNjMsNiBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAgICAgYm9vbCBleHRyYWN0VHJhbnNmZXJhYmxlcyh2ODo6TG9jYWw8djg6 OlZhbHVlPiwgTWVzc2FnZVBvcnRBcnJheSYsIEFycmF5QnVmZmVyQXJyYXkmLCB2ODo6SXNvbGF0 ZSopOyAKICAgICBib29sIGdldE1lc3NhZ2VQb3J0QXJyYXkodjg6OkxvY2FsPHY4OjpWYWx1ZT4s IE1lc3NhZ2VQb3J0QXJyYXkmLCB2ODo6SXNvbGF0ZSopOwogCi0gICAgLy8gJ0Z1bmN0aW9uT25s eScgaXMgYXNzdW1lZCBmb3IgdGhlIGNyZWF0ZWQgY2FsbGJhY2suCi0gICAgdGVtcGxhdGUgPHR5 cGVuYW1lIFY4Q2FsbGJhY2tUeXBlPgotICAgIFBhc3NSZWZQdHI8VjhDYWxsYmFja1R5cGU+IGNy ZWF0ZUZ1bmN0aW9uT25seUNhbGxiYWNrKHY4OjpMb2NhbDx2ODo6VmFsdWU+IHZhbHVlLCBib29s JiBzdWNjZWVkZWQsIHY4OjpJc29sYXRlKiBpc29sYXRlLCBDYWxsYmFja0FsbG93ZWRWYWx1ZUZs YWdzIGFjY2VwdGVkVmFsdWVzID0gMCkKLSAgICB7Ci0gICAgICAgIHN1Y2NlZWRlZCA9IHRydWU7 Ci0KLSAgICAgICAgaWYgKHZhbHVlLT5Jc1VuZGVmaW5lZCgpICYmIChhY2NlcHRlZFZhbHVlcyAm IENhbGxiYWNrQWxsb3dVbmRlZmluZWQpKQotICAgICAgICAgICAgcmV0dXJuIDA7Ci0KLSAgICAg ICAgaWYgKHZhbHVlLT5Jc051bGwoKSAmJiAoYWNjZXB0ZWRWYWx1ZXMgJiBDYWxsYmFja0FsbG93 TnVsbCkpCi0gICAgICAgICAgICByZXR1cm4gMDsKLQotICAgICAgICBpZiAoIXZhbHVlLT5Jc0Z1 bmN0aW9uKCkpIHsKLSAgICAgICAgICAgIHN1Y2NlZWRlZCA9IGZhbHNlOwotICAgICAgICAgICAg c2V0VHlwZU1pc21hdGNoRXhjZXB0aW9uKGlzb2xhdGUpOwotICAgICAgICAgICAgcmV0dXJuIDA7 Ci0gICAgICAgIH0KLQotICAgICAgICByZXR1cm4gVjhDYWxsYmFja1R5cGU6OmNyZWF0ZSh2YWx1 ZSwgZ2V0U2NyaXB0RXhlY3V0aW9uQ29udGV4dCgpKTsKLSAgICB9Ci0KIH0gLy8gbmFtZXNwYWNl IFdlYkNvcmUKIAogI2VuZGlmIC8vIFY4VXRpbGl0aWVzX2gKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEdlb2xvY2F0aW9uQ3VzdG9tLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEdlb2xvY2F0aW9uQ3VzdG9tLmNwcAppbmRl eCAzNzM0YTIzZDVhYjQ2M2U1YWVhZWQ4N2NmYWQ0YWJjNDc3ZjVkYTc2Li5lYzJmNTRmMjc3ZDdi Y2IzYTIyY2Q0YjVlMThjODk4ZWEyYmY1YTNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9i aW5kaW5ncy92OC9jdXN0b20vVjhHZW9sb2NhdGlvbkN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4R2VvbG9jYXRpb25DdXN0b20uY3BwCkBAIC0zMSw2 ICszMSw3IEBACiAjaW5jbHVkZSAiRnJhbWUuaCIKICNpbmNsdWRlICJHZW9sb2NhdGlvbi5oIgog I2luY2x1ZGUgIlY4QmluZGluZy5oIgorI2luY2x1ZGUgIlY4Q2FsbGJhY2suaCIKICNpbmNsdWRl ICJWOFBvc2l0aW9uQ2FsbGJhY2suaCIKICNpbmNsdWRlICJWOFBvc2l0aW9uRXJyb3JDYWxsYmFj ay5oIgogI2luY2x1ZGUgIlY4VXRpbGl0aWVzLmgiCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhOb3RpZmljYXRpb25DdXN0b20uY3BwIGIvU291cmNlL1dl YkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4Tm90aWZpY2F0aW9uQ3VzdG9tLmNwcAppbmRleCA3 NTY1ZmZlNDg2Zjg4Njg4OTAyZGZlYWI1ZWViNzliM2RmZWFiYTkwLi5jMWYxNDJjZTk2N2ZhZDI3 NjU4NzlmMjM4YmNhMjkyNjc4MjU5NGQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhOb3RpZmljYXRpb25DdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOE5vdGlmaWNhdGlvbkN1c3RvbS5jcHAKQEAgLTI5LDYg KzI5LDcgQEAKICNpbmNsdWRlICJWOE5vdGlmaWNhdGlvbi5oIgogCiAjaW5jbHVkZSAiRXhjZXB0 aW9uQ29kZS5oIgorI2luY2x1ZGUgIlY4Q2FsbGJhY2suaCIKICNpbmNsdWRlICJWOE5vdGlmaWNh dGlvblBlcm1pc3Npb25DYWxsYmFjay5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7Cg==