96329 2012-09-10 15:14:23 -0700 Refactor computePercentageLogicalHeight to simplify the logic a bit 2012-09-11 12:05:11 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ojan ojan eric webkit.review.bot oldest_to_newest 716577 0 ojan 2012-09-10 15:14:23 -0700 Refactor computePercentageLogicalHeight to simplify the logic a bit 716579 1 163223 ojan 2012-09-10 15:14:55 -0700 Created attachment 163223 Patch 716719 2 163223 webkit.review.bot 2012-09-10 17:22:47 -0700 Comment on attachment 163223 Patch Rejecting attachment 163223 from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: Kit/chromium/third_party/yasm/source/patched-yasm --revision 154697 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 50>At revision 154697. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/13804769 717456 3 ojan 2012-09-11 12:05:11 -0700 Committed r128215: <http://trac.webkit.org/changeset/128215> 163223 2012-09-10 15:14:55 -0700 2012-09-10 17:22:47 -0700 Patch bug-96329-20120910151431.patch text/plain 4605 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjc3MjRjNTAzZjg2MTVm NTk0ODQ2NTdkODcyZjdjZjQ2M2MzMDA0Zi4uM2I3MDEyNmY4YmUwZDVjYmVmNzY2YjQ4MzNjOGI5 NDc3ZTJjZGY3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTEwICBPamFu IFZhZmFpICA8b2phbkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmVmYWN0b3IgY29tcHV0ZVBl cmNlbnRhZ2VMb2dpY2FsSGVpZ2h0IHRvIHNpbXBsaWZ5IHRoZSBsb2dpYyBhIGJpdAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYzMjkKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIG1ha2VzIGl0IGNs ZWFyIHRoYXQgdGhlIHZhbHVlIHdlJ3JlIGNvbXB1dGluZyBhcyB3ZSBnbyBpcyB0aGUgYXZhaWxh YmxlSGVpZ2h0LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJveC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpSZW5kZXJCb3g6OmNvbXB1dGVQZXJjZW50YWdlTG9naWNhbEhlaWdodCk6CisK IDIwMTItMDktMTAgIEFuZHJlYXMgS2xpbmcgIDxrbGluZ0B3ZWJraXQub3JnPgogCiAgICAgICAg IEVsZW1lbnRBdHRyaWJ1dGVEYXRhOiBVc2Ugc3ViY2xhc3NlcyB0byBtYW5hZ2UgdmFyeWluZyBv YmplY3QgbGF5b3V0cy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5k ZXJCb3guY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAKaW5kZXgg NzkyYjljMjhiZTkxMGU5NGZmOTdkNWY3YWI0ZTY3YTIyYjNmZDNiYS4uZGU3ZjM4N2M3MWVjNTM2 MDZhZGZkOWE2NmUwZDJjNGNiZDAzZTA4ZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVu ZGVyaW5nL1JlbmRlckJveC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ckJveC5jcHAKQEAgLTIxMTgsNyArMjExOCw3IEBAIExheW91dFVuaXQgUmVuZGVyQm94Ojpjb21w dXRlQ29udGVudExvZ2ljYWxIZWlnaHRVc2luZyhTaXplVHlwZSBoZWlnaHRUeXBlLCBjb25zCiAK IExheW91dFVuaXQgUmVuZGVyQm94Ojpjb21wdXRlUGVyY2VudGFnZUxvZ2ljYWxIZWlnaHQoY29u c3QgTGVuZ3RoJiBoZWlnaHQpIGNvbnN0CiB7Ci0gICAgTGF5b3V0VW5pdCByZXN1bHQgPSAtMTsK KyAgICBMYXlvdXRVbml0IGF2YWlsYWJsZUhlaWdodCA9IC0xOwogICAgIAogICAgIC8vIEluIHF1 aXJrcyBtb2RlLCBibG9ja3Mgd2l0aCBhdXRvIGhlaWdodCBhcmUgc2tpcHBlZCwgYW5kIHdlIGtl ZXAgbG9va2luZyBmb3IgYW4gZW5jbG9zaW5nCiAgICAgLy8gYmxvY2sgdGhhdCBtYXkgaGF2ZSBh IHNwZWNpZmllZCBoZWlnaHQgYW5kIHRoZW4gdXNlIGl0LiBJbiBzdHJpY3QgbW9kZSwgdGhpcyB2 aW9sYXRlcyB0aGUKQEAgLTIxNjMsMzggKzIxNjMsNDAgQEAgTGF5b3V0VW5pdCBSZW5kZXJCb3g6 OmNvbXB1dGVQZXJjZW50YWdlTG9naWNhbEhlaWdodChjb25zdCBMZW5ndGgmIGhlaWdodCkgY29u c3QKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIDA7CiAgICAgICAgICAgICAgICAgcmV0dXJu IC0xOwogICAgICAgICAgICAgfQotICAgICAgICAgICAgcmVzdWx0ID0gY2ItPm92ZXJyaWRlTG9n aWNhbENvbnRlbnRIZWlnaHQoKTsKKyAgICAgICAgICAgIGF2YWlsYWJsZUhlaWdodCA9IGNiLT5v dmVycmlkZUxvZ2ljYWxDb250ZW50SGVpZ2h0KCk7CiAgICAgICAgICAgICBpbmNsdWRlQm9yZGVy UGFkZGluZyA9IHRydWU7CiAgICAgICAgIH0KICAgICB9IGVsc2UgaWYgKGNic3R5bGUtPmxvZ2lj YWxIZWlnaHQoKS5pc0ZpeGVkKCkpIHsKICAgICAgICAgLy8gT3RoZXJ3aXNlIHdlIG9ubHkgdXNl IG91ciBwZXJjZW50YWdlIGhlaWdodCBpZiBvdXIgY29udGFpbmluZyBibG9jayBoYWQgYSBzcGVj aWZpZWQgaGVpZ2h0LgogICAgICAgICBMYXlvdXRVbml0IGNvbnRlbnRCb3hIZWlnaHRXaXRoU2Ny b2xsYmFyID0gY2ItPmNvbXB1dGVDb250ZW50Qm94TG9naWNhbEhlaWdodChjYnN0eWxlLT5sb2dp Y2FsSGVpZ2h0KCkudmFsdWUoKSk7Ci0gICAgICAgIHJlc3VsdCA9IG1heDxMYXlvdXRVbml0Pigw LCBjb250ZW50Qm94SGVpZ2h0V2l0aFNjcm9sbGJhciAtIGNiLT5zY3JvbGxiYXJMb2dpY2FsSGVp Z2h0KCkpOworICAgICAgICBhdmFpbGFibGVIZWlnaHQgPSBtYXg8TGF5b3V0VW5pdD4oMCwgY29u dGVudEJveEhlaWdodFdpdGhTY3JvbGxiYXIgLSBjYi0+c2Nyb2xsYmFyTG9naWNhbEhlaWdodCgp KTsKICAgICB9IGVsc2UgaWYgKGNic3R5bGUtPmxvZ2ljYWxIZWlnaHQoKS5pc1BlcmNlbnQoKSAm JiAhaXNPdXRPZkZsb3dQb3NpdGlvbmVkV2l0aFNwZWNpZmllZEhlaWdodCkgewogICAgICAgICAv LyBXZSBuZWVkIHRvIHJlY3VyIGFuZCBjb21wdXRlIHRoZSBwZXJjZW50YWdlIGhlaWdodCBmb3Ig b3VyIGNvbnRhaW5pbmcgYmxvY2suCiAgICAgICAgIExheW91dFVuaXQgaGVpZ2h0V2l0aFNjcm9s bGJhciA9IGNiLT5jb21wdXRlUGVyY2VudGFnZUxvZ2ljYWxIZWlnaHQoY2JzdHlsZS0+bG9naWNh bEhlaWdodCgpKTsKICAgICAgICAgaWYgKGhlaWdodFdpdGhTY3JvbGxiYXIgIT0gLTEpIHsKICAg ICAgICAgICAgIExheW91dFVuaXQgY29udGVudEJveEhlaWdodFdpdGhTY3JvbGxiYXIgPSBjYi0+ Y29tcHV0ZUNvbnRlbnRCb3hMb2dpY2FsSGVpZ2h0KGhlaWdodFdpdGhTY3JvbGxiYXIpOwotICAg ICAgICAgICAgcmVzdWx0ID0gbWF4PExheW91dFVuaXQ+KDAsIGNvbnRlbnRCb3hIZWlnaHRXaXRo U2Nyb2xsYmFyIC0gY2ItPnNjcm9sbGJhckxvZ2ljYWxIZWlnaHQoKSk7CisgICAgICAgICAgICBh dmFpbGFibGVIZWlnaHQgPSBtYXg8TGF5b3V0VW5pdD4oMCwgY29udGVudEJveEhlaWdodFdpdGhT Y3JvbGxiYXIgLSBjYi0+c2Nyb2xsYmFyTG9naWNhbEhlaWdodCgpKTsKICAgICAgICAgfQogICAg IH0gZWxzZSBpZiAoY2ItPmlzUmVuZGVyVmlldygpIHx8IChjYi0+aXNCb2R5KCkgJiYgZG9jdW1l bnQoKS0+aW5RdWlya3NNb2RlKCkpIHx8IGlzT3V0T2ZGbG93UG9zaXRpb25lZFdpdGhTcGVjaWZp ZWRIZWlnaHQpIHsKICAgICAgICAgLy8gRG9uJ3QgYWxsb3cgdGhpcyB0byBhZmZlY3QgdGhlIGJs b2NrJyBoZWlnaHQoKSBtZW1iZXIgdmFyaWFibGUsIHNpbmNlIHRoaXMKICAgICAgICAgLy8gY2Fu IGdldCBjYWxsZWQgd2hpbGUgdGhlIGJsb2NrIGlzIHN0aWxsIGxheWluZyBvdXQgaXRzIGtpZHMu CiAgICAgICAgIExheW91dFVuaXQgb2xkSGVpZ2h0ID0gY2ItPmxvZ2ljYWxIZWlnaHQoKTsKICAg ICAgICAgY2ItPmNvbXB1dGVMb2dpY2FsSGVpZ2h0KCk7Ci0gICAgICAgIHJlc3VsdCA9IGNiLT5j b250ZW50TG9naWNhbEhlaWdodCgpOworICAgICAgICBhdmFpbGFibGVIZWlnaHQgPSBjYi0+Y29u dGVudExvZ2ljYWxIZWlnaHQoKTsKICAgICAgICAgY2ItPnNldExvZ2ljYWxIZWlnaHQob2xkSGVp Z2h0KTsKICAgICB9CiAKLSAgICBpZiAocmVzdWx0ICE9IC0xKSB7Ci0gICAgICAgIHJlc3VsdCA9 IHZhbHVlRm9yTGVuZ3RoKGhlaWdodCwgcmVzdWx0KTsKLSAgICAgICAgaWYgKGluY2x1ZGVCb3Jk ZXJQYWRkaW5nKSB7Ci0gICAgICAgICAgICAvLyBJdCBpcyBuZWNlc3NhcnkgdG8gdXNlIHRoZSBi b3JkZXItYm94IHRvIG1hdGNoIFdpbklFJ3MgYnJva2VuCi0gICAgICAgICAgICAvLyBib3ggbW9k ZWwuICBUaGlzIGlzIGVzc2VudGlhbCBmb3Igc2l6aW5nIGluc2lkZQotICAgICAgICAgICAgLy8g dGFibGUgY2VsbHMgdXNpbmcgcGVyY2VudGFnZSBoZWlnaHRzLgotICAgICAgICAgICAgcmVzdWx0 IC09IGJvcmRlckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCk7Ci0gICAgICAgICAgICByZXN1bHQg PSBtYXg8TGF5b3V0VW5pdD4oMCwgcmVzdWx0KTsKLSAgICAgICAgfQorICAgIGlmIChhdmFpbGFi bGVIZWlnaHQgPT0gLTEpCisgICAgICAgIHJldHVybiBhdmFpbGFibGVIZWlnaHQ7CisKKyAgICBM YXlvdXRVbml0IHJlc3VsdCA9IHZhbHVlRm9yTGVuZ3RoKGhlaWdodCwgYXZhaWxhYmxlSGVpZ2h0 KTsKKyAgICBpZiAoaW5jbHVkZUJvcmRlclBhZGRpbmcpIHsKKyAgICAgICAgLy8gRklYTUU6IFRh YmxlIGNlbGxzIHNob3VsZCBkZWZhdWx0IHRvIGJveC1zaXppbmc6IGJvcmRlci1ib3ggc28gd2Ug Y2FuIGF2b2lkIHRoaXMgaGFjay4KKyAgICAgICAgLy8gSXQgaXMgbmVjZXNzYXJ5IHRvIHVzZSB0 aGUgYm9yZGVyLWJveCB0byBtYXRjaCBXaW5JRSdzIGJyb2tlbgorICAgICAgICAvLyBib3ggbW9k ZWwuIFRoaXMgaXMgZXNzZW50aWFsIGZvciBzaXppbmcgaW5zaWRlCisgICAgICAgIC8vIHRhYmxl IGNlbGxzIHVzaW5nIHBlcmNlbnRhZ2UgaGVpZ2h0cy4KKyAgICAgICAgcmVzdWx0IC09IGJvcmRl ckFuZFBhZGRpbmdMb2dpY2FsSGVpZ2h0KCk7CisgICAgICAgIHJldHVybiBtYXg8TGF5b3V0VW5p dD4oMCwgcmVzdWx0KTsKICAgICB9CiAgICAgcmV0dXJuIHJlc3VsdDsKIH0K