96324 2012-09-10 14:55:26 -0700 [V8] V8LazyEventListener::prepareListenerObject uses inefficient string operations 2012-09-10 16:22:28 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 716554 0 abarth 2012-09-10 14:55:26 -0700 [V8] V8LazyEventListener::prepareListenerObject uses inefficient string operations 716555 1 163215 abarth 2012-09-10 14:56:35 -0700 Created attachment 163215 Patch 716557 2 163215 haraken 2012-09-10 14:59:23 -0700 Comment on attachment 163215 Patch OK 716657 3 163215 abarth 2012-09-10 16:22:26 -0700 Comment on attachment 163215 Patch Clearing flags on attachment: 163215 Committed r128126: <http://trac.webkit.org/changeset/128126> 716658 4 abarth 2012-09-10 16:22:28 -0700 All reviewed patches have been landed. Closing bug. 163215 2012-09-10 14:56:35 -0700 2012-09-10 16:22:26 -0700 Patch bug-96324-20120910145611.patch text/plain 3614 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmI5MmIwZGI2MWMyY2U1 NzBmZTRhN2M5OWRjYzExYmQxMzgyM2E3MS4uYzQ5ZTc3N2Y2YTQzMjg0YjY0NGJjOGYwNDQzODI0 NWMwOWRjNzY5NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDEyLTA5LTEwICBBZGFt IEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFY4TGF6eUV2ZW50 TGlzdGVuZXI6OnByZXBhcmVMaXN0ZW5lck9iamVjdCB1c2VzIGluZWZmaWNpZW50IHN0cmluZyBv cGVyYXRpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NjMyNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFByZXZpb3VzbHksIHRoaXMgY29kZSBjYWxsZWQgU3RyaW5nOjphcHBlbmQgc2V2ZXJhbCB0aW1l cywgd2hpY2gKKyAgICAgICAgbWFsbG9jcyBhIG5ldyBzdHJpbmcgYnVmZmVyIGVhY2ggdGltZS4g VGhpcyBwYXRjaCBzd2l0Y2hlcyB0aGlzIGNvZGUgdG8KKyAgICAgICAgdXNlIG9wZXJhdG9yKywg d2hpY2ggdXNlcyBTdHJpbmdBcHBlbmQgdG8gb3B0aW1pemUgdGhlc2Ugb3BlcmF0aW9ucworICAg ICAgICBkb3duIHRvIGEgc2luZ2xlIG1hbGxvYy4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4 TGF6eUV2ZW50TGlzdGVuZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhMYXp5RXZlbnRMaXN0 ZW5lcjo6cHJlcGFyZUxpc3RlbmVyT2JqZWN0KToKKworMjAxMi0wOS0xMCAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW1Y4XSBWOFBlcklzb2xhdGVEYXRhOjpt X3RvU3RyaW5nVGVtcGxhdGUgbGVha3MgbWVtb3J5CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjMyMgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy92OC9WOExhenlFdmVudExpc3RlbmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3Y4L1Y4TGF6eUV2ZW50TGlzdGVuZXIuY3BwCmluZGV4IGMxYmJkYmY3NzU2ZThiMDc1 N2E4YWQwNGI5MjQ0NDExYTFhOGFlM2QuLjhmYmRlOTM1ZTM3MDE4OWVmNzk5OTY0NmQ0MDUzNjZm ZDMwZTRkNWEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TGF6eUV2 ZW50TGlzdGVuZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4TGF6eUV2 ZW50TGlzdGVuZXIuY3BwCkBAIC0xNDUsMTYgKzE0NSwxNSBAQCB2b2lkIFY4TGF6eUV2ZW50TGlz dGVuZXI6OnByZXBhcmVMaXN0ZW5lck9iamVjdChTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250 ZXh0KQogICAgIC8vIENhbGwgd2l0aCA0IGFyZ3VtZW50cyBpbnN0ZWFkIG9mIDMsIHBhc3MgYWRk aXRpb25hbCBudWxsIGFzIHRoZSBsYXN0IHBhcmFtZXRlci4KICAgICAvLyBCeSBjYWxsaW5nIHRo ZSBmdW5jdGlvbiB3aXRoIDQgYXJndW1lbnRzLCB3ZSBjcmVhdGUgYSBzZXR0ZXIgb24gYXJndW1l bnRzIG9iamVjdAogICAgIC8vIHdoaWNoIHdvdWxkIHNoYWRvdyBwcm9wZXJ0eSAiMyIgb24gdGhl IHByb3RvdHlwZS4KLSAgICBTdHJpbmcgY29kZSA9IEFTQ0lJTGl0ZXJhbCgiKGZ1bmN0aW9uKCkg eyIgXAotICAgICAgICAid2l0aCAodGhpc1syXSkgeyIgXAotICAgICAgICAid2l0aCAodGhpc1sx XSkgeyIgXAotICAgICAgICAid2l0aCAodGhpc1swXSkgeyIpOwotICAgIGNvZGUuYXBwZW5kKCJy ZXR1cm4gZnVuY3Rpb24oIik7Ci0gICAgY29kZS5hcHBlbmQobV9ldmVudFBhcmFtZXRlck5hbWUp OwotICAgIGNvZGUuYXBwZW5kKCIpIHsiKTsKLSAgICBjb2RlLmFwcGVuZChtX2NvZGUpOwotICAg IC8vIEluc2VydCAnXG4nIG90aGVyd2lzZSAvLy1zdHlsZSBjb21tZW50cyBjb3VsZCBicmVhayB0 aGUgaGFuZGxlci4KLSAgICBjb2RlLmFwcGVuZCgiXG59O319fX0pIik7CisgICAgU3RyaW5nIGNv ZGUgPSAiKGZ1bmN0aW9uKCkgeyIKKyAgICAgICAgIndpdGggKHRoaXNbMl0pIHsiCisgICAgICAg ICJ3aXRoICh0aGlzWzFdKSB7IgorICAgICAgICAid2l0aCAodGhpc1swXSkgeyIKKyAgICAgICAg ICAgICJyZXR1cm4gZnVuY3Rpb24oIiArIG1fZXZlbnRQYXJhbWV0ZXJOYW1lICsgIikgeyIgKwor ICAgICAgICAgICAgICAgIG1fY29kZSArICJcbiIgLy8gSW5zZXJ0ICdcbicgb3RoZXJ3aXNlIC8v LXN0eWxlIGNvbW1lbnRzIGNvdWxkIGJyZWFrIHRoZSBoYW5kbGVyLgorICAgICAgICAgICAgIn07 IgorICAgICAgICAifX19fSkiOworCiAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBjb2RlRXh0 ZXJuYWxTdHJpbmcgPSB2OEV4dGVybmFsU3RyaW5nKGNvZGUpOwogCiAgICAgdjg6OkhhbmRsZTx2 ODo6U2NyaXB0PiBzY3JpcHQgPSBTY3JpcHRTb3VyY2VDb2RlOjpjb21waWxlU2NyaXB0KGNvZGVF eHRlcm5hbFN0cmluZywgbV9zb3VyY2VVUkwsIG1fcG9zaXRpb24pOwpAQCAtMjE5LDE0ICsyMTgs OCBAQCB2b2lkIFY4TGF6eUV2ZW50TGlzdGVuZXI6OnByZXBhcmVMaXN0ZW5lck9iamVjdChTY3Jp cHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0KQogICAgIGlmICghdG9TdHJpbmdUZW1wbGF0ZS5J c0VtcHR5KCkpCiAgICAgICAgIHRvU3RyaW5nRnVuY3Rpb24gPSB0b1N0cmluZ1RlbXBsYXRlLT5H ZXRGdW5jdGlvbigpOwogICAgIGlmICghdG9TdHJpbmdGdW5jdGlvbi5Jc0VtcHR5KCkpIHsKLSAg ICAgICAgU3RyaW5nIHRvU3RyaW5nUmVzdWx0ID0gQVNDSUlMaXRlcmFsKCJmdW5jdGlvbiAiKTsK LSAgICAgICAgdG9TdHJpbmdSZXN1bHQuYXBwZW5kKG1fZnVuY3Rpb25OYW1lKTsKLSAgICAgICAg dG9TdHJpbmdSZXN1bHQuYXBwZW5kKCIoIik7Ci0gICAgICAgIHRvU3RyaW5nUmVzdWx0LmFwcGVu ZChtX2V2ZW50UGFyYW1ldGVyTmFtZSk7Ci0gICAgICAgIHRvU3RyaW5nUmVzdWx0LmFwcGVuZCgi KSB7XG4gICIpOwotICAgICAgICB0b1N0cmluZ1Jlc3VsdC5hcHBlbmQobV9jb2RlKTsKLSAgICAg ICAgdG9TdHJpbmdSZXN1bHQuYXBwZW5kKCJcbn0iKTsKLSAgICAgICAgd3JhcHBlZEZ1bmN0aW9u LT5TZXRIaWRkZW5WYWx1ZShWOEhpZGRlblByb3BlcnR5TmFtZTo6dG9TdHJpbmdTdHJpbmcoKSwg djhFeHRlcm5hbFN0cmluZyh0b1N0cmluZ1Jlc3VsdCkpOworICAgICAgICBTdHJpbmcgdG9TdHJp bmdTdHJpbmcgPSAiZnVuY3Rpb24gIiArIG1fZnVuY3Rpb25OYW1lICsgIigiICsgbV9ldmVudFBh cmFtZXRlck5hbWUgKyAiKSB7XG4gICIgKyBtX2NvZGUgKyAiXG59IjsKKyAgICAgICAgd3JhcHBl ZEZ1bmN0aW9uLT5TZXRIaWRkZW5WYWx1ZShWOEhpZGRlblByb3BlcnR5TmFtZTo6dG9TdHJpbmdT dHJpbmcoKSwgdjhFeHRlcm5hbFN0cmluZyh0b1N0cmluZ1N0cmluZykpOwogICAgICAgICB3cmFw cGVkRnVuY3Rpb24tPlNldCh2ODo6U3RyaW5nOjpOZXdTeW1ib2woInRvU3RyaW5nIiksIHRvU3Ry aW5nRnVuY3Rpb24pOwogICAgIH0KIAo=