96322 2012-09-10 14:43:59 -0700 [V8] V8PerIsolateData::m_toStringTemplate leaks memory 2012-09-10 16:23:08 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 716536 0 abarth 2012-09-10 14:43:59 -0700 [V8] V8PerIsolateData::m_toStringTemplate leaks memory 716539 1 163213 abarth 2012-09-10 14:45:20 -0700 Created attachment 163213 Patch 716541 2 abarth 2012-09-10 14:45:50 -0700 This leak is also small (one per thread) 716544 3 163213 haraken 2012-09-10 14:46:38 -0700 Comment on attachment 163213 Patch Looks OK 716659 4 abarth 2012-09-10 16:23:08 -0700 Committed r128127: <http://trac.webkit.org/changeset/128127> 163213 2012-09-10 14:45:20 -0700 2012-09-10 16:15:41 -0700 Patch bug-96322-20120910144456.patch text/plain 3509 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDhjNzZmNjM3NTU4ZWU4 MDNmOWYwZTE0ZTZlMWM0YmQ2YTQ3NDY4Yy4uYmI5MmIwZGI2MWMyY2U1NzBmZTRhN2M5OWRjYzEx YmQxMzgyM2E3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIyIEBACiAyMDEyLTA5LTEwICBBZGFt IEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIFY4UGVySXNvbGF0 ZURhdGE6Om1fdG9TdHJpbmdUZW1wbGF0ZSBsZWFrcyBtZW1vcnkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MzIyCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgbmV2ZXIgY2FsbCBEaXNwb3NlIHRvIGJh bGFuY2UgdGhlIGNhbGwgdG8gdjg6OlBlcnNpc3RlbnQ6Ok5ldy4gVGhpcworICAgICAgICBwYXRj aCB1c2VzIFNjb3BlZFBlcnNpc3RlbnQgdG8gY2FsbCBEaXNwb3NlIGF1dG9tYXRpY2FsbHkuCisK KyAgICAgICAgKiBiaW5kaW5ncy92OC9WOFBlcklzb2xhdGVEYXRhLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlY4UGVySXNvbGF0ZURhdGE6OnRvU3RyaW5nVGVtcGxhdGUpOgorICAgICAgICAgICAg LSBJJ3ZlIGNoYW5nZWQgdGhpcyBmdW5jdGlvbiB0byByZXR1cm4gYSBuZXcgbG9jYWwgaGFuZGxl IGluIGNhc2UKKyAgICAgICAgICAgICAgYW55b25lIGlzIHRyeWluZyB0byBob2xkIG9uIHRvIHRo ZXNlIGhhbmRsZXMgZHVyaW5nIHNodXRkb3duLgorICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4UGVy SXNvbGF0ZURhdGEuaDoKKyAgICAgICAgKFY4UGVySXNvbGF0ZURhdGEpOgorCisyMDEyLTA5LTEw ICBBZGFtIEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KKwogICAgICAgICBbVjhdIGN1cnJl bnREb2N1bWVudCBkb2Vzbid0IG5lZWQgdG8gaGFuZGxlIHRoZSBjYXNlIHdoZXJlIHRoZXJlIGlz IG5vIHY4OjpDb250ZXh0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD05NjMxMgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9W OFBlcklzb2xhdGVEYXRhLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVySXNv bGF0ZURhdGEuY3BwCmluZGV4IDMzMDI4YTdiYTY3MDIyNTFmZmNlY2ZlNTY3YWJkMTFiZWEyOWQ2 ZmUuLjJjMzliOTUzNjIyYmFhZWIzNzk5OTlmYWIyOGVkZThlZDgyNDhlYWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVySXNvbGF0ZURhdGEuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVySXNvbGF0ZURhdGEuY3BwCkBAIC03NCw2ICs3 NCwxMyBAQCB2b2lkIFY4UGVySXNvbGF0ZURhdGE6OmRpc3Bvc2Uodjg6Oklzb2xhdGUqIGlzb2xh dGUpCiAgICAgaXNvbGF0ZS0+U2V0RGF0YSgwKTsKIH0KIAordjg6OkhhbmRsZTx2ODo6RnVuY3Rp b25UZW1wbGF0ZT4gVjhQZXJJc29sYXRlRGF0YTo6dG9TdHJpbmdUZW1wbGF0ZSgpCit7CisgICAg aWYgKG1fdG9TdHJpbmdUZW1wbGF0ZS5pc0VtcHR5KCkpCisgICAgICAgIG1fdG9TdHJpbmdUZW1w bGF0ZS5zZXQodjg6OkZ1bmN0aW9uVGVtcGxhdGU6Ok5ldyhjb25zdHJ1Y3Rvck9mVG9TdHJpbmcp KTsKKyAgICByZXR1cm4gdjg6OkxvY2FsPHY4OjpGdW5jdGlvblRlbXBsYXRlPjo6TmV3KG1fdG9T dHJpbmdUZW1wbGF0ZS5nZXQoKSk7Cit9CisKIHZvaWQgVjhQZXJJc29sYXRlRGF0YTo6cmVwb3J0 TWVtb3J5VXNhZ2UoTWVtb3J5T2JqZWN0SW5mbyogbWVtb3J5T2JqZWN0SW5mbykgY29uc3QKIHsK ICAgICBNZW1vcnlDbGFzc0luZm8gaW5mbyhtZW1vcnlPYmplY3RJbmZvLCB0aGlzLCBXZWJDb3Jl TWVtb3J5VHlwZXM6OkJpbmRpbmcpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3MvdjgvVjhQZXJJc29sYXRlRGF0YS5oIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhQ ZXJJc29sYXRlRGF0YS5oCmluZGV4IDMxYWNmMGVlNjIzOWE3NGI4MDMwOGQ3MGM4MjI3MDYxZTFi NzdjY2QuLjNkODA4ZDNiZWYwZDVhMTYzMGUyN2VmYWJiMGJhMGRlMmJhNzAyMzIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4UGVySXNvbGF0ZURhdGEuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9WOFBlcklzb2xhdGVEYXRhLmgKQEAgLTI2LDYgKzI2 LDcgQEAKICNpZm5kZWYgVjhQZXJJc29sYXRlRGF0YV9oCiAjZGVmaW5lIFY4UGVySXNvbGF0ZURh dGFfaAogCisjaW5jbHVkZSAiU2NvcGVkUGVyc2lzdGVudC5oIgogI2luY2x1ZGUgPHY4Lmg+CiAj aW5jbHVkZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvT3duUHRyLmg+CkBAIC03MCwx MyArNzEsNyBAQCBwdWJsaWM6CiAgICAgVGVtcGxhdGVNYXAmIHJhd1RlbXBsYXRlTWFwKCkgeyBy ZXR1cm4gbV9yYXdUZW1wbGF0ZXM7IH0KICAgICBUZW1wbGF0ZU1hcCYgdGVtcGxhdGVNYXAoKSB7 IHJldHVybiBtX3RlbXBsYXRlczsgfQogCi0gICAgdjg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9u VGVtcGxhdGU+JiB0b1N0cmluZ1RlbXBsYXRlKCkKLSAgICB7Ci0gICAgICAgIGlmIChtX3RvU3Ry aW5nVGVtcGxhdGUuSXNFbXB0eSgpKQotICAgICAgICAgICAgbV90b1N0cmluZ1RlbXBsYXRlID0g djg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9uVGVtcGxhdGU+OjpOZXcodjg6OkZ1bmN0aW9uVGVt cGxhdGU6Ok5ldyhjb25zdHJ1Y3Rvck9mVG9TdHJpbmcpKTsKLSAgICAgICAgcmV0dXJuIG1fdG9T dHJpbmdUZW1wbGF0ZTsKLSAgICB9Ci0KKyAgICB2ODo6SGFuZGxlPHY4OjpGdW5jdGlvblRlbXBs YXRlPiB0b1N0cmluZ1RlbXBsYXRlKCk7CiAgICAgdjg6OlBlcnNpc3RlbnQ8djg6OkZ1bmN0aW9u VGVtcGxhdGU+JiBsYXp5RXZlbnRMaXN0ZW5lclRvU3RyaW5nVGVtcGxhdGUoKQogICAgIHsKICAg ICAgICAgcmV0dXJuIG1fbGF6eUV2ZW50TGlzdGVuZXJUb1N0cmluZ1RlbXBsYXRlOwpAQCAtMTQy LDcgKzEzNyw3IEBAIHByaXZhdGU6CiAKICAgICBUZW1wbGF0ZU1hcCBtX3Jhd1RlbXBsYXRlczsK ICAgICBUZW1wbGF0ZU1hcCBtX3RlbXBsYXRlczsKLSAgICB2ODo6UGVyc2lzdGVudDx2ODo6RnVu Y3Rpb25UZW1wbGF0ZT4gbV90b1N0cmluZ1RlbXBsYXRlOworICAgIFNjb3BlZFBlcnNpc3RlbnQ8 djg6OkZ1bmN0aW9uVGVtcGxhdGU+IG1fdG9TdHJpbmdUZW1wbGF0ZTsKICAgICB2ODo6UGVyc2lz dGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gbV9sYXp5RXZlbnRMaXN0ZW5lclRvU3RyaW5nVGVt cGxhdGU7CiAgICAgT3duUHRyPFN0cmluZ0NhY2hlPiBtX3N0cmluZ0NhY2hlOwogICAgIE93blB0 cjxJbnRlZ2VyQ2FjaGU+IG1faW50ZWdlckNhY2hlOwo=