9632 2006-06-28 06:12:35 -0700 [Drosera] syntax highlighting is slow (reproducible 40 second hang) 2008-05-17 09:55:52 -0700 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 CLOSED FIXED P2 Normal --- 1 gsherloc webkit-unassigned oldest_to_newest 47445 0 gsherloc 2006-06-28 06:12:35 -0700 Launch Webkit (SVN 15070) Launch Drosera, and attach to Webkit In Webkit, go to http://nightly.webkit.org/ In Drosera, code from http://www.google-analytics.com/urchin.js will show up Use the drop down menu in Drosera to switch to looking at the source for http://nightly.webkit.org/ Drosera will now hang for ~40 seconds while rendering the source 47660 1 timothy 2006-06-28 09:13:57 -0700 This is our syntax highlighting, soon to be done in the engine at top speed. 51454 2 timothy 2006-08-02 10:41:53 -0700 I can't reproduce on the nightly page, but this is very bad on yahoo.com. I have a fix. 51456 3 9826 timothy 2006-08-02 10:50:02 -0700 Created attachment 9826 Proposed fix Do not change the file source when normalizing the line endings. We use this file source to compare against new versions of the source as it comes in, so we can skip re-syntax highlighting if they are the same. The problem apparent on yahoo.com since they have mixed line endings and once we normalize them the source will always be different. This was compounded by the fact that yahoo has around 40 inline scripts. Each inline script causes us to check if the main document has more loaded, that is when we compare the source strings. Since they are always different we would syntax highlight yahoo.com 40 times! We do check source length before doing a more expensive string comparison, but the lengths were the same. * Drosera/debugger.js: 51458 4 timothy 2006-08-02 10:57:38 -0700 Note: syntax highlight is still slow, but not 40 seconds. It is down to around 2-8 seconds for Yahoo.com depending on the computer speed. Syntax highlighting should be done in the engine, for maximum speed. See bug 10217. 51491 5 9826 darin 2006-08-02 16:02:58 -0700 Comment on attachment 9826 Proposed fix r=me 51497 6 timothy 2006-08-02 16:12:01 -0700 Landed in r15762 80738 7 timothy 2008-05-17 09:55:52 -0700 Closing since Drosera has been replaced by the new Web Inspector debugger. Moving to the New Bugs component so the Drosera component can be closed and removed. 9826 2006-08-02 10:50:02 -0700 2006-08-02 16:02:58 -0700 Proposed fix 9632.patch text/plain 2801 timothy SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1NzUx KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjMgQEAKKzIwMDYtMDgt MDIgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyA5NjMyOiBbRHJvc2VyYV0gc3lu dGF4IGhpZ2hsaWdodGluZyBpcyBzbG93IChyZXByb2R1Y2libGUgNDAgc2Vjb25kIGhhbmcpCisg ICAgICAgIGh0dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYz MgorCisgICAgICAgIERvIG5vdCBjaGFuZ2UgdGhlIGZpbGUgc291cmNlIHdoZW4gbm9ybWFsaXpp bmcgdGhlIGxpbmUgZW5kaW5ncy4KKyAgICAgICAgV2UgdXNlIHRoaXMgZmlsZSBzb3VyY2UgdG8g Y29tcGFyZSBhZ2FpbnN0IG5ldyB2ZXJzaW9ucyBvZiB0aGUgc291cmNlCisgICAgICAgIGFzIGl0 IGNvbWVzIGluLCBzbyB3ZSBjYW4gc2tpcCByZS1zeW50YXggaGlnaGxpZ2h0aW5nIGlmIHRoZXkg YXJlIHRoZSBzYW1lLgorICAgICAgICBUaGUgcHJvYmxlbSBhcHBhcmVudCBvbiB5YWhvby5jb20g c2luY2UgdGhleSBoYXZlIG1peGVkIGxpbmUgZW5kaW5ncyBhbmQKKyAgICAgICAgb25jZSB3ZSBu b3JtYWxpemUgdGhlbSB0aGUgc291cmNlIHdpbGwgYWx3YXlzIGJlIGRpZmZlcmVudC4gVGhpcyB3 YXMKKyAgICAgICAgY29tcG91bmRlZCBieSB0aGUgZmFjdCB0aGF0IHlhaG9vIGhhcyBhcm91bmQg NDAgaW5saW5lIHNjcmlwdHMuIEVhY2gKKyAgICAgICAgaW5saW5lIHNjcmlwdCBjYXVzZXMgdXMg dG8gY2hlY2sgaWYgdGhlIG1haW4gZG9jdW1lbnQgaGFzIG1vcmUgbG9hZGVkLAorICAgICAgICB0 aGF0IGlzIHdoZW4gd2UgY29tcGFyZSB0aGUgc291cmNlIHN0cmluZ3MuIFNpbmNlIHRoZXkgYXJl IGFsd2F5cyBkaWZmZXJlbnQKKyAgICAgICAgd2Ugd291bGQgc3ludGF4IGhpZ2hsaWdodCB5YWhv by5jb20gNDAgdGltZXMhIFdlIGRvIGNoZWNrIHNvdXJjZSBsZW5ndGggYmVmb3JlCisgICAgICAg IGRvaW5nIGEgbW9yZSBleHBlbnNpdmUgc3RyaW5nIGNvbXBhcmlzb24sIGJ1dCB0aGUgbGVuZ3Ro cyB3ZXJlIHRoZSBzYW1lLgorCisgICAgICAgICogRHJvc2VyYS9kZWJ1Z2dlci5qczoKKwogMjAw Ni0wOC0wMSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgLSBmaXgg YSBidWcgaW4gbXkgcmVjZW50IGNoYW5nZSB3aGVyZSB0aGUgbW91c2UgcG9zaXRpb24gYXQgdGhl IGVuZCBvZgpJbmRleDogRHJvc2VyYS9kZWJ1Z2dlci5qcwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBEcm9zZXJh L2RlYnVnZ2VyLmpzCShyZXZpc2lvbiAxNTczNykKKysrIERyb3NlcmEvZGVidWdnZXIuanMJKHdv cmtpbmcgY29weSkKQEAgLTY3NCw4ICs2NzQsNiBAQCBmdW5jdGlvbiBsb2FkRmlsZShmaWxlSW5k ZXgsIG1hbmFnZU5hdkxpCiAgICAgICAgIGZpbGVzW2N1cnJlbnRGaWxlXS5lbGVtZW50LnN0eWxl LmRpc3BsYXkgPSAibm9uZSI7CiAKICAgICBpZiAoIWZpbGUubG9hZGVkKSB7Ci0gICAgICAgIGZp bGUuc291cmNlID0gZmlsZS5zb3VyY2UucmVwbGFjZSgvXHJcbnxcci8sICJcbiIpOyAvLyBub3Jt YWxpemUgbGluZSBlbmRpbmdzCi0KICAgICAgICAgdmFyIHNvdXJjZXNEb2N1bWVudCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJzb3VyY2VzIikuY29udGVudERvY3VtZW50OwogICAgICAgICB2 YXIgc291cmNlc0RpdiA9IHNvdXJjZXNEb2N1bWVudC5ib2R5OwogICAgICAgICB2YXIgc291cmNl RGl2ID0gc291cmNlc0RvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIpOwpAQCAtNjg2LDcgKzY4 NCw4IEBAIGZ1bmN0aW9uIGxvYWRGaWxlKGZpbGVJbmRleCwgbWFuYWdlTmF2TGkKICAgICAgICAg dmFyIHRhYmxlID0gc291cmNlc0RvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRhYmxlIik7CiAgICAg ICAgIHNvdXJjZURpdi5hcHBlbmRDaGlsZCh0YWJsZSk7CiAKLSAgICAgICAgdmFyIGxpbmVzID0g c3ludGF4SGlnaGxpZ2h0KGZpbGUuc291cmNlKS5zcGxpdCgiXG4iKTsKKyAgICAgICAgdmFyIG5v cm1hbGl6ZWRTb3VyY2UgPSBmaWxlLnNvdXJjZS5yZXBsYWNlKC9cclxufFxyLywgIlxuIik7IC8v IG5vcm1hbGl6ZSBsaW5lIGVuZGluZ3MKKyAgICAgICAgdmFyIGxpbmVzID0gc3ludGF4SGlnaGxp Z2h0KG5vcm1hbGl6ZWRTb3VyY2UpLnNwbGl0KCJcbiIpOwogICAgICAgICBmb3IoIHZhciBpID0g MDsgaSA8IGxpbmVzLmxlbmd0aDsgaSsrICkgewogICAgICAgICAgICAgdmFyIHRyID0gc291cmNl c0RvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInRyIik7CiAgICAgICAgICAgICB2YXIgdGQgPSBzb3Vy Y2VzRG9jdW1lbnQuY3JlYXRlRWxlbWVudCgidGQiKTsKQEAgLTc1Niw2ICs3NTUsNyBAQCBmdW5j dGlvbiBkaWRQYXJzZVNjcmlwdChzb3VyY2UsIGZpbGVTb3VyCiAgICAgdmFyIGZpbGVJbmRleCA9 IGZpbGVzTG9va3VwW3VybF07CiAgICAgdmFyIGZpbGUgPSBmaWxlc1tmaWxlSW5kZXhdOwogICAg IHZhciBmaXJzdExvYWQgPSBmYWxzZTsKKwogICAgIGlmICghZmlsZUluZGV4IHx8ICFmaWxlKSB7 CiAgICAgICAgIGZpbGVJbmRleCA9IGZpbGVzLmxlbmd0aCArIDE7CiAgICAgICAgIGlmICh1cmwu bGVuZ3RoKQo=