96312 2012-09-10 13:41:33 -0700 [V8] currentDocument doesn't need to handle the case where there is no v8::Context 2012-09-10 16:21:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric haraken japhet webkit.review.bot oldest_to_newest 716456 0 abarth 2012-09-10 13:41:33 -0700 [V8] currentDocument doesn't need to handle the case where there is no v8::Context 716457 1 163197 abarth 2012-09-10 13:42:17 -0700 Created attachment 163197 Patch 716464 2 163197 eric 2012-09-10 13:46:55 -0700 Comment on attachment 163197 Patch k 716466 3 haraken 2012-09-10 13:48:25 -0700 In a series of your patches, it might be better to insert ASSERT() where the condition is not so obvious for ordinary people:) 716478 4 abarth 2012-09-10 13:53:41 -0700 > In a series of your patches, it might be better to insert ASSERT() where the condition is not so obvious for ordinary people:) Sure. If you see places where you think that would be useful, please mention them and I will add the ASSERTs. 716653 5 163197 abarth 2012-09-10 16:21:19 -0700 Comment on attachment 163197 Patch Clearing flags on attachment: 163197 Committed r128124: <http://trac.webkit.org/changeset/128124> 716654 6 abarth 2012-09-10 16:21:21 -0700 All reviewed patches have been landed. Closing bug. 163197 2012-09-10 13:42:17 -0700 2012-09-10 16:21:19 -0700 Patch bug-96312-20120910134153.patch text/plain 1583 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2Q4MDQxZmJlMTlmZGY3 YWU5MjE3YTVlZDgzMzA4ZjBjYjI3OTA0MS4uZDhjNzZmNjM3NTU4ZWU4MDNmOWYwZTE0ZTZlMWM0 YmQ2YTQ3NDY4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDEyLTA5LTEwICBBZGFt IEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIGN1cnJlbnREb2N1 bWVudCBkb2Vzbid0IG5lZWQgdG8gaGFuZGxlIHRoZSBjYXNlIHdoZXJlIHRoZXJlIGlzIG5vIHY4 OjpDb250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD05NjMxMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFRoaXMgZnVuY3Rpb24gaXMgYWx3YXlzIGNhbGxlZCB3aGlsZSBWOCBpcyBvbiB0aGUgc3RhY2su IEl0IGRvZXNuJ3QKKyAgICAgICAgbmVlZCB0byBoYW5kbGUgdGhpcyBpbXBvc3NpYmxlIGVycm9y IGNvbmRpdGlvbi4KKworICAgICAgICAqIGJpbmRpbmdzL3Y4L0JpbmRpbmdTdGF0ZS5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpjdXJyZW50RG9jdW1lbnQpOgorCisyMDEyLTA5LTEwICBBZGFtIEJh cnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KKwogICAgICAgICBbVjhdIElubGluZSBmaXJzdEZy YW1lIGFuZCBjdXJyZW50RnJhbWUgaW50byB0aGVpciB1bmlxdWUgY2FsbGVycwogICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYzMDkKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvQmluZGluZ1N0YXRlLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL3Y4L0JpbmRpbmdTdGF0ZS5jcHAKaW5kZXggZjZhZjZhNThmNjVlMDU1 MDU4MTBjYTY4NmNjNjZjNzQ5MGQwMmFmYy4uOWEzZDcwODFiYzNlMGJjZDI1NWM3N2FkZjcxMGRh ZjU3M2NkYWRjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvQmluZGlu Z1N0YXRlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9CaW5kaW5nU3RhdGUu Y3BwCkBAIC02OCwxMCArNjgsNyBAQCBET01XaW5kb3cqIGZpcnN0RE9NV2luZG93KEJpbmRpbmdT dGF0ZSopCiAKIERvY3VtZW50KiBjdXJyZW50RG9jdW1lbnQoQmluZGluZ1N0YXRlKikKIHsKLSAg ICBET01XaW5kb3cqIGN1cnJlbnQgPSB0b0RPTVdpbmRvdyh2ODo6Q29udGV4dDo6R2V0Q3VycmVu dCgpKTsKLSAgICBpZiAoIWN1cnJlbnQpCi0gICAgICAgIHJldHVybiAwOwotICAgIHJldHVybiBj dXJyZW50LT5kb2N1bWVudCgpOworICAgIHJldHVybiB0b0RPTVdpbmRvdyh2ODo6Q29udGV4dDo6 R2V0Q3VycmVudCgpKS0+ZG9jdW1lbnQoKTsKIH0KIAogdm9pZCBwcmludEVycm9yTWVzc2FnZUZv ckZyYW1lKEZyYW1lKiBmcmFtZSwgY29uc3QgU3RyaW5nJiBtZXNzYWdlKQo=