96310 2012-09-10 13:33:20 -0700 offlineasm has some impossible to implement, and unused, instructions 2012-09-10 13:50:57 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo oldest_to_newest 716445 0 fpizlo 2012-09-10 13:33:20 -0700 Example: btio. It tests an integer. To see if it overflowed. It's an ill-formed question. 716452 1 163196 fpizlo 2012-09-10 13:38:32 -0700 Created attachment 163196 the patch 716455 2 163196 mhahnenberg 2012-09-10 13:41:27 -0700 Comment on attachment 163196 the patch r=me 716471 3 fpizlo 2012-09-10 13:50:57 -0700 Landed in http://trac.webkit.org/changeset/128100 163196 2012-09-10 13:38:32 -0700 2012-09-10 13:41:27 -0700 the patch killimpossible_patch_1.diff text/plain 6038 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTI4MDk5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDEyLTA5LTEwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg b2ZmbGluZWFzbSBoYXMgc29tZSBpbXBvc3NpYmxlIHRvIGltcGxlbWVudCwgYW5kIHVudXNlZCwg aW5zdHJ1Y3Rpb25zCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NjMxMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogb2ZmbGluZWFzbS9hcm12Ny5yYjoKKyAgICAgICAgKiBvZmZsaW5lYXNtL2luc3RydWN0 aW9ucy5yYjoKKyAgICAgICAgKiBvZmZsaW5lYXNtL3g4Ni5yYjoKKwogMjAxMi0wOS0wOSAgR2Vv ZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlZmFjdG9yZWQgb3Bf dGVhcl9vZmYqIHRvIHN1cHBvcnQgYWN0aXZhdGlvbnMgdGhhdCBkb24ndCBhbGxvY2F0ZSBzcGFj ZSBmb3IgJ2FyZ3VtZW50cycKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNt L2FybXY3LnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNt L2FybXY3LnJiCShyZXZpc2lvbiAxMjgwMDkpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2Zm bGluZWFzbS9hcm12Ny5yYgkod29ya2luZyBjb3B5KQpAQCAtNTI3LDggKzUyNyw4IEBAIGRlZiBh cm1WN0xvd2VyTWlzcGxhY2VkQWRkcmVzc2VzKGxpc3QpCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbm9kZS5vcGNvZGUsCiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgYXJtVjdBc1JlZ2lzdGVycyhuZXdMaXN0LCBwb3N0SW5zdHJ1 Y3Rpb25zLCBub2RlLm9wZXJhbmRzLCAiaSIpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgIGFubm90YXRpb24pCi0gICAgICAgICAgICB3aGVuICJiYmVxIiwgImJi bmVxIiwgImJiYSIsICJiYmFlcSIsICJiYmIiLCAiYmJiZXEiLCAiYnRibyIsICJidGJ6IiwgImJ0 Ym56IiwgInRieiIsICJ0Ym56IiwKLSAgICAgICAgICAgICAgICAidGJvIiwgImNiZXEiLCAiY2Ju ZXEiLCAiY2JhIiwgImNiYWVxIiwgImNiYiIsICJjYmJlcSIKKyAgICAgICAgICAgIHdoZW4gImJi ZXEiLCAiYmJuZXEiLCAiYmJhIiwgImJiYWVxIiwgImJiYiIsICJiYmJlcSIsICJidGJ6IiwgImJ0 Ym56IiwgInRieiIsICJ0Ym56IiwKKyAgICAgICAgICAgICAgICAiY2JlcSIsICJjYm5lcSIsICJj YmEiLCAiY2JhZXEiLCAiY2JiIiwgImNiYmVxIgogICAgICAgICAgICAgICAgIG5ld0xpc3QgPDwg SW5zdHJ1Y3Rpb24ubmV3KG5vZGUuY29kZU9yaWdpbiwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBub2RlLm9wY29kZSwKICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICBhcm1WN0FzUmVnaXN0ZXJzKG5ld0xpc3QsIHBvc3RJbnN0cnVj dGlvbnMsIG5vZGUub3BlcmFuZHMsICJiIiksCkBAIC01NzksOCArNTc5LDggQEAgZGVmIGFybVY3 TG93ZXJSZWdpc3RlclJldXNlKGxpc3QpCiAgICAgICAgICAgICBjYXNlIG5vZGUub3Bjb2RlCiAg ICAgICAgICAgICB3aGVuICJjaWVxIiwgImNpbmVxIiwgImNpYSIsICJjaWFlcSIsICJjaWIiLCAi Y2liZXEiLCAiY2lndCIsICJjaWd0ZXEiLCAiY2lsdCIsICJjaWx0ZXEiLAogICAgICAgICAgICAg ICAgICJjcGVxIiwgImNwbmVxIiwgImNwYSIsICJjcGFlcSIsICJjcGIiLCAiY3BiZXEiLCAiY3Bn dCIsICJjcGd0ZXEiLCAiY3BsdCIsICJjcGx0ZXEiLAotICAgICAgICAgICAgICAgICJ0aW8iLCAi dGlzIiwgInRpeiIsICJ0aW56IiwgInRibyIsICJ0YnMiLCAidGJ6IiwgInRibnoiLCAidHBvIiwg InRwcyIsICJ0cHoiLCAidHBueiIsCi0gICAgICAgICAgICAgICAgImNiZXEiLCAiY2JuZXEiLCAi Y2JhIiwgImNiYWVxIiwgImNiYiIsICJjYmJlcSIsICJjYmd0IiwgImNiZ3RlcSIsICJjYmx0Iiwg ImNibHRlcSIKKyAgICAgICAgICAgICAgICAidGlzIiwgInRpeiIsICJ0aW56IiwgInRicyIsICJ0 YnoiLCAidGJueiIsICJ0cHMiLCAidHB6IiwgInRwbnoiLCAiY2JlcSIsICJjYm5lcSIsCisgICAg ICAgICAgICAgICAgImNiYSIsICJjYmFlcSIsICJjYmIiLCAiY2JiZXEiLCAiY2JndCIsICJjYmd0 ZXEiLCAiY2JsdCIsICJjYmx0ZXEiCiAgICAgICAgICAgICAgICAgaWYgbm9kZS5vcGVyYW5kcy5z aXplID09IDIKICAgICAgICAgICAgICAgICAgICAgaWYgbm9kZS5vcGVyYW5kc1swXSA9PSBub2Rl Lm9wZXJhbmRzWzFdCiAgICAgICAgICAgICAgICAgICAgICAgICB0bXAgPSBUbXAubmV3KG5vZGUu Y29kZU9yaWdpbiwgOmdwcikKQEAgLTk0MCw5ICs5NDAsNiBAQCBjbGFzcyBJbnN0cnVjdGlvbgog ICAgICAgICB3aGVuICJidGlueiIsICJidHBueiIsICJidGJueiIKICAgICAgICAgICAgIGVtaXRB cm1WN1Rlc3Qob3BlcmFuZHMpCiAgICAgICAgICAgICAkYXNtLnB1dHMgImJuZSAje29wZXJhbmRz Wy0xXS5hc21MYWJlbH0iCi0gICAgICAgIHdoZW4gImJ0aW8iLCAiYnRwbyIsICJidGJvIgotICAg ICAgICAgICAgZW1pdEFybVY3VGVzdChvcGVyYW5kcykKLSAgICAgICAgICAgICRhc20ucHV0cyAi YnZzICN7b3BlcmFuZHNbLTFdLmFzbUxhYmVsfSIKICAgICAgICAgd2hlbiAiYnRpcyIsICJidHBz IiwgImJ0YnMiCiAgICAgICAgICAgICBlbWl0QXJtVjdUZXN0KG9wZXJhbmRzKQogICAgICAgICAg ICAgJGFzbS5wdXRzICJibWkgI3tvcGVyYW5kc1stMV0uYXNtTGFiZWx9IgpAQCAtOTgyLDggKzk3 OSw2IEBAIGNsYXNzIEluc3RydWN0aW9uCiAgICAgICAgICAgICBlbWl0QXJtVjdDb21wYXJlKG9w ZXJhbmRzLCAibHQiKQogICAgICAgICB3aGVuICJjaWx0ZXEiLCAiY3BsdGVxIiwgImNibHRlcSIK ICAgICAgICAgICAgIGVtaXRBcm1WN0NvbXBhcmUob3BlcmFuZHMsICJsZSIpCi0gICAgICAgIHdo ZW4gInRpbyIsICJ0Ym8iLCAidHBvIgotICAgICAgICAgICAgZW1pdEFybVY3VGVzdFNldChvcGVy YW5kcywgInZzIikKICAgICAgICAgd2hlbiAidGlzIiwgInRicyIsICJ0cHMiCiAgICAgICAgICAg ICBlbWl0QXJtVjdUZXN0U2V0KG9wZXJhbmRzLCAibWkiKQogICAgICAgICB3aGVuICJ0aXoiLCAi dGJ6IiwgInRweiIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL2luc3Ry dWN0aW9ucy5yYgo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvb2ZmbGluZWFz bS9pbnN0cnVjdGlvbnMucmIJKHJldmlzaW9uIDEyODAwOSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9vZmZsaW5lYXNtL2luc3RydWN0aW9ucy5yYgkod29ya2luZyBjb3B5KQpAQCAtMTA3LDEx ICsxMDcsOSBAQCBNQUNST19JTlNUUlVDVElPTlMgPQogICAgICAiYmJndGVxIiwKICAgICAgImJi bHQiLAogICAgICAiYmJsdGVxIiwKLSAgICAgImJ0aW8iLAogICAgICAiYnRpcyIsCiAgICAgICJi dGl6IiwKICAgICAgImJ0aW56IiwKLSAgICAgImJ0Ym8iLAogICAgICAiYnRicyIsCiAgICAgICJi dGJ6IiwKICAgICAgImJ0Ym56IiwKQEAgLTE1NSwxNSArMTUzLDEyIEBAIE1BQ1JPX0lOU1RSVUNU SU9OUyA9CiAgICAgICJjaWd0ZXEiLAogICAgICAiY2lsdCIsCiAgICAgICJjaWx0ZXEiLAotICAg ICAidGlvIiwKICAgICAgInRpcyIsCiAgICAgICJ0aXoiLAogICAgICAidGlueiIsCi0gICAgICJ0 Ym8iLAogICAgICAidGJzIiwKICAgICAgInRieiIsCiAgICAgICJ0Ym56IiwKLSAgICAgInRwbyIs CiAgICAgICJ0cHMiLAogICAgICAidHB6IiwKICAgICAgInRwbnoiLApAQCAtMTk3LDcgKzE5Miw2 IEBAIE1BQ1JPX0lOU1RSVUNUSU9OUyA9CiAgICAgICJjcGx0IiwKICAgICAgImNwbHRlcSIsCiAg ICAgICJzdG9yZXAiLAotICAgICAiYnRwbyIsCiAgICAgICJidHBzIiwKICAgICAgImJ0cHoiLAog ICAgICAiYnRwbnoiLApJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20veDg2 LnJiCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9vZmZsaW5lYXNtL3g4Ni5y YgkocmV2aXNpb24gMTI4MDA5KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL29mZmxpbmVhc20v eDg2LnJiCSh3b3JraW5nIGNvcHkpCkBAIC04MzUsMTAgKzgzNSw2IEBAIGNsYXNzIEluc3RydWN0 aW9uCiAgICAgICAgICAgICBoYW5kbGVYODZJbnRCcmFuY2goImpsIiwgOmJ5dGUpCiAgICAgICAg IHdoZW4gImJibHRlcSIKICAgICAgICAgICAgIGhhbmRsZVg4NkludEJyYW5jaCgiamx0ZXEiLCA6 Ynl0ZSkKLSAgICAgICAgd2hlbiAiYnRpbyIKLSAgICAgICAgICAgIGhhbmRsZVg4NkJyYW5jaFRl c3QoImpvIiwgOmludCkKLSAgICAgICAgd2hlbiAiYnRwbyIKLSAgICAgICAgICAgIGhhbmRsZVg4 NkJyYW5jaFRlc3QoImpvIiwgOnB0cikKICAgICAgICAgd2hlbiAiYnRpcyIKICAgICAgICAgICAg IGhhbmRsZVg4NkJyYW5jaFRlc3QoImpzIiwgOmludCkKICAgICAgICAgd2hlbiAiYnRwcyIKQEAg LTg1MSw4ICs4NDcsNiBAQCBjbGFzcyBJbnN0cnVjdGlvbgogICAgICAgICAgICAgaGFuZGxlWDg2 QnJhbmNoVGVzdCgiam56IiwgOmludCkKICAgICAgICAgd2hlbiAiYnRwbnoiCiAgICAgICAgICAg ICBoYW5kbGVYODZCcmFuY2hUZXN0KCJqbnoiLCA6cHRyKQotICAgICAgICB3aGVuICJidGJvIgot ICAgICAgICAgICAgaGFuZGxlWDg2QnJhbmNoVGVzdCgiam8iLCA6Ynl0ZSkKICAgICAgICAgd2hl biAiYnRicyIKICAgICAgICAgICAgIGhhbmRsZVg4NkJyYW5jaFRlc3QoImpzIiwgOmJ5dGUpCiAg ICAgICAgIHdoZW4gImJ0YnoiCkBAIC05NjcsMjQgKzk2MSwxOCBAQCBjbGFzcyBJbnN0cnVjdGlv bgogICAgICAgICAgICAgaGFuZGxlWDg2SW50Q29tcGFyZVNldCgic2V0bGUiLCA6Ynl0ZSkKICAg ICAgICAgd2hlbiAiY3BsdGVxIgogICAgICAgICAgICAgaGFuZGxlWDg2SW50Q29tcGFyZVNldCgi c2V0bGUiLCA6cHRyKQotICAgICAgICB3aGVuICJ0aW8iCi0gICAgICAgICAgICBoYW5kbGVYODZT ZXRUZXN0KCJzZXRvIiwgOmludCkKICAgICAgICAgd2hlbiAidGlzIgogICAgICAgICAgICAgaGFu ZGxlWDg2U2V0VGVzdCgic2V0cyIsIDppbnQpCiAgICAgICAgIHdoZW4gInRpeiIKICAgICAgICAg ICAgIGhhbmRsZVg4NlNldFRlc3QoInNldHoiLCA6aW50KQogICAgICAgICB3aGVuICJ0aW56Igog ICAgICAgICAgICAgaGFuZGxlWDg2U2V0VGVzdCgic2V0bnoiLCA6aW50KQotICAgICAgICB3aGVu ICJ0cG8iCi0gICAgICAgICAgICBoYW5kbGVYODZTZXRUZXN0KCJzZXRvIiwgOnB0cikKICAgICAg ICAgd2hlbiAidHBzIgogICAgICAgICAgICAgaGFuZGxlWDg2U2V0VGVzdCgic2V0cyIsIDpwdHIp CiAgICAgICAgIHdoZW4gInRweiIKICAgICAgICAgICAgIGhhbmRsZVg4NlNldFRlc3QoInNldHoi LCA6cHRyKQogICAgICAgICB3aGVuICJ0cG56IgogICAgICAgICAgICAgaGFuZGxlWDg2U2V0VGVz dCgic2V0bnoiLCA6cHRyKQotICAgICAgICB3aGVuICJ0Ym8iCi0gICAgICAgICAgICBoYW5kbGVY ODZTZXRUZXN0KCJzZXRvIiwgOmJ5dGUpCiAgICAgICAgIHdoZW4gInRicyIKICAgICAgICAgICAg IGhhbmRsZVg4NlNldFRlc3QoInNldHMiLCA6Ynl0ZSkKICAgICAgICAgd2hlbiAidGJ6Igo=