96307 2012-09-10 13:20:18 -0700 Silence a warning when running update-webkit-localizable-strings 2012-09-10 13:30:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 716416 0 andersca 2012-09-10 13:20:18 -0700 Silence a warning when running update-webkit-localizable-strings 716422 1 163191 andersca 2012-09-10 13:21:50 -0700 Created attachment 163191 Patch 716429 2 163191 sullivan 2012-09-10 13:23:52 -0700 Comment on attachment 163191 Patch The other way to do this would be to make the two instances have identical localizer comments, as long as we are certain that there’s no chance that the two strings would be localized differently (taking context into account) in any language. 716431 3 163191 sullivan 2012-09-10 13:25:27 -0700 Comment on attachment 163191 Patch Oops, you also need to update Localizable.strings in this patch (you wouldn’t need to if you made the localizer comments the same). 716439 4 163191 sullivan 2012-09-10 13:28:25 -0700 Comment on attachment 163191 Patch r+ assuming you also check in the updated Localizable.strings 716443 5 andersca 2012-09-10 13:30:53 -0700 Committed r128098: <http://trac.webkit.org/changeset/128098> 163191 2012-09-10 13:21:50 -0700 2012-09-10 13:28:23 -0700 Patch bug-96307-20120910132130.patch text/plain 2131 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGRlNmU3NTc4YjkwOTFk OWQ4YjVjZWNkMDM1NWM1ZmI4NDBhNTRjYS4uN2NkNGI1MTQ2ZDI4MmQ1NzA5MjJlMTE2YzU0MjFl NmQ2NzdkYzEyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTEwICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgU2lsZW5jZSBhIHdh cm5pbmcgd2hlbiBydW5uaW5nIHVwZGF0ZS13ZWJraXQtbG9jYWxpemFibGUtc3RyaW5ncworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYzMDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTaW5jZSBib3RoIHRo ZSBibG9ja2VkUGx1Z2luQnlDb250ZW50U2VjdXJpdHlQb2xpY3lUZXh0IGFuZCBpbnNlY3VyZVBs dWdpblZlcnNpb25UZXh0IHN0cmluZ3MgdXNlIGV4YWN0IHRoZSBzYW1lIHdvcmRpbmcsCisgICAg ICAgIHVzZSBXRUJfVUlfU1RSSU5HX0tFWSB0byBpbmRpY2F0ZSB0aGF0IHRoZXkgYXJlIGRpZmZl cmVudC4KKworICAgICAgICAqIHBsYXRmb3JtL0xvY2FsaXplZFN0cmluZ3MuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6YmxvY2tlZFBsdWdpbkJ5Q29udGVudFNlY3VyaXR5UG9saWN5VGV4dCk6Cisg ICAgICAgIChXZWJDb3JlOjppbnNlY3VyZVBsdWdpblZlcnNpb25UZXh0KToKKwogMjAxMi0wOS0x MCAgTWlrZSBXZXN0ICA8bWt3c3RAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIENsYXJpZnkgdGhl IGNhdXNlIG9mIGNvbnNvbGUgd2FybmluZ3MgZ2VuZXJhdGVkIGJ5ICJjcm9zcy1vcmlnaW4iIGFj Y2VzcyB0byBzYW5kYm94ZWQgaWZyYW1lcy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL0xvY2FsaXplZFN0cmluZ3MuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9j YWxpemVkU3RyaW5ncy5jcHAKaW5kZXggMDE3MzRlMWZmYTliNjViNGMwYmQ1MzExZGIzYzkwMTAy MDUzMjVjYS4uNWE3ZGRmOGJhYmNkY2UwNmE2N2NmNTZmMzgxZDA5MzA3OGUzZWY3ZCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9jYWxpemVkU3RyaW5ncy5jcHAKQEAgLTY3NiwxMiAr Njc2LDEyIEBAIFN0cmluZyBjcmFzaGVkUGx1Z2luVGV4dCgpCiAKIFN0cmluZyBibG9ja2VkUGx1 Z2luQnlDb250ZW50U2VjdXJpdHlQb2xpY3lUZXh0KCkKIHsKLSAgICByZXR1cm4gV0VCX1VJX1NU UklORygiQmxvY2tlZCBQbHVnLWluIiwgIkxhYmVsIHRleHQgdG8gYmUgdXNlZCBpZiBwbHVnaW4g aXMgYmxvY2tlZCBieSBhIHBhZ2UncyBDb250ZW50IFNlY3VyaXR5IFBvbGljeSIpOworICAgIHJl dHVybiBXRUJfVUlfU1RSSU5HX0tFWSgiQmxvY2tlZCBQbHVnLWluIiwgIkJsb2NrZWQgUGx1Zy1J biAoQmxvY2tlZCBieSBwYWdlJ3MgQ29udGVudCBTZWN1cml0eSBQb2xpY3kpIiwgIkxhYmVsIHRl eHQgdG8gYmUgdXNlZCBpZiBwbHVnaW4gaXMgYmxvY2tlZCBieSBhIHBhZ2UncyBDb250ZW50IFNl Y3VyaXR5IFBvbGljeSIpOwogfQogCiBTdHJpbmcgaW5zZWN1cmVQbHVnaW5WZXJzaW9uVGV4dCgp CiB7Ci0gICAgcmV0dXJuIFdFQl9VSV9TVFJJTkcoIkJsb2NrZWQgUGx1Zy1pbiIsICJMYWJlbCB0 ZXh0IHRvIGJlIHVzZWQgd2hlbiBhbiBpbnNlY3VyZSBwbHVnLWluIHZlcnNpb24gd2FzIGJsb2Nr ZWQgZnJvbSBsb2FkaW5nIik7CisgICAgcmV0dXJuIFdFQl9VSV9TVFJJTkdfS0VZKCJCbG9ja2Vk IFBsdWctaW4iLCAiQmxvY2tlZCBQbHVnLUluIChJbnNlY3VyZSBwbHVnLWluKSIsICJMYWJlbCB0 ZXh0IHRvIGJlIHVzZWQgd2hlbiBhbiBpbnNlY3VyZSBwbHVnLWluIHZlcnNpb24gd2FzIGJsb2Nr ZWQgZnJvbSBsb2FkaW5nIik7CiB9CiAKIFN0cmluZyBtdWx0aXBsZUZpbGVVcGxvYWRUZXh0KHVu c2lnbmVkIG51bWJlck9mRmlsZXMpCg==