96304 2012-09-10 12:59:05 -0700 [V8] Constructors try to handle errors that cannot occur 2012-09-10 13:20:27 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abarth abarth eric.carlson eric feature-media-reviews haraken japhet webkit.review.bot oldest_to_newest 716391 0 abarth 2012-09-10 12:59:05 -0700 [V8] Constructors try to handle errors that cannot occur 716393 1 163183 abarth 2012-09-10 13:01:00 -0700 Created attachment 163183 Patch 716395 2 163183 haraken 2012-09-10 13:02:41 -0700 Comment on attachment 163183 Patch Looks OK 716417 3 163183 abarth 2012-09-10 13:20:24 -0700 Comment on attachment 163183 Patch Clearing flags on attachment: 163183 Committed r128094: <http://trac.webkit.org/changeset/128094> 716418 4 abarth 2012-09-10 13:20:27 -0700 All reviewed patches have been landed. Closing bug. 163183 2012-09-10 13:01:00 -0700 2012-09-10 13:20:24 -0700 Patch bug-96304-20120910130036.patch text/plain 5986 abarth U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjQ4MzUxNzg2OTkzMDI4 MzYwMTY4OTdkMDMzMWI4MzhlYjVmYjllNC4uYWFjY2Y2MzZkZTJiZWY5NTQ0MGVlZDA4MzRlZjk0 ZTA2YTNhYmQ4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI2IEBACiAyMDEyLTA5LTEwICBBZGFt IEJhcnRoICA8YWJhcnRoQGNocm9taXVtLm9yZz4KIAorICAgICAgICBbVjhdIENvbnN0cnVjdG9y cyB0cnkgdG8gaGFuZGxlIGVycm9ycyB0aGF0IGNhbm5vdCBvY2N1cgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYzMDQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSdzIG5vIHJlYXNvbiBmb3IgY29u c3RydWN0b3JzIHRvIGluZGlyZWN0IHRocm91Z2ggdGhlIEZyYW1lLiBOb3cKKyAgICAgICAgdGhh dCB3ZSBjYW4gcmVsaWFibHkgZ2V0IHRoZSBEb2N1bWVudCBmcm9tIHRoZSB2ODo6Q29udGV4dCwg d2UgY2FuIGp1c3QKKyAgICAgICAgZ3JhYiBpdCB3aXRob3V0IHdvcnJ5aW5nIGFib3V0IGhhbmRs aW5nIGVycm9yIGNvbmRpdGlvbnMgcmVsYXRlZCB0byBub3QKKyAgICAgICAgYmVpbmcgYWJsZSB0 byBmaW5kIHRoZSBEb2N1bWVudC4KKworICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdl bmVyYXRvclY4LnBtOgorICAgICAgICAoR2VuZXJhdGVOYW1lZENvbnN0cnVjdG9yQ2FsbGJhY2sp OgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3ROYW1lZENvbnN0cnVj dG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4VGVzdE5hbWVkQ29uc3RydWN0b3JDb25zdHJ1 Y3RvckNhbGxiYWNrKToKKyAgICAgICAgKiBiaW5kaW5ncy92OC9jdXN0b20vVjhBdWRpb0NvbnRl eHRDdXN0b20uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VjhBdWRpb0NvbnRleHQ6OmNvbnN0cnVj dG9yQ2FsbGJhY2spOgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEhUTUxJbWFnZUVs ZW1lbnRDb25zdHJ1Y3Rvci5jcHA6CisgICAgICAgIChXZWJDb3JlOjp2OEhUTUxJbWFnZUVsZW1l bnRDb25zdHJ1Y3RvckNhbGxiYWNrKToKKworMjAxMi0wOS0xMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0 aEBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW1Y4XSBWOEhUTUxEb2N1bWVudDo6d3JpdGUgYW5k IGZyaWVuZHMgc2hvdWxkIG5vdCBpbmRpcmVjdCB0aHJvdWdoIEZyYW1lCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjI4OQogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCmluZGV4IDk0ZjFh MWJjZWMzMzYyYWZmNjA4ZWJhNzc2NTJjN2Y4OTJiNjg0MmQuLjlmM2MwMWI1YmMxN2U5MGUxNmZj NzYxOTM5ODk2ODgxNzVlOGYzOGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0yMDI3LDExICsyMDI3LDcgQEAgc3RhdGlj IHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOCR7aW1wbENsYXNzTmFtZX1Db25zdHJ1Y3RvckNhbGxi YWNrKGNvbnN0IHY4OjpBcmcKICAgICBpZiAoQ29uc3RydWN0b3JNb2RlOjpjdXJyZW50KCkgPT0g Q29uc3RydWN0b3JNb2RlOjpXcmFwRXhpc3RpbmdPYmplY3QpCiAgICAgICAgIHJldHVybiBhcmdz LkhvbGRlcigpOwogCi0gICAgRnJhbWUqIGZyYW1lID0gY3VycmVudEZyYW1lKEJpbmRpbmdTdGF0 ZTo6aW5zdGFuY2UoKSk7Ci0gICAgaWYgKCFmcmFtZSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJy b3IoUmVmZXJlbmNlRXJyb3IsICIke2ltcGxDbGFzc05hbWV9IGNvbnN0cnVjdG9yIGFzc29jaWF0 ZWQgZnJhbWUgaXMgdW5hdmFpbGFibGUiLCBhcmdzLkdldElzb2xhdGUoKSk7Ci0KLSAgICBEb2N1 bWVudCogZG9jdW1lbnQgPSBmcmFtZS0+ZG9jdW1lbnQoKTsKKyAgICBEb2N1bWVudCogZG9jdW1l bnQgPSBjdXJyZW50RG9jdW1lbnQoQmluZGluZ1N0YXRlOjppbnN0YW5jZSgpKTsKIAogICAgIC8v IE1ha2Ugc3VyZSB0aGUgZG9jdW1lbnQgaXMgYWRkZWQgdG8gdGhlIERPTSBOb2RlIG1hcC4gT3Ro ZXJ3aXNlLCB0aGUgJHtpbXBsQ2xhc3NOYW1lfSBpbnN0YW5jZQogICAgIC8vIG1heSBlbmQgdXAg YmVpbmcgdGhlIG9ubHkgbm9kZSBpbiB0aGUgbWFwIGFuZCBnZXQgZ2FyYmFnZS1jb2xsZWN0ZWQg cHJlbWF0dXJlbHkuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L3Rlc3QvVjgvVjhUZXN0TmFtZWRDb25zdHJ1Y3Rvci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL3Rlc3QvVjgvVjhUZXN0TmFtZWRDb25zdHJ1Y3Rvci5jcHAKaW5kZXggNmUy NjJkNDNjNGY1OGNmNDMzMTUyZmQzYjMwNDE2MWQ0OTYwM2VhOC4uNjZkMjkwOTdiZDU4YzYyM2Fm ZmUzOTc5MWE5MmUyMDJlYjk2ZjlkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy90ZXN0L1Y4L1Y4VGVzdE5hbWVkQ29uc3RydWN0b3IuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvdGVzdC9WOC9WOFRlc3ROYW1lZENvbnN0cnVjdG9y LmNwcApAQCAtNTMsMTEgKzUzLDcgQEAgc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBWOFRl c3ROYW1lZENvbnN0cnVjdG9yQ29uc3RydWN0b3JDYWxsYmFjayhjb25zdCB2ODoKICAgICBpZiAo Q29uc3RydWN0b3JNb2RlOjpjdXJyZW50KCkgPT0gQ29uc3RydWN0b3JNb2RlOjpXcmFwRXhpc3Rp bmdPYmplY3QpCiAgICAgICAgIHJldHVybiBhcmdzLkhvbGRlcigpOwogCi0gICAgRnJhbWUqIGZy YW1lID0gY3VycmVudEZyYW1lKEJpbmRpbmdTdGF0ZTo6aW5zdGFuY2UoKSk7Ci0gICAgaWYgKCFm cmFtZSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoUmVmZXJlbmNlRXJyb3IsICJUZXN0TmFt ZWRDb25zdHJ1Y3RvciBjb25zdHJ1Y3RvciBhc3NvY2lhdGVkIGZyYW1lIGlzIHVuYXZhaWxhYmxl IiwgYXJncy5HZXRJc29sYXRlKCkpOwotCi0gICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gZnJhbWUt PmRvY3VtZW50KCk7CisgICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gY3VycmVudERvY3VtZW50KEJp bmRpbmdTdGF0ZTo6aW5zdGFuY2UoKSk7CiAKICAgICAvLyBNYWtlIHN1cmUgdGhlIGRvY3VtZW50 IGlzIGFkZGVkIHRvIHRoZSBET00gTm9kZSBtYXAuIE90aGVyd2lzZSwgdGhlIFRlc3ROYW1lZENv bnN0cnVjdG9yIGluc3RhbmNlCiAgICAgLy8gbWF5IGVuZCB1cCBiZWluZyB0aGUgb25seSBub2Rl IGluIHRoZSBtYXAgYW5kIGdldCBnYXJiYWdlLWNvbGxlY3RlZCBwcmVtYXR1cmVseS4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEF1ZGlvQ29udGV4dEN1 c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhBdWRpb0NvbnRl eHRDdXN0b20uY3BwCmluZGV4IDU2YjEyZGNkZmFmMzU1YmJkOTQzODk4ZWNkNTJlZTM0MjA1Nzc0 NGUuLjAxYThjYTdiZGUxNDNmYzgxMjBmZjhlMTExYjRkOGYwMjUwODg3ZjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEF1ZGlvQ29udGV4dEN1c3RvbS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4QXVkaW9Db250ZXh0 Q3VzdG9tLmNwcApAQCAtNDksMTMgKzQ5LDcgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFY4QXVk aW9Db250ZXh0Ojpjb25zdHJ1Y3RvckNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGEKICAg ICBpZiAoQ29uc3RydWN0b3JNb2RlOjpjdXJyZW50KCkgPT0gQ29uc3RydWN0b3JNb2RlOjpXcmFw RXhpc3RpbmdPYmplY3QpCiAgICAgICAgIHJldHVybiBhcmdzLkhvbGRlcigpOwogCi0gICAgRnJh bWUqIGZyYW1lID0gY3VycmVudEZyYW1lKEJpbmRpbmdTdGF0ZTo6aW5zdGFuY2UoKSk7Ci0gICAg aWYgKCFmcmFtZSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoUmVmZXJlbmNlRXJyb3IsICJB dWRpb0NvbnRleHQgY29uc3RydWN0b3IgYXNzb2NpYXRlZCBmcmFtZSBpcyB1bmF2YWlsYWJsZSIs IGFyZ3MuR2V0SXNvbGF0ZSgpKTsKLQotICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGZyYW1lLT5k b2N1bWVudCgpOwotICAgIGlmICghZG9jdW1lbnQpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9y KFJlZmVyZW5jZUVycm9yLCAiQXVkaW9Db250ZXh0IGNvbnN0cnVjdG9yIGFzc29jaWF0ZWQgZG9j dW1lbnQgaXMgdW5hdmFpbGFibGUiLCBhcmdzLkdldElzb2xhdGUoKSk7CisgICAgRG9jdW1lbnQq IGRvY3VtZW50ID0gY3VycmVudERvY3VtZW50KEJpbmRpbmdTdGF0ZTo6aW5zdGFuY2UoKSk7CiAK ICAgICBSZWZQdHI8QXVkaW9Db250ZXh0PiBhdWRpb0NvbnRleHQ7CiAgICAgCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MSW1hZ2VFbGVtZW50Q29u c3RydWN0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4SFRNTElt YWdlRWxlbWVudENvbnN0cnVjdG9yLmNwcAppbmRleCA5ZThkZmU4MzAzOTczM2E3OWE4MzlkM2Vl OWIwOGVkMmNlMTM5MzQ3Li42MGE4NGEwY2I5Yzk4MWIzNzczMGI0NzExYjZkOGJhZDdjM2NlOGUx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy92OC9jdXN0b20vVjhIVE1MSW1h Z2VFbGVtZW50Q29uc3RydWN0b3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL3Y4 L2N1c3RvbS9WOEhUTUxJbWFnZUVsZW1lbnRDb25zdHJ1Y3Rvci5jcHAKQEAgLTU1LDE0ICs1NSw3 IEBAIHN0YXRpYyB2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gdjhIVE1MSW1hZ2VFbGVtZW50Q29uc3Ry dWN0b3JDYWxsYmFjayhjb25zdCB2ODo6QXJnCiAgICAgaWYgKENvbnN0cnVjdG9yTW9kZTo6Y3Vy cmVudCgpID09IENvbnN0cnVjdG9yTW9kZTo6V3JhcEV4aXN0aW5nT2JqZWN0KQogICAgICAgICBy ZXR1cm4gYXJncy5Ib2xkZXIoKTsKIAotICAgIC8vIEZJWE1FOiBXZSBzaG91bGRuJ3QgbmVlZCB0 byBnbyB0aHJvdWdoIHRoZSBGcmFtZSB0byBnZXQgdGhlIERvY3VtZW50LgotICAgIEZyYW1lKiBm cmFtZSA9IGN1cnJlbnRGcmFtZShCaW5kaW5nU3RhdGU6Omluc3RhbmNlKCkpOwotICAgIGlmICgh ZnJhbWUpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKFJlZmVyZW5jZUVycm9yLCAiSW1hZ2Ug Y29uc3RydWN0b3IgYXNzb2NpYXRlZCBmcmFtZSBpcyB1bmF2YWlsYWJsZSIsIGFyZ3MuR2V0SXNv bGF0ZSgpKTsKLQotICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGZyYW1lLT5kb2N1bWVudCgpOwot ICAgIGlmICghZG9jdW1lbnQpCi0gICAgICAgIHJldHVybiB0aHJvd0Vycm9yKFJlZmVyZW5jZUVy cm9yLCAiSW1hZ2UgY29uc3RydWN0b3IgYXNzb2NpYXRlZCBkb2N1bWVudCBpcyB1bmF2YWlsYWJs ZSIsIGFyZ3MuR2V0SXNvbGF0ZSgpKTsKKyAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBjdXJyZW50 RG9jdW1lbnQoQmluZGluZ1N0YXRlOjppbnN0YW5jZSgpKTsKIAogICAgIC8vIE1ha2Ugc3VyZSB0 aGUgZG9jdW1lbnQgaXMgYWRkZWQgdG8gdGhlIERPTSBOb2RlIG1hcC4gT3RoZXJ3aXNlLCB0aGUg SFRNTEltYWdlRWxlbWVudCBpbnN0YW5jZQogICAgIC8vIG1heSBlbmQgdXAgYmVpbmcgdGhlIG9u bHkgbm9kZSBpbiB0aGUgbWFwIGFuZCBnZXQgZ2FyYmFnZS1jb2xsZWN0ZWQgcHJlbWF0dXJlbHku Cg==