96284 2012-09-10 10:07:42 -0700 [GTK] WebKitGtk+ crashes with non-UTF8 HTTP header names 2012-09-12 08:23:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://sec-virtual.usc.es/Secretaria/Login.asp P2 Normal --- 96395 96504 1 svillar svillar danw gustavo mrobinson rakuco svillar tmpsantos webkit.review.bot zan oldest_to_newest 716207 0 svillar 2012-09-10 10:07:42 -0700 This is the backtrace generously provided by mrobinson: #0 0x00007ffff489ca34 in WTF::StringImpl::is8Bit (this=0x0) at ../../Source/WTF/wtf/text/StringImpl.h:375 #1 0x00007ffff489d0d5 in WTF::CaseFoldingHash::hash (str=0x0) at ../../Source/WTF/wtf/text/StringHash.h:105 #2 0x00007ffff489d20c in WTF::CaseFoldingHash::hash (key=...) at ../../Source/WTF/wtf/text/StringHash.h:148 #3 0x00007ffff52a979c in WTF::HashMapTranslator<WTF::HashMapValueTraits<WTF::HashTraits<WTF::AtomicString>, WTF::HashTraits<WTF::String> >, WTF::CaseFoldingHash>::hash<WTF::AtomicString> ( key=...) at ../../Source/WTF/wtf/HashMap.h:220 #4 0x00007ffff52a9188 in WTF::HashTable<WTF::AtomicString, WTF::KeyValuePair<WTF::AtomicString, WTF::String>, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<WTF::AtomicString, WTF::String> >, WTF::CaseFoldingHash, WTF::HashMapValueTraits<WTF::HashTraits<WTF::AtomicString>, WTF::HashTraits<WTF::String> >, WTF::HashTraits<WTF::AtomicString> >::add<WTF::HashMapTranslator<WTF::HashMapValueTraits<WTF::HashTraits<WTF::AtomicString>, WTF::HashTraits<WTF::String> >, WTF::CaseFoldingHash>, WTF::AtomicString, WTF::String> (this=0x7fffffffcc38, key=..., extra=...) at ../../Source/WTF/wtf/HashTable.h:825 #5 0x00007ffff52a8c92 in WTF::HashMap<WTF::AtomicString, WTF::String, WTF::CaseFoldingHash, WTF::HashTraits<WTF::AtomicString>, WTF::HashTraits<WTF::String> >::inlineAdd (this=0x7fffffffcc38, key=..., mapped=...) at ../../Source/WTF/wtf/HashMap.h:334 #6 0x00007ffff52a8a20 in WTF::HashMap<WTF::AtomicString, WTF::String, WTF::CaseFoldingHash, WTF::HashTraits<WTF::AtomicString>, WTF::HashTraits<WTF::String> >::set (this=0x7fffffffcc38, key=..., mapped=...) at ../../Source/WTF/wtf/HashMap.h:341 #7 0x00007ffff52c269f in WebCore::ResourceResponse::updateFromSoupMessage (this=0x7fffffffcbd0, soupMessage=0xb101e0) at ../../Source/WebCore/platform/network/soup/ResourceResponseSoup.cpp:73 #8 0x00007ffff52bb969 in WebCore::gotHeadersCallback (msg=0xb101e0, data=0x68c130) at ../../Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp:291 #9 0x00007ffff3e764c2 in g_closure_invoke (closure=0x87a2c0, return_value=0x0, n_param_values=1, param_values=0x7fffffffcee0, invocation_hint=<optimized out>) at gclosure.c:777 #10 0x00007ffff3e87ff3 in signal_emit_unlocked_R (node=<optimized out>, detail=0, instance=<optimized out>, emission_return=0x0, instance_and_params=0x7fffffffcee0) at gsignal.c:3547 #11 0x00007ffff3e908e0 in g_signal_emit_valist (instance=<optimized out>, signal_id=<optimized out>, detail=0, var_args=<optimized out>) at gsignal.c:3296 #12 0x00007ffff3e90b22 in g_signal_emit (instance=<optimized out>, signal_id=<optimized out>, detail=<optimized out>) at gsignal.c:3352 #13 0x00007ffff7fc2c39 in io_read (msg=0xb101e0, cancellable=0x6dd6f0, error=0x7fffffffd2b8) at soup-message-io.c:607 #14 0x00007ffff7fc2ef2 in io_run_until (msg=0xb101e0, read_state=SOUP_MESSAGE_IO_STATE_BODY, write_state=SOUP_MESSAGE_IO_STATE_NOT_STARTED, cancellable=0x6dd6f0, error=0x7fffffffd318) at soup-message-io.c:846 #15 0x00007ffff7fcf7d6 in try_run_until_read (item=0x7cc980) at soup-session-async.c:689 #16 0x00007ffff7fcf97c in read_ready_cb (msg=<optimized out>, user_data=<optimized out>) at soup-session-async.c:678 716219 1 svillar 2012-09-10 10:17:52 -0700 As Martin perfectly points out the problem is that the server sends a non-UTF8 header name and thus we end up with a NULL String causing the crash. Will attach a patch with a test case soon 717046 2 163330 svillar 2012-09-11 04:22:29 -0700 Created attachment 163330 Patch 717098 3 svillar 2012-09-11 06:11:01 -0700 Committed r128175: <http://trac.webkit.org/changeset/128175> 717205 4 tmpsantos 2012-09-11 08:35:03 -0700 133 failures on the EFL bots after this change, the number is also high on GTK bots. 717208 5 webkit.review.bot 2012-09-11 08:36:56 -0700 Re-opened since this is blocked by 96395 717230 6 163379 svillar 2012-09-11 08:59:00 -0700 Created attachment 163379 Patch 717231 7 svillar 2012-09-11 09:00:49 -0700 Beh, so basically I used headerValue instead of headerName in the strlen(). Do not use copy&paste at home kids. 717280 8 163379 svillar 2012-09-11 09:41:53 -0700 Comment on attachment 163379 Patch Clearing flags on attachment: 163379 Committed r128195: <http://trac.webkit.org/changeset/128195> 717281 9 svillar 2012-09-11 09:42:00 -0700 All reviewed patches have been landed. Closing bug. 717508 10 zan 2012-09-11 13:36:06 -0700 This was rolled out again in r128221: http://trac.webkit.org/changeset/128221 The patch was causing crashes in debug builds, here's a backtrace: Crash log for DumpRenderTree (pid 23767): [New LWP 23767] [Thread debugging using libthread_db enabled] Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1". Core was generated by `/home/slave/webkitgtk/gtk-linux-64-debug/build/WebKitBuild/Debug/Programs/DumpR'. Program terminated with signal 11, Segmentation fault. #0 0x00007fb17ed45e9b in WebCore::parseHeader (header="Expires", headerLength=10, response=...) at ../../Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1058 1058 ASSERT(pos != notFound); Thread 1 (Thread 0x7fb173cab900 (LWP 23767)): #0 0x00007fb17ed45e9b in WebCore::parseHeader (header="Expires", headerLength=10, response=...) at ../../Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1058 #1 0x00007fb17ed45fbd in WebCore::parseHeaders (headers="Keep-Alive\000\302\224Õ\177\000\000\000\000:timeout=15, max=92\nCache-Control\000\000\000 \000\000\000\000\000\000\000A:no-cache, must-revalidate\nCo:85\nServer\000\000¸\302\216B\302\224Õ\177\000\000\000\000\000\000\000\000\000\000Q\000\000\000\000\000\000\000Apache/2.2.22 (Debian) mod_ssl/2:Apache/2.2.22 (Debian) mod_ssl/2.2.22 O"..., response=...) at ../../Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1073 #2 0x00007fb17ed46432 in WebCore::ApplicationCacheStorage::loadCache (this=0x6e75b0, storageID=302517) at ../../Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:1127 #3 0x00007fb17ed423f0 in WebCore::ApplicationCacheStorage::cacheGroupForURL (this=0x6e75b0, url=...) at ../../Source/WebCore/loader/appcache/ApplicationCacheStorage.cpp:238 #4 0x00007fb17ed2fd0c in WebCore::ApplicationCacheGroup::cacheForMainRequest (request=...) at ../../Source/WebCore/loader/appcache/ApplicationCacheGroup.cpp:108 #5 0x00007fb17ed3c0f0 in WebCore::ApplicationCacheHost::maybeLoadMainResource (this=0x7cb030, request=..., substituteData=...) at ../../Source/WebCore/loader/appcache/ApplicationCacheHost.cpp:81 #6 0x00007fb17edd7938 in WebCore::MainResourceLoader::load (this=0x6d7650, r=..., substituteData=...) at ../../Source/WebCore/loader/MainResourceLoader.cpp:659 #7 0x00007fb17ed8bf0a in WebCore::DocumentLoader::startLoadingMainResource (this=0x74b5b0) at ../../Source/WebCore/loader/DocumentLoader.cpp:871 #8 0x00007fb17eda6494 in WebCore::FrameLoader::continueLoadAfterWillSubmitForm (this=0x77c928) at ../../Source/WebCore/loader/FrameLoader.cpp:2227 #9 0x00007fb17eda9031 in WebCore::FrameLoader::continueLoadAfterNavigationPolicy (this=0x77c928, formState=..., shouldContinue=true) at ../../Source/WebCore/loader/FrameLoader.cpp:2835 #10 0x00007fb17eda8743 in WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy (argument=0x77c928, request=..., formState=..., shouldContinue=true) at ../../Source/WebCore/loader/FrameLoader.cpp:2705 #11 0x00007fb17edda41b in WebCore::PolicyCallback::call (this=0x7fff16380050, shouldContinue=true) at ../../Source/WebCore/loader/PolicyCallback.cpp:103 #12 0x00007fb17eddb2c9 in WebCore::PolicyChecker::continueAfterNavigationPolicy (this=0x77c938, policy=WebCore::PolicyUse) at ../../Source/WebCore/loader/PolicyChecker.cpp:167 #13 0x00007fb17e56573e in webkit_web_policy_decision_use (decision=0x73b300) at ../../Source/WebKit/gtk/webkit/webkitwebpolicydecision.cpp:88 #14 0x00007fb17e5370be in WebKit::FrameLoaderClient::dispatchDecidePolicyForNavigationAction (this=0x77b4b0, policyFunction=(void (WebCore::PolicyChecker::*)(WebCore::PolicyChecker * const, WebCore::PolicyAction)) 0x7fb17eddb07e <WebCore::PolicyChecker::continueAfterNavigationPolicy(WebCore::PolicyAction)>, action=..., resourceRequest=...) at ../../Source/WebKit/gtk/WebCoreSupport/FrameLoaderClientGtk.cpp:467 #15 0x00007fb17eddacd0 in WebCore::PolicyChecker::checkNavigationPolicy (this=0x77c938, request=..., loader=0x74b5b0, formState=..., function=0x7fb17eda86f4 <WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy(void*, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>, argument=0x77c928) at ../../Source/WebCore/loader/PolicyChecker.cpp:89 #16 0x00007fb17eda2c6c in WebCore::FrameLoader::loadWithDocumentLoader (this=0x77c928, loader=0x74b5b0, type=WebCore::FrameLoadTypeStandard, prpFormState=...) at ../../Source/WebCore/loader/FrameLoader.cpp:1413 #17 0x00007fb17eda26a4 in WebCore::FrameLoader::load (this=0x77c928, newDocumentLoader=0x74b5b0) at ../../Source/WebCore/loader/FrameLoader.cpp:1354 #18 0x00007fb17eda2099 in WebCore::FrameLoader::load (this=0x77c928, request=..., substituteData=..., lockHistory=false) at ../../Source/WebCore/loader/FrameLoader.cpp:1288 #19 0x00007fb17eda1ec3 in WebCore::FrameLoader::load (this=0x77c928, request=..., lockHistory=false) at ../../Source/WebCore/loader/FrameLoader.cpp:1277 #20 0x00007fb17e55fa70 in webkit_web_frame_load_uri (frame=0x77bd20, uri=0x74d9b8 "http://127.0.0.1:8000/appcache/document-write-html-element-2.html") at ../../Source/WebKit/gtk/webkit/webkitwebframe.cpp:696 #21 0x00007fb17e5789d1 in webkit_web_view_load_uri (webView=0x730030, uri=0x74d9b8 "http://127.0.0.1:8000/appcache/document-write-html-element-2.html") at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:4102 #22 0x00007fb17e578787 in webkit_web_view_open (webView=0x730030, uri=0x74d9b8 "http://127.0.0.1:8000/appcache/document-write-html-element-2.html") at ../../Source/WebKit/gtk/webkit/webkitwebview.cpp:4062 #23 0x000000000047749b in runTest (inputLine=...) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:751 #24 0x0000000000476b74 in runTestingServerLoop () at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:540 #25 0x0000000000479b2e in main (argc=2, argv=0x7fff16381688) at ../../Tools/DumpRenderTree/gtk/DumpRenderTree.cpp:1445 718058 11 zan 2012-09-12 01:46:10 -0700 (In reply to comment #10) > This was rolled out again in r128221: > http://trac.webkit.org/changeset/128221 This roll-out was unnecessary, the fix was already re-landed in r128195 http://trac.webkit.org/changeset/128221 I apologize, I'll clean up the mess. There have been some crashes (as reported in comment #10) on the debug build even after this rollout -that's a bit strange. I'll reland the patch from r128195 and see how the debug builder will react. 718291 12 zan 2012-09-12 06:18:57 -0700 The crashes just won't go away, hopefully rolling back in the proper patch will help to that. http://trac.webkit.org/changeset/128302 718379 13 zan 2012-09-12 08:23:59 -0700 The application cache was corrupted so it had to be cleared. The tests should be OK now. Closing the bug as fixed. 163330 2012-09-11 04:22:29 -0700 2012-09-11 08:58:55 -0700 Patch bug-96284-20120911132204.patch text/plain 3840 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDY1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGEyMTI1M2YyZGQ1NjAx YmFmZGE5ZWQzZGY5NDQ5Y2M4Y2Y2Y2RkOC4uNzlkZjNlNDZkNmEwNjBjNDZhYzE3ZjdiYmJhMWFh MmUxNGVjZWM1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTExICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFdl YktpdEd0aysgY3Jhc2hlcyB3aXRoIG5vbi1VVEY4IEhUVFAgaGVhZGVyIG5hbWVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjI4NAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vbiBVVEYtOCBjaGFyYWN0 ZXJzIHNlbnQgYXMgcGFydCBvZiBhIEhUVFAgaGVhZGVyIG5hbWUgd2VyZQorICAgICAgICBjYXVz aW5nIGNyYXNoZXMgYXMgU3RyaW5nOjpmcm9tVVRGOCgpIHdhcyByZXR1cm5pbmcgTlVMTCBmb3IK KyAgICAgICAgdGhlbS4gVXNlIFN0cmluZzo6ZnJvbVVURjhXaXRoTGF0aW4xRmFsbGJhY2soKSBp bnN0ZWFkLgorCisgICAgICAgIFRlc3Q6IGh0dHAvdGVzdHMvbWlzYy9ub24tdXRmOC1oZWFkZXIt bmFtZS5waHAKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3Bv bnNlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjp1cGRhdGVG cm9tU291cE1lc3NhZ2UpOgorCiAyMDEyLTA5LTEwICBUb21teSBXaWRlbmZseWNodCAgPHRvbW15 d0Bnb29nbGUuY29tPgogCiAgICAgICAgIFtjaHJvbWl1bV0gTWVkaWFTdHJlYW0gQVBJOiBSZW1v dmUgdGhlIERlc2NyaXB0b3IgcG9zdGZpeApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZVJlc3BvbnNlU291cC5jcHAKaW5kZXgg NDUyMTA4YjZhMjg5YThiMDk5MWQ3NzM0ZGI4ZDRmMjU4MmVlYTMwMC4uMTk1YWVkNTg3NDMzYzY1 NzlmNzg5YzdmMTI4NzBiNDVmNDYwYzJkOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXNwb25zZVNvdXAuY3BwCkBA IC02OSw3ICs2OSw3IEBAIHZvaWQgUmVzb3VyY2VSZXNwb25zZTo6dXBkYXRlRnJvbVNvdXBNZXNz YWdlKFNvdXBNZXNzYWdlKiBzb3VwTWVzc2FnZSkKIAogICAgIHNvdXBfbWVzc2FnZV9oZWFkZXJz X2l0ZXJfaW5pdCgmaGVhZGVyc0l0ZXIsIHNvdXBNZXNzYWdlLT5yZXNwb25zZV9oZWFkZXJzKTsK ICAgICB3aGlsZSAoc291cF9tZXNzYWdlX2hlYWRlcnNfaXRlcl9uZXh0KCZoZWFkZXJzSXRlciwg JmhlYWRlck5hbWUsICZoZWFkZXJWYWx1ZSkpCi0gICAgICAgIG1faHR0cEhlYWRlckZpZWxkcy5z ZXQoU3RyaW5nOjpmcm9tVVRGOChoZWFkZXJOYW1lKSwKKyAgICAgICAgbV9odHRwSGVhZGVyRmll bGRzLnNldChTdHJpbmc6OmZyb21VVEY4V2l0aExhdGluMUZhbGxiYWNrKGhlYWRlck5hbWUsIHN0 cmxlbihoZWFkZXJWYWx1ZSkpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmlu Zzo6ZnJvbVVURjhXaXRoTGF0aW4xRmFsbGJhY2soaGVhZGVyVmFsdWUsIHN0cmxlbihoZWFkZXJW YWx1ZSkpKTsKIAogICAgIG1fc291cEZsYWdzID0gc291cF9tZXNzYWdlX2dldF9mbGFncyhzb3Vw TWVzc2FnZSk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKaW5kZXggN2EzYmI5MjgxNWZjYTFlY2E1MjNhNDA5YjgzODM1ODVlMjRlNTgz Yi4uYzQ3ZjEwNjQwYTljZWY3NWRhYmNiZDg0MGJhYzBkOWJiMzBlYzJmNCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDE2IEBACisyMDEyLTA5LTExICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIFdlYktpdEd0aysgY3Jhc2hlcyB3aXRoIG5vbi1VVEY4 IEhUVFAgaGVhZGVyIG5hbWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD05NjI4NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEFkZGVkIGEgbmV3IHRlc3QgdG8gbWFrZSBzdXJlIHRoYXQgV2ViS2l0R3RrKyBk b2VzIG5vdCBjcmFzaCB3aGVuCisgICAgICAgIGEgbm9uLVVURjggY2hhcmFjdGVyIGlzIHNlbnQg YXMgcGFydCBvZiBhIEhUVFAgaGVhZGVyIG5hbWUuCisKKyAgICAgICAgKiBodHRwL3Rlc3RzL21p c2Mvbm9uLXV0ZjgtaGVhZGVyLW5hbWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBo dHRwL3Rlc3RzL21pc2Mvbm9uLXV0ZjgtaGVhZGVyLW5hbWUucGhwOiBBZGRlZC4KKwogMjAxMi0w OS0xMCAgUGF2ZWwgUG9kaXZpbG92ICA8cG9kaXZpbG92QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBzdXBwb3J0IGVtcHR5IGVudHJpZXMgaW4gc291cmNlIG1hcHMuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvbm9uLXV0ZjgtaGVhZGVyLW5h bWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL25vbi11dGY4LWhl YWRlci1uYW1lLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wZTU3YWI5ZGIzNDE2ODc2MjFkYzll Y2RhMWFiN2E5YjlhN2Q4MTVjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9taXNjL25vbi11dGY4LWhlYWRlci1uYW1lLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBA CitUZXN0IGZvciBidWcgOTYyODQ6IE5vbiBVVEYtOCBIVFRQIGhlYWRlcnMgZG8gbm90IGNhdXNl IGEgY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvbm9uLXV0 ZjgtaGVhZGVyLW5hbWUucGhwIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL25vbi11dGY4 LWhlYWRlci1uYW1lLnBocApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5mNjYyZWJmZGY4YWE4NTc2ZGE3NDg0N2MzYWE1 ZmJlNTdlNWI4ZDYxCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9t aXNjL25vbi11dGY4LWhlYWRlci1uYW1lLnBocApAQCAtMCwwICsxLDkgQEAKKzw/cGhwCitoZWFk ZXIoJ0hUVFAvMS4xIDIwMCBPSycpOworaGVhZGVyKCfDOiB0ZXh0L2h0bWwnKTsKK2VjaG8gJzxz Y3JpcHQ+JzsKK2VjaG8gJyAgIGlmICh3aW5kb3cudGVzdFJ1bm5lciknOworZWNobyAnICAgICAg IHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOyc7CitlY2hvICc8L3NjcmlwdD4nOworZWNobyAnPHA+ VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTk2Mjg0Ij5idWcgOTYyODQ8L2E+OiBOb24gVVRGLTggSFRUUCBoZWFkZXJzIGRvIG5vdCBjYXVz ZSBhIGNyYXNoLjwvcD4nOworPz4K 163379 2012-09-11 08:59:00 -0700 2012-09-11 09:41:53 -0700 Patch bug-96284-20120911175835.patch text/plain 3813 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MTkyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGE4MDM1ZmVmZDk2MWVi NzRmOWE5ZDVlZjVlYTFlM2E3YzJkYzcyNy4uZjdmMTQ2MzI1NWYxMjhhZjg0ODU4NmRjZGVmZjhh YTUxNGRlMTk2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDEyLTA5LTExICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFdl YktpdEd0aysgY3Jhc2hlcyB3aXRoIG5vbi1VVEY4IEhUVFAgaGVhZGVyIG5hbWVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjI4NAorCisgICAgICAg IFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KKworICAgICAgICBOb24gVVRGLTgg Y2hhcmFjdGVycyBzZW50IGFzIHBhcnQgb2YgYSBIVFRQIGhlYWRlciBuYW1lIHdlcmUKKyAgICAg ICAgY2F1c2luZyBjcmFzaGVzIGFzIFN0cmluZzo6ZnJvbVVURjgoKSB3YXMgcmV0dXJuaW5nIE5V TEwgZm9yCisgICAgICAgIHRoZW0uIFVzZSBTdHJpbmc6OmZyb21VVEY4V2l0aExhdGluMUZhbGxi YWNrKCkgaW5zdGVhZC4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL21pc2Mvbm9uLXV0Zjgt aGVhZGVyLW5hbWUucGhwCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3Vy Y2VSZXNwb25zZVNvdXAuY3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZTo6 dXBkYXRlRnJvbVNvdXBNZXNzYWdlKToKKwogMjAxMi0wOS0xMSAgU2hlcmlmZiBCb3QgIDx3ZWJr aXQucmV2aWV3LmJvdEBnbWFpbC5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBv dXQgcjEyODE3NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZVJlc3BvbnNlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VSZXNwb25zZVNvdXAuY3BwCmluZGV4IDQ1MjEwOGI2YTI4OWE4 YjA5OTFkNzczNGRiOGQ0ZjI1ODJlZWEzMDAuLmI3YzA0OGZhMWVjMDBmZTcwOGQ3ZGNhZTk5ZmM1 ZGI3ZWM3OTA4M2QgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv c291cC9SZXNvdXJjZVJlc3BvbnNlU291cC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL1Jlc291cmNlUmVzcG9uc2VTb3VwLmNwcApAQCAtNjksNyArNjksNyBA QCB2b2lkIFJlc291cmNlUmVzcG9uc2U6OnVwZGF0ZUZyb21Tb3VwTWVzc2FnZShTb3VwTWVzc2Fn ZSogc291cE1lc3NhZ2UpCiAKICAgICBzb3VwX21lc3NhZ2VfaGVhZGVyc19pdGVyX2luaXQoJmhl YWRlcnNJdGVyLCBzb3VwTWVzc2FnZS0+cmVzcG9uc2VfaGVhZGVycyk7CiAgICAgd2hpbGUgKHNv dXBfbWVzc2FnZV9oZWFkZXJzX2l0ZXJfbmV4dCgmaGVhZGVyc0l0ZXIsICZoZWFkZXJOYW1lLCAm aGVhZGVyVmFsdWUpKQotICAgICAgICBtX2h0dHBIZWFkZXJGaWVsZHMuc2V0KFN0cmluZzo6ZnJv bVVURjgoaGVhZGVyTmFtZSksCisgICAgICAgIG1faHR0cEhlYWRlckZpZWxkcy5zZXQoU3RyaW5n Ojpmcm9tVVRGOFdpdGhMYXRpbjFGYWxsYmFjayhoZWFkZXJOYW1lLCBzdHJsZW4oaGVhZGVyTmFt ZSkpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFN0cmluZzo6ZnJvbVVURjhXaXRo TGF0aW4xRmFsbGJhY2soaGVhZGVyVmFsdWUsIHN0cmxlbihoZWFkZXJWYWx1ZSkpKTsKIAogICAg IG1fc291cEZsYWdzID0gc291cF9tZXNzYWdlX2dldF9mbGFncyhzb3VwTWVzc2FnZSk7CmRpZmYg LS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5k ZXggZGFkYjM3Y2JhNmI1MjkyNDMwZjA0YWJkZjVjZDcwY2QzNGExYzM0NC4uMWZjODQyOWYzYmM5 OTlmMGM2MmI4M2YxNjc2ZmVkMzQwNmViYmJlMCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEy LTA5LTExICBTZXJnaW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAg ICAgIFtHVEtdIFdlYktpdEd0aysgY3Jhc2hlcyB3aXRoIG5vbi1VVEY4IEhUVFAgaGVhZGVyIG5h bWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjI4 NAorCisgICAgICAgIFJldmlld2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KKworICAgICAg ICBBZGRlZCBhIG5ldyB0ZXN0IHRvIG1ha2Ugc3VyZSB0aGF0IFdlYktpdEd0aysgZG9lcyBub3Qg Y3Jhc2ggd2hlbgorICAgICAgICBhIG5vbi1VVEY4IGNoYXJhY3RlciBpcyBzZW50IGFzIHBhcnQg b2YgYSBIVFRQIGhlYWRlciBuYW1lLgorCisgICAgICAgICogaHR0cC90ZXN0cy9taXNjL25vbi11 dGY4LWhlYWRlci1uYW1lLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0cC90ZXN0 cy9taXNjL25vbi11dGY4LWhlYWRlci1uYW1lLnBocDogQWRkZWQuCisKIDIwMTItMDktMTEgIFNo ZXJpZmYgQm90ICA8d2Via2l0LnJldmlldy5ib3RAZ21haWwuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJvbGxpbmcgb3V0IHIxMjgxNzUuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL21pc2Mvbm9uLXV0ZjgtaGVhZGVyLW5hbWUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvaHR0cC90ZXN0cy9taXNjL25vbi11dGY4LWhlYWRlci1uYW1lLWV4cGVjdGVkLnR4dApuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwLi4wZTU3YWI5ZGIzNDE2ODc2MjFkYzllY2RhMWFiN2E5YjlhN2Q4MTVjCi0tLSAvZGV2 L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL25vbi11dGY4LWhlYWRlci1u YW1lLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxIEBACitUZXN0IGZvciBidWcgOTYyODQ6IE5vbiBV VEYtOCBIVFRQIGhlYWRlcnMgZG8gbm90IGNhdXNlIGEgY3Jhc2guCmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9odHRwL3Rlc3RzL21pc2Mvbm9uLXV0ZjgtaGVhZGVyLW5hbWUucGhwIGIvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9taXNjL25vbi11dGY4LWhlYWRlci1uYW1lLnBocApuZXcgZmlsZSBt b2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw Li5mNjYyZWJmZGY4YWE4NTc2ZGE3NDg0N2MzYWE1ZmJlNTdlNWI4ZDYxCi0tLSAvZGV2L251bGwK KysrIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9taXNjL25vbi11dGY4LWhlYWRlci1uYW1lLnBo cApAQCAtMCwwICsxLDkgQEAKKzw/cGhwCitoZWFkZXIoJ0hUVFAvMS4xIDIwMCBPSycpOworaGVh ZGVyKCfDOiB0ZXh0L2h0bWwnKTsKK2VjaG8gJzxzY3JpcHQ+JzsKK2VjaG8gJyAgIGlmICh3aW5k b3cudGVzdFJ1bm5lciknOworZWNobyAnICAgICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOyc7 CitlY2hvICc8L3NjcmlwdD4nOworZWNobyAnPHA+VGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2Mjg0Ij5idWcgOTYyODQ8L2E+OiBOb24g VVRGLTggSFRUUCBoZWFkZXJzIGRvIG5vdCBjYXVzZSBhIGNyYXNoLjwvcD4nOworPz4K