96280 2012-09-10 09:26:10 -0700 Web Inspector: Network request headers text fallback has typo. 2012-09-19 07:26:13 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 vsevik vsevik apavlov bweinstein dglazkov joepeck keishi loislo pfeldman pmuellr rik timothy webkit.review.bot yurys oldest_to_newest 716152 0 vsevik 2012-09-10 09:26:10 -0700 Patch to follow. 716154 1 163149 vsevik 2012-09-10 09:27:35 -0700 Created attachment 163149 Patch 716156 2 163150 vsevik 2012-09-10 09:28:32 -0700 Created attachment 163150 Patch 716663 3 163150 webkit.review.bot 2012-09-10 16:26:39 -0700 Comment on attachment 163150 Patch Rejecting attachment 163150 from commit-queue. New failing tests: inspector/network-status-non-http.html http/tests/inspector/network/network-initiator-from-console.html http/tests/inspector/extensions-network-redirect.html inspector/extensions/extensions-network.html http/tests/inspector/extensions-useragent.html http/tests/inspector/resource-har-conversion.html Full output: http://queues.webkit.org/results/13818141 716808 4 163150 webkit.review.bot 2012-09-10 21:08:42 -0700 Comment on attachment 163150 Patch Attachment 163150 did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/13822127 New failing tests: inspector/network-status-non-http.html http/tests/inspector/network/network-initiator-from-console.html http/tests/inspector/extensions-network-redirect.html inspector/extensions/extensions-network.html http/tests/inspector/extensions-useragent.html http/tests/inspector/resource-har-conversion.html 723552 5 vsevik 2012-09-19 07:26:13 -0700 Committed r129003: <http://trac.webkit.org/changeset/129003> 163149 2012-09-10 09:27:35 -0700 2012-09-10 09:28:26 -0700 Patch bug-96280-20120910202710.patch text/plain 2195 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUyNzhkNDAzMGY1NzZm NThmMWI1M2E2Y2QzNzU5NGIwNDJmZjcyNC4uMGNiOTMwY2QxMjFhM2ZkZjM4ZjdjODhiYjIzNDAz YzA4ZDQzMGRhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA5LTEwICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IE5ldHdvcmsgcmVxdWVzdCBoZWFkZXJzIHRleHQgZmFsbGJhY2sgaGFzIHR5cG8uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjI4MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9OZXR3b3JrUmVxdWVzdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3Jr UmVxdWVzdC5wcm90b3R5cGUuZ2V0IHJlcXVlc3RIZWFkZXJzVGV4dCk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuTmV0d29ya1JlcXVlc3QucHJvdG90eXBlLmdldCByZXNwb25zZUhlYWRlcnNUZXh0 KToKKwogMjAxMi0wOS0xMCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50 ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIENyZWF0ZSBhIHRvZ2dsZSBidXR0b24gZm9yIGNsb3Nl ZCBjYXB0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9OZXR3b3JrUmVxdWVzdC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv TmV0d29ya1JlcXVlc3QuanMKaW5kZXggN2Y4OTk1YTg3NjZkZDNmOTA4ZThjYTI1Yjk1YjkyMWQ4 ZmExYTA2MC4uZjE1MGE3ZTI2MDg0NTVlYzg1MTczNTIzOWNiNDc5MDk3ZGYxZTY1MiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUmVxdWVzdC5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtSZXF1ZXN0 LmpzCkBAIC00MjIsNyArNDIyLDcgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtSZXF1ZXN0LnByb3Rv dHlwZSA9IHsKICAgICB7CiAgICAgICAgIGlmICh0aGlzLl9yZXF1ZXN0SGVhZGVyc1RleHQgPT09 IHVuZGVmaW5lZCkgewogICAgICAgICAgICAgdGhpcy5fcmVxdWVzdEhlYWRlcnNUZXh0ID0gdGhp cy5yZXF1ZXN0TWV0aG9kICsgIiAiICsgdGhpcy51cmwgKyAiIEhUVFAvMS4xXHJcbiI7Ci0gICAg ICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMucmVxdWVzdEhlYWRlcnM7ICsraSkKKyAg ICAgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5yZXF1ZXN0SGVhZGVycy5sZW5ndGg7 ICsraSkKICAgICAgICAgICAgICAgICB0aGlzLl9yZXF1ZXN0SGVhZGVyc1RleHQgKz0gdGhpcy5y ZXF1ZXN0SGVhZGVyc1tpXS5uYW1lICsgIjogIiArIHRoaXMucmVxdWVzdEhlYWRlcnNbaV0udmFs dWUgKyAiXHJcbiI7CiAgICAgICAgIH0KICAgICAgICAgcmV0dXJuIHRoaXMuX3JlcXVlc3RIZWFk ZXJzVGV4dDsKQEAgLTUyNCw3ICs1MjQsNyBAQCBXZWJJbnNwZWN0b3IuTmV0d29ya1JlcXVlc3Qu cHJvdG90eXBlID0gewogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX3Jlc3BvbnNlSGVhZGVyc1Rl eHQgPT09IHVuZGVmaW5lZCkgewogICAgICAgICAgICAgdGhpcy5fcmVzcG9uc2VIZWFkZXJzVGV4 dCA9ICJIVFRQLzEuMSAiICsgdGhpcy5zdGF0dXNDb2RlICsgIiAiICsgdGhpcy5zdGF0dXNUZXh0 ICsgIlxyXG4iOwotICAgICAgICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLnJlcXVlc3RI ZWFkZXJzOyArK2kpCisgICAgICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRoaXMucmVxdWVz dEhlYWRlcnMubGVuZ3RoOyArK2kpCiAgICAgICAgICAgICAgICAgdGhpcy5fcmVzcG9uc2VIZWFk ZXJzVGV4dCArPSB0aGlzLnJlc3BvbnNlSGVhZGVyc1tpXS5uYW1lICsgIjogIiArIHRoaXMucmVz cG9uc2VIZWFkZXJzW2ldLnZhbHVlICsgIlxyXG4iOwogICAgICAgICB9CiAgICAgICAgIHJldHVy biB0aGlzLl9yZXNwb25zZUhlYWRlcnNUZXh0Owo= 163150 2012-09-10 09:28:32 -0700 2012-09-10 21:08:42 -0700 Patch bug-96280-20120910202807.patch text/plain 2403 vsevik U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjUyNzhkNDAzMGY1NzZm NThmMWI1M2E2Y2QzNzU5NGIwNDJmZjcyNC4uMGNiOTMwY2QxMjFhM2ZkZjM4ZjdjODhiYjIzNDAz YzA4ZDQzMGRhZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDEyLTA5LTEwICBWc2V2 b2xvZCBWbGFzb3YgIDx2c2V2aWtAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IE5ldHdvcmsgcmVxdWVzdCBoZWFkZXJzIHRleHQgZmFsbGJhY2sgaGFzIHR5cG8uCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjI4MAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL2Zy b250LWVuZC9OZXR3b3JrUmVxdWVzdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OZXR3b3Jr UmVxdWVzdC5wcm90b3R5cGUuZ2V0IHJlcXVlc3RIZWFkZXJzVGV4dCk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuTmV0d29ya1JlcXVlc3QucHJvdG90eXBlLmdldCByZXNwb25zZUhlYWRlcnNUZXh0 KToKKwogMjAxMi0wOS0xMCAgQ2hyaXN0b3BoZSBEdW1leiAgPGNocmlzdG9waGUuZHVtZXpAaW50 ZWwuY29tPgogCiAgICAgICAgIFtFRkxdIENyZWF0ZSBhIHRvZ2dsZSBidXR0b24gZm9yIGNsb3Nl ZCBjYXB0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVu ZC9OZXR3b3JrUmVxdWVzdC5qcyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQv TmV0d29ya1JlcXVlc3QuanMKaW5kZXggN2Y4OTk1YTg3NjZkZDNmOTA4ZThjYTI1Yjk1YjkyMWQ4 ZmExYTA2MC4uNTAzMGQ0OGJhZTVhNjI0YzZlOTAwODRkOTM0YjI4NmZiNmIxYjVkNiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9OZXR3b3JrUmVxdWVzdC5q cworKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL05ldHdvcmtSZXF1ZXN0 LmpzCkBAIC00MjAsOSArNDIwLDkgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtSZXF1ZXN0LnByb3Rv dHlwZSA9IHsKICAgICAgKi8KICAgICBnZXQgcmVxdWVzdEhlYWRlcnNUZXh0KCkKICAgICB7Ci0g ICAgICAgIGlmICh0aGlzLl9yZXF1ZXN0SGVhZGVyc1RleHQgPT09IHVuZGVmaW5lZCkgeworICAg ICAgICBpZiAodHlwZW9mIHRoaXMuX3JlcXVlc3RIZWFkZXJzVGV4dCA9PT0gInVuZGVmaW5lZCIp IHsKICAgICAgICAgICAgIHRoaXMuX3JlcXVlc3RIZWFkZXJzVGV4dCA9IHRoaXMucmVxdWVzdE1l dGhvZCArICIgIiArIHRoaXMudXJsICsgIiBIVFRQLzEuMVxyXG4iOwotICAgICAgICAgICAgZm9y ICh2YXIgaSA9IDA7IGkgPCB0aGlzLnJlcXVlc3RIZWFkZXJzOyArK2kpCisgICAgICAgICAgICBm b3IgKHZhciBpID0gMDsgaSA8IHRoaXMucmVxdWVzdEhlYWRlcnMubGVuZ3RoOyArK2kpCiAgICAg ICAgICAgICAgICAgdGhpcy5fcmVxdWVzdEhlYWRlcnNUZXh0ICs9IHRoaXMucmVxdWVzdEhlYWRl cnNbaV0ubmFtZSArICI6ICIgKyB0aGlzLnJlcXVlc3RIZWFkZXJzW2ldLnZhbHVlICsgIlxyXG4i OwogICAgICAgICB9CiAgICAgICAgIHJldHVybiB0aGlzLl9yZXF1ZXN0SGVhZGVyc1RleHQ7CkBA IC01MjIsOSArNTIyLDkgQEAgV2ViSW5zcGVjdG9yLk5ldHdvcmtSZXF1ZXN0LnByb3RvdHlwZSA9 IHsKICAgICAgKi8KICAgICBnZXQgcmVzcG9uc2VIZWFkZXJzVGV4dCgpCiAgICAgewotICAgICAg ICBpZiAodGhpcy5fcmVzcG9uc2VIZWFkZXJzVGV4dCA9PT0gdW5kZWZpbmVkKSB7CisgICAgICAg IGlmICh0eXBlb2YgdGhpcy5fcmVzcG9uc2VIZWFkZXJzVGV4dCA9PT0gInVuZGVmaW5lZCIpIHsK ICAgICAgICAgICAgIHRoaXMuX3Jlc3BvbnNlSGVhZGVyc1RleHQgPSAiSFRUUC8xLjEgIiArIHRo aXMuc3RhdHVzQ29kZSArICIgIiArIHRoaXMuc3RhdHVzVGV4dCArICJcclxuIjsKLSAgICAgICAg ICAgIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5yZXF1ZXN0SGVhZGVyczsgKytpKQorICAgICAg ICAgICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLnJlcXVlc3RIZWFkZXJzLmxlbmd0aDsgKytp KQogICAgICAgICAgICAgICAgIHRoaXMuX3Jlc3BvbnNlSGVhZGVyc1RleHQgKz0gdGhpcy5yZXNw b25zZUhlYWRlcnNbaV0ubmFtZSArICI6ICIgKyB0aGlzLnJlc3BvbnNlSGVhZGVyc1tpXS52YWx1 ZSArICJcclxuIjsKICAgICAgICAgfQogICAgICAgICByZXR1cm4gdGhpcy5fcmVzcG9uc2VIZWFk ZXJzVGV4dDsK