96260 2012-09-10 05:06:38 -0700 [GTK] Sanitize the suggested filename when building the download destination URI 2012-09-10 06:06:15 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned gustavo mrobinson webkit.review.bot xan.lopez oldest_to_newest 715943 0 cgarcia 2012-09-10 05:06:38 -0700 The suggested filename returned by the server can contain directory separators 715944 1 163094 cgarcia 2012-09-10 05:10:18 -0700 Created attachment 163094 Patch 715948 2 webkit.review.bot 2012-09-10 05:15:00 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 715960 3 163094 gustavo 2012-09-10 05:23:54 -0700 Comment on attachment 163094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163094&action=review > Source/WebKit2/ChangeLog:9 > + directory separators so that thje filename would be interpreted as thje 715997 4 cgarcia 2012-09-10 06:06:15 -0700 Committed r128050: <http://trac.webkit.org/changeset/128050> 163094 2012-09-10 05:10:18 -0700 2012-09-10 05:23:54 -0700 Patch wk2-download-destination.diff text/plain 1906 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAwM2NhOTM5Li41ZThjMThhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTgg QEAKKzIwMTItMDktMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIFNhbml0aXplIHRoZSBzdWdnZXN0ZWQgZmlsZW5hbWUgd2hlbiBi dWlsZGluZyB0aGUgZG93bmxvYWQgZGVzdGluYXRpb24gVVJJCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjI2MAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBzdWdnZXN0ZWQgZmlsZW5hbWUgcmV0dXJu ZWQgYnkgdGhlIHNlcnZlciBjYW4gY29udGFpbgorICAgICAgICBkaXJlY3Rvcnkgc2VwYXJhdG9y cyBzbyB0aGF0IHRoamUgZmlsZW5hbWUgd291bGQgYmUgaW50ZXJwcmV0ZWQgYXMKKyAgICAgICAg YSBmdWxsIHBhdGguCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9h ZC5jcHA6CisgICAgICAgICh3ZWJraXREb3dubG9hZERlY2lkZURlc3RpbmF0aW9uKTogQ29udmVy dCBhbnkgZGlyZWN0b3J5IHNlcGFyYXRvcgorICAgICAgICBjb250YWluZWQgaW4gdGhlIHN1Z2dl c3RlZCBmaWxlbmFtZSB0byBhbiB1bmRlcnNjb3JlLgorCiAyMDEyLTA5LTEwICBTaW1vbiBIYXVz bWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KIAogICAgICAgICBbUXRdIEZpeCBnZW5l cmF0aW9uIG9mIGZvcndhcmQgaGVhZGVycyBmb3IgZ2VuZXJhdGVkIGZpbGVzIGluIFdlYkNvcmUg b24gV2luZG93cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsv V2ViS2l0RG93bmxvYWQuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0RG93bmxvYWQuY3BwCmluZGV4IGUwZDdhNjAuLmFhMjYyMzcgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdERvd25sb2FkLmNwcAorKysgYi9Tb3Vy Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXREb3dubG9hZC5jcHAKQEAgLTk4LDcg Kzk4LDkgQEAgc3RhdGljIGdib29sZWFuIHdlYmtpdERvd25sb2FkRGVjaWRlRGVzdGluYXRpb24o V2ViS2l0RG93bmxvYWQqIGRvd25sb2FkLCBjb25zdAogewogICAgIGlmICghZG93bmxvYWQtPnBy aXYtPmRlc3RpbmF0aW9uVVJJLmlzTnVsbCgpKQogICAgICAgICByZXR1cm4gRkFMU0U7Ci0gICAg R093blB0cjxjaGFyPiBkZXN0aW5hdGlvbihnX2J1aWxkX2ZpbGVuYW1lKGdfZ2V0X3VzZXJfc3Bl Y2lhbF9kaXIoR19VU0VSX0RJUkVDVE9SWV9ET1dOTE9BRCksIHN1Z2dlc3RlZEZpbGVuYW1lLCBO VUxMKSk7CisKKyAgICBHT3duUHRyPGNoYXI+IGZpbGVuYW1lKGdfc3RyZGVsaW1pdChnX3N0cmR1 cChzdWdnZXN0ZWRGaWxlbmFtZSksIEdfRElSX1NFUEFSQVRPUl9TLCAnXycpKTsKKyAgICBHT3du UHRyPGNoYXI+IGRlc3RpbmF0aW9uKGdfYnVpbGRfZmlsZW5hbWUoZ19nZXRfdXNlcl9zcGVjaWFs X2RpcihHX1VTRVJfRElSRUNUT1JZX0RPV05MT0FEKSwgZmlsZW5hbWUuZ2V0KCksIE5VTEwpKTsK ICAgICBHT3duUHRyPGNoYXI+IGRlc3RpbmF0aW9uVVJJKGdfZmlsZW5hbWVfdG9fdXJpKGRlc3Rp bmF0aW9uLmdldCgpLCAwLCAwKSk7CiAgICAgZG93bmxvYWQtPnByaXYtPmRlc3RpbmF0aW9uVVJJ ID0gZGVzdGluYXRpb25VUkkuZ2V0KCk7CiAgICAgZ19vYmplY3Rfbm90aWZ5KEdfT0JKRUNUKGRv d25sb2FkKSwgImRlc3RpbmF0aW9uIik7Cg==