<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>96257</bug_id>
          
          <creation_ts>2012-09-10 04:09:19 -0700</creation_ts>
          <short_desc>[TexMap] Fix compilation on Windows</short_desc>
          <delta_ts>2012-09-10 05:34:33 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>90879</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Simon Hausmann">hausmann</reporter>
          <assigned_to name="Simon Hausmann">hausmann</assigned_to>
          <cc>noam</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>715912</commentid>
    <comment_count>0</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-09-10 04:09:19 -0700</bug_when>
    <thetext>[TexMap] Fix compilation on Windows</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715916</commentid>
    <comment_count>1</comment_count>
      <attachid>163086</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-09-10 04:10:57 -0700</bug_when>
    <thetext>Created attachment 163086
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715926</commentid>
    <comment_count>2</comment_count>
      <attachid>163086</attachid>
    <who name="Noam Rosenthal">noam</who>
    <bug_when>2012-09-10 04:38:31 -0700</bug_when>
    <thetext>Comment on attachment 163086
Patch

Why not just change the variable names to nearValue farValue?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715932</commentid>
    <comment_count>3</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-09-10 04:50:35 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 163086 [details])
&gt; Why not just change the variable names to nearValue farValue?

I&apos;d be happy to do that, too. In fact that&apos;s what I did first, but then it felt dirty ;)

New patch dirty patch coming up ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715934</commentid>
    <comment_count>4</comment_count>
      <attachid>163089</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2012-09-10 04:53:34 -0700</bug_when>
    <thetext>Created attachment 163089
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715966</commentid>
    <comment_count>5</comment_count>
      <attachid>163089</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-10 05:34:30 -0700</bug_when>
    <thetext>Comment on attachment 163089
Patch

Clearing flags on attachment: 163089

Committed r128047: &lt;http://trac.webkit.org/changeset/128047&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715967</commentid>
    <comment_count>6</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-10 05:34:33 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>163086</attachid>
            <date>2012-09-10 04:10:57 -0700</date>
            <delta_ts>2012-09-10 04:53:28 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96257-20120910131241.patch</filename>
            <type>text/plain</type>
            <size>1633</size>
            <attacher name="Simon Hausmann">hausmann</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmRhOWNiZmJhNzdmZDI2
ZGNhOTliYmU3MmY2NDVhZTRkN2VkZmJiMi4uZDZiMzg4NDMyNTZkZTVmMzYzNjg1OWI5NmRhNTVm
YWQxMDJlYmU2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTEwICBTaW1v
biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbVGV4TWFw
XSBGaXggY29tcGlsYXRpb24gb24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYyNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBUZXh0dXJlTWFwcGVyR0wgdXNlcyBuZWFyIGFuZCBmYXIgYXMg
dmFyaWFibGUgbmFtZXMgYW5kIHVuZm9ydHVuYXRlbHkKKyAgICAgICAgV2luRGVmcy5oIG9uIFdp
bmRvd3MgaGFzIHRoZSBuYXN0eSBoYWJpdCBvZiB1bmNvbmRpdGlvbmFsbHkoISkgZGVmaW5pbmcK
KyAgICAgICAgbmVhciBhbmQgZmFyIGFzIGVtcHR5IG1hY3Jvcy4gVGhlcmUncyBubyB3YXkgdG8g
cHJldmVudCBXaW5EZWZzLmggZnJvbQorICAgICAgICBkb2luZyBzbywgYnV0IHRoZXJlJ3MgdGhl
IHNpbXBsZSBzb2x1dGlvbiBvZiBzaW1wbHkgdW5kZWZpbmluZyB0aGVtLgorCisgICAgICAgICog
cGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJHTC5jcHA6CisKIDIwMTItMDkt
MTAgIE1pa2UgV2VzdCAgPG1rd3N0QGNocm9taXVtLm9yZz4KIAogICAgICAgICBXYXJuIGF1dGhv
cnMgYWJvdXQgQ1NQIGRpcmVjdGl2ZXMgaWdub3JlZCBkdWUgdG8gbm9uLUFTQ0lJIHZhbHVlcy4K
ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0
dXJlTWFwcGVyR0wuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw
L1RleHR1cmVNYXBwZXJHTC5jcHAKaW5kZXggMWEzYmE4NGRhNzdjYjIwNDc1ZTkzMGU5NGMzMzYy
ZjkxOWI1YTA1ZC4uYzZiMjQyMjJlNTlhZmQ5NzMzMzNmNmI2NmVkNTRlMjZhYTMzNzQ3YiAxMDA2
NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN
YXBwZXJHTC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw
L1RleHR1cmVNYXBwZXJHTC5jcHAKQEAgLTU1LDYgKzU1LDExIEBACiAjZGVmaW5lIEdMX1VOUEFD
S19TS0lQX1JPV1MgMHgwQ0YzCiAjZW5kaWYKIAorLy8gV2luRGVmLmggdW5jb25kaXRpb25hbGx5
IGRlZmluZXMgbmVhciBhbmQgZmFyLCBhcyB3ZSB1c2UgdGhlbSBhcworLy8gdmFyaWFibGVzIGZ1
cnRoZXIgZG93bi4KKyN1bmRlZiBuZWFyCisjdW5kZWYgZmFyCisKIG5hbWVzcGFjZSBXZWJDb3Jl
IHsKIHN0cnVjdCBUZXh0dXJlTWFwcGVyR0xEYXRhIHsKICAgICBzdHJ1Y3QgU2hhcmVkR0xEYXRh
IDogcHVibGljIFJlZkNvdW50ZWQ8U2hhcmVkR0xEYXRhPiB7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>163089</attachid>
            <date>2012-09-10 04:53:34 -0700</date>
            <delta_ts>2012-09-10 05:34:29 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96257-20120910135518.patch</filename>
            <type>text/plain</type>
            <size>2261</size>
            <attacher name="Simon Hausmann">hausmann</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTE5NmUyNmFhM2Q0MDY4
NTc2ZTlkZjkzYTc3NjRhYzc2ODIwNWIyYy4uMDVjZDNkZDhkNWFkYjQ0ZDY4OWJhMTI3YWI2ZTY3
ZTA3MzMwMzA3NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEyLTA5LTEwICBTaW1v
biBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lhLmNvbT4KKworICAgICAgICBbVGV4TWFw
XSBGaXggY29tcGlsYXRpb24gb24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYyNTcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg
KE9PUFMhKS4KKworICAgICAgICBUZXh0dXJlTWFwcGVyR0wgdXNlcyBuZWFyIGFuZCBmYXIgYXMg
dmFyaWFibGUgbmFtZXMgYW5kIHVuZm9ydHVuYXRlbHkKKyAgICAgICAgV2luRGVmcy5oIG9uIFdp
bmRvd3MgaGFzIHRoZSBuYXN0eSBoYWJpdCBvZiB1bmNvbmRpdGlvbmFsbHkoISkgZGVmaW5pbmcK
KyAgICAgICAgbmVhciBhbmQgZmFyIGFzIGVtcHR5IG1hY3Jvcy4gVGhlcmUncyBubyB3YXkgdG8g
cHJldmVudCBXaW5EZWZzLmggZnJvbQorICAgICAgICBkb2luZyBzby4gSW5zdGVhZCB3ZSByZW5h
bWUgdGhlIHZhcmlhYmxlcy4gKEFub3RoZXIgb3B0aW9uIHdvdWxkJ3ZlIGJlZW4gdG8KKyAgICAg
ICAgI3VuZGVmKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVN
YXBwZXJHTC5jcHA6CisKIDIwMTItMDktMTAgIEFsZXhhbmRlciBQYXZsb3YgIDxhcGF2bG92QGNo
cm9taXVtLm9yZz4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbRWxlbWVudHNdIFBvb3IgcGVy
Zm9ybWFuY2UgdXBvbiBjb250aW51b3VzIGF0dHJpYnV0ZSBjaGFuZ2VzCmRpZmYgLS1naXQgYS9T
b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlckdMLmNw
cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVy
R0wuY3BwCmluZGV4IDFhM2JhODRkYTc3Y2IyMDQ3NWU5MzBlOTRjMzM2MmY5MTliNWEwNWQuLmNh
Mzc1YjFmZGI2ZTg3ZDc3NjRiN2Y4NmFkMWU3ZDYxMDJkYTNmNDMgMTAwNjQ0Ci0tLSBhL1NvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyR0wuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVy
R0wuY3BwCkBAIC03NTAsMTMgKzc1MCwxMyBAQCBQYXNzUmVmUHRyPEJpdG1hcFRleHR1cmU+IEJp
dG1hcFRleHR1cmVHTDo6YXBwbHlGaWx0ZXJzKGNvbnN0IEJpdG1hcFRleHR1cmUmIGNvbgogCiBz
dGF0aWMgaW5saW5lIFRyYW5zZm9ybWF0aW9uTWF0cml4IGNyZWF0ZVByb2plY3Rpb25NYXRyaXgo
Y29uc3QgSW50U2l6ZSYgc2l6ZSwgYm9vbCBtaXJyb3JlZCkKIHsKLSAgICBjb25zdCBmbG9hdCBu
ZWFyID0gOTk5OTk5OTsKLSAgICBjb25zdCBmbG9hdCBmYXIgPSAtOTk5OTk7CisgICAgY29uc3Qg
ZmxvYXQgbmVhclZhbHVlID0gOTk5OTk5OTsKKyAgICBjb25zdCBmbG9hdCBmYXJWYWx1ZSA9IC05
OTk5OTsKIAogICAgIHJldHVybiBUcmFuc2Zvcm1hdGlvbk1hdHJpeCgyLjAgLyBmbG9hdChzaXpl
LndpZHRoKCkpLCAwLCAwLCAwLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwLCAo
bWlycm9yZWQgPyAyLjAgOiAtMi4wKSAvIGZsb2F0KHNpemUuaGVpZ2h0KCkpLCAwLCAwLAotICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAwLCAwLCAtMi5mIC8gKGZhciAtIG5lYXIpLCAw
LAotICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtMSwgbWlycm9yZWQgPyAtMSA6IDEs
IC0oZmFyICsgbmVhcikgLyAoZmFyIC0gbmVhciksIDEpOworICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAwLCAwLCAtMi5mIC8gKGZhclZhbHVlIC0gbmVhclZhbHVlKSwgMCwKKyAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgLTEsIG1pcnJvcmVkID8gLTEgOiAxLCAtKGZhclZh
bHVlICsgbmVhclZhbHVlKSAvIChmYXJWYWx1ZSAtIG5lYXJWYWx1ZSksIDEpOwogfQogCiB2b2lk
IEJpdG1hcFRleHR1cmVHTDo6aW5pdGlhbGl6ZVN0ZW5jaWwoKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>