9625 2006-06-27 16:49:58 -0700 REGRESSION: Focus is not removed from password field after I ctrl-click into a different field 2006-07-14 12:04:14 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix, HasReduction, InRadar P1 Critical --- 1 c.petersen87 webkit-unassigned adele darin ian oldest_to_newest 47397 0 c.petersen87 2006-06-27 16:49:58 -0700 If I have focus in a password type field and ctrl-click on another input field, focus is not removed from the password field. I will then have TWO fields that have a focus ring and a flashing caret. * STEPS TO REPRODUCE 1. With a TOT webkit nightly build, go to any site that includes both a input text field and password field. (like gmail) 2. Place the caret into the password field  3. Ctrl-click into the input text field and mouse up (don't select anything in the contextual menu). 4. Notice that focus is placed on the input field but not removed from password field. * RESULTS Focus should removed from the password field but isn't. * REGRESSION Yes, this only happens with native text fields. 47398 1 c.petersen87 2006-06-27 16:52:53 -0700 This issue has been filed as<rdar://problem/4604703> 47657 2 darin 2006-06-28 08:54:06 -0700 The cause of this is code in WebHTMLView.m that doesn't return YES from acceptsFirstResponder. Should be easy to fix. 47658 3 9078 darin 2006-06-28 09:00:46 -0700 Created attachment 9078 reduction 47659 4 9079 darin 2006-06-28 09:01:13 -0700 Created attachment 9079 patch, with change log but no test 49757 5 dacarson 2006-07-14 04:44:40 -0700 Seems that a fix was checked in r15419, but this defect has not been updated. 49758 6 dacarson 2006-07-14 04:56:33 -0700 Comment from svn log. rdar number matches this bug. Marking as fixed r15419 | adele | 2006-07-14 02:48:17 -0400 (Fri, 14 Jul 2006) | 13 lines Reviewed by Maciej. - Fix for <rdar://problem/4604703> REGRESSION (NativeTextField): Focus is not removed from password field after I ctrl-click into a different field Test: * manual-tests/password-ctrl-click-lose-focus.html: Added. * bridge/mac/FrameMac.mm: (WebCore::FrameMac::sendContextMenuEvent): If we're about to set a selection in the current view, make sure its the first responder. In this case, this will cause the password field to resign first responder at the right time. 49823 7 adele 2006-07-14 12:04:14 -0700 I backed out my original change and checked in Darin's. Committed revision 15430. 9078 2006-06-28 09:00:46 -0700 2006-06-28 09:00:46 -0700 reduction password-focus-reduction.html text/html 148 darin PHA+Q2xpY2sgaW4gdGhlIGZpcnN0IChwYXNzd29yZCkgZmllbGQsIHRoZW4gY29udHJvbCBjbGlj ayBpbiB0aGUgc2Vjb25kIChub3QgcGFzc3dvcmQpIGZpZWxkLjwvcD4KPGRpdj48aW5wdXQgdHlw ZT1wYXNzd29yZD48aW5wdXQgdHlwZT10ZXh0PjwvZGl2Pg== 9079 2006-06-28 09:01:13 -0700 2006-06-28 09:01:13 -0700 patch, with change log but no test ControlClickFocusPatch.txt text/plain 1514 darin SW5kZXg6IFdlYktpdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L0NoYW5nZUxvZwko cmV2aXNpb24gMTUwNzkpCisrKyBXZWJLaXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0x LDMgKzEsMTQgQEAKKzIwMDYtMDYtMjggIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0 dHA6Ly9idWd6aWxsYS5vcGVuZGFyd2luLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYyNQorICAgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80NjA0NzAzPgorICAgICAgICAgIFJFR1JFU1NJT046IEZvY3Vz IG5vdCByZW1vdmVkIGZyb20gcGFzc3dvcmQgZmllbGQgYWZ0ZXIgY3RybC1jbGljayBpbiB0ZXh0 IGZpZWxkCisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm06ICgtW05TQXJyYXkgbWVu dUZvckV2ZW50Ol0pOiBTZXQgaGFuZGxpbmdNb3VzZURvd25FdmVudCB0bworICAgICAgICBZRVMg d2hpbGUgY2FsbGluZyBzZW5kQ29udGV4dE1lbnVFdmVudDogb24gdGhlIGJyaWRnZS4KKwogMjAw Ni0wNi0yNyAgQnJhZHkgRWlkc29uICA8YmVpZHNvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgTWFjaWVqCkluZGV4OiBXZWJLaXQvV2ViVmlldy9XZWJIVE1MVmlldy5tCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdC9XZWJWaWV3L1dlYkhUTUxWaWV3Lm0JKHJldmlzaW9uIDE1MDc3KQor KysgV2ViS2l0L1dlYlZpZXcvV2ViSFRNTFZpZXcubQkod29ya2luZyBjb3B5KQpAQCAtMjUxNyw5 ICsyNTE3LDEyIEBAIHN0YXRpYyBXZWJIVE1MVmlldyAqbGFzdEhpdFZpZXcgPSBuaWw7CiB7CiAg ICAgW19wcml2YXRlLT5jb21wQ29udHJvbGxlciBlbmRSZXZlcnRpbmdDaGFuZ2U6Tk8gbW92ZUxl ZnQ6Tk9dOwogCi0gICAgaWYgKFtbc2VsZiBfYnJpZGdlXSBzZW5kQ29udGV4dE1lbnVFdmVudDpl dmVudF0pIHsKKyAgICBfcHJpdmF0ZS0+aGFuZGxpbmdNb3VzZURvd25FdmVudCA9IFlFUzsKKyAg ICBCT09MIGhhbmRsZWRFdmVudCA9IFtbc2VsZiBfYnJpZGdlXSBzZW5kQ29udGV4dE1lbnVFdmVu dDpldmVudF07CisgICAgX3ByaXZhdGUtPmhhbmRsaW5nTW91c2VEb3duRXZlbnQgPSBOTzsKKyAg ICBpZiAoaGFuZGxlZEV2ZW50KQogICAgICAgICByZXR1cm4gbmlsOwotICAgIH0KKwogICAgIE5T UG9pbnQgcG9pbnQgPSBbc2VsZiBjb252ZXJ0UG9pbnQ6W2V2ZW50IGxvY2F0aW9uSW5XaW5kb3dd IGZyb21WaWV3Om5pbF07CiAgICAgTlNEaWN0aW9uYXJ5ICplbGVtZW50ID0gW3NlbGYgZWxlbWVu dEF0UG9pbnQ6cG9pbnRdOwogICAgIHJldHVybiBbW3NlbGYgX3dlYlZpZXddIF9tZW51Rm9yRWxl bWVudDplbGVtZW50IGRlZmF1bHRJdGVtczpuaWxdOwo=