96243 2012-09-10 00:51:46 -0700 [Qt][WK2] REGRESSION(r127862): It made one test fail and one test crash 2012-09-10 05:16:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) All All RESOLVED FIXED Qt, QtTriaged P1 Critical --- 79666 79668 88238 1 ossy allan.jensen abecsi allan.jensen cmarcelo menard ossy tony webkit.review.bot zoltan oldest_to_newest 715788 0 ossy 2012-09-10 00:51:46 -0700 fast/events/mouse-click-events.html started to fail: ----------------------------------------------------- --- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/events/mouse-click-events-expected.txt +++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/fast/events/mouse-click-events-actual.txt @@ -6,11 +6,11 @@ Left Mouse Button PASS eventLog is "mousedown(0) mouseup(0) click(0) mousedown(0) mouseup(0) click(0) dblclick(0) " Middle Mouse Button -PASS eventLog is "mousedown(1) mouseup(1) click(1) mousedown(1) mouseup(1) click(1) dblclick(1) " +FAIL eventLog should be mousedown(1) mouseup(1) click(1) mousedown(1) mouseup(1) click(1) dblclick(1) . Was mousedown(1) mousedown(1) . Right Mouse Button PASS eventLog is "mousedown(2) mouseup(2) mousedown(2) mouseup(2) " 4th Mouse Button -PASS eventLog is "mousedown(1) mouseup(1) click(1) mousedown(1) mouseup(1) click(1) dblclick(1) " +FAIL eventLog should be mousedown(1) mouseup(1) click(1) mousedown(1) mouseup(1) click(1) dblclick(1) . Was mousedown(1) mousedown(1) . PASS successfullyParsed is true TEST COMPLETE scrollbars/scrollbar-middleclick-nopaste.html started to fail and crash: (1st run - FAIL, 2nd run - CRASH) ----------------------------------------------------------------------------------------------------------- --- /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/scrollbars/scrollbar-middleclick-nopaste-expected.txt +++ /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/layout-test-results/scrollbars/scrollbar-middleclick-nopaste-actual.txt @@ -1 +1 @@ -PASS +FAIL 00:19:37.038 14068 WebProcess crash, pid = None, error_line = #CRASHED - WebProcess 00:19:37.040 14068 worker/0 scrollbars/scrollbar-middleclick-nopaste.html crashed, (stderr lines): 00:19:37.040 14068 1 0x7f6996dae248 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x1a16248) [0x7f6996dae248] 00:19:37.040 14068 2 0x7f6993ce7420 /lib/x86_64-linux-gnu/libc.so.6(+0x36420) [0x7f6993ce7420] 00:19:37.040 14068 3 0x7f69962cf798 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0xf37798) [0x7f69962cf798] 00:19:37.040 14068 4 0x7f6995cbb733 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x923733) [0x7f6995cbb733] 00:19:37.040 14068 5 0x7f6995cbcf68 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x924f68) [0x7f6995cbcf68] 00:19:37.040 14068 6 0x7f6995cc0dec /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x928dec) [0x7f6995cc0dec] 00:19:37.040 14068 7 0x7f699599a0c6 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x6020c6) [0x7f699599a0c6] 00:19:37.041 14068 8 0x7f6995991025 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x5f9025) [0x7f6995991025] 00:19:37.041 14068 9 0x7f699599121c /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x5f921c) [0x7f699599121c] 00:19:37.041 14068 10 0x7f69959e3760 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x64b760) [0x7f69959e3760] 00:19:37.041 14068 11 0x7f699584d3fb /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x4b53fb) [0x7f699584d3fb] 00:19:37.041 14068 12 0x7f699584d58b /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x4b558b) [0x7f699584d58b] 00:19:37.041 14068 13 0x7f699584e924 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x4b6924) [0x7f699584e924] 00:19:37.041 14068 14 0x7f699584ea6c /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x4b6a6c) [0x7f699584ea6c] 00:19:37.041 14068 15 0x7f69958507b9 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x4b87b9) [0x7f69958507b9] 00:19:37.041 14068 16 0x7f6995925c70 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x58dc70) [0x7f6995925c70] 00:19:37.041 14068 17 0x7f699591bfac /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(WKBundlePostSynchronousMessage+0x1c) [0x7f699591bfac] 00:19:37.041 14068 18 0x7f6947084663 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libWTRInjectedBundle.so(_ZN3WTR22EventSendingController7mouseUpEiPK13OpaqueJSValue+0x103) [0x7f6947084663] 00:19:37.041 14068 19 0x7f694708dcc3 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libWTRInjectedBundle.so(_ZN3WTR24JSEventSendingController7mouseUpEPK15OpaqueJSContextP13OpaqueJSValueS5_mPKPKS4_PS7_+0x43) [0x7f694708dcc3] 00:19:37.041 14068 20 0x7f6996afba72 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x1763a72) [0x7f6996afba72] 00:19:37.041 14068 21 0x7f6996c6a431 /home/webkitbuildbot/slaves/release64bitWebKit2_EC2/buildslave/qt-linux-64-release-webkit2/build/WebKitBuild/Release/lib/libQtWebKit.so.5(+0x18d2431) [0x7f6996c6a431] 00:19:37.042 14068 22 0x7f6947aa51cc [0x7f6947aa51cc] 00:19:37.042 14068 [30/126] scrollbar-middleclick-nopaste.html crashed unexpectedly 00:19:37.042 14068 worker/0 killing driver 00:19:37.043 14068 worker/0 scrollbars/scrollbar-middleclick-nopaste.html failed: 00:19:37.043 14068 worker/0 WebProcess crashed 715797 1 ossy 2012-09-10 00:59:26 -0700 I skipped them to paint the bots green - https://trac.webkit.org/changeset/128026 Please unskip them with the proper fix. 715864 2 abecsi 2012-09-10 02:37:31 -0700 The Web Inspector patch pointed out in the title (http://trac.webkit.org/changeset/127861) seem to be unrelated. I think the culprit is the X11 Global Selection patch which is the next change (r127862), must be a typo, am I righ Ossy? 715866 3 ossy 2012-09-10 02:44:38 -0700 Yes, it was a typo. Thanks. :) 715875 4 allan.jensen 2012-09-10 02:56:19 -0700 I am guessing the reason for the crash could be that QT_NO_CLIPBOARD is set in this case? I forgot to check for it in the WK2 code, like it is in the WK1 code. 715884 5 163079 allan.jensen 2012-09-10 03:14:31 -0700 Created attachment 163079 Patch 715894 6 163079 kenneth 2012-09-10 03:39:02 -0700 Comment on attachment 163079 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=163079&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:1355 > + bool handled = frame->eventHandler()->handleMouseReleaseEvent(platformMouseEvent); spacing issue 715901 7 allan.jensen 2012-09-10 03:54:54 -0700 Committed r128040: <http://trac.webkit.org/changeset/128040> 715933 8 ossy 2012-09-10 04:52:55 -0700 (In reply to comment #7) > Committed r128040: <http://trac.webkit.org/changeset/128040> (In reply to comment #1) > I skipped them to paint the bots green - https://trac.webkit.org/changeset/128026 > Please unskip them with the proper fix. You missed to unskip these tests. Please unskip them if they pass now. 715953 9 163079 allan.jensen 2012-09-10 05:16:33 -0700 Comment on attachment 163079 Patch Clearing flags after landing patch. 163079 2012-09-10 03:14:31 -0700 2012-09-10 05:16:33 -0700 Patch bug-96243-20120910121356.patch text/plain 2888 allan.jensen U3VidmVyc2lvbiBSZXZpc2lvbjogMTI4MDM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGNkOWYxZTZhMTI5YjZk YzFmMmEyN2YzYjI0MjI0YjM4ZjU2ODBhNC4uYjc5MTg3YTljYTJiNWYyZTIwMGIxM2YwOTdlMWRm MzM1MjVkOTgwYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEyLTA5LTEwICBBbGxh biBTYW5kZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgorCisgICAgICAgIFtR dF1bV0syXSBSRUdSRVNTSU9OKHIxMjc4NjEpOiBJdCBtYWRlIG9uZSB0ZXN0IGZhaWwgYW5kIG9u ZSB0ZXN0IGNyYXNoCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD05NjI0MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFNraXAgdGhlIGNvZGUgaWYgUUNsaXBib2FyZCBpcyBub3QgYXZhaWxhYmxlLCBhbmQgZ2l2 ZSBXZWJDb3JlIGEgY2hhbmNlIHRvIGhhbmRsZSB0aGUgZXZlbnQgZmlyc3QuCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OmhhbmRs ZU1vdXNlRXZlbnQpOgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9xdC9XZWJQYWdlUXQu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlOjpoYW5kbGVNb3VzZVJlbGVhc2VFdmVudCk6 CisKIDIwMTItMDktMTAgIEFuZHJhcyBCZWNzaSAgPGFuZHJhcy5iZWNzaUBub2tpYS5jb20+CiAK ICAgICAgICAgW1F0XVtXSzJdIFFXZWJLaXRUZXN0IHNob3VsZCByZXRyaWV2ZSB0aGUgdmlld3Bv cnQgc3RhdGUgZnJvbSB0aGUgUGFnZVZpZXdwb3J0Q29udHJvbGxlcgpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuY3BwCmluZGV4IDhkMDEwMDViNDkwYTQxMDUw NjJjMzgzNTY4NzNiMjQ3MTI5ZDdlNmIuLjIyNmQ5MjU1NDEwNzE2M2E4ZmM1NTBlY2NmZjM4NTMw MzMwYzk5NDAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9X ZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5jcHAKQEAgLTEzNTEsMTIgKzEzNTEsMTQgQEAgc3RhdGljIGJvb2wgaGFuZGxlTW91c2VFdmVu dChjb25zdCBXZWJNb3VzZUV2ZW50JiBtb3VzZUV2ZW50LCBXZWJQYWdlKiBwYWdlLCBib28KIAog ICAgICAgICAgICAgcmV0dXJuIGhhbmRsZWQ7CiAgICAgICAgIH0KLSAgICAgICAgY2FzZSBQbGF0 Zm9ybUV2ZW50OjpNb3VzZVJlbGVhc2VkOgorICAgICAgICBjYXNlIFBsYXRmb3JtRXZlbnQ6Ok1v dXNlUmVsZWFzZWQ6IHsKKyAgICAgICAgICAgIGJvb2wgaGFuZGxlZCA9ICBmcmFtZS0+ZXZlbnRI YW5kbGVyKCktPmhhbmRsZU1vdXNlUmVsZWFzZUV2ZW50KHBsYXRmb3JtTW91c2VFdmVudCk7CiAj aWYgUExBVEZPUk0oUVQpCi0gICAgICAgICAgICBpZiAocGFnZS0+aGFuZGxlTW91c2VSZWxlYXNl RXZlbnQocGxhdGZvcm1Nb3VzZUV2ZW50KSkKLSAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsK KyAgICAgICAgICAgIGlmICghaGFuZGxlZCkKKyAgICAgICAgICAgICAgICBoYW5kbGVkID0gcGFn ZS0+aGFuZGxlTW91c2VSZWxlYXNlRXZlbnQocGxhdGZvcm1Nb3VzZUV2ZW50KTsKICNlbmRpZgot ICAgICAgICAgICAgcmV0dXJuIGZyYW1lLT5ldmVudEhhbmRsZXIoKS0+aGFuZGxlTW91c2VSZWxl YXNlRXZlbnQocGxhdGZvcm1Nb3VzZUV2ZW50KTsKKyAgICAgICAgICAgIHJldHVybiBoYW5kbGVk OworICAgICAgICB9CiAgICAgICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6TW91c2VNb3ZlZDoKICAg ICAgICAgICAgIGlmIChvbmx5VXBkYXRlU2Nyb2xsYmFycykKICAgICAgICAgICAgICAgICByZXR1 cm4gZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5wYXNzTW91c2VNb3ZlZEV2ZW50VG9TY3JvbGxiYXJz KHBsYXRmb3JtTW91c2VFdmVudCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvcXQvV2ViUGFnZVF0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9xdC9XZWJQYWdlUXQuY3BwCmluZGV4IDAwNzQxMzQ3MTU3Njk5MzVkODlhNmQ1MzUw YTdmZGNjN2M0ZGFkNjkuLmUzZjYwMzRkZjIzNzJkMGQxYjIyYzBlMTFhNzE3MWVmOWZiMDQxZGIg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9xdC9XZWJQYWdl UXQuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9xdC9XZWJQYWdl UXQuY3BwCkBAIC00NDIsNiArNDQyLDcgQEAgdm9pZCBXZWJQYWdlOjpoaWRlUG9wdXBNZW51KCkK IAogYm9vbCBXZWJQYWdlOjpoYW5kbGVNb3VzZVJlbGVhc2VFdmVudChjb25zdCBQbGF0Zm9ybU1v dXNlRXZlbnQmIHBsYXRmb3JtTW91c2VFdmVudCkKIHsKKyNpZm5kZWYgUVRfTk9fQ0xJUEJPQVJE CiAgICAgaWYgKHBsYXRmb3JtTW91c2VFdmVudC5idXR0b24oKSAhPSBXZWJDb3JlOjpNaWRkbGVC dXR0b24pCiAgICAgICAgIHJldHVybiBmYWxzZTsKIApAQCAtNDUyLDYgKzQ1Myw3IEBAIGJvb2wg V2ViUGFnZTo6aGFuZGxlTW91c2VSZWxlYXNlRXZlbnQoY29uc3QgUGxhdGZvcm1Nb3VzZUV2ZW50 JiBwbGF0Zm9ybU1vdXNlRXZlCiAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQog ICAgIH0KKyNlbmRpZgogICAgIHJldHVybiBmYWxzZTsKIH0KIAo=