9624 2006-06-27 16:43:54 -0700 REGRESSION: After ctrl-clicking in a EMPTY input or textarea field, the contextual menu shows "Search in Google" and "Search in Spotlight" as active menu items 2006-07-12 14:42:00 -0700 1 1 1 Unclassified WebKit Forms 420+ Mac OS X 10.4 RESOLVED FIXED GoogleBug, InRadar, Regression P1 Minor --- 1 c.petersen87 andersca adele darin ddkilzer ian joost sullivan oldest_to_newest 47395 0 c.petersen87 2006-06-27 16:43:54 -0700 This sounds related to the http://bugzilla.opendarwin.org/show_bug.cgi?id=9580.   Ctrl-clicking in a empty input or textarea field still shows ""Search in Google" and "Search in Spotlight" as active items in the contextual menu. These menu items are active but do nothing when selected.  * STEPS TO REPRODUCE 1. With a TOT webkit NB, go to http://www.apple.com/macosx/feedback/ 2. Ctrl-click in the empty Name field or Comments field. Notice both menu items mentioned above are active but aren't functional. * RESULTS Both "Search in Google" and "Search in Spotlight" should be dimmed in the contextual if I cntrl-click in a empty field.   47396 1 c.petersen87 2006-06-27 16:45:31 -0700 This issue is filed as <rdar://problem/4604650> in Radar. 47931 2 ddkilzer 2006-07-01 19:24:55 -0700 With debug builds of WebKit, this causes an assertion failure. Steps to reproduce: 1. Open Safari+WebKit with a recent ToT debug build of WebKit. 2. Load a page with a textarea or text field on it. 3. Click in the textarea or text field to give it focus. 4. Right-click (or ctrl-left-click) somewhere on the page (but NOT on a link--that's a different bug that's getting filed next). Expected results: Contextual menu is pulled up with nominal options. Actual results: Assertion failure with debug builds of WebKit.  Release builds follow the behavior in Comment #0. Notes: Reproduced with Safari 2.0.4 (419.3) and a locally-built WebKit r15125 (with an in-progress patch for Bug 9179) on Mac OS X 10.4.7 (8J135/PowerPC). Assertion: ASSERTION FAILED: [[menuItems objectAtIndex:1] isSeparatorItem] (/Users/ddkilzer/Projects/Cocoa/WebKit/WebKit/WebView/WebView.m:723 -[WebView(WebPrivate) _menuForElement:defaultItems:]) Stack trace: Date/Time:      2006-07-01 21:10:31.228 -0500 OS Version:     10.4.7 (Build 8J135) Report Version: 4 Command: Safari Path:    /Applications/Safari.app/Contents/MacOS/Safari Parent:  bash [399] Version:        2.0.4 (419.3) Build Version:  1 Project Name:   WebBrowser Source Version: 4190300 PID:    2914 Thread: 0 Exception:  EXC_BAD_ACCESS (0x0001) Codes:      KERN_INVALID_ADDRESS (0x0001) at 0xbbadbeef Thread 0 Crashed: 0   com.apple.WebKit          0x0039aa68 -[WebView(WebPrivate) _menuForElement:defaultItems:] + 888 (WebView.m:723) 1   com.apple.WebKit          0x0036eee8 -[WebHTMLView menuForEvent:] + 404 (WebHTMLView.m:2533) 2   com.apple.AppKit          0x93b34c5c -[NSView rightMouseDown:] + 68 3   com.apple.AppKit          0x93a06404 -[NSControl _rightMouseUpOrDown:] + 440 4   com.apple.AppKit          0x9374afa0 -[NSWindow sendEvent:] + 6424 5   com.apple.Safari          0x00021734 0x1000 + 132916 6   com.apple.AppKit          0x936f38d4 -[NSApplication sendEvent:] + 4172 7   com.apple.Safari          0x00021238 0x1000 + 131640 8   com.apple.AppKit          0x936ead10 -[NSApplication run] + 508 9   com.apple.AppKit          0x937db87c NSApplicationMain + 452 10  com.apple.Safari          0x0005c77c 0x1000 + 374652 11  com.apple.Safari          0x0005c624 0x1000 + 374308 47933 3 ddkilzer 2006-07-01 19:33:55 -0700 Bug 9680 may be closely related (or a duplicate) of this bug, but the behavior is slightly different. 48828 4 darin 2006-07-08 09:21:40 -0700 (In reply to comment #0) > Both "Search in Google" and "Search in Spotlight" should be dimmed in the > contextual if I cntrl-click in a empty field.   I'm don't think that's correct. Many items that dim on normal menus instead are omitted completely from contextual menus when they don't apply. For example, both of these items are omitted entirely with the older versions of WebKit in this case, and I think that's the correct behavior. So we want to omit these items rather than dimming them. 48829 5 darin 2006-07-08 09:26:19 -0700 The assertion failure occurs only with Tiger Safari, not TOT Safari, so people on the Safari team investigating this bug will see different results. 48832 6 darin 2006-07-08 09:32:38 -0700 The code that controls this is in WebDefaulContextMenuDelegate -- the comments there scared me away from making a change to remove the items that don't apply. Disabling the commands would be done in -[WebView validateUserInterfaceItem:]. That would be relatively easy. 48833 7 darin 2006-07-08 09:33:33 -0700 Although this is a regression, I'm not sure it's serious enough to qualify as a P1. 49463 8 joost 2006-07-12 10:20:44 -0700 Adding GoogleBug keyword in one big change. 49486 9 9415 andersca 2006-07-12 13:34:17 -0700 Created attachment 9415 Patch Here's a patch. Darin, is there something wrong with doing it this way? 49499 10 9415 darin 2006-07-12 14:23:48 -0700 Comment on attachment 9415 Patch Seems to me that the thing we want to check here is not "is the item selected" but rather "is there any text selected in this item", but I think we should land this and refine later after more testing. r=me 49504 11 andersca 2006-07-12 14:42:00 -0700 Landed in r15396 9415 2006-07-12 13:34:17 -0700 2006-07-12 14:23:48 -0700 Patch default-menu-items.txt text/plain 3298 andersca SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDE1Mzk1 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDYtMDct MTIgIEFuZGVycyBDYXJsc3NvbiAgPGFjYXJsc3NvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cDovL2J1Z3ppbGxhLm9wZW5k YXJ3aW4ub3JnL3Nob3dfYnVnLmNnaT9pZD05NjI0CisgICAgICAgIFJFR1JFU1NJT046IEFmdGVy IGN0cmwtY2xpY2tpbmcgaW4gYSBFTVBUWSBpbnB1dCBvciB0ZXh0YXJlYSBmaWVsZCwgdGhlIGNv bnRleHR1YWwgbWVudSBzaG93cyAiU2VhcmNoIGluIEdvb2dsZSIgYW5kICJTZWFyY2ggaW4gU3Bv dGxpZ2h0IiBhcyBhY3RpdmUgbWVudSBpdGVtcworICAgICAgICAKKyAgICAgICAgKiBEZWZhdWx0 RGVsZWdhdGVzL1dlYkRlZmF1bHRDb250ZXh0TWVudURlbGVnYXRlLm06CisgICAgICAgICgtW1dl YkRlZmF1bHRVSURlbGVnYXRlIGVkaXRpbmdDb250ZXh0TWVudUl0ZW1zRm9yRWxlbWVudDpkZWZh dWx0TWVudUl0ZW1zOl0pOgorICAgICAgICBEb24ndCBjcmVhdGUgRGljdGlvbmFyeSwgU3BvdGxp Z2h0IG9yIEdvb2dsZSBsb29rdXAgaXRlbXMgaWYgdGhlcmUncyBubyBzZWxlY3Rpb24uCisgICAg ICAgIAogMjAwNi0wNy0xMiAgTWFyayBSb3dlICA8b3BlbmRhcndpbi5vcmdAYmRhc2gubmV0Lm56 PgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkuCkluZGV4OiBEZWZhdWx0RGVsZWdhdGVz L1dlYkRlZmF1bHRDb250ZXh0TWVudURlbGVnYXRlLm0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gRGVmYXVsdERl bGVnYXRlcy9XZWJEZWZhdWx0Q29udGV4dE1lbnVEZWxlZ2F0ZS5tCShyZXZpc2lvbiAxNTM5NSkK KysrIERlZmF1bHREZWxlZ2F0ZXMvV2ViRGVmYXVsdENvbnRleHRNZW51RGVsZWdhdGUubQkod29y a2luZyBjb3B5KQpAQCAtMjkwLDE4ICsyOTAsMTkgQEAgc3RhdGljIE5TU3RyaW5nICpsb2NhbGl6 ZWRNZW51VGl0bGVGcm9tQQogICAgICAgICBbbWVudUl0ZW1zIGFkZE9iamVjdDpbc2VsZiBtZW51 SXRlbVdpdGhUYWc6V2ViTWVudUl0ZW1UYWdMZWFyblNwZWxsaW5nIHRhcmdldDpuaWwgcmVwcmVz ZW50ZWRPYmplY3Q6ZWxlbWVudF1dOwogICAgICAgICBbbWVudUl0ZW1zIGFkZE9iamVjdDpbTlNN ZW51SXRlbSBzZXBhcmF0b3JJdGVtXV07CiAgICAgfQotICAgIAotICAgIC8vIEFkZCBpdGVtcyB0 aGF0IGFyZW4ndCBpbiBvdXIgbmliLCBvcmlnaW5hbGx5IGJlY2F1c2UgdGhleSB3ZXJlIFRpZ2Vy LW9ubHkuCi0gICAgLy8gRklYTUU6IFdlIHNob3VsZCB1cGRhdGUgdGhlIG5pYiB0byBpbmNsdWRl IHRoZXNlLgotICAgIFttZW51SXRlbXMgYWRkT2JqZWN0OltzZWxmIG1lbnVJdGVtV2l0aFRhZzpX ZWJNZW51SXRlbVRhZ1NlYXJjaEluU3BvdGxpZ2h0IHRhcmdldDpuaWwgcmVwcmVzZW50ZWRPYmpl Y3Q6ZWxlbWVudF1dOwotICAgIFttZW51SXRlbXMgYWRkT2JqZWN0OltzZWxmIG1lbnVJdGVtV2l0 aFRhZzpXZWJNZW51SXRlbVRhZ1NlYXJjaFdlYiB0YXJnZXQ6bmlsIHJlcHJlc2VudGVkT2JqZWN0 OmVsZW1lbnRdXTsKLSAgICBbbWVudUl0ZW1zIGFkZE9iamVjdDpbTlNNZW51SXRlbSBzZXBhcmF0 b3JJdGVtXV07Ci0gICAgLy8gRklYTUU6IFRoZSBOU1RleHRWaWV3IGJlaGF2aW9yIGZvciBsb29r aW5nIHRleHQgdXAgaW4gdGhlIGRpY3Rpb25hcnkgaXMgZGlmZmVyZW50IGlmCi0gICAgLy8gdGhl cmUgd2FzIGEgc2VsZWN0aW9uIGJlZm9yZSB5b3UgY2xpY2tlZCB0aGFuIGlmIHRoZSBzZWxlY3Rp b24gd2FzIGNyZWF0ZWQgYXMgcGFydCBvZgotICAgIC8vIHRoZSBjbGljay4gVGhpcyBpcyBkZXNp cmVkIGJ5IHRoZSBkaWN0aW9uYXJ5IGZvbGtzIGFwcGFyZW50bHksIHRob3VnaCBpdCBzZWVtcyBi aXphcnJlLgotICAgIC8vIEl0IG1pZ2h0IGJlIHRyaWNreSB0byBwdWxsIHRoaXMgb2ZmIGluIFdl YktpdC4KLSAgICBbbWVudUl0ZW1zIGFkZE9iamVjdDpbc2VsZiBtZW51SXRlbVdpdGhUYWc6V2Vi TWVudUl0ZW1UYWdMb29rVXBJbkRpY3Rpb25hcnkgdGFyZ2V0Om5pbCByZXByZXNlbnRlZE9iamVj dDplbGVtZW50XV07Ci0gICAgW21lbnVJdGVtcyBhZGRPYmplY3Q6W05TTWVudUl0ZW0gc2VwYXJh dG9ySXRlbV1dOworCisgICAgaWYgKFtbZWxlbWVudCBvYmplY3RGb3JLZXk6V2ViRWxlbWVudElz U2VsZWN0ZWRLZXldIGJvb2xWYWx1ZV0pIHsKKyAgICAgICAgW21lbnVJdGVtcyBhZGRPYmplY3Q6 W3NlbGYgbWVudUl0ZW1XaXRoVGFnOldlYk1lbnVJdGVtVGFnU2VhcmNoSW5TcG90bGlnaHQgdGFy Z2V0Om5pbCByZXByZXNlbnRlZE9iamVjdDplbGVtZW50XV07CisgICAgICAgIFttZW51SXRlbXMg YWRkT2JqZWN0OltzZWxmIG1lbnVJdGVtV2l0aFRhZzpXZWJNZW51SXRlbVRhZ1NlYXJjaFdlYiB0 YXJnZXQ6bmlsIHJlcHJlc2VudGVkT2JqZWN0OmVsZW1lbnRdXTsKKyAgICAgICAgW21lbnVJdGVt cyBhZGRPYmplY3Q6W05TTWVudUl0ZW0gc2VwYXJhdG9ySXRlbV1dOworCisgICAgICAgIC8vIEZJ WE1FOiBUaGUgTlNUZXh0VmlldyBiZWhhdmlvciBmb3IgbG9va2luZyB0ZXh0IHVwIGluIHRoZSBk aWN0aW9uYXJ5IGlzIGRpZmZlcmVudCBpZgorICAgICAgICAvLyB0aGVyZSB3YXMgYSBzZWxlY3Rp b24gYmVmb3JlIHlvdSBjbGlja2VkIHRoYW4gaWYgdGhlIHNlbGVjdGlvbiB3YXMgY3JlYXRlZCBh cyBwYXJ0IG9mCisgICAgICAgIC8vIHRoZSBjbGljay4gVGhpcyBpcyBkZXNpcmVkIGJ5IHRoZSBk aWN0aW9uYXJ5IGZvbGtzIGFwcGFyZW50bHksIHRob3VnaCBpdCBzZWVtcyBiaXphcnJlLgorICAg ICAgICAvLyBJdCBtaWdodCBiZSB0cmlja3kgdG8gcHVsbCB0aGlzIG9mZiBpbiBXZWJLaXQuCisg ICAgICAgIFttZW51SXRlbXMgYWRkT2JqZWN0OltzZWxmIG1lbnVJdGVtV2l0aFRhZzpXZWJNZW51 SXRlbVRhZ0xvb2tVcEluRGljdGlvbmFyeSB0YXJnZXQ6bmlsIHJlcHJlc2VudGVkT2JqZWN0OmVs ZW1lbnRdXTsKKyAgICAgICAgW21lbnVJdGVtcyBhZGRPYmplY3Q6W05TTWVudUl0ZW0gc2VwYXJh dG9ySXRlbV1dOworICAgIH0KICAgICAKICAgICAvLyBMb2FkIG91ciBOU1RleHRWaWV3LWxpa2Ug Y29udGV4dCBtZW51IG5pYi4KICAgICBpZiAoZGVmYXVsdE1lbnUgPT0gbmlsKSB7Cg==