<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>96236</bug_id>
          
          <creation_ts>2012-09-10 00:02:00 -0700</creation_ts>
          <short_desc>[JSC] Use StringBuilder::appendNumber() instead of String::number()</short_desc>
          <delta_ts>2012-09-10 12:47:52 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick R. Gansterer">paroga</reporter>
          <assigned_to name="Patrick R. Gansterer">paroga</assigned_to>
          <cc>benjamin</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>715758</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-09-10 00:02:00 -0700</bug_when>
    <thetext>[JSC] Use StringBuilder::appendNumber() instead of String::number()</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715759</commentid>
    <comment_count>1</comment_count>
      <attachid>163049</attachid>
    <who name="Patrick R. Gansterer">paroga</who>
    <bug_when>2012-09-10 00:04:02 -0700</bug_when>
    <thetext>Created attachment 163049
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>716355</commentid>
    <comment_count>2</comment_count>
      <attachid>163049</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2012-09-10 12:22:54 -0700</bug_when>
    <thetext>Comment on attachment 163049
Patch

It looks better too.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>716381</commentid>
    <comment_count>3</comment_count>
      <attachid>163049</attachid>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-10 12:47:50 -0700</bug_when>
    <thetext>Comment on attachment 163049
Patch

Clearing flags on attachment: 163049

Committed r128091: &lt;http://trac.webkit.org/changeset/128091&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>716382</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Review Bot">webkit.review.bot</who>
    <bug_when>2012-09-10 12:47:52 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>163049</attachid>
            <date>2012-09-10 00:04:02 -0700</date>
            <delta_ts>2012-09-10 12:47:50 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96236.patch</filename>
            <type>text/plain</type>
            <size>1605</size>
            <attacher name="Patrick R. Gansterer">paroga</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0UmVmLmNwcCBi
L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNDb250ZXh0UmVmLmNwcAppbmRleCA3YzgxNTM1
Li5lMmExMDI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTQ29udGV4
dFJlZi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0NvbnRleHRSZWYuY3Bw
CkBAIC0xODUsOSArMTg1LDcgQEAgSlNTdHJpbmdSZWYgSlNDb250ZXh0Q3JlYXRlQmFja3RyYWNl
KEpTQ29udGV4dFJlZiBjdHgsIHVuc2lnbmVkIG1heFN0YWNrU2l6ZSkKICAgICAgICAgaW50cHRy
X3Qgc291cmNlSUQ7CiAgICAgICAgIFN0cmluZyB1cmxTdHJpbmc7CiAgICAgICAgIEpTVmFsdWUg
ZnVuY3Rpb247Ci0gICAgICAgIAotICAgICAgICBTdHJpbmcgbGV2ZWxTdHIgPSBTdHJpbmc6Om51
bWJlcihjb3VudCk7Ci0gICAgICAgIAorCiAgICAgICAgIGV4ZWMtPmludGVycHJldGVyKCktPnJl
dHJpZXZlTGFzdENhbGxlcihjYWxsRnJhbWUsIHNpZ25lZExpbmVOdW1iZXIsIHNvdXJjZUlELCB1
cmxTdHJpbmcsIGZ1bmN0aW9uKTsKIAogICAgICAgICBpZiAoZnVuY3Rpb24pCkBAIC0yMDIsNyAr
MjAwLDcgQEAgSlNTdHJpbmdSZWYgSlNDb250ZXh0Q3JlYXRlQmFja3RyYWNlKEpTQ29udGV4dFJl
ZiBjdHgsIHVuc2lnbmVkIG1heFN0YWNrU2l6ZSkKICAgICAgICAgaWYgKCFidWlsZGVyLmlzRW1w
dHkoKSkKICAgICAgICAgICAgIGJ1aWxkZXIuYXBwZW5kKCdcbicpOwogICAgICAgICBidWlsZGVy
LmFwcGVuZCgnIycpOwotICAgICAgICBidWlsZGVyLmFwcGVuZChsZXZlbFN0cik7CisgICAgICAg
IGJ1aWxkZXIuYXBwZW5kTnVtYmVyKGNvdW50KTsKICAgICAgICAgYnVpbGRlci5hcHBlbmQoJyAn
KTsKICAgICAgICAgYnVpbGRlci5hcHBlbmQoZnVuY3Rpb25OYW1lKTsKICAgICAgICAgYnVpbGRl
ci5hcHBlbmRMaXRlcmFsKCIoKSBhdCAiKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDQx
MDhhNzMuLjUxZjE2ZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM
b2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBA
CisyMDEyLTA5LTEwICBQYXRyaWNrIEdhbnN0ZXJlciAgPHBhcm9nYUB3ZWJraXQub3JnPgorCisg
ICAgICAgIFtKU0NdIFVzZSBTdHJpbmdCdWlsZGVyOjphcHBlbmROdW1iZXIoKSBpbnN0ZWFkIG9m
IFN0cmluZzo6bnVtYmVyKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i
dWcuY2dpP2lkPTk2MjM2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgKiBBUEkvSlNDb250ZXh0UmVmLmNwcDoKKyAgICAgICAgKEpTQ29udGV4dENyZWF0
ZUJhY2t0cmFjZSk6CisKIDIwMTItMDktMDYgIFBhdHJpY2sgR2Fuc3RlcmVyICA8cGFyb2dhQHdl
YmtpdC5vcmc+CiAKICAgICAgICAgQWRkIFN0cmluZ0J1aWxkZXI6OmFwcGVuZE51bWJlcigpIGFu
ZCB1c2UgaXQK
</data>

          </attachment>
      

    </bug>

</bugzilla>