96219 2012-09-09 14:58:41 -0700 AX: Update Windows port accessible role mappings to fix some tests 2012-09-10 14:37:07 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dmazzoni dmazzoni roger_fong webkit.review.bot oldest_to_newest 715611 0 dmazzoni 2012-09-09 14:58:41 -0700 Tests currently failing due to https://bugs.webkit.org/show_bug.cgi?id=94870: accessibility/adjacent-continuations-cause-assertion-failure.html accessibility/deleting-iframe-destroys-axcache.html accessibility/div-within-anchors-causes-crash.html 715612 1 dmazzoni 2012-09-09 15:00:58 -0700 I'm uploading a patch that should fix the tests. While I was at it, I tried to map a few more accessible roles on Windows - the ones that I'm reasonably confident about based on the Chromium source code. Roger, could you patch this in and see if it fixes these three tests and doesn't break anything else on Windows? 715614 2 163015 dmazzoni 2012-09-09 15:04:30 -0700 Created attachment 163015 Patch 715620 3 163015 buildbot 2012-09-09 15:28:48 -0700 Comment on attachment 163015 Patch Attachment 163015 did not pass win-ews (win): Output: http://queues.webkit.org/results/13805300 715660 4 163024 dmazzoni 2012-09-09 19:02:06 -0700 Created attachment 163024 Patch 716147 5 163024 webkit.review.bot 2012-09-10 09:16:39 -0700 Comment on attachment 163024 Patch Clearing flags on attachment: 163024 Committed r128066: <http://trac.webkit.org/changeset/128066> 716148 6 webkit.review.bot 2012-09-10 09:16:43 -0700 All reviewed patches have been landed. Closing bug. 716523 7 roger_fong 2012-09-10 14:37:07 -0700 Hello, sorry I didn't check this earlier. But the patch has landed, the tests aren't failing and everything still builds, so I guess it's good :) 163015 2012-09-09 15:04:30 -0700 2012-09-09 19:01:34 -0700 Patch bug-96219-20120909150429.patch text/plain 2510 dmazzoni SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzk5NykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTA5 ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgorCisgICAgICAgIEFYOiBV cGRhdGUgV2luZG93cyBwb3J0IGFjY2Vzc2libGUgcm9sZSBtYXBwaW5ncyB0byBmaXggc29tZSB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYy MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRh dGUgYSBidW5jaCBvZiBhY2Nlc3NpYmxlIHJvbGUgbWFwcGluZ3MgdG8gZml4IHRlc3RzIGFuZCBp bXByb3ZlIHdpbgorICAgICAgICBhY2Nlc3NpYmlsaXR5LgorCisgICAgICAgICogQWNjZXNzaWJs ZUJhc2UuY3BwOgorICAgICAgICAoTVNBQVJvbGUpOgorCiAyMDEyLTA5LTA3ICBBbGxhbiBTYW5k ZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5 IGhpdFRlc3RSZXN1bHRBdFBvaW50IGFuZCBub2Rlc0Zyb21SZWN0IEFQSXMKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L3dpbi9BY2Nlc3NpYmxlQmFzZS5jcHAJKHJldmlzaW9uIDEyNzk5MCkKKysrIFNvdXJjZS9X ZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjY5LDYgKzY2 OSwzOCBAQCBzdGF0aWMgbG9uZyBNU0FBUm9sZShBY2Nlc3NpYmlsaXR5Um9sZSByCiAgICAgICAg ICAgICByZXR1cm4gUk9MRV9TWVNURU1fTElTVElURU07CiAgICAgICAgIGNhc2UgV2ViQ29yZTo6 UG9wVXBCdXR0b25Sb2xlOgogICAgICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX0NPTUJPQk9Y OworICAgICAgICBjYXNlIFdlYkNvcmU6OkRpdlJvbGU6CisgICAgICAgIGNhc2UgV2ViQ29yZTo6 Rm9ybVJvbGU6CisgICAgICAgIGNhc2UgV2ViQ29yZTo6TGFiZWxSb2xlOgorICAgICAgICBjYXNl IFdlYkNvcmU6OlBhcmFncmFwaFJvbGU6CisgICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1f R1JPVVBJTkc7CisgICAgICAgIGNhc2UgV2ViQ29yZTo6SG9yaXpvbnRhbFJ1bGVSb2xlOgorICAg ICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX1NFUEFSQVRPUjsKKyAgICAgICAgY2FzZSBXZWJD b3JlOjpBbGVydFJvbGU6CisgICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1fQUxFUlQ7Cisg ICAgICAgIGNhc2UgV2ViQ29yZTo6Q2FudmFzUm9sZToKKyAgICAgICAgICAgIHJldHVybiBST0xF X1NZU1RFTV9HUkFQSElDOworICAgICAgICBjYXNlIFdlYkNvcmU6OkNvbWJvQm94Um9sZToKKyAg ICAgICAgICAgIHJldHVybiBST0xFX1NZU1RFTV9DT01CT0JPWDsKKyAgICAgICAgY2FzZSBXZWJD b3JlOjpTcGluQnV0dG9uUm9sZToKKyAgICAgICAgICAgIHJldHVybiBST0xFX1NZU1RFTV9TUElO QlVUVE9OOworICAgICAgICBjYXNlIFdlYkNvcmU6OlNwaW5CdXR0b25QYXJ0Um9sZToKKyAgICAg ICAgICAgIHJldHVybiBST0xFX1NZU1RFTV9QVVNIQlVUVE9OOworICAgICAgICBjYXNlIFdlYkNv cmU6OlRvZ2dsZUJ1dHRvblJvbGU6CisgICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1fUFVT SEJVVFRPTjsKKyAgICAgICAgY2FzZSBXZWJDb3JlOjpUb29sYmFyUm9sZToKKyAgICAgICAgICAg IHJldHVybiBST0xFX1NZU1RFTV9UT09MQkFSOworICAgICAgICBjYXNlIFdlYkNvcmU6OlRvb2x0 aXBSb2xlOgorICAgICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX1RPT0xUSVA7CisgICAgICAg IGNhc2UgV2ViQ29yZTo6VHJlZVJvbGU6CisgICAgICAgIGNhc2UgV2ViQ29yZTo6VHJlZUdyaWRS b2xlOgorICAgICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX09VVExJTkU7CisgICAgICAgIGNh c2UgV2ViQ29yZTo6VHJlZUl0ZW1Sb2xlOgorICAgICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVN X09VVExJTkVJVEVNOworICAgICAgICBjYXNlIFdlYkNvcmU6OlRhYkxpc3RSb2xlOgorICAgICAg ICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX1BBR0VUQUJMSVNUOworICAgICAgICBjYXNlIFdlYkNv cmU6OlRhYlBhbmVsUm9sZToKKyAgICAgICAgICAgIHJldHVybiBST0xFX1NZU1RFTV9QUk9QRVJU WVBBR0U7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICAvLyBUaGlzIGlzIHRoZSBkZWZh dWx0IHJvbGUgZm9yIE1TQUEuCiAgICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1fQ0xJRU5U Owo= 163024 2012-09-09 19:02:06 -0700 2012-09-10 09:16:39 -0700 Patch bug-96219-20120909190205.patch text/plain 2458 dmazzoni SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDEyNzk5NykKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTA5 ICBEb21pbmljIE1henpvbmkgIDxkbWF6em9uaUBnb29nbGUuY29tPgorCisgICAgICAgIEFYOiBV cGRhdGUgV2luZG93cyBwb3J0IGFjY2Vzc2libGUgcm9sZSBtYXBwaW5ncyB0byBmaXggc29tZSB0 ZXN0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYy MTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRh dGUgYSBidW5jaCBvZiBhY2Nlc3NpYmxlIHJvbGUgbWFwcGluZ3MgdG8gZml4IHRlc3RzIGFuZCBp bXByb3ZlIHdpbgorICAgICAgICBhY2Nlc3NpYmlsaXR5LgorCisgICAgICAgICogQWNjZXNzaWJs ZUJhc2UuY3BwOgorICAgICAgICAoTVNBQVJvbGUpOgorCiAyMDEyLTA5LTA3ICBBbGxhbiBTYW5k ZmVsZCBKZW5zZW4gIDxhbGxhbi5qZW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFNpbXBsaWZ5 IGhpdFRlc3RSZXN1bHRBdFBvaW50IGFuZCBub2Rlc0Zyb21SZWN0IEFQSXMKSW5kZXg6IFNvdXJj ZS9XZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0L3dpbi9BY2Nlc3NpYmxlQmFzZS5jcHAJKHJldmlzaW9uIDEyNzk5MCkKKysrIFNvdXJjZS9X ZWJLaXQvd2luL0FjY2Vzc2libGVCYXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjY5LDYgKzY2 OSwzNiBAQCBzdGF0aWMgbG9uZyBNU0FBUm9sZShBY2Nlc3NpYmlsaXR5Um9sZSByCiAgICAgICAg ICAgICByZXR1cm4gUk9MRV9TWVNURU1fTElTVElURU07CiAgICAgICAgIGNhc2UgV2ViQ29yZTo6 UG9wVXBCdXR0b25Sb2xlOgogICAgICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX0NPTUJPQk9Y OworICAgICAgICBjYXNlIFdlYkNvcmU6OkRpdlJvbGU6CisgICAgICAgIGNhc2UgV2ViQ29yZTo6 Rm9ybVJvbGU6CisgICAgICAgIGNhc2UgV2ViQ29yZTo6TGFiZWxSb2xlOgorICAgICAgICBjYXNl IFdlYkNvcmU6OlBhcmFncmFwaFJvbGU6CisgICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1f R1JPVVBJTkc7CisgICAgICAgIGNhc2UgV2ViQ29yZTo6SG9yaXpvbnRhbFJ1bGVSb2xlOgorICAg ICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX1NFUEFSQVRPUjsKKyAgICAgICAgY2FzZSBXZWJD b3JlOjpBcHBsaWNhdGlvbkFsZXJ0Um9sZToKKyAgICAgICAgICAgIHJldHVybiBST0xFX1NZU1RF TV9BTEVSVDsKKyAgICAgICAgY2FzZSBXZWJDb3JlOjpDb21ib0JveFJvbGU6CisgICAgICAgICAg ICByZXR1cm4gUk9MRV9TWVNURU1fQ09NQk9CT1g7CisgICAgICAgIGNhc2UgV2ViQ29yZTo6U3Bp bkJ1dHRvblJvbGU6CisgICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1fU1BJTkJVVFRPTjsK KyAgICAgICAgY2FzZSBXZWJDb3JlOjpTcGluQnV0dG9uUGFydFJvbGU6CisgICAgICAgICAgICBy ZXR1cm4gUk9MRV9TWVNURU1fUFVTSEJVVFRPTjsKKyAgICAgICAgY2FzZSBXZWJDb3JlOjpUb2dn bGVCdXR0b25Sb2xlOgorICAgICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX1BVU0hCVVRUT047 CisgICAgICAgIGNhc2UgV2ViQ29yZTo6VG9vbGJhclJvbGU6CisgICAgICAgICAgICByZXR1cm4g Uk9MRV9TWVNURU1fVE9PTEJBUjsKKyAgICAgICAgY2FzZSBXZWJDb3JlOjpVc2VySW50ZXJmYWNl VG9vbHRpcFJvbGU6CisgICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1fVE9PTFRJUDsKKyAg ICAgICAgY2FzZSBXZWJDb3JlOjpUcmVlUm9sZToKKyAgICAgICAgY2FzZSBXZWJDb3JlOjpUcmVl R3JpZFJvbGU6CisgICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1fT1VUTElORTsKKyAgICAg ICAgY2FzZSBXZWJDb3JlOjpUcmVlSXRlbVJvbGU6CisgICAgICAgICAgICByZXR1cm4gUk9MRV9T WVNURU1fT1VUTElORUlURU07CisgICAgICAgIGNhc2UgV2ViQ29yZTo6VGFiTGlzdFJvbGU6Cisg ICAgICAgICAgICByZXR1cm4gUk9MRV9TWVNURU1fUEFHRVRBQkxJU1Q7CisgICAgICAgIGNhc2Ug V2ViQ29yZTo6VGFiUGFuZWxSb2xlOgorICAgICAgICAgICAgcmV0dXJuIFJPTEVfU1lTVEVNX1BS T1BFUlRZUEFHRTsKICAgICAgICAgZGVmYXVsdDoKICAgICAgICAgICAgIC8vIFRoaXMgaXMgdGhl IGRlZmF1bHQgcm9sZSBmb3IgTVNBQS4KICAgICAgICAgICAgIHJldHVybiBST0xFX1NZU1RFTV9D TElFTlQ7Cg==