96213 2012-09-09 12:52:41 -0700 [chromium] webkit_platform should only be linked into the webkit target 2012-09-09 14:04:23 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dpranke enne tony oldest_to_newest 715554 0 jamesr 2012-09-09 12:52:41 -0700 [chromium] webkit_platform should only be linked into the webkit target 715557 1 163008 jamesr 2012-09-09 12:53:44 -0700 Created attachment 163008 Patch 715558 2 jamesr 2012-09-09 12:54:45 -0700 Motivation here is to be able to statically link in some of these targets without accidentally pulling in copies of WEBKIT_EXPORT'd symbols outside of webkit.dll 715569 3 163008 enne 2012-09-09 13:17:58 -0700 Comment on attachment 163008 Patch R=me. 715570 4 163008 abarth 2012-09-09 13:17:58 -0700 Comment on attachment 163008 Patch Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target? 715571 5 enne 2012-09-09 13:24:01 -0700 (In reply to comment #3) > (From update of attachment 163008 [details]) > Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target? Yeah, it's unfortunate. I think having both webkit_wtf_support and webcore_prerequisites export the include_dirs as a dependent setting is about as good as you can get. And yeah, we do already add Platform.gyp:webkit_platform to the webkit target. 715572 6 jamesr 2012-09-09 13:25:01 -0700 (In reply to comment #3) > (From update of attachment 163008 [details]) > Ok. It's lame that we have to add these include_dirs explicitly. I guess we already add Platform.gyp:webkit_platform as an explicit dependency of the webkit target? Yes: http://trac.webkit.org/browser/trunk/Source/WebKit/chromium/WebKit.gyp#L74 715573 7 abarth 2012-09-09 13:31:56 -0700 ok 715582 8 163008 jamesr 2012-09-09 14:04:19 -0700 Comment on attachment 163008 Patch Clearing flags on attachment: 163008 Committed r127995: <http://trac.webkit.org/changeset/127995> 715583 9 jamesr 2012-09-09 14:04:23 -0700 All reviewed patches have been landed. Closing bug. 163008 2012-09-09 12:53:44 -0700 2012-09-09 14:04:19 -0700 Patch bug-96213-20120909125321.patch text/plain 4726 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3OTU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmYwMzNhNjBhMzU4MTRk M2U4MzJmMWViYzM5NzBmYzRiNGQ4MjIyMS4uMWVmOTgyNGExZDRmMDNhMTI3ZmYzM2U5Y2Q1NjEw MDk1ZTIxY2YyOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTA5ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSB3 ZWJraXRfcGxhdGZvcm0gc2hvdWxkIG9ubHkgYmUgbGlua2VkIGludG8gdGhlIHdlYmtpdCB0YXJn ZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MjEz CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIFBs YXRmb3JtLmd5cDp3ZWJraXRfcGxhdGZvcm0gdGFyZ2V0IHByb3ZpZGVzIHRoZSBpbXBsZW1lbnRh dGlvbiBvZiBzZXZlcmFsIFdFQktJVF9FWFBPUlRlZCBzeW1ib2xzLiBJdCBvbmx5CisgICAgICAg IG1ha2VzIHNlbnNlIGFzIGEgdGFyZ2V0IG9mIFdlYktpdC5neXA6d2Via2l0LCBvdGhlciB0YXJn ZXRzIHNob3VsZG4ndCBkaXJlY3RseSBkZXBlbmQgb24gaXQuCisKKyAgICAgICAgKiBXZWJDb3Jl Lmd5cC9XZWJDb3JlLmd5cDoKKwogMjAxMi0wOS0wNiAgSmVmZnJleSBQZmF1ICA8anBmYXVAYXBw bGUuY29tPgogCiAgICAgICAgIEV4dGVuZCB0aGlyZC1wYXJ0eSBzdG9yYWdlIGJsb2NraW5nIEFQ SSB0byBvcHRpb25hbGx5IGFsbG93IGJsb2NraW5nIGFsbCBzdG9yYWdlCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDA2NTBiNTI0ZTRjMjliMjBlYTgyYmE4NDY4ZmFmMWNhYzk0OTdkNTUu LjBlN2JhNmQ4NDVlZmYwMjlmMzUxNjMxYTM2NmFlZmU4MTJlNmRkNTYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTItMDktMDkgIEphbWVzIFJvYmluc29u ICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBbY2hyb21pdW1dIHdlYmtpdF9wbGF0 Zm9ybSBzaG91bGQgb25seSBiZSBsaW5rZWQgaW50byB0aGUgd2Via2l0IHRhcmdldAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYyMTMKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgUGxhdGZvcm0uZ3lw OndlYmtpdF9wbGF0Zm9ybSB0YXJnZXQgcHJvdmlkZXMgdGhlIGltcGxlbWVudGF0aW9uIG9mIHNl dmVyYWwgV0VCS0lUX0VYUE9SVGVkIHN5bWJvbHMuIEl0IG9ubHkKKyAgICAgICAgbWFrZXMgc2Vu c2UgYXMgYSB0YXJnZXQgb2YgV2ViS2l0Lmd5cDp3ZWJraXQsIG90aGVyIHRhcmdldHMgc2hvdWxk bid0IGRpcmVjdGx5IGRlcGVuZCBvbiBpdC4KKworICAgICAgICAqIFdlYktpdC5neXA6CisKIDIw MTItMDktMDcgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBbY2hyb21pdW1dIFJlbW92ZSB0cmFuc2l0aW9uYWwgV2ViQ29tcG9zaXRvclN1cHBvcnQgZmFs bGJhY2sgY29kZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29y ZS5neXAgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCAzZjE2 ZDk0ZDNkZDExMmNlMGRiMzkzYjc4NWJlNzhiNjNjNjk2ZTA2Li42NjVkNmEzZDBhNzM5YWZhNmMw ZWJmMWRmMjM2YTc4YTQ5NmQxM2I0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3Jl Lmd5cC9XZWJDb3JlLmd5cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3Jl Lmd5cApAQCAtMTMzNSw3ICsxMzM1LDYgQEAKICAgICAgICAgJy4uLy4uL1RoaXJkUGFydHkvZ2x1 L2dsdS5neXA6bGlidGVzcycsCiAgICAgICAgICcuLi8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2Ny aXB0Q29yZS5neXAvSmF2YVNjcmlwdENvcmUuZ3lwOnlhcnInLAogICAgICAgICAnLi4vLi4vV1RG L1dURi5neXAvV1RGLmd5cDp3dGYnLAotICAgICAgICAnLi4vLi4vUGxhdGZvcm0vUGxhdGZvcm0u Z3lwL1BsYXRmb3JtLmd5cDp3ZWJraXRfcGxhdGZvcm0nLAogICAgICAgICAnPChjaHJvbWl1bV9z cmNfZGlyKS9idWlsZC90ZW1wX2d5cC9nb29nbGV1cmwuZ3lwOmdvb2dsZXVybCcsCiAgICAgICAg ICc8KGNocm9taXVtX3NyY19kaXIpL3NraWEvc2tpYS5neXA6c2tpYScsCiAgICAgICAgICc8KGNo cm9taXVtX3NyY19kaXIpL3RoaXJkX3BhcnR5L2ljY2pwZWcvaWNjanBlZy5neXA6aWNjanBlZycs CkBAIC0xMzU1LDcgKzEzNTQsNiBAQAogICAgICAgJ2V4cG9ydF9kZXBlbmRlbnRfc2V0dGluZ3Mn OiBbCiAgICAgICAgICcuLi8uLi9KYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5neXAvSmF2 YVNjcmlwdENvcmUuZ3lwOnlhcnInLAogICAgICAgICAnLi4vLi4vV1RGL1dURi5neXAvV1RGLmd5 cDp3dGYnLAotICAgICAgICAnLi4vLi4vUGxhdGZvcm0vUGxhdGZvcm0uZ3lwL1BsYXRmb3JtLmd5 cDp3ZWJraXRfcGxhdGZvcm0nLAogICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9idWlsZC90 ZW1wX2d5cC9nb29nbGV1cmwuZ3lwOmdvb2dsZXVybCcsCiAgICAgICAgICc8KGNocm9taXVtX3Ny Y19kaXIpL3NraWEvc2tpYS5neXA6c2tpYScsCiAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIp L3RoaXJkX3BhcnR5L2ljY2pwZWcvaWNjanBlZy5neXA6aWNjanBlZycsCkBAIC0xMzgwLDYgKzEz NzgsNyBAQAogICAgICAgICAgICdXRUJDT1JFX05BVklHQVRPUl9WRU5ET1I9Ikdvb2dsZSBJbmMu IicsCiAgICAgICAgIF0sCiAgICAgICAgICdpbmNsdWRlX2RpcnMnOiBbCisgICAgICAgICAgJy4u Ly4uL1BsYXRmb3JtL2Nocm9taXVtJywKICAgICAgICAgICAnPChJTlRFUk1FRElBVEVfRElSKScs CiAgICAgICAgICAgJzxAKHdlYmNvcmVfaW5jbHVkZV9kaXJzKScsCiAgICAgICAgICAgJzwoY2hy b21pdW1fc3JjX2RpcikvZ3B1JywKQEAgLTIxNDYsNyArMjE0NSw2IEBACiAgICAgICAgICd3ZWJj b3JlX3JlbmRlcmluZycsCiAgICAgICAgICMgRXhwb3J0ZWQuCiAgICAgICAgICd3ZWJjb3JlX2Jp bmRpbmdzJywKLSAgICAgICAgJy4uLy4uL1BsYXRmb3JtL1BsYXRmb3JtLmd5cC9QbGF0Zm9ybS5n eXA6d2Via2l0X3BsYXRmb3JtJywKICAgICAgICAgJy4uLy4uL1dURi9XVEYuZ3lwL1dURi5neXA6 d3RmJywKICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2RpcikvYnVpbGQvdGVtcF9neXAvZ29vZ2xl dXJsLmd5cDpnb29nbGV1cmwnLAogICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9za2lhL3Nr aWEuZ3lwOnNraWEnLApAQCAtMjE1Niw3ICsyMTU0LDYgQEAKICAgICAgIF0sCiAgICAgICAnZXhw b3J0X2RlcGVuZGVudF9zZXR0aW5ncyc6IFsKICAgICAgICAgJ3dlYmNvcmVfYmluZGluZ3MnLAot ICAgICAgICAnLi4vLi4vUGxhdGZvcm0vUGxhdGZvcm0uZ3lwL1BsYXRmb3JtLmd5cDp3ZWJraXRf cGxhdGZvcm0nLAogICAgICAgICAnLi4vLi4vV1RGL1dURi5neXAvV1RGLmd5cDp3dGYnLAogICAg ICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS9idWlsZC90ZW1wX2d5cC9nb29nbGV1cmwuZ3lwOmdv b2dsZXVybCcsCiAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3NraWEvc2tpYS5neXA6c2tp YScsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAgYi9Tb3Vy Y2UvV2ViS2l0L2Nocm9taXVtL1dlYktpdC5neXAKaW5kZXggZjZjZDkzNGQxYmU4NmZiY2EzNTYz YmNkZmU1ZGZjNmYyZTY0NzFlNC4uMTc5YWQ1MGVmZmU3ZTk2ZWE3ZTUyZDVhYmY0NDEwNThlNjY2 YzAyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCisrKyBi L1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vV2ViS2l0Lmd5cApAQCAtODY1LDEyICs4NjUsMTQgQEAK ICAgICAgICAgICAgICd0YXJnZXRfbmFtZSc6ICd3ZWJraXRfd3RmX3N1cHBvcnQnLAogICAgICAg ICAgICAgJ3R5cGUnOiAnc3RhdGljX2xpYnJhcnknLAogICAgICAgICAgICAgJ2RlcGVuZGVuY2ll cyc6IFsKLSAgICAgICAgICAgICAgICAnLi4vLi4vUGxhdGZvcm0vUGxhdGZvcm0uZ3lwL1BsYXRm b3JtLmd5cDp3ZWJraXRfcGxhdGZvcm0nLAogICAgICAgICAgICAgICAgICcuLi8uLi9XVEYvV1RG Lmd5cC9XVEYuZ3lwOnd0ZicsCiAgICAgICAgICAgICBdLAogICAgICAgICAgICAgJ2RlZmluZXMn OiBbCiAgICAgICAgICAgICAgICAgJ1dFQktJVF9JTVBMRU1FTlRBVElPTj0xJywKICAgICAgICAg ICAgIF0sCisgICAgICAgICAgICAnaW5jbHVkZV9kaXJzJzogWworICAgICAgICAgICAgICAgICcu Li8uLi9QbGF0Zm9ybS9jaHJvbWl1bScsCisgICAgICAgICAgICBdLAogICAgICAgICAgICAgJ3Nv dXJjZXMnOiBbCiAgICAgICAgICAgICAgICAgJ3NyYy9DaHJvbWl1bUN1cnJlbnRUaW1lLmNwcCcs CiAgICAgICAgICAgICAgICAgJ3NyYy9DaHJvbWl1bU9TUmFuZG9tU291cmNlLmNwcCcsCg==