<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>96202</bug_id>
          
          <creation_ts>2012-09-09 05:06:46 -0700</creation_ts>
          <short_desc>Clean up the code in XvfbDriver</short_desc>
          <delta_ts>2012-09-09 23:54:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zan Dobersek">zan</reporter>
          <assigned_to name="Zan Dobersek">zan</assigned_to>
          <cc>abarth</cc>
    
    <cc>dpranke</cc>
    
    <cc>galpeter</cc>
    
    <cc>kkristof</cc>
    
    <cc>mrobinson</cc>
    
    <cc>ojan</cc>
    
    <cc>ossy</cc>
    
    <cc>pnormand</cc>
    
    <cc>webkit.review.bot</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>715480</commentid>
    <comment_count>0</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2012-09-09 05:06:46 -0700</bug_when>
    <thetext>Clean up the code in XvfbDriver</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715481</commentid>
    <comment_count>1</comment_count>
      <attachid>162990</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2012-09-09 05:11:09 -0700</bug_when>
    <thetext>Created attachment 162990
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715752</commentid>
    <comment_count>2</comment_count>
      <attachid>162990</attachid>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2012-09-09 23:54:11 -0700</bug_when>
    <thetext>Comment on attachment 162990
Patch

Clearing flags on attachment: 162990

Committed r128020: &lt;http://trac.webkit.org/changeset/128020&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>715753</commentid>
    <comment_count>3</comment_count>
    <who name="Zan Dobersek">zan</who>
    <bug_when>2012-09-09 23:54:16 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>162990</attachid>
            <date>2012-09-09 05:11:09 -0700</date>
            <delta_ts>2012-09-09 23:54:11 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-96202-20120909051047.patch</filename>
            <type>text/plain</type>
            <size>3131</size>
            <attacher name="Zan Dobersek">zan</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3ODUzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg
Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTJmYWYyZDczNDQ2NDM4YzgyMWM2YTIxNjNmMGRmOWYy
OGZmMDFiNS4uMzFiYWEwOGNiODM0MDg3ZDA4MjNjZWJiOTk2NTM2ZGRiODQ1OWI2NiAxMDA2NDQK
LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIx
IEBACisyMDEyLTA5LTA5ICBaYW4gRG9iZXJzZWsgIDx6YW5kb2JlcnNla0BnbWFpbC5jb20+CisK
KyAgICAgICAgQ2xlYW4gdXAgdGhlIGNvZGUgaW4gWHZmYkRyaXZlcgorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYyMDIKKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFuZ2VzOgorICAgICAgICAtIFJlbW92
ZSB1bm5lZWRlZCBpbXBvcnRzLAorICAgICAgICAtIGFzc2lnbiB0aGUgX2xvY2tfZmlsZSBtZW1i
ZXIgdmFyaWFibGUgd2hlbiB0aGUgZGlzcGxheSBudW1iZXIgaXMgZGV0ZXJtaW5lZCwKKyAgICAg
ICAgLSBubyBuZWVkIGZvciBwYXJlbnRoZXNlcyBhcm91bmQgYSBzaW5nbGUgc3RyaW5nIGZvcm1h
dCBhcmd1bWVudCwKKyAgICAgICAgLSB1c2UgRmlsZVN5c3RlbS5leGlzdHMgbWV0aG9kIHdoZW4g
Y2hlY2tpbmcgaWYgbG9jayBmaWxlIGlzIHByZXNlbnQgYXMgaXQKKyAgICAgICAgbWFrZXMgdGhl
IGludGVudGlvbiBtdWNoIG1vcmUgY2xlYXJlci4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0
cHkvbGF5b3V0X3Rlc3RzL3BvcnQveHZmYmRyaXZlci5weToKKyAgICAgICAgKFh2ZmJEcml2ZXIu
X3N0YXJ0KToKKyAgICAgICAgKFh2ZmJEcml2ZXIuc3RvcCk6CisKIDIwMTItMDktMDcgIENzYWJh
IE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiBB
ZGQgR8OhYm9yIEJhbGxhYsOhcyBhcyBjb250cmlidXRvci4KZGlmZiAtLWdpdCBhL1Rvb2xzL1Nj
cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQveHZmYmRyaXZlci5weSBiL1Rvb2xzL1Nj
cmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3BvcnQveHZmYmRyaXZlci5weQppbmRleCBkMTA4
MjM1ZjFkNjMzNmE5Nzc4MjMyNjViZjQ5MjZjYzNmODA5YTFkLi4yODFiMjE3M2I5YzcyODU5Mzlm
MDk3ZTVmYjk0YzNlMmRkYTEzZjQzIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5
L2xheW91dF90ZXN0cy9wb3J0L3h2ZmJkcml2ZXIucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJr
aXRweS9sYXlvdXRfdGVzdHMvcG9ydC94dmZiZHJpdmVyLnB5CkBAIC0yOCwxMiArMjgsOSBAQAog
CiBpbXBvcnQgbG9nZ2luZwogaW1wb3J0IG9zCi1pbXBvcnQgc2lnbmFsCi1pbXBvcnQgc3VicHJv
Y2VzcwogCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0LnNlcnZlcl9wcm9jZXNzIGlt
cG9ydCBTZXJ2ZXJQcm9jZXNzCiBmcm9tIHdlYmtpdHB5LmxheW91dF90ZXN0cy5wb3J0LmRyaXZl
ciBpbXBvcnQgRHJpdmVyCi1mcm9tIHdlYmtpdHB5LmNvbW1vbi5zeXN0ZW0uZXhlY3V0aXZlIGlt
cG9ydCBFeGVjdXRpdmUKIAogX2xvZyA9IGxvZ2dpbmcuZ2V0TG9nZ2VyKF9fbmFtZV9fKQogCkBA
IC01NCwxNSArNTEsMTcgQEAgY2xhc3MgWHZmYkRyaXZlcihEcml2ZXIpOgogICAgICAgICBkaXNw
bGF5X2lkID0gc2VsZi5fd29ya2VyX251bWJlciAqIDIgKyBydW5uaW5nX2Rpc3BsYXlzCiAgICAg
ICAgIGlmIHBpeGVsX3Rlc3RzOgogICAgICAgICAgICAgZGlzcGxheV9pZCArPSAxCisgICAgICAg
IHNlbGYuX2xvY2tfZmlsZSA9ICIvdG1wLy5YJWQtbG9jayIgJSBkaXNwbGF5X2lkCisKICAgICAg
ICAgcnVuX3h2ZmIgPSBbIlh2ZmIiLCAiOiVkIiAlIGRpc3BsYXlfaWQsICItc2NyZWVuIiwgICIw
IiwgIjgwMHg2MDB4MjQiLCAiLW5vbGlzdGVuIiwgInRjcCJdCiAgICAgICAgIHdpdGggb3Blbihv
cy5kZXZudWxsLCAndycpIGFzIGRldm51bGw6CiAgICAgICAgICAgICBzZWxmLl94dmZiX3Byb2Nl
c3MgPSBzZWxmLl9wb3J0Lmhvc3QuZXhlY3V0aXZlLnBvcGVuKHJ1bl94dmZiLCBzdGRlcnI9ZGV2
bnVsbCkKLSAgICAgICAgc2VsZi5fbG9ja19maWxlID0gIi90bXAvLlglZC1sb2NrIiAlIGRpc3Bs
YXlfaWQKIAogICAgICAgICBzZXJ2ZXJfbmFtZSA9IHNlbGYuX3BvcnQuZHJpdmVyX25hbWUoKQog
ICAgICAgICBlbnZpcm9ubWVudCA9IHNlbGYuX3BvcnQuc2V0dXBfZW52aXJvbl9mb3Jfc2VydmVy
KHNlcnZlcl9uYW1lKQogICAgICAgICAjIFdlIG11c3QgZG8gdGhpcyBoZXJlIGJlY2F1c2UgdGhl
IERJU1BMQVkgbnVtYmVyIGRlcGVuZHMgb24gX3dvcmtlcl9udW1iZXIKLSAgICAgICAgZW52aXJv
bm1lbnRbJ0RJU1BMQVknXSA9ICI6JWQiICUgKGRpc3BsYXlfaWQpCisgICAgICAgIGVudmlyb25t
ZW50WydESVNQTEFZJ10gPSAiOiVkIiAlIGRpc3BsYXlfaWQKKwogICAgICAgICBzZWxmLl9jcmFz
aGVkX3Byb2Nlc3NfbmFtZSA9IE5vbmUKICAgICAgICAgc2VsZi5fY3Jhc2hlZF9waWQgPSBOb25l
CiAgICAgICAgIHNlbGYuX3NlcnZlcl9wcm9jZXNzID0gc2VsZi5fcG9ydC5fc2VydmVyX3Byb2Nl
c3NfY29uc3RydWN0b3Ioc2VsZi5fcG9ydCwgc2VydmVyX25hbWUsIHNlbGYuY21kX2xpbmUocGl4
ZWxfdGVzdHMsIHBlcl90ZXN0X2FyZ3MpLCBlbnZpcm9ubWVudCkKQEAgLTczLDUgKzcyLDUgQEAg
Y2xhc3MgWHZmYkRyaXZlcihEcml2ZXIpOgogICAgICAgICBpZiBnZXRhdHRyKHNlbGYsICdfeHZm
Yl9wcm9jZXNzJywgTm9uZSk6CiAgICAgICAgICAgICBzZWxmLl9wb3J0Lmhvc3QuZXhlY3V0aXZl
LmtpbGxfcHJvY2VzcyhzZWxmLl94dmZiX3Byb2Nlc3MucGlkKQogICAgICAgICAgICAgc2VsZi5f
eHZmYl9wcm9jZXNzID0gTm9uZQotICAgICAgICAgICAgaWYgc2VsZi5fcG9ydC5ob3N0LmZpbGVz
eXN0ZW0uaXNmaWxlKHNlbGYuX2xvY2tfZmlsZSk6CisgICAgICAgICAgICBpZiBzZWxmLl9wb3J0
Lmhvc3QuZmlsZXN5c3RlbS5leGlzdHMoc2VsZi5fbG9ja19maWxlKToKICAgICAgICAgICAgICAg
ICBzZWxmLl9wb3J0Lmhvc3QuZmlsZXN5c3RlbS5yZW1vdmUoc2VsZi5fbG9ja19maWxlKQo=
</data>

          </attachment>
      

    </bug>

</bugzilla>