96190 2012-09-08 22:54:18 -0700 Pass full target idl file path to CodeGenerator as a constructor argument. 2012-09-09 19:08:14 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 96181 1 kangil.han kangil.han abarth haraken japhet webkit.review.bot oldest_to_newest 715411 0 kangil.han 2012-09-08 22:54:18 -0700 It seems passing idl file path to CodeGenerator would be useful because CodeGenerator* family could manipulate it when creating derived header and cpp files. 715438 1 162983 kangil.han 2012-09-09 00:31:59 -0700 Created attachment 162983 patch 715441 2 162983 haraken 2012-09-09 00:35:20 -0700 Comment on attachment 162983 patch View in context: https://bugs.webkit.org/attachment.cgi?id=162983&action=review > Source/WebCore/ChangeLog:8 > + Passing idl file path to CodeGenerator would be useful because CodeGenerator* family could manipulate it when creating derived header and cpp files. What use case are you assuming? 715444 3 kangil.han 2012-09-09 00:41:04 -0700 (In reply to comment #2) > > What use case are you assuming? At this stage, One use case that fills out derived sources with original copyrights. Please refer to BUG 96181. :-) 715446 4 162983 haraken 2012-09-09 00:44:29 -0700 Comment on attachment 162983 patch OK 715447 5 kangil.han 2012-09-09 00:45:40 -0700 (In reply to comment #4) > (From update of attachment 162983 [details]) > OK Thx!! 715661 6 162983 webkit.review.bot 2012-09-09 19:08:11 -0700 Comment on attachment 162983 patch Clearing flags on attachment: 162983 Committed r128010: <http://trac.webkit.org/changeset/128010> 715662 7 webkit.review.bot 2012-09-09 19:08:14 -0700 All reviewed patches have been landed. Closing bug. 162983 2012-09-09 00:31:59 -0700 2012-09-09 19:08:11 -0700 patch idlpath.txt text/plain 2832 kangil.han ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA4ZGZlNGZiLi44MjdmZGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTItMDktMDkgIEthbmdpbCBIYW4gIDxrYW5naWwuaGFuQHNhbXN1bmcuY29tPgorCisg ICAgICAgIFBhc3MgZnVsbCB0YXJnZXQgaWRsIGZpbGUgcGF0aCB0byBDb2RlR2VuZXJhdG9yIGFz IGEgY29uc3RydWN0b3IgYXJndW1lbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD05NjE5MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFBhc3NpbmcgaWRsIGZpbGUgcGF0aCB0byBDb2RlR2VuZXJhdG9yIHdv dWxkIGJlIHVzZWZ1bCBiZWNhdXNlIENvZGVHZW5lcmF0b3IqIGZhbWlseSBjb3VsZCBtYW5pcHVs YXRlIGl0IHdoZW4gY3JlYXRpbmcgZGVyaXZlZCBoZWFkZXIgYW5kIGNwcCBmaWxlcy4KKworICAg ICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvci5wbToKKyAgICAgICAgKG5ldyk6 CisgICAgICAgIChQcm9jZXNzRG9jdW1lbnQpOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMv Z2VuZXJhdGUtYmluZGluZ3MucGw6CisKIDIwMTItMDktMDggIEJlbmphbWluIFBvdWxhaW4gIDxi cG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgU3BlY2lhbGl6ZSBuZXh0QnJlYWthYmxlUG9z aXRpb24gZGVwZW5kaW5nIG9uIGJyZWFrTkJTUApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtIGIvU291cmNlL1dlYkNvcmUvYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCmluZGV4IDg5YmQ3ZjguLjFjMzU2M2E2IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3IucG0K KysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yLnBtCkBA IC0zOCw2ICszOCw3IEBAIG15ICR1c2VMYXllck9uVG9wID0gMDsKIG15ICRwcmVwcm9jZXNzb3I7 CiBteSAkd3JpdGVEZXBlbmRlbmNpZXMgPSAwOwogbXkgJGRlZmluZXMgPSAiIjsKK215ICR0YXJn ZXRJZGxGaWxlUGF0aCA9ICIiOwogCiBteSAkY29kZUdlbmVyYXRvciA9IDA7CiAKQEAgLTEwNyw2 ICsxMDgsNyBAQCBzdWIgbmV3CiAgICAgJHByZXByb2Nlc3NvciA9IHNoaWZ0OwogICAgICR3cml0 ZURlcGVuZGVuY2llcyA9IHNoaWZ0OwogICAgICR2ZXJib3NlID0gc2hpZnQ7CisgICAgJHRhcmdl dElkbEZpbGVQYXRoID0gc2hpZnQ7CiAKICAgICBibGVzcygkcmVmZXJlbmNlLCAkb2JqZWN0KTsK ICAgICByZXR1cm4gJHJlZmVyZW5jZTsKQEAgLTEzMCw3ICsxMzIsNyBAQCBzdWIgUHJvY2Vzc0Rv Y3VtZW50CiAgICAgcmVxdWlyZSAkaWZhY2VOYW1lIC4gIi5wbSI7CiAKICAgICAjIER5bmFtaWNh bGx5IGxvYWQgZXh0ZXJuYWwgY29kZSBnZW5lcmF0aW9uIHBlcmwgbW9kdWxlCi0gICAgJGNvZGVH ZW5lcmF0b3IgPSAkaWZhY2VOYW1lLT5uZXcoJG9iamVjdCwgJHVzZU91dHB1dERpciwgJHVzZU91 dHB1dEhlYWRlcnNEaXIsICR1c2VMYXllck9uVG9wLCAkcHJlcHJvY2Vzc29yLCAkd3JpdGVEZXBl bmRlbmNpZXMsICR2ZXJib3NlKTsKKyAgICAkY29kZUdlbmVyYXRvciA9ICRpZmFjZU5hbWUtPm5l dygkb2JqZWN0LCAkdXNlT3V0cHV0RGlyLCAkdXNlT3V0cHV0SGVhZGVyc0RpciwgJHVzZUxheWVy T25Ub3AsICRwcmVwcm9jZXNzb3IsICR3cml0ZURlcGVuZGVuY2llcywgJHZlcmJvc2UsICR0YXJn ZXRJZGxGaWxlUGF0aCk7CiAgICAgdW5sZXNzIChkZWZpbmVkKCRjb2RlR2VuZXJhdG9yKSkgewog ICAgICAgICBteSAkY2xhc3NlcyA9ICR1c2VEb2N1bWVudC0+Y2xhc3NlczsKICAgICAgICAgZm9y ZWFjaCBteSAkY2xhc3MgKEAkY2xhc3NlcykgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUv YmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1iaW5kaW5ncy5wbCBiL1NvdXJjZS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvZ2VuZXJhdGUtYmluZGluZ3MucGwKaW5kZXggNWUzODk1Ni4uNzMxODcy MSAxMDA3NTUKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9nZW5lcmF0ZS1i aW5kaW5ncy5wbAorKysgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL2dlbmVyYXRl LWJpbmRpbmdzLnBsCkBAIC0xOTEsNyArMTkxLDcgQEAgZm9yZWFjaCBteSAkaWRsRmlsZSAoQHN1 cHBsZW1lbnRlZElkbEZpbGVzKSB7CiB9CiAKICMgR2VuZXJhdGUgZGVzaXJlZCBvdXRwdXQgZm9y IHRoZSB0YXJnZXQgSURMIGZpbGUuCi1teSAkY29kZUdlbiA9IENvZGVHZW5lcmF0b3ItPm5ldyhc QGlkbERpcmVjdG9yaWVzLCAkZ2VuZXJhdG9yLCAkb3V0cHV0RGlyZWN0b3J5LCAkb3V0cHV0SGVh ZGVyc0RpcmVjdG9yeSwgMCwgJHByZXByb2Nlc3NvciwgJHdyaXRlRGVwZW5kZW5jaWVzLCAkdmVy Ym9zZSk7CitteSAkY29kZUdlbiA9IENvZGVHZW5lcmF0b3ItPm5ldyhcQGlkbERpcmVjdG9yaWVz LCAkZ2VuZXJhdG9yLCAkb3V0cHV0RGlyZWN0b3J5LCAkb3V0cHV0SGVhZGVyc0RpcmVjdG9yeSwg MCwgJHByZXByb2Nlc3NvciwgJHdyaXRlRGVwZW5kZW5jaWVzLCAkdmVyYm9zZSwgJHRhcmdldElk bEZpbGUpOwogJGNvZGVHZW4tPlByb2Nlc3NEb2N1bWVudCgkdGFyZ2V0RG9jdW1lbnQsICRkZWZp bmVzKTsKIAogc3ViIGdlbmVyYXRlRW1wdHlIZWFkZXJBbmRDcHAK