96173 2012-09-07 20:19:01 -0700 REGRESSION (r127936): Multiple accessibility tests failing on Lion 2012-09-10 10:01:31 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED http://build.webkit.org/results/Apple%20MountainLion%20Debug%20WK1%20(Tests)/r127946%20(650)/results.html LayoutTestFailure, MakingBotsRed, Regression P1 Normal --- 1 mitz dmazzoni cfleizach dmazzoni thorton webkit.review.bot oldest_to_newest 715243 0 mitz 2012-09-07 20:19:01 -0700 After <http://trac.webkit.org/r127936>, the fix for bug 94870, multiple accessibility tests began to fail. See the URL for example. 715248 1 dmazzoni 2012-09-07 21:00:01 -0700 I'll look at these and either fix or revert shortly. 715284 2 dmazzoni 2012-09-07 23:42:10 -0700 I took a look; no new bugs, just need to rebaseline some expectations. 715293 3 dmazzoni 2012-09-07 23:58:57 -0700 Committed revision 127963. 715399 4 ap 2012-09-08 19:35:26 -0700 In addition to changing expectations, you changed a test: > Updating one test (update-children-when-aria-role-changes.html) that > incorrectly assumed a node with an aria-lable would be ignored. Used title > instead of aria-label. This kind of change requires review. 715549 5 dmazzoni 2012-09-09 12:04:02 -0700 (In reply to comment #4) > In addition to changing expectations, you changed a test: > > > Updating one test (update-children-when-aria-role-changes.html) that > > incorrectly assumed a node with an aria-lable would be ignored. Used title > > instead of aria-label. > > This kind of change requires review. Sorry. Fixing this now - I'll revert the offending change, fix just the expectations, then upload a patch to fix the test for review. 715578 6 dmazzoni 2012-09-09 13:52:12 -0700 Reverted r127963 for reason: Inappropriately modified test, and not just expectations, without review Committed r127992: <http://trac.webkit.org/changeset/127992> 715587 7 dmazzoni 2012-09-09 14:06:37 -0700 Fixed the text expectations only: Committed r127993: <http://trac.webkit.org/changeset/127993> 715597 8 163013 dmazzoni 2012-09-09 14:19:06 -0700 Created attachment 163013 Patch 716131 9 163013 cfleizach 2012-09-10 08:59:47 -0700 Comment on attachment 163013 Patch do you know what kind of role a <span> becomes if it's not ignored all of a sudden. i want to make sure we won't start exposing AXUnknown elements if someone puts an aria-label on a <span> without a role mapping 716149 10 dmazzoni 2012-09-10 09:17:14 -0700 (In reply to comment #9) > (From update of attachment 163013 [details]) > do you know what kind of role a <span> becomes if it's not ignored all of a sudden. i want to make sure we won't start exposing AXUnknown elements if someone puts an aria-label on a <span> without a role mapping It will be AXGroup. I tested it to confirm, but the logic is at the very bottom of determineAccessibilityRole: if (supportsARIAAttributes()) return GroupRole; 716169 11 163013 cfleizach 2012-09-10 09:42:15 -0700 Comment on attachment 163013 Patch that seems like reasonable logic. 716194 12 163013 webkit.review.bot 2012-09-10 10:01:27 -0700 Comment on attachment 163013 Patch Clearing flags on attachment: 163013 Committed r128072: <http://trac.webkit.org/changeset/128072> 716195 13 webkit.review.bot 2012-09-10 10:01:31 -0700 All reviewed patches have been landed. Closing bug. 163013 2012-09-09 14:19:06 -0700 2012-09-10 10:01:27 -0700 Patch bug-96173-20120909141905.patch text/plain 2478 dmazzoni SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDEyNzk5NikKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDEyLTA5LTA5ICBEb21pbmljIE1henpvbmkg IDxkbWF6em9uaUBnb29nbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIxMjc5MzYpOiBN dWx0aXBsZSBhY2Nlc3NpYmlsaXR5IHRlc3RzIGZhaWxpbmcgb24gTGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYxNzMKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHRlc3QgKHVwZGF0ZS1jaGls ZHJlbi13aGVuLWFyaWEtcm9sZS1jaGFuZ2VzLmh0bWwpIGFzc3VtZXMgdGhhdAorICAgICAgICBh biBlbGVtZW50IHdpdGggYW4gYXJpYS1sYWJlbCBpcyBpZ25vcmVkLCB3aGljaCB3b3JrZWQgYmVm b3JlLCBidXQgaXQncworICAgICAgICBub3QgaWdub3JlZCBhbnltb3JlIGFmdGVyIHIxMjc5MzYu IE9uZSBvZiB0aGUgY29tbWVudHMgaW4KKyAgICAgICAgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dC5jcHAgc2F5czogImlmIHRoaXMgZWxlbWVudCBoYXMgYXJpYSBhdHRyaWJ1dGVzIG9uIGl0LAor ICAgICAgICBpdCBzaG91bGQgbm90IGJlIGlnbm9yZWQsIiBzbyBJIHRoaW5rIHRoZSB0ZXN0IHNo b3VsZCBiZSB1cGRhdGVkIHRvIG5vdCB1c2UKKyAgICAgICAgYXJpYS1sYWJlbCBvbiBhbiBlbGVt ZW50IHdlIHdhbnQgdG8gYmUgaWdub3JlZC4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9Ta2lw cGVkOgorICAgICAgICAqIHBsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3VwZGF0ZS1jaGlsZHJl bi13aGVuLWFyaWEtcm9sZS1jaGFuZ2VzLmh0bWw6CisKIDIwMTItMDktMDkgIERvbWluaWMgTWF6 em9uaSAgPGRtYXp6b25pQGdvb2dsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjEyNzkz Nik6IE11bHRpcGxlIGFjY2Vzc2liaWxpdHkgdGVzdHMgZmFpbGluZyBvbiBMaW9uCkluZGV4OiBM YXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9wbGF0Zm9ybS9tYWMvU2tpcHBlZAkocmV2aXNpb24gMTI3OTkzKQorKysgTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjL1NraXBwZWQJKHdvcmtpbmcgY29weSkKQEAgLTc4LDEwICs3OCw2IEBAIGFj Y2Vzc2liaWxpdHkvYXJpYS1jaGVja2JveC1zZW5kcy1ub3RpZmkKIGFjY2Vzc2liaWxpdHkvbWVu dS1saXN0LXNlbmRzLWNoYW5nZS1ub3RpZmljYXRpb24uaHRtbAogYWNjZXNzaWJpbGl0eS9tdWx0 aXNlbGVjdC1saXN0LXJlcG9ydHMtYWN0aXZlLW9wdGlvbi5odG1sCiAKLSMgVGVzdCBuZWVkcyBh IG1pbm9yIGZpeC4KLSMgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2 MTczCi1wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS91cGRhdGUtY2hpbGRyZW4td2hlbi1hcmlh LXJvbGUtY2hhbmdlcy5odG1sCi0KICMgTmVlZCB0byBhZGQgZnVuY3Rpb25hbGl0eSB0byBEdW1w UmVuZGVyVHJlZSB0byBoYW5kbGUgZXJyb3IgcGFnZXMKIGZhc3QvaGlzdG9yeS9iYWNrLWZvcndh cmQtcmVzZXQtYWZ0ZXItZXJyb3ItaGFuZGxpbmcuaHRtbAogCkluZGV4OiBMYXlvdXRUZXN0cy9w bGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS91cGRhdGUtY2hpbGRyZW4td2hlbi1hcmlhLXJvbGUt Y2hhbmdlcy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L3VwZGF0ZS1jaGlsZHJlbi13aGVuLWFyaWEtcm9sZS1jaGFuZ2VzLmh0bWwJKHJl dmlzaW9uIDEyNzk5MikKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5 L3VwZGF0ZS1jaGlsZHJlbi13aGVuLWFyaWEtcm9sZS1jaGFuZ2VzLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTExLDcgKzExLDcgQEAgaWYgKHdpbmRvdy50ZXN0UnVubmVyKQogCiA8ZGl2IGlkPSJw YXJlbnQiIHRhYmluZGV4PTAgcm9sZT0iZ3JvdXAiPgogICAgPHNwYW4gdGFiaW5kZXg9MCByb2xl PSJidXR0b24iIGlkPSJidXR0b24xIj5idXR0b24gMTwvc3Bhbj4KLSAgIDxzcGFuIHRhYmluZGV4 PTAgaWQ9ImJ1dHRvbjIiIGFyaWEtbGFiZWw9ImJ1dHRvbiAyIj48L3NwYW4+CisgICA8c3BhbiB0 YWJpbmRleD0wIGlkPSJidXR0b24yIiB0aXRsZT0iYnV0dG9uIDIiPjwvc3Bhbj4KIDwvZGl2Pgog CiA8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4K