96138 2012-09-07 13:29:02 -0700 [chromium] Remove bad assert in CCRenderPass::Id 2012-09-07 13:47:26 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 danakj danakj cc-bugs enne fsamuel jamesr webkit.review.bot oldest_to_newest 714904 0 danakj 2012-09-07 13:29:02 -0700 [chromium] Remove bad assert in CCRenderPass::Id 714906 1 162854 danakj 2012-09-07 13:30:02 -0700 Created attachment 162854 Patch 714919 2 162854 jamesr 2012-09-07 13:44:13 -0700 Comment on attachment 162854 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162854&action=review > Source/WebCore/platform/graphics/chromium/cc/CCRenderPass.h:70 > + { } } can go on its own line 714924 3 162859 danakj 2012-09-07 13:46:13 -0700 Created attachment 162859 Patch 714927 4 danakj 2012-09-07 13:47:26 -0700 Committed r127913: <http://trac.webkit.org/changeset/127913> 162854 2012-09-07 13:30:02 -0700 2012-09-07 13:46:10 -0700 Patch bug-96138-20120907162941.patch text/plain 1751 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3OTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM1ZTE3NjM0M2U3MDIw NmY5NmZlYTQ4ZmExZDcyNGJjOGM3MTJlMy4uMDczNmM2ZTdkZWZkZmViYzNmMzc0ZGQ2MDgwMWQ4 ZjczNDJjOTUzOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA5LTA3ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFtjaHJvbWl1bV0gUmVt b3ZlIGJhZCBhc3NlcnQgaW4gQ0NSZW5kZXJQYXNzOjpJZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYxMzgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgYXNzZXJ0IHByZXZlbnRzIEhhc2hNYXAgZnJv bSBjcmVhdGluZyAiZGVsZXRlZCIgYW5kICJlbXB0eSIgaWRzLiBXZQorICAgICAgICBhc3NlcnQg dGhhdCBSZW5kZXJQYXNzZXMgaGF2ZSBjb3JyZWN0IGlkcyBhbHJlYWR5LCBhbmQgZG9uJ3QgbmVl ZCB0bworICAgICAgICBhc3NlcnQgaW5zaWRlIHRoZSBJZCBzdHJ1Y3R1cmUgaXRzZWxmLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NSZW5kZXJQYXNzLmg6Cisg ICAgICAgIChXZWJDb3JlOjpDQ1JlbmRlclBhc3M6OklkOjpJZCk6CisKKzIwMTItMDktMDcgIERh bmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW2Nocm9taXVtXSBN YWtlIFJlbmRlclBhc3MgaWRzIGhvbGQgYm90aCBnZW5lcmF0aW5nIGxheWVyIGlkIGFuZCBhbiBp bmRleAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU1 MDAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NSZW5kZXJQYXNzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ1JlbmRlclBhc3MuaAppbmRleCBjZTcxNGFhNDc0YjI5ZjRiNmYyZjBkNGNi ZmQzYzExOTkxMjZhOWQzLi4xMzY2OTVmNTBkMzNmM2ZmMjIyY2VkMjAzYTgxNmUwZjUwZGMxNGI0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9j Yy9DQ1JlbmRlclBhc3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ1JlbmRlclBhc3MuaApAQCAtNjcsMTAgKzY3LDcgQEAgcHVibGljOgogICAg ICAgICBJZChpbnQgbGF5ZXJJZCwgaW50IGluZGV4KQogICAgICAgICAgICAgOiBsYXllcklkKGxh eWVySWQpCiAgICAgICAgICAgICAsIGluZGV4KGluZGV4KQotICAgICAgICB7Ci0gICAgICAgICAg ICBBU1NFUlQobGF5ZXJJZCA+IDApOwotICAgICAgICAgICAgQVNTRVJUKGluZGV4ID49IDApOwot ICAgICAgICB9CisgICAgICAgIHsgfQogCiAgICAgICAgIGJvb2wgb3BlcmF0b3I9PShjb25zdCBJ ZCYgb3RoZXIpIGNvbnN0IHsgcmV0dXJuIGxheWVySWQgPT0gb3RoZXIubGF5ZXJJZCAmJiBpbmRl eCA9PSBvdGhlci5pbmRleDsgfQogICAgICAgICBib29sIG9wZXJhdG9yIT0oY29uc3QgSWQmIG90 aGVyKSBjb25zdCB7IHJldHVybiAhKCp0aGlzID09IG90aGVyKTsgfQo= 162859 2012-09-07 13:46:13 -0700 2012-09-07 13:46:13 -0700 Patch bug-96138-20120907164552.patch text/plain 1623 danakj U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3OTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjM1ZTE3NjM0M2U3MDIw NmY5NmZlYTQ4ZmExZDcyNGJjOGM3MTJlMy4uMmJmOTM5MWU2NWUxNzM2ZGNlMzdiNTQxMmRiNTYx OWMyYmViYjQwZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDEyLTA5LTA3ICBEYW5h IEphbnNlbnMgIDxkYW5ha2pAY2hyb21pdW0ub3JnPgogCisgICAgICAgIFtjaHJvbWl1bV0gUmVt b3ZlIGJhZCBhc3NlcnQgaW4gQ0NSZW5kZXJQYXNzOjpJZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYxMzgKKworICAgICAgICBSZXZpZXdlZCBieSBK YW1lcyBSb2JpbnNvbi4KKworICAgICAgICBUaGUgYXNzZXJ0IHByZXZlbnRzIEhhc2hNYXAgZnJv bSBjcmVhdGluZyAiZGVsZXRlZCIgYW5kICJlbXB0eSIgaWRzLiBXZQorICAgICAgICBhc3NlcnQg dGhhdCBSZW5kZXJQYXNzZXMgaGF2ZSBjb3JyZWN0IGlkcyBhbHJlYWR5LCBhbmQgZG9uJ3QgbmVl ZCB0bworICAgICAgICBhc3NlcnQgaW5zaWRlIHRoZSBJZCBzdHJ1Y3R1cmUgaXRzZWxmLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vY2MvQ0NSZW5kZXJQYXNzLmg6Cisg ICAgICAgIChXZWJDb3JlOjpDQ1JlbmRlclBhc3M6OklkOjpJZCk6CisKKzIwMTItMDktMDcgIERh bmEgSmFuc2VucyAgPGRhbmFrakBjaHJvbWl1bS5vcmc+CisKICAgICAgICAgW2Nocm9taXVtXSBN YWtlIFJlbmRlclBhc3MgaWRzIGhvbGQgYm90aCBnZW5lcmF0aW5nIGxheWVyIGlkIGFuZCBhbiBp bmRleAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTU1 MDAKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21p dW0vY2MvQ0NSZW5kZXJQYXNzLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ1JlbmRlclBhc3MuaAppbmRleCBjZTcxNGFhNDc0YjI5ZjRiNmYyZjBkNGNi ZmQzYzExOTkxMjZhOWQzLi43YTVjYzYxMDZiNjE5ZDI0MzFmMzhkYjkzYmNhYTQzNWUzYjU1MDcw IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9j Yy9DQ1JlbmRlclBhc3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9jYy9DQ1JlbmRlclBhc3MuaApAQCAtNjgsOCArNjgsNiBAQCBwdWJsaWM6CiAgICAg ICAgICAgICA6IGxheWVySWQobGF5ZXJJZCkKICAgICAgICAgICAgICwgaW5kZXgoaW5kZXgpCiAg ICAgICAgIHsKLSAgICAgICAgICAgIEFTU0VSVChsYXllcklkID4gMCk7Ci0gICAgICAgICAgICBB U1NFUlQoaW5kZXggPj0gMCk7CiAgICAgICAgIH0KIAogICAgICAgICBib29sIG9wZXJhdG9yPT0o Y29uc3QgSWQmIG90aGVyKSBjb25zdCB7IHJldHVybiBsYXllcklkID09IG90aGVyLmxheWVySWQg JiYgaW5kZXggPT0gb3RoZXIuaW5kZXg7IH0K