96124 2012-09-07 10:03:00 -0700 AX: Chromium needs access to canvasHasFallbackContent 2012-09-07 15:55:03 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dmazzoni dmazzoni abarth cfleizach dglazkov fishd jamesr tkent+wkapi webkit.review.bot oldest_to_newest 714643 0 dmazzoni 2012-09-07 10:03:00 -0700 In WebAccessibilityObject 714713 1 162811 dmazzoni 2012-09-07 10:39:58 -0700 Created attachment 162811 Patch 714719 2 webkit.review.bot 2012-09-07 10:43:40 -0700 Please wait for approval from abarth@webkit.org, dglazkov@chromium.org, fishd@chromium.org, jamesr@chromium.org or tkent@chromium.org before submitting, as this patch contains changes to the Chromium public API. See also https://trac.webkit.org/wiki/ChromiumWebKitAPI. 714943 3 162811 cfleizach 2012-09-07 13:57:36 -0700 Comment on attachment 162811 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162811&action=review > Tools/DumpRenderTree/chromium/TestRunner/AccessibilityUIElementChromium.cpp:243 > + roleString += "WithFallbackContent"; it's a little weird to modify the role string like this i might have chosen to make it "AXCanvas (With Fallback Content)" but that's a minor nit 715079 4 162811 webkit.review.bot 2012-09-07 15:54:59 -0700 Comment on attachment 162811 Patch Clearing flags on attachment: 162811 Committed r127931: <http://trac.webkit.org/changeset/127931> 715080 5 webkit.review.bot 2012-09-07 15:55:03 -0700 All reviewed patches have been landed. Closing bug. 162811 2012-09-07 10:39:58 -0700 2012-09-07 15:54:59 -0700 Patch bug-96124-20120907103938.patch text/plain 5740 dmazzoni U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzU0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCmluZGV4 IDY0YzY4ZGRhNDliMjhkMmMzN2Q4YTAyYWJlMThkYTNhN2JkZjQwNTEuLjcwZmRhMTBiYjNjNWJk NDM4NjEyYjdiNWFhMjU1OGQ5ZDg4ZjhmMWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTggQEAKKzIwMTItMDktMDcgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdv b2dsZS5jb20+CisKKyAgICAgICAgQVg6IENocm9taXVtIG5lZWRzIGFjY2VzcyB0byBjYW52YXNI YXNGYWxsYmFja0NvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTk2MTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgRXhwb3NlIGNhbnZhc0hhc0ZhbGxiYWNrQ29udGVudCBvbiBDaHJvbWl1bS4KKwor ICAgICAgICAqIHB1YmxpYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJB Y2Nlc3NpYmlsaXR5T2JqZWN0KToKKyAgICAgICAgKiBzcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVj dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OmNhbnZhc0hh c0ZhbGxiYWNrQ29udGVudCk6CisgICAgICAgIChXZWJLaXQpOgorCiAyMDEyLTA5LTA2ICBJbHlh IFRpa2hvbm92c2t5ICA8bG9pc2xvQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2Vk IFdlYiBJbnNwZWN0b3I6IHRlc3QgZml4LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oIGIvU291cmNlL1dlYktpdC9jaHJv bWl1bS9wdWJsaWMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5oCmluZGV4IGE3M2FlODY5ZjU2NjY2 NzQ4NzYwZWU0NjlmMGU3ZDQ5NzA0YzhiMDguLmI2MjMzMzlkZmQ4MjFhNTlkMjBhYTAwODcwODg1 ODA0MDMwNjBjMGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkFjY2Vzc2liaWxpdHlPYmplY3QuaAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9taXVtL3B1Ymxp Yy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmgKQEAgLTEzMyw2ICsxMzMsNyBAQCBwdWJsaWM6CiAg ICAgV0VCS0lUX0VYUE9SVCBXZWJTdHJpbmcgYXJpYUxpdmVSZWdpb25SZWxldmFudCgpIGNvbnN0 OwogICAgIFdFQktJVF9FWFBPUlQgV2ViU3RyaW5nIGFyaWFMaXZlUmVnaW9uU3RhdHVzKCkgY29u c3Q7CiAgICAgV0VCS0lUX0VYUE9SVCBXZWJSZWN0IGJvdW5kaW5nQm94UmVjdCgpIGNvbnN0Owor ICAgIFdFQktJVF9FWFBPUlQgYm9vbCBjYW52YXNIYXNGYWxsYmFja0NvbnRlbnQoKSBjb25zdDsK ICAgICBXRUJLSVRfRVhQT1JUIGRvdWJsZSBlc3RpbWF0ZWRMb2FkaW5nUHJvZ3Jlc3MoKSBjb25z dDsKICAgICBXRUJLSVRfRVhQT1JUIFdlYlN0cmluZyBoZWxwVGV4dCgpIGNvbnN0OwogICAgIFdF QktJVF9FWFBPUlQgaW50IGhlYWRpbmdMZXZlbCgpIGNvbnN0OwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAppbmRleCA4NWVl NDFlYjczZjcxN2ZjZjUwODQwOTI2NDM2OGM1OGZmNDFmNWY0Li5iZDM5NzJjYzA1MjlmZjVhNzQ3 ODZkNzdmNDJhYmY2NzgxYjYwNjM2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L2Nocm9taXVt L3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJBY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcApAQCAtNDU5LDYgKzQ1OSwxNCBAQCBX ZWJSZWN0IFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OmJvdW5kaW5nQm94UmVjdCgpIGNvbnN0CiAg ICAgcmV0dXJuIG1fcHJpdmF0ZS0+cGl4ZWxTbmFwcGVkQm91bmRpbmdCb3hSZWN0KCk7CiB9CiAK K2Jvb2wgV2ViQWNjZXNzaWJpbGl0eU9iamVjdDo6Y2FudmFzSGFzRmFsbGJhY2tDb250ZW50KCkg Y29uc3QKK3sKKyAgICBpZiAoaXNEZXRhY2hlZCgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisK KyAgICByZXR1cm4gbV9wcml2YXRlLT5jYW52YXNIYXNGYWxsYmFja0NvbnRlbnQoKTsKK30KKwog ZG91YmxlIFdlYkFjY2Vzc2liaWxpdHlPYmplY3Q6OmVzdGltYXRlZExvYWRpbmdQcm9ncmVzcygp IGNvbnN0CiB7CiAgICAgaWYgKGlzRGV0YWNoZWQoKSkKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5n ZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjYjgyN2ZkYWM5MWE0MTg1NDE0MjFmM2MxYjdi ZGQ0ZDkzYTkyNDJmLi4yZjZhYjA4YTUzNzllM2U2Yjc4YzI5MDg2MTZlYTRmNTRkMzVjNmJhIDEw MDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTYgQEAKKzIwMTItMDktMDcgIERvbWluaWMgTWF6em9uaSAgPGRtYXp6b25pQGdvb2dsZS5j b20+CisKKyAgICAgICAgQVg6IENocm9taXVtIG5lZWRzIGFjY2VzcyB0byBjYW52YXNIYXNGYWxs YmFja0NvbnRlbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTk2MTI0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgRGlzdGluZ3Vpc2ggYmV0d2VlbiBjYW52YXMgcm9sZXMgd2l0aCBhbmQgd2l0aG91dCBmYWxs YmFjaworICAgICAgICBjb250ZW50IG9uIENocm9taXVtLgorCisgICAgICAgICogRHVtcFJlbmRl clRyZWUvY2hyb21pdW0vVGVzdFJ1bm5lci9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50Q2hyb21pdW0u Y3BwOgorICAgICAgICAoZ2V0Um9sZSk6CisKIDIwMTItMDktMDYgIFNpbW9uIEhhdXNtYW5uICA8 c2ltb24uaGF1c21hbm5Abm9raWEuY29tPgogCiAgICAgICAgIFtRdF0gRml4IGJ1aWxkIG9uIE1h YyBPUyBYIDEwLjYKZGlmZiAtLWdpdCBhL1Rvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1Rl c3RSdW5uZXIvQWNjZXNzaWJpbGl0eVVJRWxlbWVudENocm9taXVtLmNwcCBiL1Rvb2xzL0R1bXBS ZW5kZXJUcmVlL2Nocm9taXVtL1Rlc3RSdW5uZXIvQWNjZXNzaWJpbGl0eVVJRWxlbWVudENocm9t aXVtLmNwcAppbmRleCAzNGU0ZTNjNGUwYmQ0NzU4NzljNmIxOTNhNWZiYTU2ZGY1OWIyNjRjLi4y Mjc4NTFmOTQ5MTM3ZDUzN2M4OTQ0OGFlZTg0ODAzYzRkNDkxN2ZlIDEwMDY0NAotLS0gYS9Ub29s cy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9UZXN0UnVubmVyL0FjY2Vzc2liaWxpdHlVSUVsZW1l bnRDaHJvbWl1bS5jcHAKKysrIGIvVG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vVGVzdFJ1 bm5lci9BY2Nlc3NpYmlsaXR5VUlFbGVtZW50Q2hyb21pdW0uY3BwCkBAIC0yMzQsNyArMjM0LDE1 IEBAIHN0cmluZyBnZXRTdHJpbmdWYWx1ZShjb25zdCBXZWJBY2Nlc3NpYmlsaXR5T2JqZWN0JiBv YmplY3QpCiAKIHN0cmluZyBnZXRSb2xlKGNvbnN0IFdlYkFjY2Vzc2liaWxpdHlPYmplY3QmIG9i amVjdCkKIHsKLSAgICByZXR1cm4gcm9sZVRvU3RyaW5nKG9iamVjdC5yb2xlVmFsdWUoKSk7Cisg ICAgc3RyaW5nIHJvbGVTdHJpbmcgPSByb2xlVG9TdHJpbmcob2JqZWN0LnJvbGVWYWx1ZSgpKTsK KworICAgIC8vIFNwZWNpYWwtY2FzZSBjYW52YXMgd2l0aCBmYWxsYmFjayBjb250ZW50IGJlY2F1 c2UgQ2hyb21pdW0gd2FudHMgdG8KKyAgICAvLyB0cmVhdCB0aGlzIGFzIGVzc2VudGlhbGx5IGEg c2VwYXJhdGUgcm9sZSB0aGF0IGl0IGNhbiBtYXAgZGlmZmVyZW50bHkgZGVwZW5kaW5nCisgICAg Ly8gb24gdGhlIHBsYXRmb3JtLgorICAgIGlmIChvYmplY3Qucm9sZVZhbHVlKCkgPT0gV2ViQWNj ZXNzaWJpbGl0eVJvbGVDYW52YXMgJiYgb2JqZWN0LmNhbnZhc0hhc0ZhbGxiYWNrQ29udGVudCgp KQorICAgICAgICByb2xlU3RyaW5nICs9ICJXaXRoRmFsbGJhY2tDb250ZW50IjsKKworICAgIHJl dHVybiByb2xlU3RyaW5nOwogfQogCiBzdHJpbmcgZ2V0VGl0bGUoY29uc3QgV2ViQWNjZXNzaWJp bGl0eU9iamVjdCYgb2JqZWN0KQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGU3YmQwZjA5ZmM2MmU0ZTNlMGM0NTFiMTQ2ZWFi MzA4YzhmYjM3OTQuLjA4MzUwMGU5YTFlMzIxOWI5ZWIwMDQ5ZTA2MzcwMzA3MzE2OTU0YWYgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0wNyAgRG9taW5pYyBNYXp6b25pICA8ZG1henpv bmlAZ29vZ2xlLmNvbT4KKworICAgICAgICBBWDogQ2hyb21pdW0gbmVlZHMgYWNjZXNzIHRvIGNh bnZhc0hhc0ZhbGxiYWNrQ29udGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9OTYxMjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBVcGRhdGUgY2FudmFzIHRlc3QgdG8gZGlzdGluZ3Vpc2ggYmV0d2VlbiBj YW52YXMgZWxlbWVudHMgd2l0aAorICAgICAgICBmYWxsYmFjayBjb250ZW50IG9uIENocm9taXVt LgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vYWNjZXNzaWJpbGl0eS9jYW52YXMtZGVz Y3JpcHRpb24tYW5kLXJvbGUtZXhwZWN0ZWQudHh0OgorCiAyMDEyLTA5LTA2ICBEYW4gQmVybnN0 ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTihyMTI3NzEyKTogSXQg YnJva2UgaHR0cC90ZXN0cy94bWxodHRwcmVxdWVzdC9iYXNpYy1hdXRoLmh0bWwgb24gSlNDIHBs YXRmb3JtcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vYWNjZXNz aWJpbGl0eS9jYW52YXMtZGVzY3JpcHRpb24tYW5kLXJvbGUtZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vYWNjZXNzaWJpbGl0eS9jYW52YXMtZGVzY3JpcHRpb24t YW5kLXJvbGUtZXhwZWN0ZWQudHh0CmluZGV4IDhkYWZkYzBhOTEwNzczYTc0NzBlOTNhOTM1NzQ0 ZjljOTM2ZWJmZjkuLmQxN2ZhOGJhNzQxNGZjOWVlMmY2NmI1ZjRiYjFhM2YxNGM5MDNmYzIgMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2Nocm9taXVtL2FjY2Vzc2liaWxpdHkvY2Fu dmFzLWRlc2NyaXB0aW9uLWFuZC1yb2xlLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9w bGF0Zm9ybS9jaHJvbWl1bS9hY2Nlc3NpYmlsaXR5L2NhbnZhcy1kZXNjcmlwdGlvbi1hbmQtcm9s ZS1leHBlY3RlZC50eHQKQEAgLTcsNyArNyw3IEBAIFBBU1MgYXhDb250YWluZXIuY2hpbGRyZW5D b3VudCBpcyAyCiBDYW52YXMgMSBkZXNjcmlwdGlvbjogQVhEZXNjcmlwdGlvbjogQ2FudmFzIGxh YmVsCiBDYW52YXMgMSByb2xlOiBBWFJvbGU6IEFYQ2FudmFzCiBDYW52YXMgMiBkZXNjcmlwdGlv bjogQVhEZXNjcmlwdGlvbjogCi1DYW52YXMgMiByb2xlOiBBWFJvbGU6IEFYQ2FudmFzCitDYW52 YXMgMiByb2xlOiBBWFJvbGU6IEFYQ2FudmFzV2l0aEZhbGxiYWNrQ29udGVudAogUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCg==