96108 2012-09-07 07:38:36 -0700 [EFL] [WK2] Set theme for the inspector view 2012-09-07 17:42:27 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 naginenis naginenis gyuyoung.kim kenneth lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 714512 0 naginenis 2012-09-07 07:38:36 -0700 Right now the theme is not set for the inspector view, so all the tests are failing on EFL Debug bot. We must set the theme for the inspector view when it is created. 714517 1 162769 naginenis 2012-09-07 07:50:46 -0700 Created attachment 162769 Patch 714715 2 162769 cdumez 2012-09-07 10:40:21 -0700 Comment on attachment 162769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162769&action=review > Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:50 > + ewk_view_theme_set(m_inspectorView, TEST_THEME_DIR"/default.edj"); Shouldn't we do this in _ewk_view_initialize() so that we are sure every view has a theme set? Since it seems to be causing crashes when a view does not have a theme set, I think we should fix this at the origin. 714803 3 162769 naginenis 2012-09-07 11:38:11 -0700 Comment on attachment 162769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162769&action=review >> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:50 >> + ewk_view_theme_set(m_inspectorView, TEST_THEME_DIR"/default.edj"); > > Shouldn't we do this in _ewk_view_initialize() so that we are sure every view has a theme set? Since it seems to be causing crashes when a view does not have a theme set, I think we should fix this at the origin. I was about to fix your comment, but now I found that recently we dropped the default theme setting on the view initialization. https://bugs.webkit.org/show_bug.cgi?id=94778 715145 4 162769 kenneth 2012-09-07 17:03:32 -0700 Comment on attachment 162769 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162769&action=review >>> Source/WebKit2/UIProcess/efl/WebInspectorProxyEfl.cpp:50 >>> + ewk_view_theme_set(m_inspectorView, TEST_THEME_DIR"/default.edj"); >> >> Shouldn't we do this in _ewk_view_initialize() so that we are sure every view has a theme set? Since it seems to be causing crashes when a view does not have a theme set, I think we should fix this at the origin. > > I was about to fix your comment, but now I found that recently we dropped the default theme setting on the view initialization. > https://bugs.webkit.org/show_bug.cgi?id=94778 Huh? So we are supposed to not have a default theme and it should then paint what? 715152 5 162769 kenneth 2012-09-07 17:08:44 -0700 Comment on attachment 162769 Patch We should probably land this and fix the real issues in a separate bug. 715171 6 162769 webkit.review.bot 2012-09-07 17:42:24 -0700 Comment on attachment 162769 Patch Clearing flags on attachment: 162769 Committed r127942: <http://trac.webkit.org/changeset/127942> 715172 7 webkit.review.bot 2012-09-07 17:42:27 -0700 All reviewed patches have been landed. Closing bug. 162769 2012-09-07 07:50:46 -0700 2012-09-07 17:42:23 -0700 Patch 96108.patch text/plain 1546 naginenis ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmYmU0MTQ4Li4xYmZhZjk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTItMDktMDcgIFN1ZGFyc2FuYSBOYWdpbmVuaSAgPHN1ZGFyc2FuYS5uYWdpbmVuaUBs aW51eC5pbnRlbC5jb20+CisKKyAgICAgICAgW0VGTF0gW1dLMl0gU2V0IHRoZW1lIGZvciB0aGUg aW5zcGVjdG9yIHZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTk2MTA4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgU2V0IHRoZSB0aGVtZSBmb3IgdGhlIGluc3BlY3RvciB2aWV3IHdoZW4gaXQgaXMgY3Jl YXRlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3Bw OgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVJbnNw ZWN0b3JQYWdlKToKKwogMjAxMi0wOS0wNyAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFw cGxlLmNvbT4KIAogICAgICAgICBBZGQgb3B0aW9uYWwgZGVidWcgbG9nZ2luZyB3aGVuIHdlIGZh bGwgaW50by9vdXQgb2YgdGhyZWFkZWQgc2Nyb2xsaW5nCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0Mi9VSVByb2Nlc3MvZWZsL1dlYkluc3BlY3RvclByb3h5RWZsLmNwcCBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5zcGVjdG9yUHJveHlFZmwuY3BwCmluZGV4IDJiMTUzN2Uu LjUzODM1NjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2ViSW5z cGVjdG9yUHJveHlFZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9lZmwvV2Vi SW5zcGVjdG9yUHJveHlFZmwuY3BwCkBAIC0yOSw2ICsyOSw3IEBACiAjaWYgRU5BQkxFKElOU1BF Q1RPUikKIAogI2luY2x1ZGUgIldlYlByb2Nlc3NQcm94eS5oIgorI2luY2x1ZGUgImV3a192aWV3 LmgiCiAjaW5jbHVkZSAiZXdrX3ZpZXdfcHJpdmF0ZS5oIgogI2luY2x1ZGUgPFdlYkNvcmUvTm90 SW1wbGVtZW50ZWQuaD4KICNpbmNsdWRlIDx1bmlzdGQuaD4KQEAgLTQ2LDYgKzQ3LDcgQEAgV2Vi UGFnZVByb3h5KiBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1DcmVhdGVJbnNwZWN0b3JQYWdl KCkKICAgICAgICAgcmV0dXJuIDA7CiAKICAgICBtX2luc3BlY3RvclZpZXcgPSBld2tfdmlld19i YXNlX2FkZChlY29yZV9ldmFzX2dldChtX2luc3BlY3RvcldpbmRvdyksIHRvQVBJKHBhZ2UoKS0+ cHJvY2VzcygpLT5jb250ZXh0KCkpLCB0b0FQSShpbnNwZWN0b3JQYWdlR3JvdXAoKSkpOworICAg IGV3a192aWV3X3RoZW1lX3NldChtX2luc3BlY3RvclZpZXcsIFRFU1RfVEhFTUVfRElSIi9kZWZh dWx0LmVkaiIpOwogICAgIHJldHVybiBld2tfdmlld19wYWdlX2dldChtX2luc3BlY3RvclZpZXcp OwogfQogCg==