96106 2012-09-07 07:29:20 -0700 [Qt][WK2] QWebKitTest should retrieve the viewport state from the PageViewportController 2012-09-10 02:26:42 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 abecsi abecsi cmarcelo jturcotte kenneth menard webkit.review.bot zoltan oldest_to_newest 714505 0 abecsi 2012-09-07 07:29:20 -0700 [Qt][WK2] QWebKitTest should retrieve the viewport state from the PageViewportController 714506 1 162766 abecsi 2012-09-07 07:30:03 -0700 Created attachment 162766 Patch 715546 2 162766 kenneth 2012-09-09 11:45:28 -0700 Comment on attachment 162766 Patch Nice! 715857 3 162766 abecsi 2012-09-10 02:26:37 -0700 Comment on attachment 162766 Patch Clearing flags on attachment: 162766 Committed r128035: <http://trac.webkit.org/changeset/128035> 715858 4 abecsi 2012-09-10 02:26:42 -0700 All reviewed patches have been landed. Closing bug. 162766 2012-09-07 07:30:03 -0700 2012-09-10 02:26:37 -0700 Patch bug-96106-20120907163032.patch text/plain 6787 abecsi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3ODY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZmZhNjZiZmU1NmNjMGY1 MTI5MDA4YmUzMWJlYzE2NWJlNjU1YWFmMy4uMWEwMjNkYTExNmJhMmZjZGFmZjQzOTFkNTZkOGI1 NmQ0Zjk4NjI4OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDEyLTA5LTA3ICBBbmRy YXMgQmVjc2kgIDxhbmRyYXMuYmVjc2lAbm9raWEuY29tPgorCisgICAgICAgIFtRdF1bV0syXSBR V2ViS2l0VGVzdCBzaG91bGQgcmV0cmlldmUgdGhlIHZpZXdwb3J0IHN0YXRlIGZyb20gdGhlIFBh Z2VWaWV3cG9ydENvbnRyb2xsZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTk2MTA2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIGZ1bmN0aW9ucyBpbiBQYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50 UXQgcHJveHlpbmcgdGhlCisgICAgICAgIHZpZXdwb3J0IHN0YXRlIHZhbHVlcyBjYW4gYmUgcmVt b3ZlZCBpZiBRV2ViS2l0VGVzdCB1c2VzIHRoZQorICAgICAgICBQYWdlVmlld3BvcnRDb250cm9s bGVyIHRvIHJldHJpZXZlIHRoZXNlIHZhbHVlcy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlld19wX3AuaDoKKyAgICAgICAgKFFRdWlja1dlYlZpZXdQcml2YXRlOjp2 aWV3cG9ydENvbnRyb2xsZXIpOgorICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvcXQvcXdlYmtpdHRl c3QuY3BwOgorICAgICAgICAoUVdlYktpdFRlc3Q6OnZpZXdwb3J0KToKKyAgICAgICAgKFFXZWJL aXRUZXN0OjpkZXZpY2VQaXhlbFJhdGlvKToKKyAgICAgICAgKFFXZWJLaXRUZXN0Ojpjb250ZW50 c1NjYWxlKToKKyAgICAgICAgKiBVSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlci5oOgor ICAgICAgICAoV2ViS2l0OjpQYWdlVmlld3BvcnRDb250cm9sbGVyOjpjdXJyZW50Q29udGVudHNT Y2FsZSk6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGll bnRRdC5jcHA6CisgICAgICAgICogVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJD bGllbnRRdC5oOgorICAgICAgICAoUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0KToKKwog MjAxMi0wOS0wNyAgQWxsYW4gU2FuZGZlbGQgSmVuc2VuICA8YWxsYW4uamVuc2VuQG5va2lhLmNv bT4KIAogICAgICAgICBYMTEgR2xvYmFsIFNlbGVjdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oIGIvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xcXVpY2t3ZWJ2aWV3X3BfcC5oCmluZGV4IGI5Yzg5ZWM3MDBl OTVkYTcyNzkxNWExMzY1YTMzZmFlZWEwYzhhMTAuLmQxZDNkOWU4OGY5YTk0ZjFhYjhlMjkwOTBm OGI3Yjg2MmI3NWIxNzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkv cXQvcXF1aWNrd2Vidmlld19wX3AuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJ L3F0L3FxdWlja3dlYnZpZXdfcF9wLmgKQEAgLTg3LDcgKzg3LDcgQEAgcHVibGljOgogICAgIGlu dCBsb2FkUHJvZ3Jlc3MoKSBjb25zdCB7IHJldHVybiBtX2xvYWRQcm9ncmVzczsgfQogICAgIHZv aWQgc2V0TmVlZHNEaXNwbGF5KCk7CiAKLSAgICBXZWJLaXQ6OlBhZ2VWaWV3cG9ydENvbnRyb2xs ZXJDbGllbnRRdCogcGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudCgpIGNvbnN0IHsgcmV0dXJu IG1fcGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudC5kYXRhKCk7IH0KKyAgICBXZWJLaXQ6OlBh Z2VWaWV3cG9ydENvbnRyb2xsZXIqIHZpZXdwb3J0Q29udHJvbGxlcigpIGNvbnN0IHsgcmV0dXJu IG1fcGFnZVZpZXdwb3J0Q29udHJvbGxlci5kYXRhKCk7IH0KICAgICB2aXJ0dWFsIHZvaWQgdXBk YXRlVmlld3BvcnRTaXplKCkgeyB9CiAgICAgdm9pZCB1cGRhdGVUb3VjaFZpZXdwb3J0U2l6ZSgp OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3F3ZWJraXR0 ZXN0LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdlYmtpdHRlc3QuY3Bw CmluZGV4IDFmMjE4N2E4ODFkYTRkNGYzNWY1MDc1MzE1NTY3MDI1YTUyMDlmZTguLmE4YTljNjg2 YjdhZDVlODFkYTViYWE2MWM3MGE4NDg5NzEzNTQ1MTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvcXQvcXdlYmtpdHRlc3QuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9BUEkvcXQvcXdlYmtpdHRlc3QuY3BwCkBAIC0xNDgsNyArMTQ4LDcgQEAgc3Rh dGljIGlubGluZSBRSnNvbk9iamVjdCB0b0pzb25PYmplY3QoY29uc3QgUVNpemVGJiBzaXplRikK IFFKc29uT2JqZWN0IFFXZWJLaXRUZXN0Ojp2aWV3cG9ydCgpIGNvbnN0CiB7CiAgICAgUUpzb25P YmplY3Qgdmlld3BvcnREYXRhOwotICAgIGlmIChjb25zdCBQYWdlVmlld3BvcnRDb250cm9sbGVy Q2xpZW50UXQqIGNvbnN0IHZpZXdwb3J0SGFuZGxlciA9IG1fd2ViVmlld1ByaXZhdGUtPnBhZ2VW aWV3cG9ydENvbnRyb2xsZXJDbGllbnQoKSkgeworICAgIGlmIChjb25zdCBQYWdlVmlld3BvcnRD b250cm9sbGVyKiBjb25zdCB2aWV3cG9ydEhhbmRsZXIgPSBtX3dlYlZpZXdQcml2YXRlLT52aWV3 cG9ydENvbnRyb2xsZXIoKSkgewogICAgICAgICB2aWV3cG9ydERhdGEuaW5zZXJ0KFFMYXRpbjFT dHJpbmcoImxheW91dFNpemUiKSwgdG9Kc29uT2JqZWN0KHZpZXdwb3J0SGFuZGxlci0+Y29udGVu dHNMYXlvdXRTaXplKCkpKTsKICAgICAgICAgdmlld3BvcnREYXRhLmluc2VydChRTGF0aW4xU3Ry aW5nKCJpc1NjYWxhYmxlIiksIHZpZXdwb3J0SGFuZGxlci0+YWxsb3dzVXNlclNjYWxpbmcoKSk7 CiAgICAgICAgIHZpZXdwb3J0RGF0YS5pbnNlcnQoUUxhdGluMVN0cmluZygibWluaW11bVNjYWxl IiksIHZpZXdwb3J0SGFuZGxlci0+bWluaW11bUNvbnRlbnRzU2NhbGUoKSk7CkBAIC0xNjUsMTQg KzE2NSwxNCBAQCBRSnNvbk9iamVjdCBRV2ViS2l0VGVzdDo6dmlld3BvcnQoKSBjb25zdAogCiBR VmFyaWFudCBRV2ViS2l0VGVzdDo6ZGV2aWNlUGl4ZWxSYXRpbygpIGNvbnN0CiB7Ci0gICAgaWYg KGNvbnN0IFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdCogY29uc3Qgdmlld3BvcnQgPSBt X3dlYlZpZXdQcml2YXRlLT5wYWdlVmlld3BvcnRDb250cm9sbGVyQ2xpZW50KCkpCisgICAgaWYg KGNvbnN0IFBhZ2VWaWV3cG9ydENvbnRyb2xsZXIqIGNvbnN0IHZpZXdwb3J0ID0gbV93ZWJWaWV3 UHJpdmF0ZS0+dmlld3BvcnRDb250cm9sbGVyKCkpCiAgICAgICAgIHJldHVybiB2aWV3cG9ydC0+ ZGV2aWNlUGl4ZWxSYXRpbygpOwogICAgIHJldHVybiAxLjA7CiB9CiAKIFFWYXJpYW50IFFXZWJL aXRUZXN0Ojpjb250ZW50c1NjYWxlKCkgY29uc3QKIHsKLSAgICBpZiAoY29uc3QgUGFnZVZpZXdw b3J0Q29udHJvbGxlckNsaWVudFF0KiBjb25zdCB2aWV3cG9ydCA9IG1fd2ViVmlld1ByaXZhdGUt PnBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnQoKSkKKyAgICBpZiAoY29uc3QgUGFnZVZpZXdw b3J0Q29udHJvbGxlciogY29uc3Qgdmlld3BvcnQgPSBtX3dlYlZpZXdQcml2YXRlLT52aWV3cG9y dENvbnRyb2xsZXIoKSkKICAgICAgICAgcmV0dXJuIHZpZXdwb3J0LT5jdXJyZW50Q29udGVudHNT Y2FsZSgpOwogICAgIHJldHVybiAxLjA7CiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29udHJvbGxlci5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1BhZ2VWaWV3cG9ydENvbnRyb2xsZXIuaAppbmRleCA5NWZkM2Y3OGZmNzYxNzIzNjdiMTE1 ZGU0MTJmNjljM2Q5NjllYTJmLi4wNzQ2ZmYxZGYxNGE3OTY0NWU1MTJmZjJjMmNjZmIwYTk5ZWU2 ODM3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZVZpZXdwb3J0Q29u dHJvbGxlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlVmlld3BvcnRDb250 cm9sbGVyLmgKQEAgLTkzLDYgKzkzLDcgQEAgcHVibGljOgogICAgIGZsb2F0IGRldmljZVBpeGVs UmF0aW8oKSBjb25zdCB7IHJldHVybiBtX2RldmljZVBpeGVsUmF0aW87IH0KICAgICBmbG9hdCBt aW5pbXVtQ29udGVudHNTY2FsZSgpIGNvbnN0IHsgcmV0dXJuIG1fbWluaW11bVNjYWxlOyB9CiAg ICAgZmxvYXQgbWF4aW11bUNvbnRlbnRzU2NhbGUoKSBjb25zdCB7IHJldHVybiBtX21heGltdW1T Y2FsZTsgfQorICAgIGZsb2F0IGN1cnJlbnRDb250ZW50c1NjYWxlKCkgY29uc3QgeyByZXR1cm4g Y29udmVydEZyb21WaWV3cG9ydChtX2VmZmVjdGl2ZVNjYWxlKTsgfQogCiAgICAgdm9pZCBzZXRI YWRVc2VySW50ZXJhY3Rpb24oYm9vbCBkaWRVc2VySW50ZXJhY3QpIHsgbV9oYWRVc2VySW50ZXJh Y3Rpb24gPSBkaWRVc2VySW50ZXJhY3Q7IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdC5jcHAgYi9Tb3VyY2Uv V2ViS2l0Mi9VSVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0LmNwcApp bmRleCBhOTk3NWRlYmE5MzQyMTA0ODQwZGIyZmU2YjlmNDlmMWE0YTRiOWE4Li4zZDEzNGVhOTM5 YTNjNGVkNmEzNjBkMWRhNTdiODEzYjNlNGQ5NzAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0 LmNwcApAQCAtMzUwLDM2ICszNTAsNiBAQCB2b2lkIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGll bnRRdDo6ZGlkUmVzdW1lQ29udGVudCgpCiAgICAgdXBkYXRlVmlld3BvcnRDb250cm9sbGVyKCk7 CiB9CiAKLWJvb2wgUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0OjphbGxvd3NVc2VyU2Nh bGluZygpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIG1fY29udHJvbGxlci0+YWxsb3dzVXNlclNjYWxp bmcoKTsKLX0KLQotcXJlYWwgUGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0OjpkZXZpY2VQ aXhlbFJhdGlvKCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9jb250cm9sbGVyLT5kZXZpY2VQaXhl bFJhdGlvKCk7Ci19Ci0KLXFyZWFsIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJDbGllbnRRdDo6bWlu aW11bUNvbnRlbnRzU2NhbGUoKSBjb25zdAotewotICAgIHJldHVybiBtX2NvbnRyb2xsZXItPm1p bmltdW1Db250ZW50c1NjYWxlKCk7Ci19Ci0KLXFyZWFsIFBhZ2VWaWV3cG9ydENvbnRyb2xsZXJD bGllbnRRdDo6bWF4aW11bUNvbnRlbnRzU2NhbGUoKSBjb25zdAotewotICAgIHJldHVybiBtX2Nv bnRyb2xsZXItPm1heGltdW1Db250ZW50c1NjYWxlKCk7Ci19Ci0KLXFyZWFsIFBhZ2VWaWV3cG9y dENvbnRyb2xsZXJDbGllbnRRdDo6Y3VycmVudENvbnRlbnRzU2NhbGUoKSBjb25zdAotewotICAg IHJldHVybiBtX3BhZ2VJdGVtLT5jb250ZW50c1NjYWxlKCk7Ci19Ci0KLVFTaXplRiBQYWdlVmll d3BvcnRDb250cm9sbGVyQ2xpZW50UXQ6OmNvbnRlbnRzTGF5b3V0U2l6ZSgpIGNvbnN0Ci17Ci0g ICAgcmV0dXJuIG1fY29udHJvbGxlci0+Y29udGVudHNMYXlvdXRTaXplKCk7Ci19Ci0KIGJvb2wg UGFnZVZpZXdwb3J0Q29udHJvbGxlckNsaWVudFF0OjpzY3JvbGxBbmltYXRpb25BY3RpdmUoKSBj b25zdAogewogICAgIHJldHVybiBtX3ZpZXdwb3J0SXRlbS0+aXNGbGlja2luZygpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRyb2xsZXJD bGllbnRRdC5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL3F0L1BhZ2VWaWV3cG9ydENvbnRy b2xsZXJDbGllbnRRdC5oCmluZGV4IGE3YmQ1MmJjNWMwM2FhZmRmYzM3MWY0MTFjOWM2ZDEyODQ5 MzdiZTcuLjRkNmFlYmM4ODZkZTZmZmY3MTcyODdmZDMyMTU3MzlhNjQ0ZWM2OGIgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9xdC9QYWdlVmlld3BvcnRDb250cm9sbGVyQ2xp ZW50UXQuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvcXQvUGFnZVZpZXdwb3J0Q29u dHJvbGxlckNsaWVudFF0LmgKQEAgLTEyMCwxMyArMTIwLDYgQEAgcHJpdmF0ZToKICAgICBRUXVp Y2tXZWJWaWV3KiBjb25zdCBtX3ZpZXdwb3J0SXRlbTsKICAgICBRUXVpY2tXZWJQYWdlKiBjb25z dCBtX3BhZ2VJdGVtOwogCi0gICAgYm9vbCBhbGxvd3NVc2VyU2NhbGluZygpIGNvbnN0OwotICAg IHFyZWFsIGRldmljZVBpeGVsUmF0aW8oKSBjb25zdDsKLSAgICBxcmVhbCBtaW5pbXVtQ29udGVu dHNTY2FsZSgpIGNvbnN0OwotICAgIHFyZWFsIG1heGltdW1Db250ZW50c1NjYWxlKCkgY29uc3Q7 Ci0gICAgcXJlYWwgY3VycmVudENvbnRlbnRzU2NhbGUoKSBjb25zdDsKLSAgICBRU2l6ZUYgY29u dGVudHNMYXlvdXRTaXplKCkgY29uc3Q7Ci0KICAgICBmbG9hdCB2aWV3cG9ydFNjYWxlRm9yUmVj dChjb25zdCBRUmVjdEYmKSBjb25zdDsKICAgICBRUmVjdEYgdmlzaWJsZUNvbnRlbnRzUmVjdCgp IGNvbnN0OwogICAgIFFSZWN0RiBuZWFyZXN0VmFsaWRWaXNpYmxlQ29udGVudHNSZWN0KCkgY29u c3Q7Cg==