96093 2012-09-07 03:56:31 -0700 SVGSMILElement.cpp: fix float-to-bool conversion compiler warning 2012-10-08 16:14:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED DUPLICATE 94756 P2 Normal --- 1 hans hans thakis webkit.review.bot oldest_to_newest 714366 0 hans 2012-09-07 03:56:31 -0700 SVGSMILElement.cpp: fix float-to-bool conversion compiler warning 714369 1 162733 hans 2012-09-07 03:57:37 -0700 Created attachment 162733 Patch 714371 2 webkit.review.bot 2012-09-07 04:02:48 -0700 Attachment 162733 did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/svg/animation/SVGSMILElement.cpp:970: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 714372 3 hans 2012-09-07 04:03:37 -0700 thakis: ToT Clang warns about this. But the fix goes against WebKit style guides :/ It's the second argument that triggers the warning: !simpleDuration.value(). Clang warns about the last argument in a function call is implicitly converted from bool to float, and the function returns a float which gets implicitly converted to bool. 714484 4 hans 2012-09-07 07:06:52 -0700 *** This bug has been marked as a duplicate of bug 94756 *** 737183 5 162733 eric 2012-10-08 16:14:25 -0700 Comment on attachment 162733 Patch Cleared review? from attachment 162733 so that this bug does not appear in http://webkit.org/pending-review. If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again). 162733 2012-09-07 03:57:37 -0700 2012-10-08 16:14:24 -0700 Patch bug-96093-20120907115716.patch text/plain 2156 hans U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3ODM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2IwY2FlM2NlMDc0YjY0 MTYxMjYwZmQ5NmQxNTEyZTg2Yjg3YWY1MS4uZmQyN2IxYWI5NjM2ZGExMDg1NjJiYzk0MjdkMTI3 Yzc5YmUxMDgwMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDEyLTA5LTA3ICBIYW5z IFdlbm5ib3JnICA8aGFuc0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgU1ZHU01JTEVsZW1lbnQu Y3BwOiBmaXggZmxvYXQtdG8tYm9vbCBjb252ZXJzaW9uIGNvbXBpbGVyIHdhcm5pbmcKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MDkzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVjZW50IHZlcnNpb25z IG9mIENsYW5nIHdhcm5zIGFib3V0IHRoaXM6CisKKyAgICAgICAgLi4vLi4vdGhpcmRfcGFydHkv V2ViS2l0L1NvdXJjZS9XZWJDb3JlL3N2Zy9hbmltYXRpb24vU1ZHU01JTEVsZW1lbnQuY3BwOjk3 MDoxMzogZXJyb3I6IGltcGxpY2l0IGNvbnZlcnNpb24gdHVybnMgZmxvYXRpbmctcG9pbnQgbnVt YmVyIGludG8gYm9vbDogJ2RvdWJsZScgdG8gJ2Jvb2wnIFstV2Vycm9yLC1XaW1wbGljaXQtY29u dmVyc2lvbi1mbG9hdGluZy1wb2ludC10by1ib29sXQorICAgICAgICBpZiAoZm1vZChyZXBlYXRp bmdEdXJhdGlvbi52YWx1ZSgpLCAhc2ltcGxlRHVyYXRpb24udmFsdWUoKSkpCisgICAgICAgIH5+ ICBefn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+fn5+ fgorCisgICAgICAgIE5vIG5ldyBmdW5jdGlvbmFsaXR5OyBubyBuZXcgdGVzdHMuCisKKyAgICAg ICAgKiBzdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OlNWR1NNSUxFbGVtZW50OjpjYWxjdWxhdGVBbmltYXRpb25QZXJjZW50QW5kUmVwZWF0KToKKwog MjAxMi0wOS0wNyAgTHVrZSBNYWNwaGVyc29uICAgPG1hY3BoZXJzb25AY2hyb21pdW0ub3JnPgog CiAgICAgICAgIE1ha2UgQ1NTUHJpbWl0aXZlVmFsdWU6OmNsZWFudXAoKSBoYW5kbGUgYWxsIFVu aXRUeXBlcywgZml4aW5nIG1lbW9yeSBsZWFrIGluIHRoZSBwcm9jZXNzLgpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvc3ZnL2FuaW1hdGlvbi9TVkdTTUlMRWxlbWVudC5jcHAgYi9Tb3VyY2Uv V2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NWR1NNSUxFbGVtZW50LmNwcAppbmRleCBhNTEzMmEwNWZl ZmM2ZTU2NjMxZDc1MDYwM2I1ODAxN2I4MTYyOWQ0Li42Mjg2NWJlYTIyYzFlNzM5NTY1NjBkMWRj MTc0MjU2MGVhZGIyMGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9u L1NWR1NNSUxFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9zdmcvYW5pbWF0aW9uL1NW R1NNSUxFbGVtZW50LmNwcApAQCAtOTY3LDcgKzk2Nyw3IEBAIGZsb2F0IFNWR1NNSUxFbGVtZW50 OjpjYWxjdWxhdGVBbmltYXRpb25QZXJjZW50QW5kUmVwZWF0KFNNSUxUaW1lIGVsYXBzZWQsIHVu c2lnCiAgICAgU01JTFRpbWUgcmVwZWF0aW5nRHVyYXRpb24gPSB0aGlzLT5yZXBlYXRpbmdEdXJh dGlvbigpOwogICAgIGlmIChlbGFwc2VkID49IG1faW50ZXJ2YWxFbmQgfHwgYWN0aXZlVGltZSA+ IHJlcGVhdGluZ0R1cmF0aW9uKSB7CiAgICAgICAgIHJlcGVhdCA9IHN0YXRpY19jYXN0PHVuc2ln bmVkPihyZXBlYXRpbmdEdXJhdGlvbi52YWx1ZSgpIC8gc2ltcGxlRHVyYXRpb24udmFsdWUoKSk7 Ci0gICAgICAgIGlmIChmbW9kKHJlcGVhdGluZ0R1cmF0aW9uLnZhbHVlKCksICFzaW1wbGVEdXJh dGlvbi52YWx1ZSgpKSkKKyAgICAgICAgaWYgKGZtb2QocmVwZWF0aW5nRHVyYXRpb24udmFsdWUo KSwgIXNpbXBsZUR1cmF0aW9uLnZhbHVlKCkpICE9IDApCiAgICAgICAgICAgICByZXBlYXQtLTsK IAogICAgICAgICBkb3VibGUgcGVyY2VudCA9IChtX2ludGVydmFsRW5kLnZhbHVlKCkgLSBtX2lu dGVydmFsQmVnaW4udmFsdWUoKSkgLyBzaW1wbGVEdXJhdGlvbi52YWx1ZSgpOwo=