9609 2006-06-26 11:28:15 -0700 REGRESSION: Missing image icon needs to be moved back to WebKit 2007-03-10 14:52:23 -0800 1 1 1 Unclassified WebKit New Bugs 420+ Mac OS X 10.4 RESOLVED FIXED EasyFix, InRadar, Regression P1 Normal --- 1 adele webkit-unassigned fishd ian oldest_to_newest 47309 0 adele 2006-06-26 11:28:15 -0700 Missing image icon needs to be moved back to WebKit We moved this down to WebCore thinking that it was only used in WebCore, but that's not true. WebHTMLView.m:1391 still tries to load it. 47367 1 darin 2006-06-27 10:19:13 -0700 We can: 1) change WebKit to load the one in WebCore, or 2) move the WebCore one back into WebKit, or 3) have two copies, or 4) move the code in WebKit that uses the missing image into WebCore. 48330 2 alice.barraclough 2006-07-05 09:41:04 -0700 <rdar://problem/4613571> 25341 3 mjs 2007-02-07 03:39:12 -0800 Does this have a real symptom? 19730 4 13570 ddkilzer 2007-03-09 16:49:43 -0800 Created attachment 13570 Patch v1 Proposed patch implementing item 4 in Comment #1. Compiles. I wasn't sure how to test this since the method is a bit too complex (IMO) for an ObjC test, although I didn't actually try that option yet. I also thought about creating a new method that simply returns the missing image (so that loadPlatformResource() isn't exported), but I'm not sure if that's a concern or not. 19677 5 13570 darin 2007-03-10 09:10:10 -0800 Comment on attachment 13570 Patch v1 r=me 19575 6 ddkilzer 2007-03-10 14:52:23 -0800 Committed revision 20097. 13570 2007-03-09 16:49:43 -0800 2007-03-10 09:10:10 -0800 Patch v1 bug-9609-v1.diff text/plain 3463 ddkilzer SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMDA5MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDctMDMtMDkgIERhdmlkIEtpbHplciAgPGRka2lsemVyQHdlYmtp dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg LSBmaXggaHR0cDovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYwOQorICAgICAg ICAgIFJFR1JFU1NJT046IE1pc3NpbmcgaW1hZ2UgaWNvbiBuZWVkcyB0byBiZSBtb3ZlZCBiYWNr IHRvIFdlYktpdAorCisgICAgICAgICogV2ViQ29yZS5leHA6IEV4cG9ydCBXZWJDb3JlOjpJbWFn ZTo6bG9hZFBsYXRmb3JtUmVzb3VyY2UoY29uc3QgY2hhciopIGZvciB1c2UgaW4KKyAgICAgICAg W1dlYkhUTUxWaWV3IF9zdGFydERyYWdnaW5nSW1hZ2U6YXQ6b3BlcmF0aW9uOmV2ZW50OnNvdXJj ZUlzREhUTUw6REhUTUxXcm90ZURhdGE6XS4KKwogMjAwNy0wMy0wOSAgTWl0eiBQZXR0ZWwgIDxt aXR6QHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4uCkluZGV4OiBXZWJD b3JlL1dlYkNvcmUuZXhwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvV2ViQ29yZS5leHAJKHJldmlz aW9uIDIwMDkxKQorKysgV2ViQ29yZS9XZWJDb3JlLmV4cAkod29ya2luZyBjb3B5KQpAQCAtMzUx LDYgKzM1MSw3IEBAIF9fWk43V2ViQ29yZTVGcmFtZTI2ZGFzaGJvYXJkUmVnaW9uc0RpY3QKIF9f Wk43V2ViQ29yZTVGcmFtZTlzZXRCcmlkZ2VFUDE4V2ViQ29yZUZyYW1lQnJpZGdlCiBfX1pON1dl YkNvcmU1RnJhbWVDMUVQTlNfNFBhZ2VFUE5TXzIxSFRNTEZyYW1lT3duZXJFbGVtZW50RVBOU18x N0ZyYW1lTG9hZGVyQ2xpZW50RQogX19aTjdXZWJDb3JlNUltYWdlMTBnZXROU0ltYWdlRXYKK19f Wk43V2ViQ29yZTVJbWFnZTIwbG9hZFBsYXRmb3JtUmVzb3VyY2VFUEtjCiBfX1pON1dlYkNvcmU1 SW1hZ2UyMWdldFRJRkZSZXByZXNlbnRhdGlvbkV2CiBfX1pON1dlYkNvcmU1UmFuZ2VDMUVQTlNf OERvY3VtZW50RVBOU180Tm9kZUVpUzRfaQogX19aTjdXZWJDb3JlNVJhbmdlRDFFdgpJbmRleDog V2ViS2l0L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvQ2hhbmdlTG9nCShyZXZpc2lv biAyMDA5MSkKKysrIFdlYktpdC9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NCBAQAorMjAwNy0wMy0wOSAgRGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAd2Via2l0Lm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAtIGZpeCBodHRw Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD05NjA5CisgICAgICAgICAgUkVHUkVT U0lPTjogTWlzc2luZyBpbWFnZSBpY29uIG5lZWRzIHRvIGJlIG1vdmVkIGJhY2sgdG8gV2ViS2l0 CisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkhUTUxWaWV3Lm1tOgorICAgICAgICAoLVtXZWJIVE1M VmlldyBfc3RhcnREcmFnZ2luZ0ltYWdlOmF0Om9wZXJhdGlvbjpldmVudDpzb3VyY2VJc0RIVE1M OkRIVE1MV3JvdGVEYXRhOl0pOgorICAgICAgICBVc2UgV2ViQ29yZTo6SW1hZ2U6OmxvYWRQbGF0 Zm9ybVJlc291cmNlKGNvbnN0IGNoYXIqKSB0byBsb2FkIHRoZSBtaXNzaW5nSW1hZ2UgaW1hZ2Uu CisKIDIwMDctMDMtMDkgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAg ICogRW5nbGlzaC5scHJvai9TdHJpbmdzTm90VG9CZUxvY2FsaXplZC50eHQ6IFVwZGF0ZWQgZm9y IHJlY2VudCBjaGFuZ2VzLgpJbmRleDogV2ViS2l0L1dlYlZpZXcvV2ViSFRNTFZpZXcubW0KPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0L1dlYlZpZXcvV2ViSFRNTFZpZXcubW0JKHJldmlzaW9uIDIwMDkx KQorKysgV2ViS2l0L1dlYlZpZXcvV2ViSFRNTFZpZXcubW0JKHdvcmtpbmcgY29weSkKQEAgLTgx LDYgKzgxLDcgQEAKICNpbXBvcnQgPFdlYkNvcmUvRm9jdXNDb250cm9sbGVyLmg+CiAjaW1wb3J0 IDxXZWJDb3JlL0ZyYW1lLmg+CiAjaW1wb3J0IDxXZWJDb3JlL0hpdFRlc3RSZXN1bHQuaD4KKyNp bXBvcnQgPFdlYkNvcmUvSW1hZ2UuaD4KICNpbXBvcnQgPFdlYkNvcmUvS2V5Ym9hcmRFdmVudC5o PgogI2ltcG9ydCA8V2ViQ29yZS9NaW1lVHlwZVJlZ2lzdHJ5Lmg+CiAjaW1wb3J0IDxXZWJDb3Jl L1BhZ2UuaD4KQEAgLTE0NDIsOSArMTQ0Myw3IEBAIHN0YXRpYyBOU1VSTCogdW5pcXVlVVJMV2l0 aFJlbGF0aXZlUGFydCgKICAgICAgICAgW1t3ZWJWaWV3IF9VSURlbGVnYXRlRm9yd2FyZGVyXSB3 ZWJWaWV3OndlYlZpZXcgd2lsbFBlcmZvcm1EcmFnU291cmNlQWN0aW9uOldlYkRyYWdTb3VyY2VB Y3Rpb25ESFRNTCBmcm9tUG9pbnQ6bW91c2VEb3duUG9pbnQgd2l0aFBhc3RlYm9hcmQ6cGFzdGVi b2FyZF07CiAgICAgICAgIGlmIChkcmFnSW1hZ2UgPT0gbmlsKSB7CiAgICAgICAgICAgICAvLyBX ZWJDb3JlIHNob3VsZCBoYXZlIGdpdmVuIHVzIGFuIGltYWdlLCBidXQgd2UnbGwgbWFrZSBvbmUg dXAKLSAgICAgICAgICAgIC8vIEZJWE1FOiBPb3BzISBJIHJlbW92ZWQgdGhpcyBpbWFnZSBmcm9t IFdlYktpdC4gSXMgdGhpcyBhIGRlYWQgY29kZSBwYXRoPwotICAgICAgICAgICAgTlNTdHJpbmcg KmltYWdlUGF0aCA9IFtbTlNCdW5kbGUgYnVuZGxlRm9yQ2xhc3M6W3NlbGYgY2xhc3NdXSBwYXRo Rm9yUmVzb3VyY2U6QCJtaXNzaW5nX2ltYWdlIiBvZlR5cGU6QCJ0aWZmIl07Ci0gICAgICAgICAg ICBkcmFnSW1hZ2UgPSBbW1tOU0ltYWdlIGFsbG9jXSBpbml0V2l0aENvbnRlbnRzT2ZGaWxlOmlt YWdlUGF0aF0gYXV0b3JlbGVhc2VdOworICAgICAgICAgICAgZHJhZ0ltYWdlID0gSW1hZ2U6Omxv YWRQbGF0Zm9ybVJlc291cmNlKCJtaXNzaW5nSW1hZ2UiKS0+Z2V0TlNJbWFnZSgpOwogICAgICAg ICAgICAgTlNTaXplIGltYWdlU2l6ZSA9IFtkcmFnSW1hZ2Ugc2l6ZV07CiAgICAgICAgICAgICBk cmFnTG9jID0gTlNNYWtlUG9pbnQobW91c2VEb3duUG9pbnQueCAtIGltYWdlU2l6ZS53aWR0aCAv IDIsIG1vdXNlRG93blBvaW50LnkgKyBpbWFnZVNpemUuaGVpZ2h0IC8gMik7CiAgICAgICAgICAg ICBkcmFnQ29udHJvbGxlci0+c2V0RHJhZ09mZnNldChJbnRQb2ludCgoaW50KShpbWFnZVNpemUu d2lkdGggLyAyKSwgKGludCkoaW1hZ2VTaXplLmhlaWdodCAvIDIpKSk7Cg==