96082 2012-09-07 01:18:35 -0700 Fix FilterTypeZoom to properly call canvas->restore() 2012-09-11 09:44:14 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 zork zork cc-bugs enne jamesr senorblanco webkit.review.bot oldest_to_newest 714265 0 zork 2012-09-07 01:18:35 -0700 Fix FilterTypeZoom to properly call canvas->restore() 714269 1 162703 zork 2012-09-07 01:19:58 -0700 Created attachment 162703 Patch 714622 2 162703 enne 2012-09-07 09:50:47 -0700 Comment on attachment 162703 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162703&action=review > Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:443 > - canvas->drawBitmap(state.source(), 0, 0); > + canvas->drawSprite(state.source(), 0, 0, &paint); Not being a Skia expert, can you explain this change? I see that the difference between drawSprite and drawBitmap is that drawSprite ignores the transform on the canvas, but I don't understand why you would want to do that here. 715720 3 163040 zork 2012-09-09 22:34:36 -0700 Created attachment 163040 Patch 715722 4 zork 2012-09-09 22:36:21 -0700 (In reply to comment #2) > (From update of attachment 162703 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=162703&action=review > > > Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:443 > > - canvas->drawBitmap(state.source(), 0, 0); > > + canvas->drawSprite(state.source(), 0, 0, &paint); > > Not being a Skia expert, can you explain this change? I see that the difference between drawSprite and drawBitmap is that drawSprite ignores the transform on the canvas, but I don't understand why you would want to do that here. Upon further investigation, it seems that "canvas->Restore()" was sufficient, so I reverted this call. 716255 5 163040 enne 2012-09-10 10:46:39 -0700 Comment on attachment 163040 Patch R=me. 717282 6 163040 webkit.review.bot 2012-09-11 09:44:11 -0700 Comment on attachment 163040 Patch Clearing flags on attachment: 163040 Committed r128196: <http://trac.webkit.org/changeset/128196> 717283 7 webkit.review.bot 2012-09-11 09:44:14 -0700 All reviewed patches have been landed. Closing bug. 162703 2012-09-07 01:19:58 -0700 2012-09-09 22:34:32 -0700 Patch bug-96082-20120907171937.patch text/plain 3539 zork U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBhOTc5MTgzNGEzMmU4 Nzg5MzA5YjlkZDY3NTliMzBmZGE0NGM2MWIyLi43NGUwZDdlOTBlZGRlMTIwMDVkZWIxYmE5NDEx OWZmYTQxM2JhZjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOS0wNyAg WmFjaCBLdXpuaWEgIDx6b3JrQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggRmlsdGVyVHlw ZVpvb20gdG8gcHJvcGVybHkgY2FsbCBjYW52YXMtPnJlc3RvcmUoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYwODIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggem9vbSBmaWx0ZXIgdG8gcHJvcGVy bHkgaW5kaWNhdGUgdGhhdCBpdCBhZmZlY3RzIHBpeGVscy4KKworICAgICAgICAqIGNocm9taXVt L3NyYy9XZWJGaWx0ZXJPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRmlsdGVy T3BlcmF0aW9uczo6aGFzRmlsdGVyVGhhdE1vdmVzUGl4ZWxzKToKKyAgICAgICAgKFdlYktpdDo6 V2ViRmlsdGVyT3BlcmF0aW9uczo6aGFzRmlsdGVyVGhhdEFmZmVjdHNPcGFjaXR5KToKKwogMjAx Mi0wOS0wNiAgSGlyb25vcmkgQm9ubyAgPGhib25vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBB IGJ1aWxkIGZpeCBmb3IgQ2hyb21pdW0gV2luZG93cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDY0NGJlODI0NDJh OTIyMmQzZWZiZTBhYmFkMmQwZjg4YjgzNmEwMmMuLjVkNjdlYzA3NmUxZDQwMTAzOTQxZTgxMDAx MjQ1NTUxM2VjMWNmYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0wNyAg WmFjaCBLdXpuaWEgIDx6b3JrQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggRmlsdGVyVHlw ZVpvb20gdG8gcHJvcGVybHkgY2FsbCBjYW52YXMtPnJlc3RvcmUoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYwODIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggem9vbSBmaWx0ZXIgdG8gcHJvcGVy bHkgY2FsbCBjYW52YXMtPnJlc3RvcmUoKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NSZW5kZXJTdXJmYWNlRmlsdGVycy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDQ1JlbmRlclN1cmZhY2VGaWx0ZXJzOjphcHBseSk6CisKIDIwMTItMDktMDYgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4IGZvciBX aW5DRSBhZnRlciByMTI3ODAxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3NyYy9XZWJGaWx0ZXJPcGVyYXRpb25zLmNwcCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9z cmMvV2ViRmlsdGVyT3BlcmF0aW9ucy5jcHAKaW5kZXggODgyZDVhMWU4NWY2MjZjODc2NTU1YTQ1 MzNhMWI1ZjlhNmY3Yjc2MC4uZDcyNGQ1MzE2NjBjNDEzODY0ZjY2ZjViYjkwY2NhMTg2MjdmN2Yx YiAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3NyYy9XZWJGaWx0ZXJPcGVy YXRpb25zLmNwcAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vc3JjL1dlYkZpbHRlck9w ZXJhdGlvbnMuY3BwCkBAIC0xMTYsNiArMTE2LDcgQEAgYm9vbCBXZWJGaWx0ZXJPcGVyYXRpb25z OjpoYXNGaWx0ZXJUaGF0TW92ZXNQaXhlbHMoKSBjb25zdAogICAgICAgICBzd2l0Y2ggKG9wLnR5 cGUoKSkgewogICAgICAgICBjYXNlIFdlYkZpbHRlck9wZXJhdGlvbjo6RmlsdGVyVHlwZUJsdXI6 CiAgICAgICAgIGNhc2UgV2ViRmlsdGVyT3BlcmF0aW9uOjpGaWx0ZXJUeXBlRHJvcFNoYWRvdzoK KyAgICAgICAgY2FzZSBXZWJGaWx0ZXJPcGVyYXRpb246OkZpbHRlclR5cGVab29tOgogICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICBicmVhazsK QEAgLTEzMiw2ICsxMzMsNyBAQCBib29sIFdlYkZpbHRlck9wZXJhdGlvbnM6Omhhc0ZpbHRlclRo YXRBZmZlY3RzT3BhY2l0eSgpIGNvbnN0CiAgICAgICAgIGNhc2UgV2ViRmlsdGVyT3BlcmF0aW9u OjpGaWx0ZXJUeXBlT3BhY2l0eToKICAgICAgICAgY2FzZSBXZWJGaWx0ZXJPcGVyYXRpb246OkZp bHRlclR5cGVCbHVyOgogICAgICAgICBjYXNlIFdlYkZpbHRlck9wZXJhdGlvbjo6RmlsdGVyVHlw ZURyb3BTaGFkb3c6CisgICAgICAgIGNhc2UgV2ViRmlsdGVyT3BlcmF0aW9uOjpGaWx0ZXJUeXBl Wm9vbToKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICBjYXNlIFdlYkZpbHRlck9w ZXJhdGlvbjo6RmlsdGVyVHlwZUNvbG9yTWF0cml4OiB7CiAgICAgICAgICAgICBjb25zdCBTa1Nj YWxhciogbWF0cml4ID0gb3AubWF0cml4KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2VGaWx0ZXJzLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3Vy ZmFjZUZpbHRlcnMuY3BwCmluZGV4IGYwYjI2NTk3MTFlMmZjYjg4YTA5OGFkZWJkMGJiOTNjODNh ODU0NTUuLmQxMTg2YzE0ZTkyOWY1ODhkOGIzMThmNTgzZmJiY2VjYmY4YzcyMjUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVy U3VyZmFjZUZpbHRlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnMuY3BwCkBAIC00NDAsNyArNDQwLDgg QEAgU2tCaXRtYXAgQ0NSZW5kZXJTdXJmYWNlRmlsdGVyczo6YXBwbHkoY29uc3QgV2ViS2l0OjpX ZWJGaWx0ZXJPcGVyYXRpb25zJiBmaWx0ZXIKICAgICAgICAgICAgICAgICAgICAgb3AuYW1vdW50 KCkpKTsKICAgICAgICAgICAgIHBhaW50LnNldEltYWdlRmlsdGVyKHpvb21GaWx0ZXIuZ2V0KCkp OwogICAgICAgICAgICAgY2FudmFzLT5zYXZlTGF5ZXIoMCwgJnBhaW50KTsKLSAgICAgICAgICAg IGNhbnZhcy0+ZHJhd0JpdG1hcChzdGF0ZS5zb3VyY2UoKSwgMCwgMCk7CisgICAgICAgICAgICBj YW52YXMtPmRyYXdTcHJpdGUoc3RhdGUuc291cmNlKCksIDAsIDAsICZwYWludCk7CisgICAgICAg ICAgICBjYW52YXMtPnJlc3RvcmUoKTsKICAgICAgICAgICAgIGJyZWFrOwogICAgICAgICB9CiAg ICAgICAgIGNhc2UgV2ViS2l0OjpXZWJGaWx0ZXJPcGVyYXRpb246OkZpbHRlclR5cGVCcmlnaHRu ZXNzOgo= 163040 2012-09-09 22:34:36 -0700 2012-09-11 09:44:11 -0700 Patch bug-96082-20120910143412.patch text/plain 3440 zork U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3ODM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvUGxhdGZvcm0v Q2hhbmdlTG9nIGIvU291cmNlL1BsYXRmb3JtL0NoYW5nZUxvZwppbmRleCBhOTc5MTgzNGEzMmU4 Nzg5MzA5YjlkZDY3NTliMzBmZGE0NGM2MWIyLi43NGUwZDdlOTBlZGRlMTIwMDVkZWIxYmE5NDEx OWZmYTQxM2JhZjRhIDEwMDY0NAotLS0gYS9Tb3VyY2UvUGxhdGZvcm0vQ2hhbmdlTG9nCisrKyBi L1NvdXJjZS9QbGF0Zm9ybS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMi0wOS0wNyAg WmFjaCBLdXpuaWEgIDx6b3JrQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggRmlsdGVyVHlw ZVpvb20gdG8gcHJvcGVybHkgY2FsbCBjYW52YXMtPnJlc3RvcmUoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYwODIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggem9vbSBmaWx0ZXIgdG8gcHJvcGVy bHkgaW5kaWNhdGUgdGhhdCBpdCBhZmZlY3RzIHBpeGVscy4KKworICAgICAgICAqIGNocm9taXVt L3NyYy9XZWJGaWx0ZXJPcGVyYXRpb25zLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViRmlsdGVy T3BlcmF0aW9uczo6aGFzRmlsdGVyVGhhdE1vdmVzUGl4ZWxzKToKKyAgICAgICAgKFdlYktpdDo6 V2ViRmlsdGVyT3BlcmF0aW9uczo6aGFzRmlsdGVyVGhhdEFmZmVjdHNPcGFjaXR5KToKKwogMjAx Mi0wOS0wNiAgSGlyb25vcmkgQm9ubyAgPGhib25vQGNocm9taXVtLm9yZz4KIAogICAgICAgICBB IGJ1aWxkIGZpeCBmb3IgQ2hyb21pdW0gV2luZG93cwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDY0NGJlODI0NDJh OTIyMmQzZWZiZTBhYmFkMmQwZjg4YjgzNmEwMmMuLjVkNjdlYzA3NmUxZDQwMTAzOTQxZTgxMDAx MjQ1NTUxM2VjMWNmYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysg Yi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMi0wOS0wNyAg WmFjaCBLdXpuaWEgIDx6b3JrQGNocm9taXVtLm9yZz4KKworICAgICAgICBGaXggRmlsdGVyVHlw ZVpvb20gdG8gcHJvcGVybHkgY2FsbCBjYW52YXMtPnJlc3RvcmUoKQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYwODIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggem9vbSBmaWx0ZXIgdG8gcHJvcGVy bHkgY2FsbCBjYW52YXMtPnJlc3RvcmUoKQorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv Y2hyb21pdW0vY2MvQ0NSZW5kZXJTdXJmYWNlRmlsdGVycy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpDQ1JlbmRlclN1cmZhY2VGaWx0ZXJzOjphcHBseSk6CisKIDIwMTItMDktMDYgIFBhdHJpY2sg R2Fuc3RlcmVyICA8cGFyb2dhQHdlYmtpdC5vcmc+CiAKICAgICAgICAgQnVpbGQgZml4IGZvciBX aW5DRSBhZnRlciByMTI3ODAxLgpkaWZmIC0tZ2l0IGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVt L3NyYy9XZWJGaWx0ZXJPcGVyYXRpb25zLmNwcCBiL1NvdXJjZS9QbGF0Zm9ybS9jaHJvbWl1bS9z cmMvV2ViRmlsdGVyT3BlcmF0aW9ucy5jcHAKaW5kZXggODgyZDVhMWU4NWY2MjZjODc2NTU1YTQ1 MzNhMWI1ZjlhNmY3Yjc2MC4uZDcyNGQ1MzE2NjBjNDEzODY0ZjY2ZjViYjkwY2NhMTg2MjdmN2Yx YiAxMDA2NDQKLS0tIGEvU291cmNlL1BsYXRmb3JtL2Nocm9taXVtL3NyYy9XZWJGaWx0ZXJPcGVy YXRpb25zLmNwcAorKysgYi9Tb3VyY2UvUGxhdGZvcm0vY2hyb21pdW0vc3JjL1dlYkZpbHRlck9w ZXJhdGlvbnMuY3BwCkBAIC0xMTYsNiArMTE2LDcgQEAgYm9vbCBXZWJGaWx0ZXJPcGVyYXRpb25z OjpoYXNGaWx0ZXJUaGF0TW92ZXNQaXhlbHMoKSBjb25zdAogICAgICAgICBzd2l0Y2ggKG9wLnR5 cGUoKSkgewogICAgICAgICBjYXNlIFdlYkZpbHRlck9wZXJhdGlvbjo6RmlsdGVyVHlwZUJsdXI6 CiAgICAgICAgIGNhc2UgV2ViRmlsdGVyT3BlcmF0aW9uOjpGaWx0ZXJUeXBlRHJvcFNoYWRvdzoK KyAgICAgICAgY2FzZSBXZWJGaWx0ZXJPcGVyYXRpb246OkZpbHRlclR5cGVab29tOgogICAgICAg ICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIGRlZmF1bHQ6CiAgICAgICAgICAgICBicmVhazsK QEAgLTEzMiw2ICsxMzMsNyBAQCBib29sIFdlYkZpbHRlck9wZXJhdGlvbnM6Omhhc0ZpbHRlclRo YXRBZmZlY3RzT3BhY2l0eSgpIGNvbnN0CiAgICAgICAgIGNhc2UgV2ViRmlsdGVyT3BlcmF0aW9u OjpGaWx0ZXJUeXBlT3BhY2l0eToKICAgICAgICAgY2FzZSBXZWJGaWx0ZXJPcGVyYXRpb246OkZp bHRlclR5cGVCbHVyOgogICAgICAgICBjYXNlIFdlYkZpbHRlck9wZXJhdGlvbjo6RmlsdGVyVHlw ZURyb3BTaGFkb3c6CisgICAgICAgIGNhc2UgV2ViRmlsdGVyT3BlcmF0aW9uOjpGaWx0ZXJUeXBl Wm9vbToKICAgICAgICAgICAgIHJldHVybiB0cnVlOwogICAgICAgICBjYXNlIFdlYkZpbHRlck9w ZXJhdGlvbjo6RmlsdGVyVHlwZUNvbG9yTWF0cml4OiB7CiAgICAgICAgICAgICBjb25zdCBTa1Nj YWxhciogbWF0cml4ID0gb3AubWF0cml4KCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9jYy9DQ1JlbmRlclN1cmZhY2VGaWx0ZXJzLmNwcCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVyU3Vy ZmFjZUZpbHRlcnMuY3BwCmluZGV4IGYwYjI2NTk3MTFlMmZjYjg4YTA5OGFkZWJkMGJiOTNjODNh ODU0NTUuLmI4NjkyNjMzYjQ4ZmRlOTY5ZWRlZjU3ZDQxYTg4YzM3NDg0Y2VmNWMgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL2NjL0NDUmVuZGVy U3VyZmFjZUZpbHRlcnMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2Nocm9taXVtL2NjL0NDUmVuZGVyU3VyZmFjZUZpbHRlcnMuY3BwCkBAIC00NDEsNiArNDQxLDcg QEAgU2tCaXRtYXAgQ0NSZW5kZXJTdXJmYWNlRmlsdGVyczo6YXBwbHkoY29uc3QgV2ViS2l0OjpX ZWJGaWx0ZXJPcGVyYXRpb25zJiBmaWx0ZXIKICAgICAgICAgICAgIHBhaW50LnNldEltYWdlRmls dGVyKHpvb21GaWx0ZXIuZ2V0KCkpOwogICAgICAgICAgICAgY2FudmFzLT5zYXZlTGF5ZXIoMCwg JnBhaW50KTsKICAgICAgICAgICAgIGNhbnZhcy0+ZHJhd0JpdG1hcChzdGF0ZS5zb3VyY2UoKSwg MCwgMCk7CisgICAgICAgICAgICBjYW52YXMtPnJlc3RvcmUoKTsKICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICB9CiAgICAgICAgIGNhc2UgV2ViS2l0OjpXZWJGaWx0ZXJPcGVyYXRpb246OkZp bHRlclR5cGVCcmlnaHRuZXNzOgo=