96078 2012-09-07 00:41:19 -0700 [Qt] Fix ROOT_BUILD_DIR on Windows MSVC build 2012-09-07 03:44:38 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Qt P2 Normal --- 0 zarvai webkit-unassigned abecsi hausmann ossy vestbo webkit.review.bot oldest_to_newest 714220 0 zarvai 2012-09-07 00:41:19 -0700 Currently QtWebKit MSVC build on Windows places JSC, DumpRenderTree, ImageDiff and QtTestBrowser to wrong directories: WebKitBuild\Release\Source\bin\jsc.exe WebKitBuild\Release\Tools\DumpRenderTree\bin\DumpRenderTree.exe WebKitBuild\Release\Tools\DumpRenderTree\bin\ImageDiff.exe WebKitBuild\Release\Tools\bin\QtTestBrowser.exe Those should land in WebKitBuild\Release\bin\ 714226 1 162694 zarvai 2012-09-07 00:45:40 -0700 Created attachment 162694 patch Correct JSC, DumpRenderTree, ImageDiff, QtTestBrowser binaries location by adding $$toSystemPath to ROOT_BUILD_DIR generation. 714361 2 162694 webkit.review.bot 2012-09-07 03:44:34 -0700 Comment on attachment 162694 patch Clearing flags on attachment: 162694 Committed r127851: <http://trac.webkit.org/changeset/127851> 714362 3 webkit.review.bot 2012-09-07 03:44:38 -0700 All reviewed patches have been landed. Closing bug. 162694 2012-09-07 00:45:40 -0700 2012-09-07 03:44:34 -0700 patch builddir.patch text/plain 1409 zarvai ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA1MTc4 YmM2Li5iZDI1NTM3IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTItMDktMDcgIFpvbHRhbiBBcnZhaSAgPHphcnZh aUBpbmYudS1zemVnZWQuaHU+CisKKyAgICAgICAgW1F0XSBGaXggUk9PVF9CVUlMRF9ESVIgb24g V2luZG93cyBNU1ZDIGJ1aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTYwNzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBDb3JyZWN0IEpTQywgRHVtcFJlbmRlclRyZWUsIEltYWdlRGlmZiwgUXRUZXN0 QnJvd3NlciBiaW5hcmllcyBsb2NhdGlvbiBieSBhZGRpbmcgJCR0b1N5c3RlbVBhdGggdG8gUk9P VF9CVUlMRF9ESVIgZ2VuZXJhdGlvbi4KKworICAgICAgICAqIHFtYWtlL21rc3BlY3MvZmVhdHVy ZXMvZGVmYXVsdF9wcmUucHJmOgorCiAyMDEyLTA5LTA2ICBKYW1lcyBSb2JpbnNvbiAgPGphbWVz ckBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2Nocm9taXVtXSBVc2UgV2ViQ29tcG9zaXRvclN1 cHBvcnQgZnVuY3Rpb25zIGluc3RlYWQgb2YgV2ViQ29tcG9zaXRvciBzdGF0aWNzCmRpZmYgLS1n aXQgYS9Ub29scy9xbWFrZS9ta3NwZWNzL2ZlYXR1cmVzL2RlZmF1bHRfcHJlLnByZiBiL1Rvb2xz L3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJmCmluZGV4IGVmYzFhZDkuLjdj ZGViMTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9w cmUucHJmCisrKyBiL1Rvb2xzL3FtYWtlL21rc3BlY3MvZmVhdHVyZXMvZGVmYXVsdF9wcmUucHJm CkBAIC0xOSw3ICsxOSw3IEBAIGlzRW1wdHkocHJvX2ZpbGUpOiBDT05GSUcgKz0gcmVjdXJzaXZl X2luY2x1ZGUKICMgUmVzb2x2ZSByb290IGRpcmVjdG9yaWVzIGZvciBzb3VyY2UgYW5kIGJ1aWxk CiBST09UX1dFQktJVF9ESVIgPSAkJHJlcGxhY2UoUFdELCAvVG9vbHMvcW1ha2UvbWtzcGVjcy9m ZWF0dXJlcyQsKQogV0VCS0lUX1NVQkRJUiA9ICQkcmVwbGFjZShfUFJPX0ZJTEVfUFdEXywgJCR7 Uk9PVF9XRUJLSVRfRElSfSwpCi1ST09UX0JVSUxEX0RJUiA9ICQkcmVwbGFjZShPVVRfUFdELCAk JHtXRUJLSVRfU1VCRElSfSQsKQorUk9PVF9CVUlMRF9ESVIgPSAkJHRvU3lzdGVtUGF0aCgkJHJl cGxhY2UoT1VUX1BXRCwgJCR7V0VCS0lUX1NVQkRJUn0kLCkpCiAKICMgV2Ugd2FudCB0aGUgUXRX ZWJLaXQgQVBJIGZvcndhcmRpbmcgaW5jbHVkZXMgdG8gbGl2ZSBpbiB0aGUgcm9vdCBidWlsZCBk aXIuCiBNT0RVTEVfQkFTRV9ESVIgPSAkJFJPT1RfV0VCS0lUX0RJUgo=