96074 2012-09-06 23:24:49 -0700 [EFL][WK2] Minibrowser locks up when right clicking editable filed 2012-09-09 19:33:21 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 95955 1 jinwoo7.song jinwoo7.song gyuyoung.kim lucas.de.marchi rakuco webkit.review.bot oldest_to_newest 714165 0 jinwoo7.song 2012-09-06 23:24:49 -0700 Minibrowser locks up when we click the input filed or text area with right mouse button. 715410 1 162977 jinwoo7.song 2012-09-08 22:24:04 -0700 Created attachment 162977 patch WebProcess crashes when the context menu type is SubmenuType and non-CROSS_PLATFORM_CONTEXT_MENUS is used. It is because platformSubMenu() in the ContextMenuItemEfl.cpp returns null. This patch implements the setSubMenu() and platformSubMenu() to set and return the subMenuItems. 715664 2 162977 gyuyoung.kim 2012-09-09 19:23:24 -0700 Comment on attachment 162977 patch Looks good to me because EFL port also uses Vector class for context menu item as chromium port. 715667 3 162977 webkit.review.bot 2012-09-09 19:33:17 -0700 Comment on attachment 162977 patch Clearing flags on attachment: 162977 Committed r128011: <http://trac.webkit.org/changeset/128011> 715668 4 webkit.review.bot 2012-09-09 19:33:21 -0700 All reviewed patches have been landed. Closing bug. 162977 2012-09-08 22:24:04 -0700 2012-09-09 19:33:17 -0700 patch LockUp.patch text/plain 2561 jinwoo7.song ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZTZmMTQ1Li4yN2Q5ZTBhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTItMDktMDggIEppbndvbyBTb25nICA8amlud29vNy5zb25nQHNhbXN1bmcuY29tPgor CisgICAgICAgIFtFRkxdW1dLMl0gTWluaWJyb3dzZXIgbG9ja3MgdXAgd2hlbiByaWdodCBjbGlj a2luZyBlZGl0YWJsZSBmaWxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9OTYwNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICBXZWJQcm9jZXNzIGNyYXNoZXMgd2hlbiB0aGUgY29udGV4dCBtZW51IHR5cGUg aXMgU3VibWVudVR5cGUgYW5kIG5vbi1DUk9TU19QTEFURk9STV9DT05URVhUX01FTlVTIGlzIHVz ZWQuCisgICAgICAgIEl0IGlzIGJlY2F1c2UgcGxhdGZvcm1TdWJNZW51KCkgaW4gdGhlIENvbnRl eHRNZW51SXRlbUVmbC5jcHAgcmV0dXJucyBudWxsLiBUaGlzIHBhdGNoIGltcGxlbWVudHMgdGhl IHNldFN1Yk1lbnUoKQorICAgICAgICBhbmQgcGxhdGZvcm1TdWJNZW51KCkgdG8gc2V0IGFuZCBy ZXR1cm4gdGhlIHN1Yk1lbnVJdGVtcy4KKworICAgICAgICAqIHBsYXRmb3JtL2VmbC9Db250ZXh0 TWVudUl0ZW1FZmwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29udGV4dE1lbnVJdGVtOjpzZXRT dWJNZW51KToKKyAgICAgICAgKFdlYkNvcmU6OkNvbnRleHRNZW51SXRlbTo6cGxhdGZvcm1TdWJN ZW51KToKKyAgICAgICAgKFdlYkNvcmUpOgorCiAyMDEyLTA5LTA2ICBZb3NoaWZ1bWkgSW5vdWUg IDx5b3NpbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgV2Ugc2hvdWxkIGhhdmUgbG9jYWxpemVk IHN0cmluZ3Mgb2YgZGF0ZSB0aW1lIGZpZWxkcyBmb3IgYWNjZXNzaWJpbGl0eQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZWZsL0NvbnRleHRNZW51SXRlbUVmbC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvQ29udGV4dE1lbnVJdGVtRWZsLmNwcAppbmRleCBi OGI2MjAxLi5jNGVkMDY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv Q29udGV4dE1lbnVJdGVtRWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9lZmwv Q29udGV4dE1lbnVJdGVtRWZsLmNwcApAQCAtMyw3ICszLDcgQEAKICAqIENvcHlyaWdodCAoQykg MjAwNyBTdGFpa29zIENvbXB1dGluZyBTZXJ2aWNlcyBJbmMuIDxpbmZvQHN0YWlrb3MubmV0Pgog ICogQ29weXJpZ2h0IChDKSAyMDA4IElOZFQgLSBJbnN0aXR1dG8gTm9raWEgZGUgVGVjbm9sb2dp YQogICogQ29weXJpZ2h0IChDKSAyMDA5LTIwMTAgUHJvRlVTSU9OIGVtYmVkZGVkIHN5c3RlbXMK LSAqIENvcHlyaWdodCAoQykgMjAxMSBTYW1zdW5nIEVsZWN0cm9uaWNzCisgKiBDb3B5cmlnaHQg KEMpIDIwMTEtMjAxMiBTYW1zdW5nIEVsZWN0cm9uaWNzCiAgKgogICogUmVkaXN0cmlidXRpb24g YW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBt b2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNv bmRpdGlvbnMKQEAgLTMzLDYgKzMzLDcgQEAKIAogI2luY2x1ZGUgIkNvbnRleHRNZW51SXRlbS5o IgogCisjaW5jbHVkZSAiQ29udGV4dE1lbnUuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5o IgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0xMjEsMTUgKzEyMiwyMSBAQCBib29sIENvbnRl eHRNZW51SXRlbTo6ZW5hYmxlZCgpIGNvbnN0CiAgICAgcmV0dXJuIG1fcGxhdGZvcm1EZXNjcmlw dGlvbi5lbmFibGVkOwogfQogCi12b2lkIENvbnRleHRNZW51SXRlbTo6c2V0U3ViTWVudShDb250 ZXh0TWVudSopCit2b2lkIENvbnRleHRNZW51SXRlbTo6c2V0U3ViTWVudShDb250ZXh0TWVudSog bWVudSkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAgIG1fcGxhdGZvcm1EZXNjcmlwdGlv bi5zdWJNZW51SXRlbXMgPSAqbWVudS0+cGxhdGZvcm1EZXNjcmlwdGlvbigpOwogfQogCiBQbGF0 Zm9ybU1lbnVEZXNjcmlwdGlvbiBDb250ZXh0TWVudUl0ZW06OnBsYXRmb3JtU3ViTWVudSgpIGNv bnN0Ci17ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgCi0gICAgcmV0dXJuIDA7Ci19ICAK K3sKKyAgICByZXR1cm4gJm1fcGxhdGZvcm1EZXNjcmlwdGlvbi5zdWJNZW51SXRlbXM7Cit9CisK K3ZvaWQgQ29udGV4dE1lbnVJdGVtOjpzZXRTdWJNZW51KFZlY3RvcjxDb250ZXh0TWVudUl0ZW0+ JiBpdGVtcykKK3sKKyAgICBtX3BsYXRmb3JtRGVzY3JpcHRpb24uc3ViTWVudUl0ZW1zID0gaXRl bXM7Cit9CisKICNlbmRpZgogfQogI2VuZGlmIC8vIEVOQUJMRShDT05URVhUX01FTlVTKQo=