96068 2012-09-06 22:25:30 -0700 webkit.py gdb pretty printer can't print CString 2012-09-08 00:35:58 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bashi bashi tony webkit.review.bot oldest_to_newest 714110 0 bashi 2012-09-06 22:25:30 -0700 Due to r126191. 714111 1 162671 bashi 2012-09-06 22:29:35 -0700 Created attachment 162671 Patch 714112 2 bashi 2012-09-06 22:30:21 -0700 Hi Tony, Could you take a look? 714628 3 162671 tony 2012-09-07 09:53:46 -0700 Comment on attachment 162671 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162671&action=review > Tools/gdb/webkit.py:119 > + data = self.val['m_buffer']['m_ptr']['m_data'].cast(gdb.lookup_type("char").pointer()) Nit: I would use ' instead of " to be consistent with the code around it. 715233 4 162934 bashi 2012-09-07 19:38:16 -0700 Created attachment 162934 Patch for landing 715234 5 162671 bashi 2012-09-07 19:38:39 -0700 Comment on attachment 162671 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162671&action=review >> Tools/gdb/webkit.py:119 >> + data = self.val['m_buffer']['m_ptr']['m_data'].cast(gdb.lookup_type("char").pointer()) > > Nit: I would use ' instead of " to be consistent with the code around it. Done. Thanks! 715305 6 162934 webkit.review.bot 2012-09-08 00:35:55 -0700 Comment on attachment 162934 Patch for landing Clearing flags on attachment: 162934 Committed r127965: <http://trac.webkit.org/changeset/127965> 715306 7 webkit.review.bot 2012-09-08 00:35:58 -0700 All reviewed patches have been landed. Closing bug. 162671 2012-09-06 22:29:35 -0700 2012-09-07 19:38:39 -0700 Patch bug-96068-20120907142915.patch text/plain 1689 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Nzk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTE3OGJjNjYzMWQ0NDNmMjYxY2QwMzE0MmZmZGJiOTE2 N2Q1ZjcyNy4uYzAwYzUxZThiOTIxYTRiOTllNzc1ODdlYmY4YTgzZGM3Y2I5OWFmOSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA5LTA2ICBLZW5pY2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4K KworICAgICAgICB3ZWJraXQucHkgZ2RiIHByZXR0eSBwcmludGVyIGNhbid0IHByaW50IENTdHJp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MDY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRl IFdURkNTdHJpbmdQcmludGVyIHRvIGZvbGxvdyByMTI2MTkxLgorCisgICAgICAgICogZ2RiL3dl YmtpdC5weToKKyAgICAgICAgKFdURkNTdHJpbmdQcmludGVyLnRvX3N0cmluZyk6CisKIDIwMTIt MDktMDYgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KIAogICAgICAgICBb Y2hyb21pdW1dIFVzZSBXZWJDb21wb3NpdG9yU3VwcG9ydCBmdW5jdGlvbnMgaW5zdGVhZCBvZiBX ZWJDb21wb3NpdG9yIHN0YXRpY3MKZGlmZiAtLWdpdCBhL1Rvb2xzL2dkYi93ZWJraXQucHkgYi9U b29scy9nZGIvd2Via2l0LnB5CmluZGV4IGJkZjNkMDg5MDIxMWI2MmZjMmI3NDBjZDA0ZTM0ODc4 MGY3YzFlZmUuLmYxZmRmZTE3NTE5MTE3NzllNWU5NWZkOGQyNjk1MzE5NzM0NWUwMzQgMTAwNjQ0 Ci0tLSBhL1Rvb2xzL2dkYi93ZWJraXQucHkKKysrIGIvVG9vbHMvZ2RiL3dlYmtpdC5weQpAQCAt MTE1LDEwICsxMTUsMTAgQEAgY2xhc3MgV1RGQXRvbWljU3RyaW5nUHJpbnRlcihTdHJpbmdQcmlu dGVyKToKIGNsYXNzIFdURkNTdHJpbmdQcmludGVyKFN0cmluZ1ByaW50ZXIpOgogICAgICJQcmlu dCBhIFdURjo6Q1N0cmluZyIKICAgICBkZWYgdG9fc3RyaW5nKHNlbGYpOgotICAgICAgICAjIFRo ZSBDU3RyaW5nIGhvbGRzIGEgYnVmZmVyLCB3aGljaCBpcyBhIHJlZnB0ciB0byBhIFdURjo6VmVj dG9yIG9mIGNoYXJzLgotICAgICAgICB2ZWN0b3IgPSBzZWxmLnZhbFsnbV9idWZmZXInXVsnbV9w dHInXVsnbV92ZWN0b3InXQotICAgICAgICAjIFRoZSB2ZWN0b3IgaGFzIHR3byBtb3JlIGxheWVy cyBvZiBidWZmZXIgbWVtYmVycy4KLSAgICAgICAgcmV0dXJuIHZlY3RvclsnbV9idWZmZXInXVsn bV9idWZmZXInXQorICAgICAgICAjIFRoZSBDU3RyaW5nIGhvbGRzIGEgYnVmZmVyLCB3aGljaCBp cyBhIHJlZnB0ciB0byBhIFdURjo6Q1N0cmluZ0J1ZmZlci4KKyAgICAgICAgZGF0YSA9IHNlbGYu dmFsWydtX2J1ZmZlciddWydtX3B0ciddWydtX2RhdGEnXS5jYXN0KGdkYi5sb29rdXBfdHlwZSgi Y2hhciIpLnBvaW50ZXIoKSkKKyAgICAgICAgbGVuZ3RoID0gc2VsZi52YWxbJ21fYnVmZmVyJ11b J21fcHRyJ11bJ21fbGVuZ3RoJ10KKyAgICAgICAgcmV0dXJuICcnLmpvaW4oW2NocigoZGF0YSAr IGkpLmRlcmVmZXJlbmNlKCkpIGZvciBpIGluIHhyYW5nZShsZW5ndGgpXSkKIAogCiBjbGFzcyBX VEZTdHJpbmdJbXBsUHJpbnRlcihTdHJpbmdQcmludGVyKToK 162934 2012-09-07 19:38:16 -0700 2012-09-08 00:35:54 -0700 Patch for landing bug-96068-20120908113755.patch text/plain 1685 bashi U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Nzk5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTE3OGJjNjYzMWQ0NDNmMjYxY2QwMzE0MmZmZGJiOTE2 N2Q1ZjcyNy4uNTA1NmFhZDg2YjRlMzVmYmZiZDlkOWZiNDY3Nzk4YjgwYzE4ZmM1ZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA5LTA3ICBLZW5pY2hpIElzaGliYXNoaSAgPGJhc2hpQGNocm9taXVtLm9yZz4K KworICAgICAgICB3ZWJraXQucHkgZ2RiIHByZXR0eSBwcmludGVyIGNhbid0IHByaW50IENTdHJp bmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MDY4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFuZy4KKworICAgICAgICBVcGRhdGUgV1RG Q1N0cmluZ1ByaW50ZXIgdG8gZm9sbG93IHIxMjYxOTEuCisKKyAgICAgICAgKiBnZGIvd2Via2l0 LnB5OgorICAgICAgICAoV1RGQ1N0cmluZ1ByaW50ZXIudG9fc3RyaW5nKToKKwogMjAxMi0wOS0w NiAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtjaHJv bWl1bV0gVXNlIFdlYkNvbXBvc2l0b3JTdXBwb3J0IGZ1bmN0aW9ucyBpbnN0ZWFkIG9mIFdlYkNv bXBvc2l0b3Igc3RhdGljcwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ2RiL3dlYmtpdC5weSBiL1Rvb2xz L2dkYi93ZWJraXQucHkKaW5kZXggYmRmM2QwODkwMjExYjYyZmMyYjc0MGNkMDRlMzQ4NzgwZjdj MWVmZS4uZjBkMzIwNzQxYzkzMDQyZmJiMzQzNDU4M2ZkMGY5NTI1NTZjYzA0MyAxMDA2NDQKLS0t IGEvVG9vbHMvZ2RiL3dlYmtpdC5weQorKysgYi9Ub29scy9nZGIvd2Via2l0LnB5CkBAIC0xMTUs MTAgKzExNSwxMCBAQCBjbGFzcyBXVEZBdG9taWNTdHJpbmdQcmludGVyKFN0cmluZ1ByaW50ZXIp OgogY2xhc3MgV1RGQ1N0cmluZ1ByaW50ZXIoU3RyaW5nUHJpbnRlcik6CiAgICAgIlByaW50IGEg V1RGOjpDU3RyaW5nIgogICAgIGRlZiB0b19zdHJpbmcoc2VsZik6Ci0gICAgICAgICMgVGhlIENT dHJpbmcgaG9sZHMgYSBidWZmZXIsIHdoaWNoIGlzIGEgcmVmcHRyIHRvIGEgV1RGOjpWZWN0b3Ig b2YgY2hhcnMuCi0gICAgICAgIHZlY3RvciA9IHNlbGYudmFsWydtX2J1ZmZlciddWydtX3B0cidd WydtX3ZlY3RvciddCi0gICAgICAgICMgVGhlIHZlY3RvciBoYXMgdHdvIG1vcmUgbGF5ZXJzIG9m IGJ1ZmZlciBtZW1iZXJzLgotICAgICAgICByZXR1cm4gdmVjdG9yWydtX2J1ZmZlciddWydtX2J1 ZmZlciddCisgICAgICAgICMgVGhlIENTdHJpbmcgaG9sZHMgYSBidWZmZXIsIHdoaWNoIGlzIGEg cmVmcHRyIHRvIGEgV1RGOjpDU3RyaW5nQnVmZmVyLgorICAgICAgICBkYXRhID0gc2VsZi52YWxb J21fYnVmZmVyJ11bJ21fcHRyJ11bJ21fZGF0YSddLmNhc3QoZ2RiLmxvb2t1cF90eXBlKCdjaGFy JykucG9pbnRlcigpKQorICAgICAgICBsZW5ndGggPSBzZWxmLnZhbFsnbV9idWZmZXInXVsnbV9w dHInXVsnbV9sZW5ndGgnXQorICAgICAgICByZXR1cm4gJycuam9pbihbY2hyKChkYXRhICsgaSku ZGVyZWZlcmVuY2UoKSkgZm9yIGkgaW4geHJhbmdlKGxlbmd0aCldKQogCiAKIGNsYXNzIFdURlN0 cmluZ0ltcGxQcmludGVyKFN0cmluZ1ByaW50ZXIpOgo=