96029 2012-09-06 14:50:24 -0700 StringBuilder::toAtomicString() can create an 16 bit string with 8 bit contents 2012-09-06 21:48:04 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 msaboff msaboff benjamin webkit.review.bot oldest_to_newest 713737 0 msaboff 2012-09-06 14:50:24 -0700 For the case where a StringBuild is partially populated with 8 bit data, when toAtomicString() is called, it will convert the string unnecessarily to 16 bits. 713756 1 162600 msaboff 2012-09-06 15:15:16 -0700 Created attachment 162600 Patch 714081 2 162600 webkit.review.bot 2012-09-06 21:48:01 -0700 Comment on attachment 162600 Patch Clearing flags on attachment: 162600 Committed r127821: <http://trac.webkit.org/changeset/127821> 714082 3 webkit.review.bot 2012-09-06 21:48:04 -0700 All reviewed patches have been landed. Closing bug. 162600 2012-09-06 15:15:16 -0700 2012-09-06 21:48:01 -0700 Patch 96029.patch text/plain 1497 msaboff SW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvQ2hh bmdlTG9nCShyZXZpc2lvbiAxMjc3ODcpCisrKyBTb3VyY2UvV1RGL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEyLTA5LTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1z YWJvZmZAYXBwbGUuY29tPgorCisgICAgICAgIFN0cmluZ0J1aWxkZXI6OnRvQXRvbWljU3RyaW5n KCkgY2FuIGNyZWF0ZSBhbiAxNiBiaXQgc3RyaW5nIHdpdGggOCBiaXQgY29udGVudHMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MDI5CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkZWQgOCBiaXQgcGF0 aCB3aGVuIGNyZWF0aW5nIGFuIEF0b21pY1N0cmluZyBmcm9tIGEgcGFydGlhbCA4IGJpdCBidWZm ZXIuCisKKyAgICAgICAgKiB3dGYvdGV4dC9TdHJpbmdCdWlsZGVyLmg6CisgICAgICAgIChXVEY6 OlN0cmluZ0J1aWxkZXI6OnRvQXRvbWljU3RyaW5nKToKKwogMjAxMi0wOS0wNiAgUGF0cmljayBH YW5zdGVyZXIgIDxwYXJvZ2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBGaXggZXhwb3J0IG1hY3Jv cyBpbiBJbnRlZ2VyVG9TdHJpbmdDb252ZXJzaW9uLmgKSW5kZXg6IFNvdXJjZS9XVEYvd3RmL3Rl eHQvU3RyaW5nQnVpbGRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XVEYvd3RmL3RleHQvU3Ry aW5nQnVpbGRlci5oCShyZXZpc2lvbiAxMjc3NTQpCisrKyBTb3VyY2UvV1RGL3d0Zi90ZXh0L1N0 cmluZ0J1aWxkZXIuaAkod29ya2luZyBjb3B5KQpAQCAtMTU0LDggKzE1NCwxMSBAQCBwdWJsaWM6 CiAgICAgICAgICAgICByZXR1cm4gQXRvbWljU3RyaW5nKCk7CiAKICAgICAgICAgLy8gSWYgdGhl IGJ1ZmZlciBpcyBzdWZmaWNpZW50bHkgb3Zlci1hbGxvY2F0ZWQsIG1ha2UgYSBuZXcgQXRvbWlj U3RyaW5nIGZyb20gYSBjb3B5IHNvIGl0cyBidWZmZXIgaXMgbm90IHNvIGxhcmdlLgotICAgICAg ICBpZiAoY2FuU2hyaW5rKCkpCi0gICAgICAgICAgICByZXR1cm4gQXRvbWljU3RyaW5nKGNoYXJh Y3RlcnMoKSwgbGVuZ3RoKCkpOworICAgICAgICBpZiAoY2FuU2hyaW5rKCkpIHsKKyAgICAgICAg ICAgIGlmIChpczhCaXQoKSkKKyAgICAgICAgICAgICAgICByZXR1cm4gQXRvbWljU3RyaW5nKGNo YXJhY3RlcnM4KCksIGxlbmd0aCgpKTsKKyAgICAgICAgICAgIHJldHVybiBBdG9taWNTdHJpbmco Y2hhcmFjdGVyczE2KCksIGxlbmd0aCgpKTsgICAgICAgICAgICAKKyAgICAgICAgfQogCiAgICAg ICAgIGlmICghbV9zdHJpbmcuaXNOdWxsKCkpCiAgICAgICAgICAgICByZXR1cm4gQXRvbWljU3Ry aW5nKG1fc3RyaW5nKTsK