96027 2012-09-06 14:39:43 -0700 [BlackBerry] Exiting fullscreen mode can leave user stuck without Browser menus 2012-11-02 12:51:41 -0700 1 1 1 Unclassified WebKit WebKit BlackBerry 528+ (Nightly build) Other Other CLOSED FIXED P2 Major --- 1 mfeil mfeil mifenton tonikitoo webkit.review.bot oldest_to_newest 713722 0 mfeil 2012-09-06 14:39:43 -0700 The changes for https://bugs.webkit.org/show_bug.cgi?id=87337 (landed as http://svn.webkit.org/repository/webkit/trunk@119119) introduced a bug. The same conditions are not checked on enter fullscreen vs. exit. Web sites such as http://videojs.com and youtube's mobile HTML5 player make the div container of the video element go fullscreen. This is allowed in WebPagePrivate::enterFullScreenForElement() but disallowed in WebPagePrivate::exitFullScreenForElement(). I am fixing this by allowing containers of video elements to exit fullscreen. 713734 1 162593 mfeil 2012-09-06 14:47:53 -0700 Created attachment 162593 Patch 715405 2 162593 webkit.review.bot 2012-09-08 21:28:56 -0700 Comment on attachment 162593 Patch Clearing flags on attachment: 162593 Committed r127975: <http://trac.webkit.org/changeset/127975> 715406 3 webkit.review.bot 2012-09-08 21:29:00 -0700 All reviewed patches have been landed. Closing bug. 757492 4 mfeil 2012-11-02 12:51:41 -0700 Closing bug for patch that landed a long time ago. 162593 2012-09-06 14:47:53 -0700 2012-09-08 21:28:56 -0700 Patch bug-96027-20120906174733.patch text/plain 2102 mfeil U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Nzg1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L2Js YWNrYmVycnkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0NoYW5nZUxvZwpp bmRleCBjNTI1ZGIyZWZlY2QyYjEzYWZlOTU5MzAzY2MxNGM1NDVmMTc3YjU2Li45MDhjMDIyZDNl Y2JmYzg0NzUyMTY1YzlmM2JjZTg2MGM5ODA3NzIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L2JsYWNrYmVycnkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9DaGFu Z2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMi0wOS0wNiAgTWF4IEZlaWwgIDxtZmVpbEByaW0u Y29tPgorCisgICAgICAgIFtCbGFja0JlcnJ5XSBFeGl0aW5nIGZ1bGxzY3JlZW4gbW9kZSBjYW4g bGVhdmUgdXNlciBzdHVjayB3aXRob3V0IEJyb3dzZXIgbWVudXMKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MDI3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGNoYW5nZXMgZm9yIGJ1ZyA4NzMzNyAo bGFuZGVkIGFzIHRydW5rIHN2biByZXZpc2lvbiAxMTkxMTkpCisgICAgICAgIGludHJvZHVjZWQg YSBidWcuIFRoZSBzYW1lIGNvbmRpdGlvbnMgYXJlIG5vdCBjaGVja2VkIG9uIGVudGVyCisgICAg ICAgIGZ1bGxzY3JlZW4gdnMuIGV4aXQuIFdlYiBzaXRlcyBzdWNoIGFzIGh0dHA6Ly92aWRlb2pz LmNvbQorICAgICAgICBhbmQgeW91dHViZSdzIG1vYmlsZSBIVE1MNSBwbGF5ZXIgbWFrZSB0aGUg ZGl2IGNvbnRhaW5lcgorICAgICAgICBvZiB0aGUgdmlkZW8gZWxlbWVudCBnbyBmdWxsc2NyZWVu LiBUaGlzIGlzIGFsbG93ZWQgaW4KKyAgICAgICAgV2ViUGFnZVByaXZhdGU6OmVudGVyRnVsbFNj cmVlbkZvckVsZW1lbnQoKSBidXQgZGlzYWxsb3dlZCBpbgorICAgICAgICBXZWJQYWdlUHJpdmF0 ZTo6ZXhpdEZ1bGxTY3JlZW5Gb3JFbGVtZW50KCkuIEkgYW0gZml4aW5nIHRoaXMgYnkKKyAgICAg ICAgYWxsb3dpbmcgY29udGFpbmVycyBvZiB2aWRlbyBlbGVtZW50cyB0byBleGl0IGZ1bGxzY3Jl ZW4uCisKKyAgICAgICAgKiBBcGkvV2ViUGFnZS5jcHA6CisgICAgICAgIChCbGFja0JlcnJ5OjpX ZWJLaXQ6OldlYlBhZ2VQcml2YXRlOjpleGl0RnVsbFNjcmVlbkZvckVsZW1lbnQpOgorCiAyMDEy LTA5LTA2ICBHZW5ldmlldmUgTWFrICA8Z21ha0ByaW0uY29tPgogCiAgICAgICAgIEFkZCBkYXRh LWJsYWNrYmVycnktd2Vid29ya3MtY29udGV4dCBhdHRyaWJ1dGUgYW5kIHNldCB0aGUgY3VzdG9t IGNvbnRleHQgd2hlbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9ibGFja2JlcnJ5L0FwaS9X ZWJQYWdlLmNwcCBiL1NvdXJjZS9XZWJLaXQvYmxhY2tiZXJyeS9BcGkvV2ViUGFnZS5jcHAKaW5k ZXggYmYyNGMxOTc1OGEyOTMxZjU5MTg5YjkyZWE1ZGZkNjU2ZjRjMDNjOC4uNDI0M2EyMWMyMDc1 YzI1Mjg5ZWYwY2Y1YTQwZTI2OWUyNDY4MGM3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9i bGFja2JlcnJ5L0FwaS9XZWJQYWdlLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L2JsYWNrYmVycnkv QXBpL1dlYlBhZ2UuY3BwCkBAIC02MDE0LDcgKzYwMTQsNyBAQCB2b2lkIFdlYlBhZ2VQcml2YXRl OjpleGl0RnVsbFNjcmVlbkZvckVsZW1lbnQoRWxlbWVudCogZWxlbWVudCkKIHsKICNpZiBFTkFC TEUoVklERU8pCiAgICAgLy8gVE9ETzogV2Ugc2hvdWxkIG5vdCBjaGVjayB2aWRlbyB0YWcgd2hl biB3ZSBkZWNpZGUgdG8gc3VwcG9ydCBhbGwgZWxlbWVudHMuCi0gICAgaWYgKCFlbGVtZW50IHx8 ICFlbGVtZW50LT5oYXNUYWdOYW1lKEhUTUxOYW1lczo6dmlkZW9UYWcpKQorICAgIGlmICghZWxl bWVudCB8fCAoIWVsZW1lbnQtPmhhc1RhZ05hbWUoSFRNTE5hbWVzOjp2aWRlb1RhZykgJiYgIWNv bnRhaW5zVmlkZW9UYWdzKGVsZW1lbnQpKSkKICAgICAgICAgcmV0dXJuOwogICAgIGlmIChtX3dl YlNldHRpbmdzLT5mdWxsU2NyZWVuVmlkZW9DYXBhYmxlKCkpIHsKICAgICAgICAgLy8gVGhlIEJy b3dzZXIgY2hyb21lIGhhcyBpdHMgb3duIGZ1bGxzY3JlZW4gdmlkZW8gd2lkZ2V0Lgo=