96021 2012-09-06 14:05:20 -0700 [chromium] Split platform geometry types into separate static target 2012-09-06 14:44:29 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jamesr jamesr abarth dpranke enne fishd tony oldest_to_newest 713670 0 jamesr 2012-09-06 14:05:20 -0700 [chromium] Split platform geometry types into separate static target 713671 1 162578 jamesr 2012-09-06 14:06:25 -0700 Created attachment 162578 Patch 713673 2 jamesr 2012-09-06 14:08:21 -0700 Chop chop! 713687 3 162578 tony 2012-09-06 14:18:41 -0700 Comment on attachment 162578 Patch Seems fine, but when adding a new file to platform/graphics, how does one know where to put it? 713691 4 jamesr 2012-09-06 14:20:26 -0700 If a build breaks somewhere, I'll fix it :). I expect this situation to be temporary and we don't add many new files. 713692 5 jamesr 2012-09-06 14:20:40 -0700 "this situation" = statically linking against this target from elsewhere. 713729 6 jamesr 2012-09-06 14:44:29 -0700 Committed r127787: <http://trac.webkit.org/changeset/127787> 162578 2012-09-06 14:06:25 -0700 2012-09-06 14:18:40 -0700 Patch bug-96021-20120906140606.patch text/plain 6363 jamesr U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3NzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjI1MjcxMWRjMmQxZDNl MDYwOTk1NDhhZTBmNjc3NTA5Y2JkMmQ3MC4uZWQ2MGViZjc4ZDVmN2NmZWJmMzgyNTNmNzFmY2M3 ODMzMGFkOTA1OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDEyLTA5LTA2ICBKYW1l cyBSb2JpbnNvbiAgPGphbWVzckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBT cGxpdCBwbGF0Zm9ybSBnZW9tZXRyeSB0eXBlcyBpbnRvIHNlcGFyYXRlIHN0YXRpYyB0YXJnZXQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MDIxCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBtb3Zl cyBzZXZlcmFsIFdlYkNvcmUvcGxhdGZvcm0gZ2VvbWV0cnkgY2xhc3NlcyBvdXQgb2Ygd2ViY29y ZV9wbGF0Zm9ybSBpbnRvIGEgc2VwYXJhdGUgc3RhdGljIGxpYnJhcnkuCisgICAgICAgIFRoaXMg bGlicmFyeSBpcyByZWxhdGl2ZWx5IHN0YW5kYWxvbmUgYW5kIHVzZWZ1bCB0byBzdGF0aWNhbGx5 IGxpbmsgYWdhaW5zdCBpbiBvdGhlciBjb250ZXh0cy4KKworICAgICAgICAqIFdlYkNvcmUuZ3lw L1dlYkNvcmUuZ3lwOgorICAgICAgICAqIFdlYkNvcmUuZ3lwaToKKwogMjAxMi0wOS0wNiAgQW5k cmVpIFBvZW5hcnUgIDxwb2VuYXJ1QGFkb2JlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9y OiBQcm90b2NvbCBFeHRlbnNpb246IEFkZCAicmVnaW9uTGF5b3V0VXBkYXRlIiBldmVudApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXAvV2ViQ29yZS5neXAgYi9Tb3VyY2Uv V2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cAppbmRleCA0ZGY0ZWE1YTYwYjUxM2FkODcz ZmU2MGJiN2ExNzgzODJlZTQ0MjZiLi5kMDQwZTNkMjIzYjBkY2JkMjlkYzMyZTFlZjA3YmU2MTIy NjVkNDk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5 cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5cC9XZWJDb3JlLmd5cApAQCAtMTkwMCw2 ICsxOTAwLDE5IEBACiAgICAgICBdLAogICAgIH0sCiAgICAgeworICAgICAgJ3RhcmdldF9uYW1l JzogJ3dlYmNvcmVfcGxhdGZvcm1fZ2VvbWV0cnknLAorICAgICAgJ3R5cGUnOiAnc3RhdGljX2xp YnJhcnknLAorICAgICAgJ2RlcGVuZGVuY2llcyc6IFsKKyAgICAgICAgJ3dlYmNvcmVfcHJlcmVx dWlzaXRlcycsCisgICAgICBdLAorICAgICAgJ2RlZmluZXMnOiBbCisgICAgICAgICdXRUJLSVRf SU1QTEVNRU5UQVRJT049MScsCisgICAgICBdLAorICAgICAgJ3NvdXJjZXMnOiBbCisgICAgICAg ICc8QCh3ZWJjb3JlX3BsYXRmb3JtX2dlb21ldHJ5X2ZpbGVzKScsCisgICAgICBdLAorICAgIH0s CisgICAgewogICAgICAgJ3RhcmdldF9uYW1lJzogJ3dlYmNvcmVfY2hyb21pdW1fY29tcG9zaXRv cicsCiAgICAgICAndHlwZSc6ICdzdGF0aWNfbGlicmFyeScsCiAgICAgICAnZGVwZW5kZW5jaWVz JzogWwpAQCAtMjEzMCw2ICsyMTQzLDcgQEAKICAgICAgICAgJ3dlYmNvcmVfZG9tJywKICAgICAg ICAgJ3dlYmNvcmVfaHRtbCcsCiAgICAgICAgICd3ZWJjb3JlX3BsYXRmb3JtJywKKyAgICAgICAg J3dlYmNvcmVfcGxhdGZvcm1fZ2VvbWV0cnknLAogICAgICAgICAnd2ViY29yZV9yZW1haW5pbmcn LAogICAgICAgICAnd2ViY29yZV9yZW5kZXJpbmcnLAogICAgICAgICAjIEV4cG9ydGVkLgpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvV2ViQ29yZS5neXBpIGIvU291cmNlL1dlYkNvcmUvV2Vi Q29yZS5neXBpCmluZGV4IDUzZTFkMDQzNmIwZjgwMmI4MDQzMGU2OTFkZmY4ZjVhYTEwYWM3NDUu LjA1NTkwY2VlMGI1NTQwMjA1NjUxOWQ0YjA2NDEzODg5ZjJiZGM4MGEgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL1dlYkNvcmUuZ3lwaQorKysgYi9Tb3VyY2UvV2ViQ29yZS9XZWJDb3JlLmd5 cGkKQEAgLTQ3MzUsMTEgKzQ3MzUsNiBAQAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNz L0Nyb3NzZmFkZUdlbmVyYXRlZEltYWdlLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3Jh cGhpY3MvQ3Jvc3NmYWRlR2VuZXJhdGVkSW1hZ2UuaCcsCiAgICAgICAgICAgICAncGxhdGZvcm0v Z3JhcGhpY3MvRXh0ZW5zaW9uczNELmgnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNz L0Zsb2F0UG9pbnQuY3BwJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBv aW50M0QuY3BwJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFF1YWQuY3Bw JywKLSAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFJlY3QuY3BwJywKLSAgICAg ICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFNpemUuY3BwJywKICAgICAgICAgICAgICdw bGF0Zm9ybS9ncmFwaGljcy9Gb250LmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhp Y3MvRm9udENhY2hlLmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvRm9udERh dGEuY3BwJywKQEAgLTQ3NTEsNyArNDc0Niw2IEBACiAgICAgICAgICAgICAncGxhdGZvcm0vZ3Jh cGhpY3MvRm9udFBsYXRmb3JtRGF0YS5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBo aWNzL0ZvbnRQbGF0Zm9ybURhdGEuaCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3Mv RnJhY3Rpb25hbExheW91dEJveEV4dGVudC5jcHAnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL2dy YXBoaWNzL0ZyYWN0aW9uYWxMYXlvdXRSZWN0LmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0v Z3JhcGhpY3MvR2VuZXJhdG9yR2VuZXJhdGVkSW1hZ2UuY3BwJywKICAgICAgICAgICAgICdwbGF0 Zm9ybS9ncmFwaGljcy9HZW5lcmF0ZWRJbWFnZS5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3Jt L2dyYXBoaWNzL0dlbmVyYXRlZEltYWdlLmgnLApAQCAtNDc2OSw3ICs0NzYzLDYgQEAKICAgICAg ICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUJ1ZmZlci5jcHAnLAogICAgICAgICAgICAg J3BsYXRmb3JtL2dyYXBoaWNzL0ltYWdlT3JpZW50YXRpb24uY3BwJywKICAgICAgICAgICAgICdw bGF0Zm9ybS9ncmFwaGljcy9JbWFnZVNvdXJjZS5jcHAnLAotICAgICAgICAgICAgJ3BsYXRmb3Jt L2dyYXBoaWNzL0ludFJlY3QuY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9N ZWRpYVBsYXllci5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL01lZGlhUGxh eWVyUHJpdmF0ZS5oJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9OYXRpdmVJbWFn ZVB0ci5oJyAsCkBAIC00Nzc3LDcgKzQ3NzAsNiBAQAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dy YXBoaWNzL1BhdGhUcmF2ZXJzYWxTdGF0ZS5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dy YXBoaWNzL1BhdGhUcmF2ZXJzYWxTdGF0ZS5oJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFw aGljcy9QYXR0ZXJuLmNwcCcsCi0gICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvUmVnaW9u LmNwcCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvUm91bmRlZFJlY3QuY3BwJywK ICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9TZWdtZW50ZWRGb250RGF0YS5jcHAnLAog ICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL1NlZ21lbnRlZEZvbnREYXRhLmgnLApAQCAt NTAxMSw4ICs1MDAzLDYgQEAKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hh cmVkR3JhcGhpY3NDb250ZXh0M0QuaCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L1RleHR1cmUuY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGV4 dHVyZS5oJywKLSAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0YS5j cHAnLAotICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9UaWxpbmdEYXRhLmgnLAog ICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9tYWMvRHJhd2luZ0J1ZmZlck1hYy5t bScsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L3F0L0RyYXdpbmdCdWZmZXJR dC5jcHAnLAogICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HUmVmUHRy R1N0cmVhbWVyLmNwcCcsCkBAIC01MjAxLDcgKzUxOTEsNiBAQAogICAgICAgICAgICAgJ3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllci5oJywKICAgICAg ICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclNoYWRlck1hbmFn ZXIuY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1h cHBlclNoYWRlck1hbmFnZXIuaCcsCi0gICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvdHJh bnNmb3Jtcy9BZmZpbmVUcmFuc2Zvcm0uY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFw aGljcy90cmFuc2Zvcm1zL0lkZW50aXR5VHJhbnNmb3JtT3BlcmF0aW9uLmgnLAogICAgICAgICAg ICAgJ3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvTWF0cml4M0RUcmFuc2Zvcm1PcGVyYXRp b24uY3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL01hdHJp eDNEVHJhbnNmb3JtT3BlcmF0aW9uLmgnLApAQCAtNTIxNiw3ICs1MjA1LDYgQEAKICAgICAgICAg ICAgICdwbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1NrZXdUcmFuc2Zvcm1PcGVyYXRpb24u Y3BwJywKICAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1NrZXdUcmFu c2Zvcm1PcGVyYXRpb24uaCcsCiAgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNm b3Jtcy9UcmFuc2Zvcm1PcGVyYXRpb25zLmNwcCcsCi0gICAgICAgICAgICAncGxhdGZvcm0vZ3Jh cGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAnLAogICAgICAgICAgICAg J3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNmb3JtU3RhdGUuY3BwJywKICAgICAg ICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy90cmFuc2Zvcm1zL1RyYW5zZm9ybVN0YXRlLmgnLAog ICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvVHJhbnNsYXRlVHJhbnNm b3JtT3BlcmF0aW9uLmNwcCcsCkBAIC01ODUyLDYgKzU4NDAsMjAgQEAKICAgICAgICAgICAgICdw bGF0Zm9ybS93eC93eGNvZGUvd2luL25vbi1rZXJuZWQtZHJhd2luZy5jcHAnLAogICAgICAgICAg ICAgJ3BsYXRmb3JtL3d4L3d4Y29kZS93aW4vc2Nyb2xsYmFyX3JlbmRlci5jcHAnLAogICAgICAg ICBdLAorICAgICAgICAnd2ViY29yZV9wbGF0Zm9ybV9nZW9tZXRyeV9maWxlcyc6IFsKKyAgICAg ICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9GbG9hdFBvaW50LmNwcCcsCisgICAgICAgICAgICAn cGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRQb2ludDNELmNwcCcsCisgICAgICAgICAgICAncGxhdGZv cm0vZ3JhcGhpY3MvRmxvYXRRdWFkLmNwcCcsCisgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhp Y3MvRmxvYXRSZWN0LmNwcCcsCisgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvRmxvYXRT aXplLmNwcCcsCisgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvSW50UmVjdC5jcHAnLAor ICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL0ZyYWN0aW9uYWxMYXlvdXRSZWN0LmNwcCcs CisgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvUmVnaW9uLmNwcCcsCisgICAgICAgICAg ICAncGxhdGZvcm0vZ3JhcGhpY3MvdHJhbnNmb3Jtcy9UcmFuc2Zvcm1hdGlvbk1hdHJpeC5jcHAn LAorICAgICAgICAgICAgJ3BsYXRmb3JtL2dyYXBoaWNzL3RyYW5zZm9ybXMvQWZmaW5lVHJhbnNm b3JtLmNwcCcsCisgICAgICAgICAgICAncGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1RpbGluZ0RhdGEu Y3BwJywKKyAgICAgICAgICAgICdwbGF0Zm9ybS9ncmFwaGljcy9ncHUvVGlsaW5nRGF0YS5oJywK KyAgICAgICAgXSwKICAgICAgICAgJ3dlYmNvcmVfc3ZnX2ZpbGVzJzogWwogICAgICAgICAgICAg J3JlbmRlcmluZy9zdHlsZS9TVkdSZW5kZXJTdHlsZS5jcHAnLAogICAgICAgICAgICAgJ3JlbmRl cmluZy9zdHlsZS9TVkdSZW5kZXJTdHlsZURlZnMuY3BwJywK