96003 2012-09-06 11:49:16 -0700 Fix WTF.Lrint on 32-bit platforms 2012-09-06 12:50:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fsamuel fsamuel benjamin d-r oldest_to_newest 713527 0 fsamuel 2012-09-06 11:49:16 -0700 Disable WTF.Lrint as it fails on Chromium Win/Mac 713534 1 162548 fsamuel 2012-09-06 11:52:04 -0700 Created attachment 162548 Patch 713585 2 162559 fsamuel 2012-09-06 12:43:48 -0700 Created attachment 162559 Patch 713586 3 162559 benjamin 2012-09-06 12:45:22 -0700 Comment on attachment 162559 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=162559&action=review > Tools/TestWebKitAPI/Tests/WTF/MathExtras.cpp:49 > + // Largest double number with 0.5 precision and one halfway rounding case below. > + EXPECT_EQ(lrint(pow(2.0, 52) - 0.5), pow(2.0, 52)); > + EXPECT_EQ(lrint(pow(2.0, 52) - 1.5), pow(2.0, 52) - 2); > + // Smallest double number with 0.5 precision and one halfway rounding case above. > + EXPECT_EQ(lrint(-pow(2.0, 52) + 0.5), -pow(2.0, 52)); > + EXPECT_EQ(lrint(-pow(2.0, 52) + 1.5), -pow(2.0, 52) + 2); Wrong indent. 713588 4 benjamin 2012-09-06 12:50:13 -0700 Committed r127775: <http://trac.webkit.org/changeset/127775> 162548 2012-09-06 11:52:04 -0700 2012-09-06 12:43:45 -0700 Patch bug-96003-20120906145144.patch text/plain 1424 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Njk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQyOTNjZmMyYjA2MjY5ODhlNmUwZGQ1MTE4ODk5NjBl MDM3YWMxMy4uNDI0NzZkMDBmZGMwZGJiYjE1MDI1Y2RhZThkOWZiYTI3ODUzNDJkMyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIy IEBACisyMDEyLTA5LTA2ICBGYWR5IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIERpc2FibGUgV1RGLkxyaW50IGFzIGl0IGZhaWxzIG9uIENocm9taXVtIFdpbi9NYWMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTk2MDAzCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGVzdCBvcmln aW5hbGx5IGFkZGVkIGhlcmU6CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQwMjcyCisKKyAgICAgICAgVGhlIGJyZWFrYWdlIHdhcyBvYnNlcnZlZCBo ZXJlOgorCisgICAgICAgIGh0dHA6Ly9idWlsZC53ZWJraXQub3JnL2J1aWxkZXJzL0Nocm9taXVt JTIwTWFjJTIwUmVsZWFzZSUyMCUyOFRlc3RzJTI5L2J1aWxkcy8yMzQ0MgorICAgICAgICBodHRw Oi8vYnVpbGQud2Via2l0Lm9yZy9idWlsZGVycy9DaHJvbWl1bSUyMFdpbiUyMFJlbGVhc2UlMjAl MjhUZXN0cyUyOS9idWlsZHMvMjk3NjMKKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMv V1RGL01hdGhFeHRyYXMuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIw MTItMDktMDUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAgICBbY2hy b21pdW1dIFJlbW92ZSBkZXBlbmRlbmN5IG9uIHdlYmtpdF91c2VyX2FnZW50CmRpZmYgLS1naXQg YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NYXRoRXh0cmFzLmNwcCBiL1Rvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV1RGL01hdGhFeHRyYXMuY3BwCmluZGV4IDAzMjBiNDc5NTU5Y2Vh NjJlOTg0NDE0ZWExYjI5NjUyOTk1NGU4MmYuLmVlMTdhYmIxMmRkMDYwNDg1OWMyNGY1MWRlOGI0 ODAzNTdkNGExN2QgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01h dGhFeHRyYXMuY3BwCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL01hdGhFeHRy YXMuY3BwCkBAIC0yOSw3ICsyOSw3IEBACiAKIG5hbWVzcGFjZSBUZXN0V2ViS2l0QVBJIHsKIAot VEVTVChXVEYsIExyaW50KQorVEVTVChXVEYsIERJU0FCTEVEX0xyaW50KQogewogICAgIEVYUEVD VF9FUShscmludCgtNy41KSwgLTgpOwogICAgIEVYUEVDVF9FUShscmludCgtOC41KSwgLTgpOwo= 162559 2012-09-06 12:43:48 -0700 2012-09-06 12:45:22 -0700 Patch bug-96003-20120906154328.patch text/plain 2018 fsamuel U3VidmVyc2lvbiBSZXZpc2lvbjogMTI3Njk2CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNzQyOTNjZmMyYjA2MjY5ODhlNmUwZGQ1MTE4ODk5NjBl MDM3YWMxMy4uMGQxZTk1NmMxNjBhYjg3ZWUxMTAyZGQyZTRiYzBjMTEzMzkxODI0OCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDEyLTA5LTA2ICBGYWR5IFNhbXVlbCAgPGZzYW11ZWxAY2hyb21pdW0ub3JnPgorCisg ICAgICAgIEZpeCBXVEYuTHJpbnQgb24gMzItYml0IHBsYXRmb3JtcworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9OTYwMDMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlZCBmYWlsaW5nIFdURi5McmludCB0 ZXN0IG9uIDMyLWJpdCBwbGF0Zm9ybXMuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3Rz L1dURi9NYXRoRXh0cmFzLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1QpOgorCiAy MDEyLTA5LTA1ICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgW2No cm9taXVtXSBSZW1vdmUgZGVwZW5kZW5jeSBvbiB3ZWJraXRfdXNlcl9hZ2VudApkaWZmIC0tZ2l0 IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XVEYvTWF0aEV4dHJhcy5jcHAgYi9Ub29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NYXRoRXh0cmFzLmNwcAppbmRleCAwMzIwYjQ3OTU1OWNl YTYyZTk4NDQxNGVhMWIyOTY1Mjk5NTRlODJmLi45MmE5YzllNmZjNWY5OGE3MWNjNjYyM2RhY2Iw YjA2ZGM1MGNmYWNhIDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9N YXRoRXh0cmFzLmNwcAorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9NYXRoRXh0 cmFzLmNwcApAQCAtNDAsMTIgKzQwLDE0IEBAIFRFU1QoV1RGLCBMcmludCkKICAgICBFWFBFQ1Rf RVEobHJpbnQoMS43KSwgMik7CiAgICAgRVhQRUNUX0VRKGxyaW50KDApLCAwKTsKICAgICBFWFBF Q1RfRVEobHJpbnQoLTApLCAwKTsKLSAgICAvLyBMYXJnZXN0IGRvdWJsZSBudW1iZXIgd2l0aCAw LjUgcHJlY2lzaW9uIGFuZCBvbmUgaGFsZndheSByb3VuZGluZyBjYXNlIGJlbG93LgotICAgIEVY UEVDVF9FUShscmludChwb3coMi4wLCA1MikgLSAwLjUpLCBwb3coMi4wLCA1MikpOwotICAgIEVY UEVDVF9FUShscmludChwb3coMi4wLCA1MikgLSAxLjUpLCBwb3coMi4wLCA1MikgLSAyKTsKLSAg ICAvLyBTbWFsbGVzdCBkb3VibGUgbnVtYmVyIHdpdGggMC41IHByZWNpc2lvbiBhbmQgb25lIGhh bGZ3YXkgcm91bmRpbmcgY2FzZSBhYm92ZS4KLSAgICBFWFBFQ1RfRVEobHJpbnQoLXBvdygyLjAs IDUyKSArIDAuNSksIC1wb3coMi4wLCA1MikpOwotICAgIEVYUEVDVF9FUShscmludCgtcG93KDIu MCwgNTIpICsgMS41KSwgLXBvdygyLjAsIDUyKSArIDIpOworICAgIGlmIChzaXplb2YobG9uZyBp bnQpID09IDgpIHsKKyAgICAgIC8vIExhcmdlc3QgZG91YmxlIG51bWJlciB3aXRoIDAuNSBwcmVj aXNpb24gYW5kIG9uZSBoYWxmd2F5IHJvdW5kaW5nIGNhc2UgYmVsb3cuCisgICAgICBFWFBFQ1Rf RVEobHJpbnQocG93KDIuMCwgNTIpIC0gMC41KSwgcG93KDIuMCwgNTIpKTsKKyAgICAgIEVYUEVD VF9FUShscmludChwb3coMi4wLCA1MikgLSAxLjUpLCBwb3coMi4wLCA1MikgLSAyKTsKKyAgICAg IC8vIFNtYWxsZXN0IGRvdWJsZSBudW1iZXIgd2l0aCAwLjUgcHJlY2lzaW9uIGFuZCBvbmUgaGFs ZndheSByb3VuZGluZyBjYXNlIGFib3ZlLgorICAgICAgRVhQRUNUX0VRKGxyaW50KC1wb3coMi4w LCA1MikgKyAwLjUpLCAtcG93KDIuMCwgNTIpKTsKKyAgICAgIEVYUEVDVF9FUShscmludCgtcG93 KDIuMCwgNTIpICsgMS41KSwgLXBvdygyLjAsIDUyKSArIDIpOworICAgIH0KIH0KIAogfSAvLyBu YW1lc3BhY2UgVGVzdFdlYktpdEFQSQo=